GitLab

Review URL: https://codereview.chromium.org/563093002

Cr-Commit-Position: refs/heads/master@{#294525}

Patchset 2 of 4 in switching the w3c layout tests to be checked
directly into Blink. By moving the expectations here, we can
then land a patch upstream to switch to running the tests in
LayoutTests/imported without worrying about the old tests until
they are deleted and we stop pulling the repos.

TBR=eseidel@chromium.org
BUG=413454

Review URL: https://codereview.chromium.org/567833002

Cr-Commit-Position: refs/heads/master@{#294524}

R=lcwu@chromium.org,byungchul@chromium.org,phajdan.jr@chromium.org
BUG=409163

Review URL: https://codereview.chromium.org/518773003

Cr-Commit-Position: refs/heads/master@{#294523}

Looking at the UMA value of DirectWrite.Fonts.Loaded, 1000->1750 will
take us from ~96% to >99% of users having all their fonts loaded.

Hopefully this will alleviate most annoyance until the proxy code is
ready.

R=shrikant@chromium.org
BUG=413059

Review URL: https://codereview.chromium.org/557633003

Cr-Commit-Position: refs/heads/master@{#294522}

Previously, CDP would fail if the scroll child wasn't the immediate
descendant of the lowest common ancestor of the scroll parent and child.

With this patch I've fixed up two things so that CDP can handle these
cases.

1. Dumber sorting.
  I've made sorting simpler by removing assumptions about the tree
  topology. Instead, I assigned "sort weights" to the layers in
  PreCalculateMetaInformation. The approach is pretty naive. As I
  walk the tree I assign a monotonically increasing weight. If I ever
  hit a scroll child before its parent, I jump up to the lowest common
  ancestor and make sure that the child of the LCA is assigned the
  smallest weight in the tree so far (the negative of the next
  monotonically increasing weight). This ensures that the scroll parent
  will be visited first. Here's a picture of a layer tree and the
  weights that would be assigned.

  lca(0)
  + filler(1)
  | + scroll child(2)
  + more-filler(-3)
    + scroll parent(4)

  It would be a huge bummer if we had to sort all the time, though, so
  I've taken care to flag the LCA if I ever have to assign a negative
  weight so that we only sort in that case.

  Here's my argument for the correctness of the algorithm. Clearly,
  we force correct ordering of a particular scroll child/parent pair,
  but the worry is that by setting a negative weight, we'll force an
  illegal ordering (i.e., we'll "undo" an ordering we've forced
  earlier in the algorithm). Here's a diagram.

  lca
  + subtree with scroll parent #1
  + subtree with scroll child #1 and scroll_parent #2
  + subtree with scroll child #2.

  Now, say we're processing scroll child #2. We want to be sure that
  we don't go reordering subtrees and mess up the relative ordering of
  scroll child #1 and scroll parent #1's subtrees.

  But we know that this is impossible. Since we've already visited the
  subtree with scroll child #1, scroll child #2 will necessarily get a
  higher sort weight, so we'll never need to force any reordering in
  this case; we won't assign any negative weights here.

  Say the ordering were changed such that when processing scroll child
  #2, we haven't seen scroll child #1's subtree. We're also fine in
  this case because we will do any ordering fixups required when we do
  eventually visit scroll child #1.

  The only case where we get into trouble is when we have a cycle. For
  example,

  lca
   + scroll parent 1
   | + scroll child 2
   + scroll parent 2
     + scroll child 1

  No ordering could satisfy a situation with a cycle, but this is
  an impossible situation as CSS stacking defines a well defined, non
  circular order.

2. Proper clip transformations.
  We sometimes need to put the scroll parent's clip into the space of
  the scroll child's immediate parent. This needs to go through the
  LCA. Previously, we'd assumed that the LCA was going to be the scroll
  child's immediate parent, but we no longer make that assumption.

BUG=403866

Review URL: https://codereview.chromium.org/548963002

Cr-Commit-Position: refs/heads/master@{#294521}

When a frame is navigating cross-process, its existing document will be completely destroyed and all child frames will be gone. This means that we don't need to create proxy objects for the new SiteInstance in the subtree of the navigating frame.

BUG=357747

Review URL: https://codereview.chromium.org/536143002

Cr-Commit-Position: refs/heads/master@{#294520}

BUG=352293

Review URL: https://codereview.chromium.org/564913003

Cr-Commit-Position: refs/heads/master@{#294519}

BUG=412754

Review URL: https://codereview.chromium.org/562303002

Cr-Commit-Position: refs/heads/master@{#294518}

Missed this one when testing earlier.

BUG=43667, 367785
TEST=DCHECKs no longer fire.

Review URL: https://codereview.chromium.org/563723006

Cr-Commit-Position: refs/heads/master@{#294517}

Currently the Cellular properties are not documented in onc_spec.html
at all. This provides rudimentary documentation based on the Shill
documentaiton.

It also removes 'SelectedNetwork' which is undocumented in Shill and
unused in Chrome.

BUG=None

Review URL: https://codereview.chromium.org/563643002

Cr-Commit-Position: refs/heads/master@{#294516}

https://skia.googlesource.com/skia/+log/0b36e6b65f8c124f2ef2601294288219b3c3a1f0..fbe4136845fd68f583f9f9bfb628706c4b87480b

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/567823002

Cr-Commit-Position: refs/heads/master@{#294515}

All platforms uses PdfMetafileSkia now.

TBR=sgurun@chromium.org

Review URL: https://codereview.chromium.org/559263002

Cr-Commit-Position: refs/heads/master@{#294514}

With --show-host-pairing-demo and remora requisition, we start on the host pairing screen instead of the network screen.

There's an issue with the host pairing screen not being ready to accept context changes.

This is a temporary fix to get the end to end flow working. dzhioev@ will land a sequence of patches that are better long term.

BUG=405150
TEST=manual

Review URL: https://codereview.chromium.org/562923002

Cr-Commit-Position: refs/heads/master@{#294513}

A 2MB+ regression was introduced but a cause cannot be identified.

https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-xp&tests=sizes%2Fmini_installer.exe&checked=mini_installer.exe&rev=294272

BUG=413191
NOTRY=true
TBR=weitaosu,engedy

Review URL: https://codereview.chromium.org/569453002

Cr-Commit-Position: refs/heads/master@{#294512}

According to crbug.com/412186, there is some incorrect handle management in
NaClProcessHost. It's much easier to use base::File to manage closing the
socket handles, and it cleans up some weirdness with directly using NaClHandle
as well.

BUG=412186

Review URL: https://codereview.chromium.org/552183004

Cr-Commit-Position: refs/heads/master@{#294511}

BUG=314889

Review URL: https://codereview.chromium.org/557393003

Cr-Commit-Position: refs/heads/master@{#294510}

BUG=

Review URL: https://codereview.chromium.org/566753002

Cr-Commit-Position: refs/heads/master@{#294509}

[Findit] [Findit] Remove usage of sys.exit(0) because it still causes exception stack in clusterfuzz.

NOTRY=true

Review URL: https://codereview.chromium.org/561353002

Cr-Commit-Position: refs/heads/master@{#294508}

This typo could cause a false negative when we use
EXPECT_FILE_READ(kSuccess, NULL, 0)

This CL fixes the typo and all tests are still passing.

Review URL: https://codereview.chromium.org/562833002

Cr-Commit-Position: refs/heads/master@{#294507}

BUG=None

Review URL: https://codereview.chromium.org/555983002

Cr-Commit-Position: refs/heads/master@{#294506}

If the user initiates an app install via the app launcher, it is
possible to close the install dialog by clicking on the background.
The app launcher window and modal dialog are destroyed without
cancelling the dialog, therefore keeping the install active.

This patch ensures that ExtensionInstallPrompt::Delegate::
InstallUIAbort() is called in this scenario to allow the delegate
(WebstoreStandaloneInstaller) to abort the install.

BUG=409616
TEST=browser_tests

Review URL: https://codereview.chromium.org/547253002

Cr-Commit-Position: refs/heads/master@{#294505}

Just some additional code cleanup in preparation for adding a separate
requestor for carrier info and other remaining non ONC data.

BUG=279351

Review URL: https://codereview.chromium.org/563553004

Cr-Commit-Position: refs/heads/master@{#294504}

Followup to 475113005, use OVERRIDE macro instead of using override
directly.

Review URL: https://codereview.chromium.org/560353003

Cr-Commit-Position: refs/heads/master@{#294503}

Instead of manually constructing base::Value for event invocation, we should
use code generated from IDL just designed for that.

TEST=browser_test, unit_tests: *FileSystemProvider*
BUG=403673

Review URL: https://codereview.chromium.org/547313002

Cr-Commit-Position: refs/heads/master@{#294502}

This converts the view manager protocol over to specify view contents via
surfaces instead of shuffling a bitmap. To ease the transition, this provides a
wrapper in the client library that accepts an SkBitmap and uploads it into a
texture wrapped in a surface so existing code still works. Next I'll port the
clients over to providing surfaces themselves and remove this shim.

BUG=

Review URL: https://codereview.chromium.org/534843002

Cr-Commit-Position: refs/heads/master@{#294501}

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/556263005

Cr-Commit-Position: refs/heads/master@{#294500}

This CL is a second CL to move mock URLRequestJob files
from content/test/net/ to net/test/url_request/. The first
CL is crrev.com/541743002. The reason for this refactoring
is that Cronet (go/cronet) will need to use url_request_failed_job
and url_request_mock_http_job for testing. It will be nice
if they can be in net/test, as Cronet wouldn't need to depend
on content.

BUG=

Review URL: https://codereview.chromium.org/567563002

Cr-Commit-Position: refs/heads/master@{#294499}

Extract the handling of the clean exit beacon from MetricsService. The extracted implementation supports the use of a backup storage location and reports consistency between the two locations.

BUG=412398

Review URL: https://codereview.chromium.org/558683002

Cr-Commit-Position: refs/heads/master@{#294498}

Also fix the type of death messages expected in these tests.

BUG=398611

Review URL: https://codereview.chromium.org/563913002

Cr-Commit-Position: refs/heads/master@{#294497}

https://chromium.googlesource.com/chromium/blink/+log/a1f6307669c32a40076d299272d220343ff74bb9..a6d61dbff0a4bce30fce5b29c2efb77a94ddc3ee
TBR=jianli@chromium.org,loislo@chromium.org

Review URL: https://codereview.chromium.org/567803003

Cr-Commit-Position: refs/heads/master@{#294496}

Give the delegate class an ExtensionOptionsGuest member so that the
calls to the delegate do not require passing a WebContents.

BUG=409316

Review URL: https://codereview.chromium.org/562353002

Cr-Commit-Position: refs/heads/master@{#294495}

the request with a URLRequestRedirectJob. This is used by HSTS, the extension
webRequest API and protocol handlers.

These redirects are trusted and must be followed. However when such redirects are
triggered  for a cross-origin resource, e.g. <img src=".." crossorigin="anonymous">,
Blink blocks the redirect because the Access-Control-Allow-{Origin,Credentials}
response headers are missing.
This CL adds these headers to fix the problem.

Adding these CORS headers to the redirect response is safe, because CORS is still
enforced at the redirect target. For example, if HSTS is active for google.com and
an evil page embeds <img src="http://google.com/" crossorigin="use-credentials">,
then the image is not displayed because google.com does not reply with
"Access-Control-Allow-Origin: null".

BUG=387198
TEST=ExtensionWebRequestApiTest.WebRequestBlocking, HTTPSRequestTest.HSTSCrossOriginAddHeaders

Review URL: https://codereview.chromium.org/348253002

Cr-Commit-Position: refs/heads/master@{#294494}

* Move socket_permission_unittest.cc and usb_device_permission_unittest.cc
  into src/extensions -- they have no src/chrome dependencies.
* Move permissions_data_unittest.cc back into src/chrome -- its tests rely on
  extension manifest keys that aren't part of src/extensions yet.
* Rename the latter tests to PermissionsDataTest

BUG=397165
TEST=unit_tests PermissionsDataTest.* and extensions_unittests

Review URL: https://codereview.chromium.org/563663002

Cr-Commit-Position: refs/heads/master@{#294493}

Cr-Commit-Position: refs/heads/master@{#294492}

Apply WebUI styles to extension options pages that opt into using them
through a user agent stylesheet. The styles are copied from widgets.css
and chrome_shared.css in ui/webui/resources/css/ - this is intentional
so that WebUI changes won't break extensions.

The extension.css stylesheet will only be applied to extensions that
opt in using the "options_ui.chrome_style" manifest entry, and it will
only affect the options page specified in the manifest. The font
stylesheet for extensions have been moved to extension_fonts.css, and
are still applied to every extension page.

BUG=408271

Review URL: https://codereview.chromium.org/537773003

Cr-Commit-Position: refs/heads/master@{#294491}

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/566713004

Cr-Commit-Position: refs/heads/master@{#294490}

- Don't remove -fno-ident from gyp build (was added about 3y ago, seemingly unnecessary for current clang)
- Add -fno-slp-vectorize to GN to make builds match (both to be removed after next clang roll)
- Make usage of -Wno-reserved-user-defined-literal match (required for dbus pre-trusty)
- Add -march=x86-64 to gn cflags
- Default symbol_level based on is_debug, and turn it off by default in Release (same as gyp)

Also, fiddle with output of gyp_flag_compare.py.

R=brettw@chromium.org
BUG=335824

Review URL: https://codereview.chromium.org/562383002

Cr-Commit-Position: refs/heads/master@{#294489}

Revert of Move PseudoTCP and channel auth out of LibjingleTransportFactory. (patchset #5 id:100001 of https://codereview.chromium.org/551173004/)

Reason for revert:
Failed to compile on android builder.

http://build.chromium.org/p/chromium.webkit/builders/Android%20Builder/builds/46485

In file included from ../../remoting/protocol/pseudotcp_channel_factory.h:11:0,
                 from ../../remoting/protocol/pseudotcp_channel_factory.cc:5:
../../remoting/protocol/stream_channel_factory.h:34:41:error: 'string' in namespace 'std' does not name a type
   virtual void CreateChannel(const std::string& name,
                                         ^
../../remoting/protocol/stream_channel_factory.h:40:49:error: 'string' in namespace 'std' does not name a type
   virtual void CancelChannelCreation(const std::string& name) = 0;
...

Original issue's description:
> Move PseudoTCP and channel auth out of LibjingleTransportFactory.
>
> Previously TransportFactory interface was responsible for creation
> and initialization of several protocol layers, including PseudoTCP and
> authentication (TLS). Simplified it so now it only creates raw datagram
> transport channel. PseudoTcpChannelFactory is now responsible for
> setting up PseudoTcpAdapter and AuthenticatingChannelFactory takes care
> of channel authentication. Also added DatagramChannelFactory for
> Datagram channels.
>
> This change will make it possible to replace PseudoTcpChannelFactory
> with an object that creates SCTP-based channels.
>
> Also fixed a bug in SslHmacChannelAuthenticator. It wasn't working
> properly when deleted from the callback. (base::Callback objects
> shouldn't be deleted while being called because when deleted they
> also destroy reference parameters values they are holding).
>
> BUG=402993
>
> Committed: https://crrev.com/28d886c967e016a5d5812be43cd5916f577c2e10
> Cr-Commit-Position: refs/heads/master@{#294474}

TBR=wez@chromium.org,sergeyu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=402993

Review URL: https://codereview.chromium.org/570463002

Cr-Commit-Position: refs/heads/master@{#294488}

This was not included, but was referenced by ps_main.c

BUG=none
R=sbc@google.com, sbc@chromium.org, noelallen@chromium.org

Review URL: https://codereview.chromium.org/563863003

Cr-Commit-Position: refs/heads/master@{#294487}

Allow sigaltstack on Android as it is needed for thread creation.
On AARCH64, we now restrict setpriority() like on any architecture.

BUG=398611

Review URL: https://codereview.chromium.org/568533002

Cr-Commit-Position: refs/heads/master@{#294486}