GitLab

Revert of More System Dialog printing code disabled on Windows. (patchset #3 id:40001 of https://codereview.chromium.org/517193003/)

Reason for revert:
Need also to check if !ENABLE_FULL_PRINTING

Original issue's description:
> More System Dialog printing code disabled on Windows.
>
> BUG=374321
>
> Committed: https://chromium.googlesource.com/chromium/src/+/77daf4022522fd889f31fe8cb6abb33c45a54857

TBR=thestig@chromium.org,jschuh@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=374321

Review URL: https://codereview.chromium.org/546373002

Cr-Commit-Position: refs/heads/master@{#293688}

This is just a couple of quick sanity checks to prevent future regressions
like the one in the linked bug. It tests both a Search+Shift shortcut and
the corresponding Prefix Key shortcut.

Adds support for sending the meta modifier key in
aura/x11 tests.

BUG=404470

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291547

Committed: https://chromium.googlesource.com/chromium/src/+/8cab2737f1cb6e6011b0946f6bef5027868602c0

Review URL: https://codereview.chromium.org/490443002

Cr-Commit-Position: refs/heads/master@{#293687}

Revert of Forward input and compositing tasks to the Blink scheduler (patchset #21 id:400001 of https://codereview.chromium.org/363383002/)

Reason for revert:
suspecting it's causing the high rate of flakes in Instrumentation test ContentShellTest

BUG=411756

Original issue's description:
> Forward input and compositing tasks to the Blink scheduler
>
> Instead of posting input and compositor tasks directly to the
> main thread message loop, forward them to the Blink scheduler
> so they can be prioritized over other tasks.
>
> BUG=391005
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290845
>
> Committed: https://chromium.googlesource.com/chromium/src/+/68bab3290b45a8610ad875d3c92530477c16a948

TBR=jamesr@chromium.org,alexclarke@chromium.org,picksi@chromium.org,eseidel@chromium.org,skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=391005

Review URL: https://codereview.chromium.org/548253002

Cr-Commit-Position: refs/heads/master@{#293686}

Revert of cc: Single-threaded impl-side painting for unit tests (patchset #5 id:80001 of https://codereview.chromium.org/508373002/)

Reason for revert:
LayerTreeHostContextTestDontUseLostResources.RunSingleThread_DirectRenderer_MainThreadPaint Fails on Win7 bot after this change.

Speculative revert by sheriff.

http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/30957/steps/cc_unittests/logs/RunSingleThread_DirectRenderer_MainThreadPaint

Original issue's description:
> cc: Single-threaded impl-side painting for unit tests
>
> This adds methods to SingleThreadProxy to support impl-side painting
> when using the scheduler.  This allows most unit tests to test impl-side
> painting classes through both the single and threaded paths.
>
> The biggest caveat to this approach is the "commit waits for activation"
> logic that mailboxes want to use.  Because there is no easy way to block
> the only thread there is while activation happens, activation always
> happens immediately during commit, even if the tree is not ready.  To
> cause the tree to wait to draw until it is ready, drawing is prevented
> via SetRequiresHighResToDraw.  This prepares the way for the future
> where the SingleThreadProxy will likely commit directly to the active
> tree.
>
> The synchronous CompositeImmediately function does not support impl-side
> painting yet.  This is the path used by everything but unit tests at
> this point.
>
> R=danakj@chromium.org
> BUG=329553
>
> Committed: https://chromium.googlesource.com/chromium/src/+/7eee8e03582772716b820001af75343f6341e6e8

TBR=danakj@chromium.org,enne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=329553

Review URL: https://codereview.chromium.org/550073002

Cr-Commit-Position: refs/heads/master@{#293685}

When a receive error occurs, the SerialConnection pauses receives, which
triggers a call to CancelRead(). This should be a no-op as this occurs
after the previous read completed with an error, but
pending_read_buffer_ isn't cleared until after the error is reported to
SerialConnection. Thus, on posix, a call to ReadDone is enqueued, but
the pending read is cleared before it runs, leading to a crash. This
change clears pending_read_buffer_ and pending_write_buffer_ before
calling Done() or DoneWithError().

BUG=410331

Review URL: https://codereview.chromium.org/551713002

Cr-Commit-Position: refs/heads/master@{#293684}

BUG=393634

Review URL: https://codereview.chromium.org/548133002

Cr-Commit-Position: refs/heads/master@{#293683}

Cr-Commit-Position: refs/heads/master@{#293682}

Syncs to tip of tree to bring in fix for memory leak detected by LSan
and locally in memcheck on WebRTC code. Fixes were in usrsctplib
r8988-r8990.

R=tommi@chromium.org
BUG=

Review URL: https://codereview.chromium.org/550023002

Cr-Commit-Position: refs/heads/master@{#293681}

which leads to code duplication, platform #ifdef checks on multiple levels and
general confusion on how to work with the SyncSocket.

Typical use case for |SyncSocket|:
1. Browser creates and connects the socket pair - one for browser and one for renderer.
2. Browser prepares the foreign socket (Windows duplicates, POSIX creates file descriptor).
3. Browser relays the foreign socket handle to the renderer via IPC.
4. Renderer receives the IPC and creates the socket using the handle provided.
5. Sockets are ready for send/receive on both ends.

Steps 1-4 get simplified since there is no need to check the platform in order to prepare the socket for transit.

What this CL brings:
1. Adds |SyncSocket::TransitDescriptor| type which wraps the socket handle and is cross-platform.
2. Adds |SyncSocket::PrepareTransitDescriptor| method which is implemented depending on the platform.
3. Adds |SyncSocket::UnwrapHandle| method which unwraps |SyncSocket::Handle| from |SyncSocket::TransitDescriptor|.
4. Removes #ifdefs for platform-checks in code using |SyncSocket| and simplifies preparing the SyncSocket.

Note:
- There is still some less evident duplication in the ppapi and pepper-broker code which should be addressed.
- SyncSocket unit test should also be reviewed.
- There is a similar pattern when using SharedMemory.

BUG=409656

Review URL: https://codereview.chromium.org/525313002

Cr-Commit-Position: refs/heads/master@{#293680}

Since metadata properties fetched by DriveProvider in MetadataCache are going
to work for FSP also, it is renamed to ExternalProvider (since Drive and FSP
are both on the external backend).

TEST=Tested manually that Files app and the gallery work.
BUG=408017

Review URL: https://codereview.chromium.org/529413002

Cr-Commit-Position: refs/heads/master@{#293679}

Changing the order of weak_ptr_factory in src/sync module, to ensure proper cleanup while object is inactive.

BUG=303818

Review URL: https://codereview.chromium.org/509853003

Cr-Commit-Position: refs/heads/master@{#293678}

StreamCopyOrMoveImpl has some issue.
* Return infelicity error code.
* Don't notify to observer.
This issue is fixed in Issue 522543002 so we can support it in sandbox.

BUG=360088
TEST=content_unittests passed

Review URL: https://codereview.chromium.org/541363002

Cr-Commit-Position: refs/heads/master@{#293677}

For platforms that support multiple workspaces (currently Mac and Linux), this
allows app windows be visible on all workspaces simultaneously.

API proposal:
https://docs.google.com/document/d/1RC3CYwsrVxS_5hXg6nE3zA9y59G98z9Ezmmmq_Gzx9o/edit?usp=sharing

BUG=384644

Review URL: https://codereview.chromium.org/469993003

Cr-Commit-Position: refs/heads/master@{#293676}

TBR=bruening@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/549053002

Cr-Commit-Position: refs/heads/master@{#293675}

This class will be used for setting/reading the string positions
used by the enhanced bookmarks.
BUG=411412

Review URL: https://codereview.chromium.org/510543002

Cr-Commit-Position: refs/heads/master@{#293674}

This CL makes dragging an app in the experimental app list change pages at
the top and bottom of the apps grid rather than at the sides. This matches
the scroll behavior of the experimental app list.

BUG=406222

Review URL: https://codereview.chromium.org/518673008

Cr-Commit-Position: refs/heads/master@{#293673}

To support CDM_6, make the following changes:
- add SetServerCertificate
- add GetUsableKeyIds
- rename ReleaseSession to CloseSession
- add RemoveSession
- add SessionKeysChange event
- add SessionExpirationChange event

Includes changes to cdm_adapter for the new functionality. Changes to
use these new interfaces in blink in a future CL.

BUG=358271
TEST=existing EME tests still pass + manual testing

Review URL: https://codereview.chromium.org/496143002

Cr-Commit-Position: refs/heads/master@{#293672}

The content_shell_apk does not have the full native part that it should.
It builds, installs, starts, loads the native library, and then crashes
when it tries to access missing native parts.

This requires fixes to a bunch of little things:
1. Should only extract java files to compile from srcjars.
2. The way we were creating the single combined resources zip was wrong
because we were clobbering xml files (we should only clobber images, xml
files need to be handled more carefully). Instead of trying to properly
handle xml files, the combined zip now just puts all the different
dependencies in different folders (0/, 1/, etc) and then when packaging
we detect that type of zip and pass all the subdirs to aapt.
3. java_cpp_template with multiple sources needs to have a unique
depfile path for each source
4. jni_generator needs to clear the classlist variable in each loop of
foreach (otherwise gn complains about assigning to non-empty list)
5. a couple parts of apk native lib handling was not skipped for an apk
with no native lib

This adds a bunch of targets:
//base:base_java_test_support
//content/public/android:content_java_resources
//content/public/android:content_java
//content/public/android:content_strings_grd
//content/public/android:gesture_event_type_java
//content/public/android:page_transition_types_java
//content/public/android:popup_item_type_java
//content/public/android:result_codes_java
//content/public/android:selection_event_type_java
//content/public/android:speech_recognition_error_java
//content/public/android:top_controls_state_java
//content/public/android:screen_orientation_values_java
//content/public/android:content_gamepad_mapping_java
//content/public/android:content_jni_headers
//content/shell/android:content_shell_jni_headers
//content/shell/android:libcontent_shell_content_view (partial)
//content/shell/android:content_shell_java_resources
//content/shell/android:content_shell_java
//content/shell/android:content_shell_apk_resources
//content/shell/android:content_shell_apk
//net/android:net_java
//net/android:remote_android_keystore_aidl
//net/android:net_java_test_support
//net/android:net_javatests
//net/android:net_errors_java
//net/android:certificate_mime_types_java
//net/android:cert_verify_status_android_java
//net/android:private_key_types_java
//net/android:net_unittests_apk (disabled)

TBR=yfriedman,thestig
BUG=359249

Review URL: https://codereview.chromium.org/507523002

Cr-Commit-Position: refs/heads/master@{#293671}

It doesn't need to run as part of Chrome's unit_tests

BUG=397164
TEST=extensions_unittests

Review URL: https://codereview.chromium.org/548653002

Cr-Commit-Position: refs/heads/master@{#293670}

media/base/user_input_monitor_linux.cc depends on //ui/gfx/x and
//ui/events:events_base

Review URL: https://codereview.chromium.org/547533006

Cr-Commit-Position: refs/heads/master@{#293669}

This stuff is needed to get blink linking in android.

R=brettw@chromium.org,fbarchard@chromium.org

Review URL: https://codereview.chromium.org/541953002

Cr-Commit-Position: refs/heads/master@{#293668}

Let's let the compiler do its job :). As mentionned in https://codereview.chromium.org/532533002/ this preprocessor precondition is useless as the linker will removed the unreferenced code anyway, and this break the PGO build.

TBR=magjed, tommi
NOTRY=true

Review URL: https://codereview.chromium.org/546043003

Cr-Commit-Position: refs/heads/master@{#293667}

BUG=387288

Review URL: https://codereview.chromium.org/547593002

Cr-Commit-Position: refs/heads/master@{#293666}

Revert of Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup (patchset #3 id:40001 of https://codereview.chromium.org/513313004/)

Reason for revert:
Caused cast_unittest rtcp test failures on Linux Asan Lsan builders (memory leaks).

http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7132

Original issue's description:
> Cast: Re-factor rtcp_sender.cc into rtcp_builder.cc and do some cleanup
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6217e450d9e75037c62fff773c94aebe7f3ed2e6

TBR=miu@chromium.org,hubbe@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/541293004

Cr-Commit-Position: refs/heads/master@{#293665}

Cr-Commit-Position: refs/heads/master@{#293664}

To support unbundled updates we need to stop depending on system
libraries. Disable using the system version of libjpeg and instead link
Chromium's libjpeg_turbo.

This increases binary size by ~120KB.

BUG=409851

Review URL: https://codereview.chromium.org/548513002

Cr-Commit-Position: refs/heads/master@{#293663}

https://skia.googlesource.com/skia/+log/ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba..9f8cab153878f6e88190c5e2ef572ee708791177

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/549923002

Cr-Commit-Position: refs/heads/master@{#293662}

Removing LOG(WARNING) from DataReductionProxyUsageStats that made it in https://codereview.chromium.org/510353004/

BUG=409934

Review URL: https://codereview.chromium.org/547753003

Cr-Commit-Position: refs/heads/master@{#293661}

Cr-Commit-Position: refs/heads/master@{#293660}

Review URL: https://codereview.chromium.org/513313004

Cr-Commit-Position: refs/heads/master@{#293659}

BUG=409705

Review URL: https://codereview.chromium.org/545683003

Cr-Commit-Position: refs/heads/master@{#293658}

Review URL: https://codereview.chromium.org/535773002

Cr-Commit-Position: refs/heads/master@{#293657}

If a mask layer's width or height are larger than the max texture size,
we do not use the contents of the mask layer. So if we're not going to
use the contents, there's no reason to make tiles and allocate memory
for them.

This changes PictureLayerImpl to return an empty tile size for masks
that are too large to have tiles. Then changes PictureLayerTiling to
use the empty tile size as a signal to make the whole tiling an empty
size.

Last, we use the empty tile size to also signal not making a low res
tiling, so that masks continue to not get a low res tiling if they are
large.

R=enne, vmpstr
BUG=409984

Review URL: https://codereview.chromium.org/547463002

Cr-Commit-Position: refs/heads/master@{#293656}

They are:
- app_locale_settings.h
- ui_unscaled_resources.h
- webui_resources.h

BUG=401588
TEST=None
R=thestig@chromium.org,thakis@chromium.org
TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/530623002

Cr-Commit-Position: refs/heads/master@{#293655}

behind the fullscreen and profile buttons.
Calculate the maximum number of times we can show and hide the rest, similar
to how it works on Linux and Windows.
Also changed so that only the one active tab has a bigger minimum width (and
draws the close button) instead of potentially multiple selected tabs. This also
matches Linux and Windows.

BUG=392137

Review URL: https://codereview.chromium.org/476313003

Cr-Commit-Position: refs/heads/master@{#293654}

Revert of [Mac] Shut down connections to WindowServer before engaging the sandbox. (patchset #1 id:1 of https://codereview.chromium.org/545603002/)

Reason for revert:
Speculative revert: seems this change caused 135 layout tests failures on the webkit mac builders, from OSX 10.6-10.9

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.6%20%28deps%29/builds/30830

Original issue's description:
> [Mac] Shut down connections to WindowServer before engaging the sandbox.
>
> The connection is only needed during sandbox warmup to initialize the default
> color space. It was formerly needed by scrollbar NSAnimations, but that was
> replaced via https://codereview.chromium.org/529103002/.
>
> BUG=397642,306348
> TEST=Manually tested on 10.6-10.10.
> R=avi@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/d9707172e540487d14c53363c5d1c2151999c2d8

TBR=avi@chromium.org,rsesek@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=397642,306348

Review URL: https://codereview.chromium.org/550763002

Cr-Commit-Position: refs/heads/master@{#293653}

BUG=411648
TBR=hans@chromium.org

Review URL: https://codereview.chromium.org/548083002

Cr-Commit-Position: refs/heads/master@{#293652}

https://skia.googlesource.com/skia/+log/a1ae66d252edf6da932caed1fe43d11216e56c0e..ce23aaee8dfb3dff1acc2294f775e4f3fcf002ba

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=fmalita@google.com

Review URL: https://codereview.chromium.org/550743002

Cr-Commit-Position: refs/heads/master@{#293651}

In https://chromiumcodereview.appspot.com/473583002/ we removed a
'shadow' element in thumbnail <iframe> to improve customization. A side
effect is that this exposes the thumbnail image, thereby alow the user
to futilely access the chrome-search://thumb/#/# image below. This CL
adds back a transparent "blocker" in front of the thumbnail to restore
old behavior. Also making 2 CSS changes to:
- Fix fake box text positioning for RTL.
- Move top-margin back from #ntp-contents to #logo, for correctness.

BUG=411005

Review URL: https://codereview.chromium.org/542033002

Cr-Commit-Position: refs/heads/master@{#293650}

BUG=411565

Review URL: https://codereview.chromium.org/549723002

Cr-Commit-Position: refs/heads/master@{#293649}