GitLab

When a Crostini app is started by clicking on the launcher item, this
change makes the app windows start in the same display as the launcher.

BUG=chromium:843001
TEST=Manual test on an eve device.

Change-Id: Id3b65d71148d1e4107d8f9bddd31b2a27df6a58b
Reviewed-on: https://chromium-review.googlesource.com/1089880Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Commit-Queue: Tim Zheng <timzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565391}

At the moment, the implementation of the startup notification protocol [1]
does only make sure that the window manager gets notified when the startup
process finishes for non-primary instances of the main process, that is,
when the user attempts to spawn a new chromium-browser process while another
instance is already running.

This is because ProcessSingleton::NotifyOtherProcessWithTimeout() is the only
placed where NotifyWindowManagerStartupComplete() is being called, which used
to be fine when chromium relied on GTK+ for its top-level windows (GTK+ calls
gdk_display_notify_startup_complete() when mapping the top-level window) in
the past, but now that chromium relies on Aura, it's necessary to add another
explicit call in the codepath that completes startup for the main instance.

[1] https://www.freedesktop.org/wiki/Specifications/startup-notification-spec

Bug: 553956
Change-Id: Ie9bf2db9bc04589229a18785771b6fc97dbcc9bd
Reviewed-on: https://chromium-review.googlesource.com/1072088Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565390}

Check that the display supports color correction before trying to apply
it to the hardware.

BUG=850182
TEST=Ran on device and verified NOTREACHED in
HardwareDisplayPlaneManagerLegacy isn't triggered.

Change-Id: I086e718e7ebfa8bbaf0286dac411ffee45a743ef
Reviewed-on: https://chromium-review.googlesource.com/1089858Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565389}

Bug: 850078
Change-Id: I414ccfe5457ea91f482ed18494c70b2dbc1681b4
Reviewed-on: https://chromium-review.googlesource.com/1089831
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565388}

Using wpt-import in Chromium ab8ee841.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"
fbdd17fb "Improve RTCPeerConnection-setRemoteDescription-tracks.https.html tests."
c220be7c "Fire RTCPeerConnection.onsignalingstatechange in the correct order."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19163

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
drott@chromium.org, kojii@chromium.org:
  external/wpt/css/css-fonts
rego@igalia.com:
  external/wpt/css/css-ui

TBR=foolip

No-Export: true
Change-Id: Ie665876ce5e3950d3c44bf473ec091fc4dc5d26b
Reviewed-on: https://chromium-review.googlesource.com/1091219
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565387}

Since dynamic pins are going away.

Bug: 779166
Change-Id: I3872a872b84f0780facd161f7abb88990a872b31
Reviewed-on: https://chromium-review.googlesource.com/1087646
Commit-Queue: Chris Palmer <palmer@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Reviewed-by: Nick Harper <nharper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565386}

Merge the following into item_horizontal_padding:
 - icon_to_label_padding
 - item_left_margin
 - label_to_minor_text_padding

Merge the following into touchable_item_horizontal_padding:
 - touchable_icon_to_label_padding
 - touchable_item_left_margin

Bug: 850172
Change-Id: I3ae0207b1a1d332ac636b70a2f3c48817068ca20
Reviewed-on: https://chromium-review.googlesource.com/1089431
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565385}

We don't need to compiler workarounds for initializing text runs
anymore.

Also, harmonize escaped notation: Replace \x notation with using full
length \U universal character names.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I020cb509bf3a89eebbf9629da45a26061e4ac04c
Reviewed-on: https://chromium-review.googlesource.com/1091461
Commit-Queue: Dominik Röttsches <drott@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565384}

1. Mimic Page Info behavior on URL -> add copying URL to clipboard
after long press on header
2. Move code to using lambdas in TabularContextMenuUi.java

Change-Id: If61c74b6abe1bff37b7fe168715041d8ed5d0028
Reviewed-on: https://chromium-review.googlesource.com/1088692Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#565383}

https://chromium.googlesource.com/catapult.git/+log/1331d4b..72a8685


git log 1331d4b..72a8685 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 simonhatch@chromium.org Dashboard - Remove some unused indexes from TestMetadata.
2018-06-07 simonhatch@chromium.org Dashboard - Skip empty last_ran_timestamps
2018-06-07 simonhatch@chromium.org HistogramSet - Merge TagMap diagnostics in add_reserved_diagnostics
2018-06-07 simonhatch@chromium.org Dashboard - Removed unused global from pinpoint_request.py


Created with:
  gclient setdep -r src/third_party/catapult@72a8685

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:849752
TBR=sullivan@chromium.org

Change-Id: I34997ad164552bf636bd13c5dce8f68fd2f47c16
Reviewed-on: https://chromium-review.googlesource.com/1091173Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565382}

Clients of //ios/web_view may display a favicon as a UIImageView.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I85da27ac6fbcd4b8a0244d468daf17cb8c619499
Reviewed-on: https://chromium-review.googlesource.com/1089644Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565381}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/0de5a91..a206cf9


git log 0de5a91..a206cf9 --date=short --no-merges --format='%ad %ae %s'
2018-06-07 hidehiko@chromium.org Remove 90 min timeout for Pre-CQ launching.
2018-06-07 nya@chromium.org sync_stages: Detect early crashes of pre-CQ builders with Buildbucket.


Created with:
  gclient setdep -r src/third_party/chromite@a206cf9

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:843640,chromium:843640
TBR=chrome-os-gardeners@chromium.org

Change-Id: I8545700c0cb5acc6ddf0a2762670d305be5692af
Reviewed-on: https://chromium-review.googlesource.com/1090764Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#565380}

Releasing new Chromedriver 2.40

Change-Id: Icca7d51d495fe4fe86aa3bc49c00d04eb636fa40
Reviewed-on: https://chromium-review.googlesource.com/1091234
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565379}

The SimplerURLLoader API is compatible with the out-of-process network
service.

This is the only code that uses chunked uploads, and the new API for
that requires the consumer handle all the complexities of that, which
makes this CL much more complicated than most URLFetcher to
SimplerURLLoader conversions.

BUG:  810555

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_vr
Change-Id: I4cc1f5f8710d08830062e95296ae5d814a6097e8
Reviewed-on: https://chromium-review.googlesource.com/1050825Reviewed-by: Biao She <bshe@chromium.org>
Reviewed-by: Tommi <tommi@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Doug Turner <dougt@chromium.org>
Reviewed-by: Max Morin <maxmorin@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565378}

Move image_decoding_cases into rendering folder and modify to inherit
from RenderingStory class

Bug: 849392
Change-Id: I56b02c60c1f674f7c48b8bf378b8bc92f68f4205
Reviewed-on: https://chromium-review.googlesource.com/1089290
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#565377}

fidl_library.gni will be used for targets defined outside "third_party",
so promoting the GN template to a higher level makes sense.

The relocation was verified using "gn gen --check".

TBR=sergeyu@chromium.org

Change-Id: Ib632e466185f77f7b4f5bc43b13439bdd28faf3c
Reviewed-on: https://chromium-review.googlesource.com/1091157Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565376}

This change creates the NetBiosClientInterface. This interface will allow
us to create a FakeNetBiosClient that can be injected into the
NetBiosHostLocator class for testing.

Bug: chromium:757625
Change-Id: Iadf5965ce43a504f5babe2220944d91b48b9d537
Reviewed-on: https://chromium-review.googlesource.com/1081299
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565375}

https://chromium.googlesource.com/chromium/third_party/ffmpeg.git/+log/1da9c3346d87..f7d78b109d17

$ git log 1da9c3346..f7d78b109 --date=short --no-merges --format='%ad %ae %s'
2018-06-05 liberato Updated chromium/patches/README
2018-05-31 michael avcodec/vp3: Fix end of bitstream check in unpack_superblocks()
2018-06-05 liberato Automatically build chrome patches with find_patches.py
2018-05-31 modmaker Fix heap buffer overflow.
2018-06-01 liberato Add check_merge.py
2018-05-24 liberato Add null check for encryption info.
2018-05-21 liberato Configs for merge-m68a
2018-05-15 michael avformat/mov: Only fail for STCO/STSC contradictions if both exist
2018-05-15 michael avformat/mov: Break out early if chunk_count is 0 in mov_build_index()
2018-05-20 jerome.borsboom avcodec/vc1: FIELDTX is only present in interlaced frame I/BI pictures
(...)

Created with:
  roll-dep src/third_party/ffmpeg
BUG=832852

Change-Id: If5ffa2bfedd2bdd9a43ac338455af9993d634b93
Reviewed-on: https://chromium-review.googlesource.com/1087767Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Frank Liberato <liberato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565374}

Now that the app shell is being built on the bots, it shouldn't give verbose
logging output during the build.  This CL is a partial merge of [1], which fixed
the issue for the Linux Chrome packages.

[1] https://chromium.googlesource.com/chromium/src/+/8e3b5543f0dfc6585ad06aa2c2235a3a813438cd

BUG=None
R=michaelpg

Change-Id: Id97fe1b3e6694a15e36f324d954a9fa7e2b61e7b
Reviewed-on: https://chromium-review.googlesource.com/1091295Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565373}

We previously had a behavior in the new Android horizontal tab switcher where
opening the tab switcher would show the previous tab instead of the current one.
I previously landed a CL to remove this behavior, but swiping down from the
toolbar is still showing the previous tab. It turns out there's a totally
separate piece of pre-existing logic that, together with the scroll snapping,
is actually causing swiping down from the toolbar to still go to the previous
tab. We of course did not notice this prior to removing the "show previous tab"
behavior.

This CL fixes this pre-existing logic to not show the previous tab.

Bug: 849480,831359
Change-Id: I0b89f87e536c5d4938638fbd6ac7fabde568e772
Reviewed-on: https://chromium-review.googlesource.com/1091230Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565372}

These tests mix use of QuitCurrent*Deprecated() with use of the current
RunLoop::Quit*Closure() model. Migrate them off the deprecated API so
that we can enforce quit-by-closure-only wherever QuitClosure is used.

Bug: 844016
Change-Id: I5c8b2557d361ea9ade9f5da0440bac7f7878440e
Reviewed-on: https://chromium-review.googlesource.com/1090214Reviewed-by: Nicolas Zea <zea@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565371}

Add function to convert byte array spans into stringpiece
representations in fido_parsing_utils.

Change-Id: I8a5aca9c980cee994aeb6b46fd2cfd7f5417998c
Reviewed-on: https://chromium-review.googlesource.com/1087816
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565370}

content:Shell used QuitCurrent*Deprecated(), while many of the //content
browser-tests use the modern RunLoop::Quit*Closure() mechanism.

Migrate content::Shell off the deprecated API, so that we can enforce
quit-by-closure-only wherever QuitClosure is used.

TBR: kinuko
Bug: 844016
Change-Id: I661c3ed1c799680dea9760d3fb43d78aa8039897
Reviewed-on: https://chromium-review.googlesource.com/1090219Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565369}

We are in the process of migrating ContentHashFetcher from
URLRequestFetcher to SimpleURLLoader (see bug 844926).

For this, we need to stop storing URLRequestContextGetter
raw pointers in ContentHash::FetchParam. Instead it will store
a std::unique_ptr<network::SharedURLLoaderFactoryInfo> instance,
which is non-copyable.

This is a preparation CL that adapts ContentHash::FetchParam
to hold non-copyable members. For this, it removes both copy-ctor
and the assignment overload (=), and uses std::move to pass
FetchParam instances around.

BUG=844926

Change-Id: I417543ddd377eef39146fcce69c325a35c499f6c
Reviewed-on: https://chromium-review.googlesource.com/1089273
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565368}

Bug: 843124
Change-Id: I56b9beb4e16e74361cf291998fc78ec232c6fc0c
Reviewed-on: https://chromium-review.googlesource.com/1089587
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565367}

Bug: 813104
Change-Id: I0139374f0f05c2a685d413e8c9d4bfcd5204cd67
Reviewed-on: https://chromium-review.googlesource.com/1088702
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565366}

Also rename from LevelDBWrapper to StorageArea to better reflect what
the interface is used for.

Bug: 781870, 809771
Change-Id: I712fee920d95f5e18dc6bfa74d1277c8aed4bd19
Reviewed-on: https://chromium-review.googlesource.com/1087495Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Marijn Kruisselbrink <mek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565365}

SynchronousCompositorProxy only uses mojo and no longer uses the old
IPC. Mojo is now the default implementation rather than a subclass of
SynchronousCompositorProxyMojo.

Bug: 687695
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ieddf50f1441648ba1a88197b690b321ff6f83ba1
Reviewed-on: https://chromium-review.googlesource.com/1062956Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: James Wallace-Lee <jamwalla@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565364}

Bug: 831123
Change-Id: Ic6e39ee80a0db626b04b163314ed9589997fa268
Reviewed-on: https://chromium-review.googlesource.com/1090928Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565363}

This reverts commit 43bebb1d.

Reason for revert: suspected to have broken analyze on android CQ bot
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/android-kitkat-arm-rel?limit=200
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/android-kitkat-arm-rel/6471

ERROR at //components/browser_sync/profile_sync_test_util.cc:27:11: Include not allowed.
#include "services/network/test/test_url_loader_factory.h"

Original change's description:
> Migate SyncStoppedReporter to SimpleURLLoader
> 
> Bug: 844966
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I3c198d95735770668eed4a1342a3979224239529
> Reviewed-on: https://chromium-review.googlesource.com/1089132
> Commit-Queue: Mark Pilgrim <pilgrim@chromium.org>
> Reviewed-by: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Matt Menke <mmenke@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565321}

TBR=sky@chromium.org,mmenke@chromium.org,pilgrim@chromium.org,mastiz@chromium.org

Change-Id: Iaf73cd80c169fc9451d82c42f807685258d3b09f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 844966
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1091306Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565362}

This reverts commit c7c852a5.

Reason for revert: This did not revert cleanly. generate_build_files is failing e.g. https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-gcc-rel/12779

Original change's description:
> Revert "S13n: Port components/image_fetcher to SimpleURLLoader."
> 
> This reverts commit d6f27e51.
> 
> Reason for revert: image_fetcher is used from more than UI thread,
> and SharedURLLoaderFactory isn't cross-thread.
> 
> Note that this isn't a 100% mechanical revert since it needed a merge
> with some ImageDataFetcher cleanups; I also kept in some iOS glue bits
> that are used in a pending CL and aren't directly related to the substance
> of the revert.
> 
> Bug: 850089
> 
> Original change's description:
> > S13n: Port components/image_fetcher to SimpleURLLoader.
> >
> > URLFetcher will stop working in the browser process with advent
> > of Network Service, and SimpleURLLoader is the replacement API
> > for most clients.
> >
> > Bug: 843205
> > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
> > Change-Id: I23f22f2b00e4ece0ca85d0bad95909cd15309eb6
> > Reviewed-on: https://chromium-review.googlesource.com/1060254
> > Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> > Reviewed-by: Eugene But <eugenebut@chromium.org>
> > Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> > Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> > Commit-Queue: Maks Orlovich <morlovich@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#564526}
> 
> TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 843205
> Change-Id: Ifeb0c24a9e83bf271be3f10cb32f6d81ea0d0832
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
> Reviewed-on: https://chromium-review.googlesource.com/1090930
> Commit-Queue: Maks Orlovich <morlovich@chromium.org>
> Reviewed-by: Maks Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565348}

TBR=rogerta@chromium.org,jam@chromium.org,mathp@chromium.org,eugenebut@chromium.org,gambard@chromium.org,morlovich@chromium.org

Change-Id: Iee4b628c585b7f3f4509f4dc0c691a012d31c874
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 850089, 843205
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1091305Reviewed-by: Kevin McNee <mcnee@chromium.org>
Commit-Queue: Kevin McNee <mcnee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565361}

It already runs on the regular linux main waterfall and memory bots.

TBR=hans

Bug: 843511
Change-Id: I3f5f97694291f4143614fb2b72344dda31cf1556
Reviewed-on: https://chromium-review.googlesource.com/1091141Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565360}

BUG=NONE

Change-Id: I6130bcff05d90ad35b3106eeee6d8973c58b8c11
Reviewed-on: https://chromium-review.googlesource.com/1090311Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Toni Barzic <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565359}

https://github.com/w3c/csswg-drafts/issues/2714 clarified that
serialization should always use the expanded form.

Bug: 850537
Change-Id: I77e60df149fb490b0c2c1db78f020a7246ea7b5c
Reviewed-on: https://chromium-review.googlesource.com/1090820Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565358}

We collect logs from the VM after tests. The problem is, if the test
hangs indefinitely, we won't get a chance to grab the logs before
swarming kills us when we reach the timeout.

Swarming sends a SIGTERM, waits for grace_period, then SIGKILLs the task
if it's still running. This CL will catch the SIGTERM and kill what
should be the frozen test process. This will let cros_run_vm_test pull
the logs before we get SIGKILLed.

Bug: 848402
Change-Id: I48be1de865e3b287584978b5461f15e2bae49dfd
Reviewed-on: https://chromium-review.googlesource.com/1087800
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565357}

This CL renames the send_command_and_get_result endpoint to
/goog/cdp/execute which follows the extension specification format
and is a more appropriate API name. Note we still support the old name.

Bug: chromedriver:2307
Change-Id: Ia7a389781eb92a2cf9bd6244e766e6c32e9b5ab9
Reviewed-on: https://chromium-review.googlesource.com/1091216Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565356}

Since these two flags should map 1:1 to each other, this change removes
the former in favor of the latter, which is reachable from
SourceBufferState even before OnSourceInitDone has occurred.  It also
notes a pre-existing spec incompliance with newly filed crbug 850316.

BUG=607372,850316

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I83d10db6b7c367615f5b968447dbdb415aee5cb7
Reviewed-on: https://chromium-review.googlesource.com/1089494Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565355}

Bug: 827376
Test: Run WizardControllerDemoSetupTest
Change-Id: I84525ecf4b370fac104aba99e8da04eaf32342de
Reviewed-on: https://chromium-review.googlesource.com/1088127Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565354}

Connect ConsentSyncBridge to ConsentAuditor behind a feature
on all platforms except iOS. ConsentAuditor does not use the
bridge at all yet.

This CL is a part of a series to split user consents from user events
into a separate datatype.

Bug: 840357
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Id23914d4afcf105f21dab856208d98979aa82209
Reviewed-on: https://chromium-review.googlesource.com/1084475
Commit-Queue: vitaliii <vitaliii@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565353}

Toolkit-views menus positioned with POSITION_BEST_FIT are be
positioned to the side of the anchor when the menu height is greater
than ~50% of the screen. Currently in this situation, the "actual"
position of the menu is incorrectly recorded as POSITION_BELOW_BOUNDS.
If a menu delegate invokes MenuChildrenChanged() and recalculates the
menu bounds, this can cause the menu to reposition itself under
the anchor rather than remaining to the side.

To fix, record the "actual" position as POSITION_BEST_FIT in this
situation.

Bug: 840919
Change-Id: I4102e014c058b2f89d5bc38b7b4371c010367119
Reviewed-on: https://chromium-review.googlesource.com/1087516
Commit-Queue: Tessa Nijssen <tnijssen@google.com>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#565352}