- 19 Jun, 2020 40 commits
-
-
Maggie Chen authored
Optimization: If clipping is on, clip the overlay quad first. Then the occluding damage rect will intersect with the clipped overlay quad. Bug:1096097 Change-Id: I741cbd45f5ed11118185a69b03753fe6108563ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249597Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780497}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/64150e03b378..f8393bee83f1 2020-06-19 jrw@google.com Made certificate_proto fuzzable. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ieb60628a3d1071e1c11696d6eec15f984560b2a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255164Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780496}
-
Henrique Ferreiro authored
The main change in this CL is using the same cursor fallback selection machinery for both Aura/X11 and Ozone/X11. In addition to that: Cursor loading now uses cursor names, instead of a mix of cursor names and shapes (as introduced in [0]), given that all shapes can be loaded by Xcursor using their corresponding name. The CSS name is preferred over other options, relying on cursor themes usually linking known cursor names to cursors defined in the theme, or alternatively, picking alternative cursors as defined in a fallback table. It fixes the w-resize fallback changing it to left_side and replaces v-scroll and h-scroll (introduced in [1]) with all-scroll, as they are only available on Windows. [0]: https://crrev.com/c/1998353 [1]: https://crrev.com/c/1638924 Bug: 1029142 Change-Id: If50698d5305135be43cda4eeb48532d23816754f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245704 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#780495}
-
Yi Xu authored
Change-Id: Ib9f3c32779cc410b010c6f3940fa75f2b16bb65f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252696Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#780494}
-
Jose Dapena Paz authored
Bug: 819294 Change-Id: Ibf5b13cdccaa371b7f5972bf511aeb20ed1bf9c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252000 Commit-Queue: José Dapena Paz <jdapena@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#780493}
-
Scott Lee authored
R=robertma@chromium.org CC=chanli@chromium.org,iannucci@chromium.org,nodir@chromium.org Bug: 1084459 Change-Id: I5927eae3308757027aab956dcc5086e7dc596983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253140 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#780492}
-
Chris Cunningham authored
Change-Id: Ib74ee08c23c077c729923397cae17c72811d83f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255022 Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#780491}
-
Brian Geffon authored
When reading procfs files we shouldn't use the base file operations as they are annotated as MAY_BLOCK. This CL introduces an equivalent to base::ReadFileToString which doesn't have any blocking annotations. Bug: 1090623 Change-Id: I159f239caf1fe0613de9fdb92cd5fca687cb955b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229153 Commit-Queue: Brian Geffon <bgeffon@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#780490}
-
Sergey Ulanov authored
baseaudiocontext-audioworklet.https.html is flaky due to dependency on FuchsiaMediaResourceProvider, which is currently not implemented in content_shell TBR=chonggu@google.com Bug: 1061226, 1096611 Change-Id: I79d642bc0353117dde81cfa566881ac2075c5156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255518Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#780489}
-
Philip Rogers authored
Bug: 1097346 Change-Id: I09239e7647e182e1094ffed28aecd12c89f31fa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255218 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780488}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1909f444..a9ea1674 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1b2ccd305c8f23771f56f18205b369db1e41c708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254881Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780487}
-
Aleks Totic authored
Algorithm helpers that distribute widths to columns. Bug: 958381 Change-Id: I2a876e81c8caa6ef4743f3c4ae5fd4f45f6fec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242129Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780486}
-
Adam Langley authored
(Test-only change.) The following change[1] updates |GetAssertionTask| to only assert the matching credential after a silent probe batch. However, some of the golden-data tests then fail because they were returning a different credential ID, and that mismatch isn't caught until higher up in the stack. Fixing that causes other test failures and so on. This change is the transitive closure of updating all the mismatched test data. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2250893 Change-Id: Ida7a92f7e8b2bbaa74352caf6963c6ce0c00e246 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252640 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#780485}
-
Sebastien Marchand authored
Change-Id: Ife0bbd6baa9deedac77a777ddc672d723dd276c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255121Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#780484}
-
Zach Trudo authored
Priority will be needed to identify which queue a sequencing id belongs to. Also - minor cleanup of unused using statements. Bug: chromium:1078512 Change-Id: Ic851eb5dfc0aba8460218241cf30ff7a86380c39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252948 Auto-Submit: Zach Trudo <zatrudo@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#780483}
-
Victor Vasiliev authored
https://quiche.googlesource.com/quiche.git/+log/46d05bc682ff..37b2e1806f4a $ git log 46d05bc68..37b2e1806 --date=short --no-merges --format='%ad %ae %s' 2020-06-18 renjietang Fix incorrect determination of stream type in QUIC T050. 2020-06-18 fayang In quic, bundle server initial crypto data with initial ack. protected by gfe2_reloadable_flag_quic_bundle_crypto_data_with_initial_ack. 2020-06-18 fayang In quic, include undecryptable packets information in error details when client closes connection with quic_handshake_timeout for debugging purpose. client only, not protected. 2020-06-18 dschinazi Properly ignore HTTP Infomational 1XX status codes in QUIC 2020-06-18 renjietang Turn on end_to_end tests on TLS 0-RTT reject. 2020-06-18 renjietang In QUIC client with TLS versions, delay retransmission of 0-RTT packets until 1-RTT keys are available. 2020-06-18 fayang In quic with tls, remove the head of line blocking caused by an unprocessable packet. protected by gfe2_reloadable_flag_quic_fix_undecryptable_packets. 2020-06-17 nharper Support 0-RTT TLS in QuicSpdySession Created with: roll-dep src/net/third_party/quiche/src R=dschinazi@chromium.org Change-Id: I2018fb64314c84bdb297bbe5551e8c3fee3796fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254467Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#780482}
-
Chris Harrelson authored
The original CL that added it was: https://codereview.chromium.org/1413363003 which has to do with the ways in which the pre-BGPT system explained scrolling and fixed-position elements to the compositor. Since then BGPT shipped, which no longer requires communicating this via the graphics layer tree. Bug: 1096732,950418 Change-Id: I9d6fe98298d69244ad4ca298e934d5c5765cf2da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253282Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#780481}
-
Nina Satragno authored
Fix the inline biometric enrollment dialog button not getting focus by default. Fixed: 1097311 Change-Id: I58cf4492287b68cc7ce5bb3f6980e65d3caebd80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255101 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#780480}
-
Xiyuan Xia authored
ui::ThroughputTracker should not be reused. It DCHECKs when data tracking overlaps and drop reports when it happens. This CL changes to create a new ui::ThroughputTracker instance when the hover card bubble animation starts. This also fixes one crash that a browser window on external display gets moved to internal display when disconnecting external displays, where the Compositor becomes invalid. Bug: 1060816, 1096840 Change-Id: I63b50279492fe2e464ed45efd7139e4cb8a43148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254698Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780479}
-
Lijin Shen authored
Add metrics for recording: 1. the state of the default brwoser when promo is displayed 2. the result of the promo 3. the reason of dismissing the dialog Bug: 1090103 Change-Id: I38c04bb12272a3128afcb6f0762c8ee16ea4b121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248453 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#780478}
-
Gabriel Charette authored
Use a scoped trace event for the duration of RunServiceManager ends up covering the main RunLoop::Run() and adding an event over idle phases of the main thread (undesired) : https://snipboard.io/S2puE6.jpg Changed to emit an instant event that highlights when RunServiceManager starts without tracking it through the entire browser lifetime. R=oksamyt@chromium.org, rockot@google.com Bug: Event over idle phases in startup traces. Change-Id: I0bb36e9446a052059973af3445727128113eb168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254097 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#780477}
-
Ian Kilpatrick authored
Also changes some text in this test as well. Bug: 1097225 Change-Id: I3dc128dee8d5f35d30509af38291183297ffc535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254824 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#780476}
-
Toni Barzic authored
During hotseat drag, if the gesture keeps moving up after the hotseat has been fully extended, the hotseat will stop moving. Do not record the presentation time metric, as there may not be any changes for compositor to handle. In that case, all pending presentation durations would be recorded when the gesture ends, with inflated presentation time values. BUG=1093068 Change-Id: I449e9af5658b8d2de706cbdf843e0ddd96e940ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252947Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#780475}
-
Andrew Grieve authored
Bug: 1095654 Change-Id: I55cd6e7c1871fc681480927b9fb90a8466d4791b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255099 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#780474}
-
Kalvin Lee authored
This change moves some header inclusions around to properly respect our philosophy of IWYU. Bug: chromium:888189 Test: simple-chrome with board=coral Change-Id: If48d9ea596578adf2c26ade54e0c28478b4c37ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248452Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Kalvin Lee <kdlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#780473}
-
Tibor Goldschwendt authored
Image doodles have a background color they are designed for (white for light mode doodles). If the NTP's background doesn't match this color the image doodle is shown in a box of its design background color. We sent the doodle design background color via mojo in preparation of dark mode doodles that will have a different color. Bug: 688960 Change-Id: I70bb8be129228a8e35cdbfd16fee9a3b2f2d79ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253210 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#780472}
-
Aya ElAttar authored
Fixed a reversed condition caused safe API permissions trigger full warning on the login screen of the managed-guest session. Bug: 1096838 Change-Id: I535d823c26de93a6934e82e61c2b12b27fc73680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253758Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#780471}
-
David Bokan authored
This CL makes it so that portal activation is blocked when the document enters a beforeunload handler. If the unload proceeds, portal activation will continue to be blocked This must be implemented inside the renderer as the renderer can initiate navigations which the browser won't hear about until after beforeunload is confirmed. We do this by looking at the Document's LoadEventProgress state. Unfortunately, the current behavior is that, following a beforeunload, this state would progress unconditionally to kBeforeUnloadEventCompleted. This prevents us from distinguishing the case where the navigation is canceled, which should once again allow portal activation. This CL updates this state to only progress to the (renamed for consistency and clarity) kBeforeUnloadEventCompleted state only after we confirm the unload will proceed. Bug: 1043764 Change-Id: I80363ccf2228e3dc5434486c95c62c17e00743aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251104 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#780470}
-
Joel Hockey authored
Bug: b/158617133 Change-Id: Icf4418961c380a8126cef0017edb4608f39094e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251574 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#780469}
-
Mounir Lamouri authored
Bug: 1097232 Change-Id: I5be4062ea0ad1e55b9f063b5c80b629d28aa91d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255098 Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#780468}
-
Bruce Dawson authored
This reverts commit 424526a0. Reason for revert: win64-chrome build succeeded (progress) but win32-chrome builder failed with a previously unseen error, shown here: [170/58214] ACTION //remoting/host/win:remoting_lib_idl_idl_action(//build/toolchain/win:win_clang_x86) FAILED: gen/remoting/host/win/chromoting_lib.h gen/remoting/host/win/chromoting_lib.dlldata.c gen/remoting/host/win/chromoting_lib_i.c gen/remoting/host/win/chromoting_lib_p.c gen/remoting/host/win/chromoting_lib.tlb c:\b\s\w\ir\cipd_bin_packages\cpython\bin\python.exe ../../build/toolchain/win/midl.py environment.x86 c:/b/s/w/ir/cache/builder/src/third_party/win_build_output/midl/remoting/host/win gen/remoting/host/win 7219b935-4873-533b-9ce1-20c9e9b12def chromoting_lib.tlb chromoting_lib.h chromoting_lib.dlldata.c chromoting_lib_i.c chromoting_lib_p.c gen/remoting/host/win/chromoting_lib.idl /char signed /env win32 /Oicf cl : Command line error D8027 : cannot execute 'c:\b\s\w\ir\cache\builder\src\third_party\depot_tools\win_toolchain\vs_files\a687d8e2e4114d9015eb550e1b156af21381faac\win_sdk\bin\..\..\VC\Tools\MSVC\14.26.28801\bin\HostX64\x86\c1.dll' midl : command line error MIDL1003 : error returned by the C preprocessor (2) Original change's description: > Reland "New toolchain for Windows 10 19041 SDK" > > This is a reland of 4a4f53a7 > > The original patch would fail to build on the mksnapshot step on > Windows 7 (and server equivalents). This was due to two APISet DLLs > that are required for the new dbghelp.dll. This change copies the two > of them during gn gen. In order to have them as part of the isolates > for cdb and in order to avoid dangerous ambiguity they are now > required, which means that when this change lands the new SDK will be > required. This is slightly disruptive for developers who aren't using > our toolchain, but it seems unavoidable. > > Developers who don't have the latest SDK installed will hit this error > message during gn gen: > > Exception: api-ms-win-downlevel-kernel32-l2-1-0.dll not found in "..." > You must install the "Debugging Tools for Windows" feature from the > Windows 10 SDK, the 10.0.19041.0 version. > > Original change's description: > > New toolchain for Windows 10 19041 SDK > > > > This change updates the toolchain package used to build Chromium with > > the 10.0.19041.0 (2020-04) SDK and VS 16.6.1. The d3dcompiler_47.dll > > DLLs for x86 and x64 were swapped out for the 10.0.17134 versions (as > > usual). > > > > The Debuggers directory was not swapped out this time because the > > problem with loading dbghelp.dll on Windows 7 > > (https://crbug.com/1021650) has been resolved. > > > > The output for the cdb copy step was updated because one additional UCRT > > DLL is now copied. > > > > Packaging was done on a Windows Server 2019 VM, cleanly created for this > > purpose. > > > > The package was created by downloading the VS Professional 2019 > > installer from https://visualstudio.microsoft.com/downloads/ > > (free trial, not preview) and then running the installer like this: > > > > $ PATH_TO_INSTALLER.EXE ^ > > --add Microsoft.VisualStudio.Workload.NativeDesktop ^ > > --add Microsoft.VisualStudio.Component.VC.ATLMFC ^ > > --add Microsoft.VisualStudio.Component.VC.Tools.ARM64 ^ > > --add Microsoft.VisualStudio.Component.VC.MFC.ARM64 ^ > > --includeRecommended --passive > > > > Then the latest Windows 10 SDK was downloaded and installed from > > https://developer.microsoft.com/en-us/windows/downloads/windows-10-sdk/ > > > > Then the packaging script was run like this: > > > > python3 depot_tools\win_toolchain\package_from_installed.py 2019 -w 10.0.19041.0 > > > > Since the new d3dcompiler_47.dll uses the UCRT and we want to avoid > > shipping that (https://crbug.com/920704) the final packaging step was to > > unzip the package, copy over the two copies of that DLL from the > > previous toolchain's win_sdk\Redist, and then repackage the toolchain > > with: > > > python3 package_from_installed.py --repackage=<full-path-to-toolchain-dir> > > > > UWP and ARM64 support and Python 3 compatibility were previously added > > to package_from_installed.py. > > > > Future changes will require the new SDK, but for now the previous SDK > > can also be used to build Chromium. > > > > The failures on the win*msvc* bots are unrelated. This was proven by > > creating crrev.com/c/2245914 which is a NOP toolchain test. The existing > > toolchain was repackaged with a single text file added and that caused > > identical failures. > > > > Bug: 920704, 1014701, 10216507, 1089996 > > Change-Id: Ie496354582458aa8c1292ed4ef63d949ee2eb15d > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225224 > > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > > Reviewed-by: Henrik Andreasson <henrika@chromium.org> > > Reviewed-by: Jamie Madill <jmadill@chromium.org> > > Reviewed-by: Nico Weber <thakis@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#778924} > > Bug: 920704, 1014701, 10216507, 1089996, 1095767 > Change-Id: I75e7653d57964e2929106e41b3f50594d3969e5f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249394 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Jesse McKenna <jessemckenna@google.com> > Reviewed-by: Jamie Madill <jmadill@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#780431} TBR=dcheng@chromium.org,henrika@webrtc.org,thakis@chromium.org,brucedawson@chromium.org,henrika@chromium.org,jessemckenna@google.com,jmadill@chromium.org Change-Id: If00e3865e66d9071189b2aca28f7541ecbdc6486 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920704, 1014701, 10216507, 1089996, 1095767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2255558Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#780467}
-
Ted Meyer authored
The accelerator was misinterpreting the |bool update_mode_deltas[2]| and |bool update_ref_deltas[4]| as something that should be used when copying the data. These flags are for the parser only. The spec (http://downloads.webmproject.org/docs/vp9/vp9-bitstream_superframe-and-uncompressed-header_v1.0.pdf) seems to imply that they shouldn't even be stored in the Vp9LoopFilterParams struct at all, and only used to help compress the headers. Bug: 1091466 Change-Id: I6c73dd46f748583fae42b5aa2beab91d6649eca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2253216Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#780466}
-
gogerald authored
Start surface is disabled on low end devices, https://source.chromium.org/chromium/chromium/src/+/master:chrome/android/features/start_surface/public/java/src/org/chromium/chrome/features/start_surface/StartSurfaceConfiguration.java;drc=deaf430507674cc3fa853964e99578a9143e13f2;l=51?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 1094417 Change-Id: I457d786f43afd61c9aa5cbb8916497bf50cda393 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254095 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#780465}
-
Maks Orlovich authored
(There are a lot of those, so this will be done in multiple CLs) StaleIndex various: keeping as potential area of improvement, low traffic SyncKeySHA256Result: removed, not interesting any more (long ago format changes) SyncWriteResult: kept as can help diagnose trouble root cause. SyncCheckEOFHasCRC: removed, old format migrationi SyncCheckEOFResult: kept, diagnostic value SyncCreateResult: removed, file error peer probably more useful SyncCreatePlatformFileError: kept, diagnostic value SyncCloseResult: kept since Close() doesn't have way of signaling failure and trouble here may mean data loss. SyncOpenEntryAge: removed SyncOpenResult,PlatformFileError: kept, trouble-shooting value WriteResult2: removed ReadResult: removed. ReadStream1FromPrefetched: removed. Bug: 1089963, 1089962, 1089961 Bug: 1089980, 1089979, 1089981 Bug: 1089973, 1089974, 1089975 Bug: 1089967, 1089968, 1089969 Bug: 1089970, 1089971, 1089972 Change-Id: I463dc981806e71c6ab26e75c2fe7917a199119b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252958Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#780464}
-
Ian Kilpatrick authored
... in blink/core/renderer. There are still quite a few references to "master" which weren't fixed in this patch. Left some references in /csp/ as well at the moment. This patch fixes the "random" references. Bug: 842296 Change-Id: I84d31598a26c308fb1bf1f0a4f51599e4404bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254898 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#780463}
-
Sam Bowen authored
See the bug description. This is step (1) of the scaled back requirements. We will post this task in an upcoming CL. For mojo change, we need to add the reset token to be saved in the DB so we can bypass an unnecessary DB call in this new code path. Bug: 1064751 Change-Id: I31ac1261a5f0e9fccb89787994eba65830cef092 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243671 Commit-Queue: Sam Bowen <sgbowen@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#780462}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I7262adc376491acdf85f0f97d9bf7e8b4eecb14c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250071 Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#780461}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1592582404-8222a440e7e5a063efaa22c6430adc77286858ae.profdata to chrome-win64-master-1592585969-c70917dc3124c4b50e9e9ae9a9c8ca3f9c90b67e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I85eaa764f5494fc8061512307200f02980b8ecb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254839 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#780460}
-
Charlene Yan authored
Bug: 1018230 Change-Id: Ie015fdd3b162830f98a56b73bf6af19d2341b030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2252844Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#780459}
-
Daniel Nicoara authored
This broke the Chromecast build since the EGL/GLES ANGLE libraries are not whitelisted in the GPU sandbox. BUG=1097320 TEST=Ran on device Change-Id: I372e7e722eaef6217c2749a3ab8972d3c0e2e58e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2254529Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#780458}
-