- 03 Aug, 2019 22 commits
-
-
Sergey Ulanov authored
non-test fuchsia runner was broken because it had dependency on args.test_launcher_bot_mode, but that argument exists only for test runners. Change-Id: Ib19e03d5e30534f14968041ae785ef65bdcb9033 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720794 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#683820}
-
Jianfeng Wang authored
Refactor the code for recording the mapping score to UMA. Only records the data when there are at least 10 samples in the cache. Change-Id: I18dd83fc19ea1773458533e7b54fa297cb0bb97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733459 Commit-Queue: Jianfeng Wang <jfwang@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#683819}
-
Takuto Ikuta authored
No behavior change intended. Bug: 790309, 790294, 790286, 864817, 790343 Change-Id: I8a3d3f9d24e34c5a009c4927f3c9f26f756a6a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732677 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#683818}
-
Gayane Petrosyan authored
Bug: 990370 Change-Id: I3a5a1e66020f2c7bcb335137ac63c0679f5cb7a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730785 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683817}
-
Idan Raiter authored
This change passes the swapchain format to where we create the shared image. This is required to be able to render both bgra and rgba, since dawn verifies the texture descriptor of the shared image matches the one requested in the javascript. Bug: 976495 Change-Id: Ief4693649b6e67d363702063afab38fffd290062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728343 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#683816}
-
Miyoung Shin authored
This CL renames mojo to mojom and *_struct_traits.* to *_mojom_traits.* in //media/mojo. *_struct_traits.* => *_mojom_traits.* media/mojo/interfaces => media/mojo/mojom Bug: 806965 Change-Id: I62871e855f32640d5a39bfbcc2889118d0d46886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724839Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683815}
-
Sammie Quon authored
Pressing ctrl+W will delete a desk if a mini view is highlighted. It will have no effect if the new desk button is highlighted. Pressing enter will activate a desk if a mini view is highlighted. It will create a new desk if possible if the new desk button is highlighted. Test: manual, added tests Bug: 988141 Change-Id: Ibd5996052cd882ec8d5a768e9c452eed1524cfb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724279 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#683814}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/c40e52fce50c..80de50146e30 git log c40e52fce50c..80de50146e30 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 vapier@chromium.org lint: fix quoting style everywhere 2019-08-02 tomhughes@chromium.org Add navbar and update README Created with: gclient setdep -r src/third_party/chromite@80de50146e30 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I472191d5fa77be45a6e337c3a13e12cc600d24c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733422Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683813}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f8feeaf77b75..f6e0b7e42191 Created with: gclient setdep -r src-internal@f6e0b7e42191 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None Change-Id: I8b84bd102edd9c53ceeaadb50cdb4f3536c8bcf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733991Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683812}
-
Regan Hsu authored
screenshots: https://drive.google.com/open?id=1GUi8CHDkYbaA8oBdwLY4dqTbVzUYruAT Change-Id: Idacf0f78e5ac1d7fade39a30ce513b580d38e012 Bug: 987659 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717683 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#683811}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4c118cb3d371..de50d039b1b4 git log 4c118cb3d371..de50d039b1b4 --date=short --no-merges --format='%ad %ae %s' 2019-08-02 timvp@google.com Enable ASTC 3D Textures Created with: gclient setdep -r src/third_party/angle@de50d039b1b4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: I85c10133b8243da6fb933cf5fc70386bc8a9590c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734030Reviewed-by:
-
Sunny Sachanandani authored
kPassThrough was added as a new canvas ResourceProviderType, but the enum's kMaxValue wasn't updated which causes a DCHECK to fail in histogram functions when this code path is taken. TBR=fserb@chromium.org Bug: 939657 Change-Id: Iae6231f90d2d01cf60f293273e5345eb37e06f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732334Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#683809}
-
dpapad authored
- Add a new |polymer3_args| collection of JS Compiler flags in closure_args.gni, needed for type-checking Polymer3 modules. - Adding a new |is_polymer3| parameter to js_binary/js_type_check (defaults to false) - Updating compile_js.gni to not use polymer_externs for Polymer3, since Polymer itself is passed to the compiler (otherwise compilation fails) - Add js_type_check() targets for cr-button, cr-checkbox, cr-toast, cr-toggle, cr-view-manager. Also fixing a bug where editing closure_args.gni did not trigger js_type_check() targets to re-run. Bug: 970885 Change-Id: I9b43eac504f80fd43e542565fc9746579a4ba10a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726873 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#683808}
-
David Benjamin authored
https://chromium.googlesource.com/chromium/deps/nasm.git/+log/f564874f4955..da0dcccc44f1 $ git log f564874f4..da0dcccc4 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 rnk Skip compiling ilog2.c on Windows where 'inline' uses C++ semantics Created with: roll-dep src/third_party/nasm Bug: 989745 Change-Id: I712bc7d2cb6b3d6ab8315174459f9837581d84b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734032 Commit-Queue: David Benjamin <davidben@chromium.org> Commit-Queue: Reid Kleckner <rnk@chromium.org> Auto-Submit: David Benjamin <davidben@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683807}
-
John Budorick authored
Noticed this while setting up android-pie-x86-fyi-rel. Change-Id: I6f10d9c6c9c8e3e1bb07ca34ea8eb1aa531d643f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733582 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#683806}
-
Sky Malice authored
Specifics: +77,824 bytes main lib size +644,532 bytes main dex size +1,053,989 bytes normalized apk size InstallSize: +412,739 bytes APK size +1,166,841 bytes Estimated installed size (Android Go) +3,016,648 bytes Estimated installed size InstallBreakdown (+3,012,121 bytes): +3,954 bytes Native resources (no l10n) size +1,987 bytes Non-compiled Android resources size +77,824 bytes Native code size +3,412 bytes PNG drawables size +749 bytes Package metadata size +2,896,227 bytes Java code size +27,968 bytes Compiled Android resources size Dex: +2,960 entries fields +2,481 entries strings +4,208 entries unique methods +1,266 entries types +4,208 entries methods Bug: 990408 Change-Id: I910bc8d1f6e8d926f6ccfcf7507ed0fb95dc38ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733019 Commit-Queue: Sky Malice <skym@chromium.org> Commit-Queue: Carlos Knippschild <carlosk@chromium.org> Reviewed-by:Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683805}
-
Min Qin authored
Network service is enabled by default, the if checks can go away BUG=934009, 990490 Change-Id: Iaaed4aa95f3a2d9dcda7a10c82e57b539a5539fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733793Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#683804}
-
Ahmed Fakhry authored
Since the display work area bounds are not updated when the shelf alignment changes while in overview mode, then updating the grid bounds won't make any difference, so we simply exit overview. BUG=990293 TEST=Added a test Change-Id: I545edaea9080012c34263a6f48962fbf710e984c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733797Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#683803}
-
Eric Karl authored
The following tests are flaky. No clear regression point. Disabling. Http/MediaTest.VideoBearMp4Vp9/0 File/MediaTest.VideoBearMp4Vp9/0 Bug: 990116 Change-Id: Ic96ff5563a91c4e7bc57b7d3cf1cdbf2ba4534c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733035 Commit-Queue: Eric Karl <ericrk@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Eric Karl <ericrk@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#683802}
-
Jenna Himawan authored
Bug: 989787 Change-Id: I60b320350ccdd640f246d26af422f70b1d2a40b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733114Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jenna Himawan <jhimawan@google.com> Cr-Commit-Position: refs/heads/master@{#683801}
-
Bo Liu authored
Move SkiaOutputSurfaceDependencyWebView into its own cc/h files, so it can be shared easily with the new viz code path. Also only hold raw pointers instead of scoped_refptr to objects, since those objects may not be thread safe, and DependencyWebView may not be destroyed on render thread. Re-order header declaration order so that viz classes are destroyed before the raw pointer dependencies. Bug: 805739 Change-Id: I06aaecc3aa41a24ae468890f0329499a0723559b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732744 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Cr-Commit-Position: refs/heads/master@{#683800}
-
Yuly Novikov authored
TBR=kbr Bug: 988833 Change-Id: Ia60caed939633ddf9410fb54fb7317d6bd9915e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732749 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
-
- 02 Aug, 2019 18 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/898bbfac2e35..d7325185a26b git log 898bbfac2e35..d7325185a26b --date=short --no-merges --format='%ad %ae %s' 2019-08-02 senorblanco@chromium.org Dawn backend: update to recent Skia changes. Created with: gclient setdep -r src/third_party/skia@d7325185a26b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I6375a3000b7e6acc0e397dbfb749e6086e285a14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734029Reviewed-by:
-
Reid Kleckner authored
There was an API update to use ErrorOr in r367615. No dedicated bug for this. TBR=dcheng@chromium.org, inglorion@chromium.org, thakis@chromium.org Bug: 983371 Change-Id: I85018cac6531512498eb95c1e7ca3a0d24f7df2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733796Reviewed-by:
-
Avery Musbach authored
The present CL rewrites a condition on which OverviewSession::OnKeyEvent bails out. Instead of checking for clamshell split view mode, it shall simply check for clamshell mode. This change is a step toward multi- display support for split view, because it removes a dependency on the single-display split view functionality. Test: ash_unittests SplitViewOverviewSessionTest.NoCrashWhenPressTabKey Bug: 970013 Change-Id: Ibf84a9ab1b41b4481cee3ed6763f92eaeee52f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733713Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0fca4beb4959..f8feeaf77b75 Created with: gclient setdep -r src-internal@f8feeaf77b75 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I4ed5f4695cc386f24ea894a5befd137490439112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733858Reviewed-by:
-
Matthew Webb authored
This CL fixes a focus error due to credential management being wrapped in a <template>. Change-Id: Ibbd0b48b1b2a92df0cc3f2a1ebb4a2c2669d76af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733024Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Matthew Webb <noviv@google.com> Cr-Commit-Position: refs/heads/master@{#683794}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8c79db8a0702..c40e52fce50c git log 8c79db8a0702..c40e52fce50c --date=short --no-merges --format='%ad %ae %s' 2019-08-02 vapier@chromium.org PRESUBMIT.py: disallow use of `git cl` Created with: gclient setdep -r src/third_party/chromite@c40e52fce50c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I96813f9ba2be173ae23d5b901cf937d89055361f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733857Reviewed-by:
-
Carlos Caballero authored
MessageLoopForIO will go away soon use ScopedTaskEnvironment instead. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=rbpotter@chromium.org Change-Id: I6488b766455b858343b2ca9b953027f001a077d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733496 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
-
Daniel Clark authored
An earlier change (commit aa9f4c85) added the new ax::mojom::StringAttribute inputType. This test-only change updates AX browser tests to dump the value of this attribute where applicable. Change-Id: I9411b9dc779beacfa03c6c79b0f1a3644be0a9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733112 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#683791}
-
Jinsuk Kim authored
Occasionally the close indicator does not appear when left swipe exits the app. The condition for exiting (minimizing) app had a bug not reflecting the tab launch type (when launched from an external app). This CL rectifies the condition. Bug: 988546 Change-Id: I8bc93f48400dbf831c998806c7d00de61030b76e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730294Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#683790}
-
David Benjamin authored
When client certificate preferences change, we should clear all session cache entries for the host. This allows SSLClientSessionCache to determine the host portion of each key. Note this changes it from a std::unordered_map-backed MRUCache to a std::map-backed one. I'm assuming that, given the cache is bounded to 1024 entries, it doesn't matter either way. Bug: 951205 Change-Id: Ia6cb77a7331fa8cfc8aaa86f366b42f845940cd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707035 Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#683789}
-
Jordy Greenblatt authored
The bug in refers to the fact that before this change, pressing 'ENTER' with the exportPasswords dialog up would cause a password check initially, however if the user cancelled the password check prompt, they will again see the exportPasswords but this time 'ENTER' does nothing. hcarmona@ pointed out that this is part of a broader accessibility issue on this page, namely that the password prompts' closing doesn't put focus back on the element that triggered it to open. This can lead to a confusing and difficult UX for users who are using tab to navigate through the interactive elements on the page. I ran through a wide range of use cases affected by this change and recorded them, mostly captured in [1]. Note that the transition at 0:29-0:30 in [1] resulted from pressing enter at the passwords-export-dialog. I recorded successful password entries ([2], [3], [4]) separately because if they are done in close succession, the auth token is reused and the password prompt is skipped, which negates defeats the purpose of the recording. [1] https://drive.google.com/file/d/13naHaZSf7hG3pC09XaO7WW4bmDmmhYW6/view [2] Successful password prompt from passwords-export-dialog: https://drive.google.com/file/d/1LLN0dJ8NY54zSTOoZL6F9AcPSFHF0EFy/view [3] Successful password prompt from password-list-item: https://drive.google.com/file/d/1hIDOFFrEMRClFlT0VfVTXtyw-YweIfsp/view [4] Successful password entry from password-edit-dialog https://drive.google.com/file/d/1XJaGTrmDm4dOnc6a1tQyKnNxaHWU_NzR/view Bug: 989449 Change-Id: Ic5a363d217cb70e76aa6acb5104ec2fea3a00b4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731733 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#683788}
-
Yuke Liao authored
This filter has a list of tests that crash in coverage build and lead to profdata corruptions. Two outstanding test suites are: -PasswordManagerBrowserTest.* -CredentialManagerBrowserTest.* Bug: 988146 Change-Id: Ibeda872c496dda54d7b038e7286085981a3295e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730790 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#683787}
-
Chris Palmer authored
This cleans up some code introduced in https://chromium-review.googlesource.com/c/chromium/src/+/1678937. Bug: 978888 Change-Id: Ic66516d58e379b7cadc2da9d0fffede8d5c35126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732748Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#683786}
-
Alice Boxhall authored
Example crash: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906269450018283968/+/steps/content_browsertests__with_patch_/0/logs/Deterministic_failure:_DumpAccessibilityEventsTest.DeleteSubtree__x2f_linux__status_CRASH_/0 Fixed by avoiding computing bounds from child nodes during tree updates. Change-Id: Ia2a293ee4e2c655fe3939ca76264efd54b3cf354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731634Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#683785}
-
John Budorick authored
Bug: 922145,961025 Change-Id: Icddbe1798727c67cebbfbb82a6f374d2562f9c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699275Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#683784}
-
Sky Malice authored
Bug: 990399 Change-Id: I5f7727acf55fca3fea3572b2d8a237f43eecb845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733015Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#683783}
-
danakj authored
We don't want to Send() IPCs on a frozen/provisional RenderWidget. The DoDeferredClose path in RenderWidget needs to send the IPC from a fresh call stack, but in the meantime, the RenderWidget may have become frozen (the main frame may have been swapped out in that RenderWidget's RenderView). In that case, we still allow the WidgetHostMsg_Close to go through, and behave as if the IPC was already in transit to the browser. But since RenderWidget::Send() should not be used, we use a static method. This is one step toward allowing us to CHECK() that we don't Send() IPCs from frozen/provisional RenderWidgets. R=dcheng@chromium.org Bug: 419087, 745091 Change-Id: I85f707c3c9bf071f7adf6273d78d40a6f530b10b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733852 Auto-Submit: danakj <danakj@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#683782}
-
Brandon Wylie authored
Bug: 987905 Change-Id: Id5e8e366cabba5cea56725ff459de0f49c19c4ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728267Reviewed-by:
-
