- 09 Sep, 2020 36 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0cf22e5ad89d..a67d868f6c11 2020-09-08 aerotwist@chromium.org Adds Puppeteer support to frontend 2020-09-08 aerotwist@chromium.org Bypass third_party files when linting in presubmit If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107392 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I94793ae7ab120a016da872741af0d93e3b5809a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399073Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805172}
-
Sophie Chang authored
Bug: 1112500 Change-Id: I48ca40822ea7677e438fca13009454c863658ab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399521Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805171}
-
Joel Hockey authored
Bug: 960056 Change-Id: Ic8b449303b5858e1677fd0bb346bc332c9fbc9b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391702 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#805170}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b5eeca1f. With Chromium commits locally applied on WPT: c255d0e2 "Add WPTs for invalid WC inputs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: I80d656ef8e0da4cab510e5f0b183c19e82c29730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398859Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805169}
-
John Abd-El-Malek authored
Bug: 1123212 Change-Id: I8d5d3a23d9d8c7902d37cf19faa3a1dbfe898ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399574 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#805168}
-
Siye Liu authored
During long tap, |WebViewImpl::HandleGestureEvent| asks the main frame's GestureManager is the long tap should invoke context menu. However, the previeus long press event was routed to iframe's GestureManager. Therefore, main frame's GestureManager returns false in |GestureManager::LongTapShouldInvokeContextMenu|. Therefore, context menu is not invoked if the link is in an iframe. We should ask the hit frame to decide whether we should invoke context menu during long tap. Bug: 1112987 Change-Id: I90f5e1f09380258b6bdf83c9cc78b9764d2adeca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2382054Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#805167}
-
Yoshisato Yanagisawa authored
This reverts commit ccb9f3bf. I noticed I need to update other GCS permission to allow the task service account to run gclient sync. Bug: b/166712857 Change-Id: I4e534eb1bb1a026de169b2c0b58e9bd50b354b26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398070Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805166}
-
Martin Šrámek authored
Since this file has a limited maximum size, a new entry can only be added if one previous one is removed. We remove the FriendlySettingsHats entry, as this study has been fully launched and all corresponding features are enabled by default on Desktop platforms. Bug: 1097757 Change-Id: I59024c59c7c7754051fff90e194b40dea2b83a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377935Reviewed-by:
Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#805165}
-
Johann authored
Remove usage of DISALLOW_COPY_AND_ASSIGN from mojo documentation. styleguide/c++/c++-dos-and-donts.md: 'DISALLOW_COPY_AND_ASSIGN` is deprecated. For a non-copyable/movable type, delete the copy operations (the move operations will be implicitly deleted); otherwise, declare either copy operations, move operations, or both (a non-declared pair will be implicitly deleted). Always declare or delete both construction and assignment, not just one (which can introduce subtle bugs). Change-Id: Iad752e093643a0f964056c1d4b6714cea724728f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398069Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#805164}
-
Melissa Zhang authored
This CL adds a strings file for Sharesheet UI. It also changes the target display label to be multi-line if there is no secondary label. Bug: 1097623 Change-Id: Id75f9fa0de851de58707fa6b730098d472038599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2395135Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805163}
-
wutao authored
This patch uses the ic-checked-filled icon for the checked mark. Screenshot: https://screenshot.googleplex.com/69U4WGtZ63GUsoK Bug: b/167085170 Test: added new js test Change-Id: I5249ca6470a795bf45a782f3687be96c00e9ad08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384335 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#805162}
-
Daniel Cheng authored
It is possible for the browser to ask the renderer to commit a document with an unsupported MIME type [1], though `NavigationURLLoaderImpl` [2] ould normally turn this into a download. For example, when mobile emulation is enabled, plugins are disabled in the renderer. However, the browser-side navigation code is not aware of this. If the user navigates to a PDF file, the browser will still ask the renderer to commit a PDF navigation, even though requesting an unsupported MIME type should normally turn into a download. In the renderer, the `CommitNavigation()` request is currently ignored. With this CL, synthesise an artificial response so that `CommitNavigation()` cannot silently fail in this case. Note that there is at least one other bug: when `ShouldNavigate()` returns false, `FrameLoader` calls `DidFinishNavigation()`. However, this does not actually appear to stop the progress spinner. The fact that this doesn't work is now masked by the fact that `ShouldNavigate()` never returns false. [1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/public/common/mime_util/mime_util.h;l=25;drc=3abd909af895533327e5ce0fe554bce7f87087a6 [2] https://source.chromium.org/chromium/chromium/src/+/master:content/browser/loader/navigation_url_loader_impl.cc;l=800;drc=48d758b185dbcf4f4e3380de15990378fa7485eb Bug: 696745, 1117282 Change-Id: I1b44b1ff59e81f2b4f3a7b5dc2e0a98921869373 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388705 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#805161}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04b9443274cf..b8ae7fa12aa0 2020-09-08 jvanverth@google.com Reland "Use Microsoft's ComPtr to wrap D3D12 objects." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: Idab289262f5240dba73b358b31cbe4161d3ef6ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399262Reviewed-by:
-
Sophie Chang authored
Proto without histogram change was initially landed here: https://chromium-review.googlesource.com/c/chromium/src/+/2387905/5 Bug: 1112515 Change-Id: I8663add11363d7edbbae8d7c2f85ec6fb1b03e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399309 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
-
Joel Hockey authored
Bug: 1117088 Change-Id: Ib59706e6494f732babe70dd970c0f803c7698ac4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391703Reviewed-by:
-
Donn Denman authored
Extends a couple of Contextual Search histograms to M89 for the Related Searches experiment. BUG=1125745 Change-Id: I37f69019e682694f18ee8f962b7ccc4b7ee7b288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399504Reviewed-by:
-
Liquan (Max) Gu authored
Change: Only moving mId, mRawShippingOptions, mRawLineItems, mRawTotal. Bug: 1102522 Change-Id: I58f1e56a2a51a4deacd4d2684ccb56456677fdb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390942 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805156}
-
Fergus Dall authored
Concierge now supports a dlc_id parameter to boot a trusted VM from a DLC. Set this when the crostini dlc flag is enabled. With this CL it is now possible to use termina-dlc on any board with dlc enabled. Bug: chromium:953544 Change-Id: I95fba796e6f80f10e308dd306b5ef1befd416e62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397455 Auto-Submit: Fergus Dall <sidereal@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#805155}
-
Ryan Hansberry authored
Discovered while debugging crbug.com/2393616. The code in question moves the wrapped CorePayload of a std::unique_ptr<CorePayload>, instead of moving the entire smart pointer. Resolved by simply not using std::unique_ptr in the first place. Also fix a minor typo discovered while debugging. Bug: 2393616 Change-Id: I518230bd2ced6735d13f4fc8fbee54758ceec1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398952 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#805154}
-
Noel Gordon authored
This API is used by image loader clients: Gallery, Video Player, Files app. They are chrome extensions and have an extension id: nlkncpkkdoccmpiclbokaimcnedabhhm Gallery jcgeabjmjgoblfofpppfkcoakmfobdko Video Player hhaomjibdihmijegdhdafkllkbggdgoj Files app The image loader client code must replace the client extension id with the image loader extension id in client request URLs. The code uses chrome.i18n.getMessage() to figure out the client extension id. Remove that code: use a regular expression instead. No change in behavior. Bug: 1126229 Change-Id: I3214335a6ecc2b70be614918a4cffd577071ffb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397969Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805153}
-
Kent Tamura authored
- It contained non-existent encoded_frame.h. - It has a circular dependency with modules/webrtc. The dependency is safe because these targets are in a single library. This CL has no behavior changes. Bug: 800764 Change-Id: I8759b5e88a4596d22a9d2e83e447dc94214bb4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397104 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
danielng authored
Added browser tests for the Borealis installer view. Cq-Depend: 2391891 Tests: Ran tests Bug: b:161650651 Change-Id: I2e5e6a2fb5d744f1fd3cd2f0e6efa1622953c0ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392285 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Siyu An authored
Introduced the autofill_offer_data which will be shared by chrome client codebase. Also added tests. Bug: 1112095 Change-Id: If335e20074b580f5caa613b7360e24f884da8081 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391906 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#805150}
-
wutao authored
Art albums will use grid layout. Screenshot before: https://screenshot.googleplex.com/9YTwncEZ8n0 Screenshot after: https://screenshot.googleplex.com/6dQb75nzTSvst6g Bug: b/167080802 Test: added new js tests Change-Id: If086169782cddaff87199405b12d713f39c54d58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384331Reviewed-by:
-
zhaoyangli authored
This is a work around to eliminate the bad impact of mixed usage of Xcode 11 & Xcode 12 on one machine. Bug: 1115022 Change-Id: I11c97719a79951bc1c7073362c5661ac3cb03ab1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363687 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805148}
-
Eric Willigers authored
method and enctype are persisted as enums. Only title, text and url are optional message members. Thanks to mhochk@microsoft.com for the suggestions. The ShareTarget messages are not yet being used (the optional share_target member of WebAppProto is not yet being set), so it is currently safe to change the proto format. Bug: 1125880 Change-Id: If3f45ebddaa2f8bcb0daf9d82d8cd37b0a8a4cf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398439Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/76c7a195fd79..99396cad183b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC chcunningham@google.com,zmin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1099917,chromium:1120109,chromium:1124367,chromium:912681 Tbr: chcunningham@google.com,zmin@google.com Change-Id: Ifbd87d5c818055dfcb3c61e1f481b59bb5cbfd62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399363Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805146}
-
Adam Rice authored
Add links to code locations to the README.md for modules/encoding. Also clarify that only ISO-2022-JP has been patched in ICU. Change-Id: Id1058d8ab4971da05c59e7f65b4f2f69987e7419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397973 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#805145}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e5882825af72..41c93c550b07 2020-09-08 m.maiya@samsung.com Vulkan: Bug fix in atomic counter buffer count calculation 2020-09-08 ianelliott@google.com Vulkan: Suppress VVL PushConstantOutOfRange errors If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Test: Test: angle_unittests.exe --gtest_filter=AtomicCounterBufferTest31.AtomicCounterBuffer* Change-Id: Iae1691773a62581d5ad8559ca3ed7ab1764acbf3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399679Reviewed-by:
-
Lei Zhang authored
Point to an OWNERS file instead of having a single contact. Also suggest contributing updates, as all the documentation is now in the git repo. Change-Id: Id7e6f5c00f5f3f9264f0c580b269284d1ad37c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399720Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#805143}
-
Weilun Shi authored
We recently supported pattern histograms in histograms.xml so we've to update split_xml to accommodate this new change and split more histograms xmls. Bug: 993193 Change-Id: Iae2cf38a5bb533bb87ce8389c75ec4028efb6e97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399339Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#805142}
-
Gavin Williams authored
With the impending deprecation of Google Cloud Print (GCP), CrOS has shifted to implementing Save to Drive using the local Drive folder. Thus the Save to Drive option should be removed from Destination Dialog which has an account picker. Without GCP, the user no longer has the ability to choose which account's Drive to save to. Bug: 1112416 Change-Id: I985ebae6948a96e6698edad11b580cb3a87ff361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387427Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#805141}
-
Rakib M. Hasan authored
This builder will be replaced with a main waterfall builder. This CL will temporarily remove the weblayer_shell_wpt test suite. CL crrev.com/c/2386600 will re-add the test suite. Bug: 1050760 Change-Id: Idfa10db9d42e67ac02e5de1861f1e46a8dd01e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399007Reviewed-by:
Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#805140}
-
Tom Anderson authored
After [1], all X11 usage is done on a single thread, so no locking is necessary, and using the atomic xcb_send_request_with_fds() is no longer necessary; instead, we can send the FDs followed by the request. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2343314 Change-Id: Id47a07e283965a5e72bfa4cc3266b448e986400c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399502 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#805139}
-
Natalie Chouinard authored
Test has continued to show flakiness on android-marshmallow-arm64-rel since it was re-enabled in: https://crrev.com/c/2355005 Builder: https://ci.chromium.org/p/chromium/builders/ci-m85/android-marshmallow-arm64-rel TBR=mdjones@chromium.org, sinansahin@google.com Bug: 1109965 Change-Id: Ibd0accb3e81e6384a35cbed49f8e4d5087beddb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399508Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#805138}
-
Jia authored
This cl also changes IsInvertedIndexBuilt: As index building happens async, it's possible that |terms_to_be_updated_| is empty but index is still being built. Hence the returned result should be false. Bug: 1125927 Change-Id: I180658967c45fd3b9cdbb7c12ade0b274c80a445 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397595Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805137}
-
- 08 Sep, 2020 4 commits
-
-
Sébastien Séguin-Gagnon authored
Change-Id: I664fa63b5b69369cb69fb4b87463ba3bb4cfc94d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386295Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
-
Alex Chau authored
- The metrics is still actively being used Bug: 1123571 Change-Id: I8dc856f789b8ba9175074dd6520d30b3c11452df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391062 Auto-Submit: Alex Chau <alexchau@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Felipe Erias authored
Implementation of the keywords "stable", "always" and "both" of the scrollbar-gutter CSS property, which provides Web authors with more control over how their layouts respond to the presence of scrollbars. ng_length_utils: ComputeScrollbars uses the space taken up by the scrollbars and by the additional gutters defined by scrollbar-gutter. paint_layer_scrollable_area: HypotheticalScrollbarThickness takes an additional parameter to return the thickness of overlay scrollbars (default: false). layout_box: ComputeScrollbars and ComputeLogicalScrollbars calculate the space needed by scrollbars and scrollbar gutters along physical or logical edges, respectively. Scrollbars are calculated by ComputeScrollbarsInternal, with an early exit (CanSkipComputeScrollbars) to skip cases where we can know ahead of time that the scrollbars will be empty. The methods that could be easily replaced by ComputeScrollbars or ComputeLogicalScrollbars have been removed from the LayoutBox API. WPT and unit tests are included. inspector_highlight: While adapting the DevTools highlight to use the new API, some inconsistencies in the previous implementation have been fixed. Context and related discussion: https://groups.google.com/a/chromium.org/g/devtools-dev/c/_6JKYu7qzto/m/1v3dZOpfCQAJ Spec: http://drafts.csswg.org/css-overflow-4/#scrollbar-gutter-property Bug: 710214 Change-Id: Icd918badd3a8f5b705da744e446978223b64dc64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306498 Commit-Queue: Felipe Erias Morandeira <felipeerias@gmail.com> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#805134}
-
Rachel Carpenter authored
Bug: b/16651000 Change-Id: Ib752327267282023972f06b15e57691b16a8562b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397381 Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#805133}
-
