GitLab

We don't want to run test on the builders.
I will add webrtc target in tools repository.
https://chromium.googlesource.com/chromium/tools/build/+/master/scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py

Bug: b/78251210
Bug: 835686
Bug: 834213
Change-Id: Ib2ac5238e86fc965df9bfd4af098d60d3cbfb89b
Reviewed-on: https://chromium-review.googlesource.com/1027575Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553903}

gfx::VectorIcons were refactored in r552619 to allow arbitrarily many versions
for the same icon. Update documentation to reflect this.

Bug: 647286
Change-Id: I2b82a7c1c9832ed2a7bf4c83bd3223b7d73f1110
Reviewed-on: https://chromium-review.googlesource.com/1023625
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553902}

After marking Document's "location" attribute as kHasNoSideEffect,
the CL [1] failed to reset bindings tests results.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1024863/

Bug: none
Change-Id: Ie0be4542bd1b58939b12c342056d521abb5e4ddd
Reviewed-on: https://chromium-review.googlesource.com/1029451Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553901}

According to the task type usage guideline, we use kInternalDefault for
internal and default behavior tasks. This CL introduces kInternalDefault
by renaming kUnspecedTimer.

Doc: https://docs.google.com/document/d/1k7EEHQUEujgQ7BAhbmNdeaddwfJPWp7qjLy8mnVTQ9Y/edit

Bug: 836410
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Id3d1aec136c6c30c632b87d58a13b8de76738653
Reviewed-on: https://chromium-review.googlesource.com/1027572
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553900}

The GDB pretty printers for blink has moved. Update the doc accordingly.

Bug: N/A
Change-Id: Ifce05658d6c207d761fb349d5c4ab877f7e09ae9
Reviewed-on: https://chromium-review.googlesource.com/1029650
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553899}

This CL fixes a regression caused by https://chromium-review.googlesource.com/1004886
where permission prompts would appear partially off screen in full screen mode
on platforms where we hide the Chrome UI.

Before:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334665&signed_aid=cQIe_b4bfUZn8i-akRK_ZQ==&inline=1

After:
https://bugs.chromium.org/p/chromium/issues/attachment?aid=334829&signed_aid=cXhOlJe-_oibvrzmLtL4Bw==&inline=1

This also fixes the DCHECK in GetPageInfoAnchorRect() to be relative to
GetPageInfoAnchorView() rather than copy pasting its bail out condition.

Bug: 833257, 814532
Change-Id: I6ef85ace735b0b217b3a473365791ad453cf8378
Reviewed-on: https://chromium-review.googlesource.com/1013676
Commit-Queue: Alan Cutter <alancutter@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553898}

https://chromium.googlesource.com/webm/libwebm.git/+log/b03c65468b06..af81f26025b7

$ git log b03c65468..af81f2602 --date=short --no-merges --format='%ad %ae %s'
2018-03-02 mjbshaw Fix MSVC warning about 2147483648 not fitting in an int
2018-02-28 mjbshaw Fix compilation with MSVC
2018-02-06 tomfinegan Allow shared builds of libwebm.
2018-01-31 tomfinegan webm2pes: Avoid OOB reads caused by invalid superframe index.
2018-02-01 jzern vp9_header_parser: make SetFrame private
2018-01-30 tomfinegan Limit string element size to 20 million bytes.
2018-01-22 velden Replace uses of deprecated std::auto_ptr with std::unique_ptr.
2018-01-19 mjbshaw Set a maximum limit on element recursion depth
2017-12-18 tomfinegan Silence -Wdeprecated-declarations in GCC 4.7+.
2017-12-07 huisu Update VP9 level definition

Created with:
  roll-dep src/third_party/libwebm/source
BUG=836706

Change-Id: I16a6a0a850e9a47a81176d116af7ddde4fd6c0bf
Reviewed-on: https://chromium-review.googlesource.com/1027561Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553897}

This patch fixes a bug where font display timeouts (100ms and 3s)
didn't start if the font resource is already started loading by
<link rel=preload>.

Bug: 835583
Change-Id: Ie464179ebcc56f2d18c99d234eadd4fc26bc1fcd
Reviewed-on: https://chromium-review.googlesource.com/1027331Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553896}

BUG=836347

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I53cb9dca6a9dd1d874c58d72b36c75e82b1142c4
Reviewed-on: https://chromium-review.googlesource.com/1026415Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553895}

changes Socket::Read(), Socket::ReadIfRead(), Socket::Write(), StreamSocket::Connect(), SocketPosix::Accept() & SocketPosix::Connect() to CompletionOnceCallback.

R=bnc@chromium.org, reillyg@chromium.org, sergeyu@chromium.org, sky@chromium.org

Bug: 807724
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia363b632bf1193c40576e3ccdd93188081aca589
Reviewed-on: https://chromium-review.googlesource.com/907076
Commit-Queue: Brad Lassey <lassey@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Stephen Lanham <slan@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553894}

Mime handler guests currently do not set their view type. Thus, their
foreground pages do not count as foreground pages for the purpose of
deciding whether to keep their background pages alive, resulting in the
background page being shut down while the mime handler remains open.

Set the view type to VIEW_TYPE_EXTENSION_GUEST when creating mime
handler guests to ensure mime handlers keep their background pages alive
while open.

Bug: 819761
Change-Id: Ibc64c93bbb33022375cf91b45785f543a53ca71c
Reviewed-on: https://chromium-review.googlesource.com/1023518
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553893}

This patch wanted to confirm changing selection invalidation
between execCommand("selectAll") and Selection.setBaseAndExtent().
However calling execCommand("selectAll") before load is flaky from
the point of invalidation.

This patch arranges the function calls so that invalidation occurs
only on selection difference w/o flakiness.

Bug: 774437
Change-Id: I63efe553282f4a6643c0d7b8eb0b0597b1ccac9f
Reviewed-on: https://chromium-review.googlesource.com/1025594
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553892}

This is so that exporting of this functionality over mojo can accurately
express the underlying type and the kNoLimit constant. (Which doesn't
seem doable with size_t since its size, and therefore value of its max,
differs on different platforms).

Bug: 767450
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I741bfe1c942e5ee7752f346932a26e861cefb0c8
Reviewed-on: https://chromium-review.googlesource.com/1027905Reviewed-by: Eric Roman <eroman@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553891}

https://chromium.googlesource.com/catapult.git/+log/d43ffede2b5c..dc970d3e1f7b

$ git log d43ffede2..dc970d3e1 --date=short --no-merges --format='%ad %ae %s'
2018-04-24 simonhatch Dashboard - Remove alert_group.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: Ia5ddfdf725e1f290fe2f04d6c0db1ff92fe17093
Reviewed-on: https://chromium-review.googlesource.com/1028990Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553890}

Bug: 810904
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I07075a30553f1c3e2f70b1b776ea064c376ce186
Reviewed-on: https://chromium-review.googlesource.com/1018114
Commit-Queue: Daniel Blakemore <danblakemore@google.com>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553889}

We were getting into a state where we thought we had requested a vsync
from the device, but actually haven't.  This causes future RAFs to not
run, and we won't render.

BUG=835888

Change-Id: I41af90675fa5ba8e6b78a598594f4a2cf28217ed
Reviewed-on: https://chromium-review.googlesource.com/1028935Reviewed-by: Bill Orr <billorr@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553888}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/62d5021bb6d4..1f64aefc280e

$ git log 62d5021bb..1f64aefc2 --date=short --no-merges --format='%ad %ae %s'
2018-04-20 timloh Add startup_notify field to apps.proto

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 821662
Change-Id: I5126d2b48bb46832aea047cb857cf8bab6cee518
Reviewed-on: https://chromium-review.googlesource.com/1029330Reviewed-by: Nicholas Verne <nverne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553887}

R=mmoroz@chromium.org,metzman@chromium.org

Bug: 821574
Change-Id: I628a946982489fa9f265f78cbd467d9be7ceabe3
Reviewed-on: https://chromium-review.googlesource.com/1028668
Commit-Queue: Abhishek Arya <inferno@chromium.org>
Reviewed-by: Jonathan Metzman <metzman@chromium.org>
Reviewed-by: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553886}

If enable-threaded-compositing is specified (via a threaded virtual test,
or on the command line), along with the display compositor dumps, then
we don't need to synchronously composite frames. Instead we should rely
on surface synchronization to wait for frames to be submitted via
a scheduler.

R=piman@chromium.org, fsamuel@chromium.org

Bug: 667551
Change-Id: I05859b1ebe18cc59379514d604268940714250b0
Reviewed-on: https://chromium-review.googlesource.com/1026563Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553885}

R=justincohen@chromium.org

Bug: 834527
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I8707404256448ffe8f60037785d9b0ee20d08fc6
Reviewed-on: https://chromium-review.googlesource.com/1029205
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553884}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6376ebcedebd..7e2468888f99

$ git log 6376ebced..7e2468888 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src-internal
BUG=chromium:None


The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=mmoss@chromium.org

Change-Id: I56d244721388dcb6b654930ef03715055af7e17e
Reviewed-on: https://chromium-review.googlesource.com/1029259
Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#553883}

We are trying to show SignedExchange related information in DevTools.
https://bit.ly/2HXVbCU

This CL adds LayoutTests and -expected.txt files to track the progress
of the implementation.

Currently there are some difference from the ideal behavior:
- The status code of the succeeded .htxg should be 200. Currenly it is
  302 which is the status code of internally generated redirect
  response.
- The status code of the invalid .htxg should be 200. Currenly it is 0
  because the actual response is not sent to DevTools. DevTools just
  recieves "loadingFailed" event.
- The request to the certificate file shold be displayed. Currenly
  DevTools doesn't recieve the certificate request which is sent from
  the browser process.
- There is no signed exchange related information in the network log.

Bug: 830505
Change-Id: I80c4c648c466505fef4f729eb046a91ede4a4660
Reviewed-on: https://chromium-review.googlesource.com/1027574
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553882}

Bug: 782863
Change-Id: I9565b84c027f0c88dfb4ee02602a2d49c3a95016
Reviewed-on: https://chromium-review.googlesource.com/1029218Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553881}

Incognito state is indicated by the avatar button in the toolbar.

BUG=822070
TEST=none

Change-Id: Ib87a4f8dbc6e89694277e40fa0f4143ad8e25496
Reviewed-on: https://chromium-review.googlesource.com/1029255Reviewed-by: Peter Boström <pbos@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553880}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ic9ad97d4381e555ba69f55e72152965098041e92
Reviewed-on: https://chromium-review.googlesource.com/1029670Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553879}

This reverts commit 6b5ac2ef.

Reason for revert:
It broke the Win ASan bot on the LKGR waterfall (see second bug).

Original change's description:
> Reland "win: Link with lld instead of MSVC's link.exe by default"
> 
> This is a reland of be8138a4
> The issues with the previous attempt were addressed in the latest
> Clang roll (#553415).
> 
> Original change's description:
> > win: Link with lld instead of MSVC's link.exe by default
> >
> > lld is LLVM's linker. It produces PE/COFF and PDB files just like
> > link.exe, but it's significantly faster and it can also handle LLVM's
> > internal representation, which will enable us to do link-time
> > optimization and control-flow integraty checks with Clang.
> >
> > While lld is much faster at linking, it doesn't support incremental
> > links, meaning builds that only touch a few files and re-link a large
> > executable may become slower.
> >
> > This is the first attempt at switching everything over, with the
> > purpose of gathering data and finding unknown unknowns. It's likely
> > temporary until something breaks.
> >
> > is_win_fastlink is implicitly ignored when using lld, as lld without
> > fastlink is faster than link.exe with it.
> >
> > Also switch the CrWinClangLLD bots on chromium.clang to use MSVC's
> > link.exe to make sure that configuration keeps working.
> >
> > Bug: 792131
> > Change-Id: I0f115a78c33d69eadbd480f75c2a5d636e86483d
> > Reviewed-on: https://chromium-review.googlesource.com/983632
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#551367}
> 
> Bug: 792131
> Change-Id: I3b76cd015ef18bb3e2ac7a3efa4352c4f04e560b
> Reviewed-on: https://chromium-review.googlesource.com/1028374
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Hans Wennborg <hans@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553776}

TBR=thakis@chromium.org,hans@chromium.org

Change-Id: Ied5addd2f8d16d1e002bf37846e7106b4c754cb9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 792131, 837090
Reviewed-on: https://chromium-review.googlesource.com/1029631Reviewed-by: Hans Wennborg <hans@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553878}

Mash browser tests do not support this test (see patch set #2 trys) so
disable it in mash.

No-Tree-Checks: true
Bug: 836254,701924
Change-Id: I3266d131b84c261e5bb6b9358b7c9132172bbabf
Reviewed-on: https://chromium-review.googlesource.com/1029470Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553877}

This reverts commit 116dd7c3.

Reason for revert: broke https://ci.chromium.org/buildbot/chromium.webkit/WebKit%20Mac%20Builder/240835

Original change's description:
> Replace hermetic Xcode installation with CIPD-based flow.
> 
> The 'API' to the scripts remains the same, only the delivery mechanism changes.
> 
> BUG=797051
> R=​erikchen@chromium.org, justincohen@chromium.org
> 
> Change-Id: I8ee5486b107061f9fb6e64354463ac51de53d4cc
> Reviewed-on: https://chromium-review.googlesource.com/887819
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Erik Chen <erikchen@chromium.org>
> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#553871}

TBR=erikchen@chromium.org,justincohen@chromium.org,sergeyberezin@chromium.org,jbudorick@chromium.org

Change-Id: Icdd25e048a8ed6de19b7a98e41a438c1c7c6ed2f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 797051
Reviewed-on: https://chromium-review.googlesource.com/1029630Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553876}

Using DecoderBuffer removes the need to provided SharedMemoryHandles in
cases that SharedMemory is not already allocated (in particular, when
VDAs are used through MojoVideoDecoder+VdaVideoDecoder). Since
base::SharedMemory is not an interface, a new type is required, and
DecoderBuffer already implements a suitable interface for this use case.

This CL adds:
  - A VideoDecodeAccelerator::Decode() overload for decoding
    DecoderBuffers, which VDAs may optionally implement.
    Note that VdaVideoDecoder will require this, and therefore all VDAs
    will be updated to support DecoderBuffers over time.
  - Support for SHM in DecoderBuffer. This eases the transition by
    allowing BitstreamBuffers to be easily converted to equivalent
    DecoderBuffers.
  - An implementation of the new VideoDecodeAccelerator::Decode()
    overload in VTVideoDecodeAccelerator.
  - Calling the new overload from VdaVideoDecoder.

Originally landed as 4596c802. This
reland removes a DCHECK() in unaligned_shared_memory_unittest.cc so that
SHM is still allocated when DCHECKs are disabled.

Bug: 522298
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Id5d6bb103070dfcb23e3db82c68d2ead23b9e3b5
Reviewed-on: https://chromium-review.googlesource.com/1028834
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553875}

The icon itself lives in //third_party/libapps/nassh/images/dev
and is only used in chromeos. We allow chromeos to scale the icon from 192
to the device-appropriate size.

Bug: 813699
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I01385219919686915abbfddbc7032adff6aab3a0
Reviewed-on: https://chromium-review.googlesource.com/1025470Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553874}

Add UpdateSettings API for update settings ui request.

Bug: 819782
Test: Manual Test
Change-Id: Ibd7c303da98f0bc95b53ac08c365cc4276ac605f
Reviewed-on: https://chromium-review.googlesource.com/1016039
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553873}

See go/closure-compile-gn for details.

This CL converts the Closure Compilation of the file manager from GYP to
GN, and fixes a number of type-checking issues that were somehow
suppressed due to the way the compiler used to be run.

A local closure compile can be run by setting closure_compile = true in
args.gn, and then running ninja -C out/Default webui_closure_compile.
A more localized compile may look like:
ninja -C out/Default ui/file_manager:closure_compile

Bug: 632206
TBR=tbreisacher@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ic95ae50ee2e61cb6b5432cb4c5e13a8ac3b2bb44
Reviewed-on: https://chromium-review.googlesource.com/1018684
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Sasha Morrissey <sashab@chromium.org>
Reviewed-by: Naoki Fukino <fukino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553872}

The 'API' to the scripts remains the same, only the delivery mechanism changes.

BUG=797051
R=erikchen@chromium.org, justincohen@chromium.org

Change-Id: I8ee5486b107061f9fb6e64354463ac51de53d4cc
Reviewed-on: https://chromium-review.googlesource.com/887819Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553871}

Change-Id: Iab1194d9b98a6460847627e94fb385ce31db43ea
Reviewed-on: https://chromium-review.googlesource.com/1028456Reviewed-by: Bence Béky <bnc@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553870}

It's not used anymore.

Bug: 672962
TBR: tsepez@chromium.org
Change-Id: I7e1485259d42a3396337db0d54a1c9f4ab561b01
Reviewed-on: https://chromium-review.googlesource.com/1029128Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553869}

Bug: 831585
Change-Id: I3436ca3abe39a648a150d703173715f69756e508
Reviewed-on: https://chromium-review.googlesource.com/1028009
Commit-Queue: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553868}

BUG=836858

Change-Id: I34333a72501129fd40b5a9aa6378c9f35f1e7fc2
Reviewed-on: https://chromium-review.googlesource.com/1028511Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Charlie Reis <creis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553867}

Restructured and updated doc on content scripts.
Included more code samples and further explained
different script insertion types.

Change-Id: I93bf8d111078eb34e78ffd1a1fbae696c521c019
Reviewed-on: https://chromium-review.googlesource.com/698290
Commit-Queue: Crystal Lambert <crystallambert@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553866}

SearchResultMetadata holds the information that shared between Chrome
and Ash. It'll act as the basic data structure to represent a search
result over IPC.

This commit also:
- adds missing stuff in app_list_struct_traits.h;
- adds more result types since we'll not pass kUnknown type over IPC;
- adds a display score to SearchResult, which is currently mixed with
  relevance.

Bug: 733662
Change-Id: I6b29d2d7bc4f7287f373c6c1083f382f5f0f781b
Reviewed-on: https://chromium-review.googlesource.com/998681
Commit-Queue: Jiaquan He <hejq@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553865}

This coordinator manages the BrowserContainerViewController, which
displays the main web page content view.  This is in preparation for
a new fullscreen implementation experiment where the container will
conform to FullscreenUIElement.  The coordinator can setup and tear
down FullscreenUIUpdaters for the BrowserContainerViewController upon
starting/stopping.

Bug: 836400
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4054c279dcabe2a8f88ebb769ae40d1d15f07b67
Reviewed-on: https://chromium-review.googlesource.com/1026564Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#553864}