GitLab

app-route is a fairly heavy-weight element, supporting complex routing
patterns designed for large pages. This is unnecessary for MD History,
which currently has one routing pattern and one query parameter.

This CL replaces app-route with a custom router, <history-router>, which
is responsible for two-way binding between the page state and the page
URL. This also refactors handling of search terms elsewhere in the app
to ensure that changes to the search term are reflected correctly across
the page.

This CL has a small positive impact on load time (~20ms on a Z620), code
health (all routing is handled in one place) and binary size (app-route
can be deleted from the binary).

BUG=629710
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2352293002
Cr-Commit-Position: refs/heads/master@{#420590}

BUG=614320

Review-Url: https://codereview.chromium.org/2360723002
Cr-Commit-Position: refs/heads/master@{#420589}

Bluetooth needs to use document->frame() in ContextLifecycleObesrver::contextDestroyed().
Hence this CL moves m_frame=nullptr to after dispatching contextDestroyed().

See https://groups.google.com/a/chromium.org/d/topic/blink-dev/sfpRQc4LB_I/discussion for more motivation of this CL.

BUG=610176

Review-Url: https://codereview.chromium.org/2362173002
Cr-Commit-Position: refs/heads/master@{#420588}

BUG=624095

Review-Url: https://codereview.chromium.org/2353333005
Cr-Commit-Position: refs/heads/master@{#420587}

We applied OPTION's style incorrectly.

BUG=649320

Review-Url: https://codereview.chromium.org/2361113003
Cr-Commit-Position: refs/heads/master@{#420586}

This CL make sure the downloads of the entries start with the delay associated
with the entry and retry to download them if the failure is recoverable.

BUG=629771

Review-Url: https://codereview.chromium.org/2351113003
Cr-Commit-Position: refs/heads/master@{#420585}

The original DCHECK was asserting on float equality. This was too strict
and was firing for small negligible differences. This change flattens
specified Lengths into a single float and compares them with a constant
slack allowance.

This check is intended to pick up on differences like -5 vs 0 due to
different clamping behaviour, small differences in floating point
arithmetic is fine.

BUG=649525

Review-Url: https://codereview.chromium.org/2366823003
Cr-Commit-Position: refs/heads/master@{#420584}

This was an abstraction so that tests could substitute in a fake
version of a Mojo interface in tests. However, the test can just
implement a testing version of the Mojo interface and use it
directly, simplifying the code.

BUG=none

Review-Url: https://codereview.chromium.org/2345423002
Cr-Commit-Position: refs/heads/master@{#420583}

BUG=148757

Review-Url: https://codereview.chromium.org/2361253002
Cr-Commit-Position: refs/heads/master@{#420582}

offset-position and offset-anchor are both animatable as
<position>.
https://drafts.fxtf.org/motion-1/#offset-position-property
https://drafts.fxtf.org/motion-1/#offset-anchor-property

BUG=638055

Review-Url: https://codereview.chromium.org/2364503002
Cr-Commit-Position: refs/heads/master@{#420581}

The purpose of this CL is to make the code a little simpler and easier to read.

Review-Url: https://codereview.chromium.org/2367573002
Cr-Commit-Position: refs/heads/master@{#420580}

This patch fixes var() references to registered properties to return
initial values where appropriate. When a registered property is not
explicitly set, var() references to it should result in that property's
initial value. We now store the initial value as a token stream as well
to accommodate this.

Any unregistered property in a var() cycle will continue to compute to
their initial value (i.e. the invalid value). Any registered property
in a var() cycle similar compute to their initial value (I don't think
this is explicitly mentioned in the spec, but for consistency this makes
more sense than the unset value). Valid references to properties in a
var() cycle will resolve to the referenced property'd initial value.

BUG=641877

Review-Url: https://codereview.chromium.org/2358203003
Cr-Commit-Position: refs/heads/master@{#420579}

 * The hash function is not resilient to hash flooding (but neither is the other
   hash functions we already use for e.g. unordered_containers).

 * Add std::hash and WTF::DefaultHash/HashTraits traits for {Inlined}StructPtr.

 * Modify the generated Struct/UnionTraits so they generate const accessors to
   the struct/union fields where possible (i.e. when there are not handle
   fields).

Review-Url: https://codereview.chromium.org/2339413004
Cr-Commit-Position: refs/heads/master@{#420578}

Slimming paint v2 (SPV2) initially had root property tree nodes on the
FrameView. This approach required some contortions when the root-layer-
scrolls codepath was added because LayoutView needed to store the root
nodes.

This patch adds static root paint property tree nodes but only uses
them on FrameView. A followup patch will switch the root-layer-scrolls
codepath to use this approach as well.

Because the root nodes can no longer be looked up off the FrameView,
a cache of the entire property tree state has been added to FrameView
(totalPropertyTreeStateForContents). This is similar to
LocalBorderBoxProperties on ObjectPaintProperties, and a followup patch
will refactor LocalBorderBoxProperties to use PropertyTreeState as well.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
BUG=645615

Review-Url: https://codereview.chromium.org/2359063002
Cr-Commit-Position: refs/heads/master@{#420577}

Review-Url: https://codereview.chromium.org/2364543003
Cr-Commit-Position: refs/heads/master@{#420576}

CopyTexImage2D has bug for cube map texture target on Intel Mac, if the
CUBE_MAP_POSITIVE_X texture is not allocated yet.

This CL works around this bug by doing TexImage2D to allocate the CUBE_MAP_POSITIVE_X
texture before CopyTexImage2D if target is one face of a cube map texture.

BUG=648197
TEST=deqp/functional/gles3/texturespecification/basic_copyteximage2d.html
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2348243002
Cr-Commit-Position: refs/heads/master@{#420575}

BUG=232040

Review-Url: https://codereview.chromium.org/2351373003
Cr-Commit-Position: refs/heads/master@{#420574}

Update createContextualFragment behavior to latest spec listed under [1].
This means specifically we do not throw an exception when the context node is
not HTML or SVG and if initially the context element is null, we follow step 2
to create an appropriate context element to be used in step 3.

Behavior matches Firefox and Safari.

BUG=616760

[1] https://w3c.github.io/DOM-Parsing/#extensions-to-the-range-interface

Review-Url: https://codereview.chromium.org/2356373002
Cr-Commit-Position: refs/heads/master@{#420573}

There was previously a typo in this line. We should pick the high-resolution
icon when scale >= 1.5f and the low-resolution icon otherwise.

BUG=648998
BUG=b/31596656
TEST=samus verify icon is high resolution in app list before arc opt-in
TBR=xiyuan

Review-Url: https://codereview.chromium.org/2360873004
Cr-Commit-Position: refs/heads/master@{#420572}

The approach is very simple: if the PaintChunk.id's match, then reuse the layer
backing a chunk, and rely on the raster invalidations to invalidate as needed if
content changes or moves relative to the PaintChunk.

BUG=647831
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2345233004
Cr-Commit-Position: refs/heads/master@{#420571}

Skia actually renders to a larger radius than just blur().

BUG=648963,624175

Review-Url: https://codereview.chromium.org/2356213004
Cr-Commit-Position: refs/heads/master@{#420570}

BUG=649539

Review-Url: https://codereview.chromium.org/2358083004
Cr-Commit-Position: refs/heads/master@{#420569}

https://pdfium.googlesource.com/pdfium.git/+log/39ee9dfac1c6..917d24852841

$ git log 39ee9dfac..917d24852 --date=short --no-merges --format='%ad %ae %s'
2016-09-22 tsepez Make CPDF_ColorSpace::Load() return a unique_ptr

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2361333002
Cr-Commit-Position: refs/heads/master@{#420568}

https://boringssl.googlesource.com/boringssl/+log/e34bcc91c07c0bf65ecc53a814d51f5246007150..bd672ae8c7494732be9cf71b9bfdd431580204f1

BUG=none
TBR=svaldez@chromium.org

Review-Url: https://codereview.chromium.org/2368473002
Cr-Commit-Position: refs/heads/master@{#420567}

ChannelMojo between Service process <-> service utility process is
currently disabled because:
  -- Service process starts service utility process with a command line
     containing kMojoChannelToken switch but no kMojoApplicationChannelToken,
     because they are not in ServiceManager world now.
  -- But, service utility process(ChildThreadImpl) will disable ChannelMojo
     because of lack of kMojoApplicationChannelToken switch.

This CL lets ChildThreadImpl enable ChannelMojo also for a kMojoChannelToken
switch.

BUG=646833
TBR=ben@chromium.org

Review-Url: https://codereview.chromium.org/2366443004
Cr-Commit-Position: refs/heads/master@{#420566}

This lets the layer view to be reused without bringing the entire Timeline
panel as a dependency. Also, made all component widgets of the layer viewer
to be web components.

Review-Url: https://codereview.chromium.org/2358253002
Cr-Commit-Position: refs/heads/master@{#420565}

This is the same dialog as shown when external links are opened from
incognito, informing the user that they are leaving incognito mode and
potentially sharing data with an external application.

BUG=645007

Review-Url: https://codereview.chromium.org/2354833002
Cr-Commit-Position: refs/heads/master@{#420564}

Cr-Commit-Position: refs/heads/master@{#420563}

The other split string functions have a consistent set of arguments that allow callers to specify whitespace handling and what to do with empty items. This one variant still used the old signature and passed through the parameters to the same backend.

This patch makes the parameters match the other forms and removes the legacy versions. There should be no behavior change since this should end up calling the same backend with the same parameters.

gesture_property_provider.cc changed to using a range-based for loop since it didn't need the temporary.

R=dcheng@chromium.org
TBR=bauerb@chromium.org (webui owners)

Review-Url: https://codereview.chromium.org/2356253006
Cr-Commit-Position: refs/heads/master@{#420562}

//mojo/public/cpp/bindings has global state: putting it in a source set
is trouble in a component build, since it's easy to end up with
multiple copies of globals in different components.

//mojo/public/cpp/system is a dependency of bindings, so change it to
a component as well to avoid multiple definitions in different
components that depend on bindings.

BUG=648397

Review-Url: https://codereview.chromium.org/2358133002
Cr-Commit-Position: refs/heads/master@{#420561}

Since there is no known crash for these functions, we will bring back
the assertions to fortify the IME thread logic.

BUG=643477

Review-Url: https://codereview.chromium.org/2365543002
Cr-Commit-Position: refs/heads/master@{#420560}

BUG=600915

Review-Url: https://codereview.chromium.org/2350623002
Cr-Commit-Position: refs/heads/master@{#420559}

When a device disconnects all its characteristics get destroyed which
was causing callbacks for GATT operations to get dropped. This patch
fixes only mac's write and read. Follow up patches will fix android and
windows.

BUG=621901

Review-Url: https://codereview.chromium.org/2347133002
Cr-Commit-Position: refs/heads/master@{#420558}

These moveTo calls appear to be unneeded and they don't work on the main window
anyway. Due to the way that RenderWidget caches move requests, this causes us to
return incorrect values for the windowRect until the browser resets the rect.

This appears to work correctly today due to a bug in how the pending_window_rect
gets cached in RenderWidget but makes it difficult to fix that bug. See related
CL: https://codereview.chromium.org/2333353002/

Note: This change affects only LayoutTests.

BUG=638671

Review-Url: https://codereview.chromium.org/2354273002
Cr-Commit-Position: refs/heads/master@{#420557}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/60ebc91bfe416e751ba02606db5292e244457d24 Use [CACHE]/cipd/goma for goma_dir in recipe_modules/chromium/config.py (tikuta@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=621828

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2366753003
Cr-Commit-Position: refs/heads/master@{#420556}

BUG=635833

Review-Url: https://codereview.chromium.org/2358983004
Cr-Commit-Position: refs/heads/master@{#420555}

This is in preperation of being able to revert changes in the sources panel.

BUG=610061

Review-Url: https://codereview.chromium.org/2349823002
Cr-Commit-Position: refs/heads/master@{#420554}

BUG=648803

Review-Url: https://codereview.chromium.org/2365643003
Cr-Commit-Position: refs/heads/master@{#420553}

Also, add newlines to host forwarder error logging.

BUG=

Review-Url: https://codereview.chromium.org/2364733003
Cr-Commit-Position: refs/heads/master@{#420552}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/3e8973fd8aef93211db73c3eb873b04581fd2e32 Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
depot_tools:
  https://crrev.com/15ab08227b961ddce83db7e41fb83b9288ff9ccc Roll recipe dependencies (trivial). (recipe-roller@chromium.org)
recipe_engine:
  https://crrev.com/044dba0634a396fd78f97f0f633136420780fc37 More strategic retries in fetch. (dnj@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=chromium:649466,chromium:649529

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354413005
Cr-Commit-Position: refs/heads/master@{#420551}