GitLab

Change-Id: I5108679e13789cce24feda792123b5161cbcd995
Reviewed-on: https://chromium-review.googlesource.com/1079227
Commit-Queue: Brad Lassey <lassey@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563079}

This allows compilers targeting the MS ABI to select the correct
inheritance model for the member function pointer type RunnerMethodType
using the complete type of TaskHandle::Runner. It will allow us to
enable the new Clang flag -fcomplete-member-pointers globally.

Bug: 847724
Change-Id: Ib716e3c0774b7d6b46087e46057ca249e9aa72e7
Reviewed-on: https://chromium-review.googlesource.com/1079852Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563078}

In a follow up, we will make CollectGarbage the bottleneck for the GC
atomic phase.

Bug: chromium:757440
Change-Id: Icf27cfde4a61375eda52207e967c84c4ed9c7c31
Reviewed-on: https://chromium-review.googlesource.com/1078214
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563077}

The implementations are |NOTREACHED()| since users cannnot sign out of
Chrome in Chrome OS.

Bug: 820046
Change-Id: Ie559d52388418d5a8a182afdb8a08f92b726c21b
Reviewed-on: https://chromium-review.googlesource.com/1076291Reviewed-by: Lutz Justen <ljusten@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kush Sinha <sinhak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563076}

A test includes the cc file
components/search_engines/search_engines_test_util.cc instead of
its header file. This patch changes that to include the header
file instead.

This inclusion has caused no to me known problems and was just found
as a result of looking through the source for this pattern after
a similar instance did cause problems.

Change-Id: Iffdb68a8055d69a8a3df450c7982ec1e674dcf6e
Reviewed-on: https://chromium-review.googlesource.com/1005175
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563075}

Update references to ExtensionService in c/b/renderer_context_menu to
use extensions::ExtensionService.

There should be no behavior change as a result of this CL.

Bug: 117261
Change-Id: I7a137ee97d0d884d36cf20db1c8484bae6e5c62a
Reviewed-on: https://chromium-review.googlesource.com/1079716
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563074}

https://www.w3.org/TR/webauthn/#ref-for-dom-authenticatorassertionresponse-userhandle

Bug: 847878
Change-Id: I8071207c15d3150a486133eb50cc7d00cbba5401
Reviewed-on: https://chromium-review.googlesource.com/1079200Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563073}

Moves HandleViewResources to ui/resources.
Also removes the DEPS exception rule that becomes unnecessary.

Bug: 617324
Change-Id: Ideb9b2d858ffe8a9f5ea7f345c7a9cdd3a9c38cd
Reviewed-on: https://chromium-review.googlesource.com/1071148Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563072}

No actual logic is added, simply the plumbing to call between Java and
native code. In subsequent patches logic will be added to the
FeedSchedulerHost.

Bug: 831642, 831644
Change-Id: Icec552cbf4d482739d7211a9cc81bb669e0df413
Reviewed-on: https://chromium-review.googlesource.com/1068199
Commit-Queue: Sky Malice <skym@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563071}

https://pdfium.googlesource.com/pdfium.git/+log/0789714..a7b65b8


git log 0789714..a7b65b8 --date=short --no-merges --format='%ad %ae %s'
2018-05-30 rharrison@chromium.org Migrate coverage_report.py to use upstream Chromium scripts
2018-05-30 npm@chromium.org Roll third_party/freetype/src/ 9e345c911..d45d4b97e (27 commits)
2018-05-30 thestig@chromium.org Remove dead code in various write function.
2018-05-30 thestig@chromium.org Add pixel tests for PDFs that use generation numbers.
2018-05-30 thestig@chromium.org Exclude certain colorspace types for calculating transparency backdrop color.
2018-05-30 thomasanderson@chromium.org Remove manual references to exe_and_shlib_deps
2018-05-30 tsepez@chromium.org Make common page base class for XFA and non-XFA.

Created with:
  gclient setdep -r src/third_party/pdfium@a7b65b8

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:847346,chromium:845700

TBR=dsinclair@chromium.org

Change-Id: I040d66e3a3a9344b7d3858c743a524f40ccd5a76
Reviewed-on: https://chromium-review.googlesource.com/1079847Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563070}

- Only 1 Console test dumps classNames: 'console-format-classes.js'
- Classes dumped with indentation

Bug: none
Change-Id: Ieb919f05e3a69f374ed6baecbaef99f66cf20e33
Reviewed-on: https://chromium-review.googlesource.com/1077747Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563069}

Sort gtests in the same way the src/testing/buildbot version does, to
minimize differences when switching over to that script.

Apply swarming_settings to gtests, not just isolated_scripts.

Tbr: ynovikov@chromium.org
Tbr: geofflang@chromium.org
Bug: 844815
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifd791b9e459230f78b020bf46f031b3d3691e64a
Reviewed-on: https://chromium-review.googlesource.com/1079850Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563068}

Adjust the dialog based on UI review.
1) Align the enterprise logo with the head of button instead of tail.
2) Append "..." into the launching information.
3) Using close button instead of cancel button.

Bug: 840018
Change-Id: I5689eceef9ad9b9061d5e4a3d1e314456704b6a2
Reviewed-on: https://chromium-review.googlesource.com/1072207Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563067}

For incognito profiles, the infobar is not being shown since
the DownloadManagerService only starts observing the download item updates
after we open download home in incognito. Fixed this bug in this CL.

Bug: 846139
Change-Id: I507c285901474ce47f09a1610639805afe3c904f
Reviewed-on: https://chromium-review.googlesource.com/1073078
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563066}

Previous attempts of adding and removing to the top layer were done
synchronously. The spec has been updated to do this asynchronously and
this change matches those changes.

Bug: 240576
Change-Id: Ic57a651596c685daa4b32d78421de5db912c106e
Reviewed-on: https://chromium-review.googlesource.com/1066600
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563065}

Based on UX feedback.

BUG=848070

Change-Id: I794b8069d74379887ad5ad04070873eb8aeaaf94
Reviewed-on: https://chromium-review.googlesource.com/1080170Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563064}

TBR=pfeldman@chromium.org

Bug: chromium:595206
Change-Id: I1abab36d1af07acb7198048f0082423a2d58e258
Reviewed-on: https://chromium-review.googlesource.com/1080176Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563063}

Tooltips only show when the mouse target is visible/has offsetParent.
Elements using shadow DOM can have <content> elements in the event
path, which may be visible despite having no offsetParent.

Bug: 847387
Change-Id: Ie5dab99d27146787ad7b14bdf95c7932af1e712d
Reviewed-on: https://chromium-review.googlesource.com/1077328Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563062}

This reverts commit 714e3f7d.

Reason for revert: reproducible crash: http://crbug.com/847276

Original change's description:
> Reland "Re-land: Avoid serializing the same accessibility node twice in the same message"
>
> Reverted second time speculatively to see if it was related to
> failures on Win10 Tests x64 (dbg), but it didn't seem related.
>
> This reverts commit 50da791e.
>
> Original change's description:
> > Revert "Re-land: Avoid serializing the same accessibility node twice in the same message"
> >
> > Speculative revert, see build failures on Win10 Tests x64 (dbg):
> > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win10%20Tests%20x64%20%28dbg%29/803
> >
> > Bug: http://crbug.com/846837
> >
> > This reverts commit 983e926b.
> >
> > Reason for revert: <INSERT REASONING HERE>
> >
> > Original change's description:
> > > Re-land: Avoid serializing the same accessibility node twice in the same message
> > >
> > > Originally landed: r560165, crrev.com/c/1063007
> > > Reverted: r561246, crrev.com/c/1069891
> > >
> > > TBR=dtseng@chromium.org
> > > Bug: 651614, 845778
> > >
> > > Change-Id: I77b54de28cb0c4a231b5b0758ba4708100d27fff
> > > Reviewed-on: https://chromium-review.googlesource.com/1072875
> > > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#561913}
> >
> > TBR=dmazzoni@chromium.org,dtseng@chromium.org
> >
> > Change-Id: I5cbf8006e4917a9c008143ae4b746543d2b038c2
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 651614, 845778, 846837
> > Reviewed-on: https://chromium-review.googlesource.com/1074050
> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> > Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#562043}
>
> TBR=dmazzoni@chromium.org,dtseng@chromium.org
>
> Change-Id: I3dc8009836eb084271a3ac5239311008dc17105b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: http://crbug.com/846837, 651614, 845778, 846837
> Reviewed-on: https://chromium-review.googlesource.com/1074587
> Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#562118}

TBR=dmazzoni@chromium.org,dtseng@chromium.org

NOTRY=true

Bug: http://crbug.com/846837, 651614, 845778, 846837, 847276
Change-Id: I342db1180d09bc9eaa1a9c8fc7054fa2ca366eb6
Reviewed-on: https://chromium-review.googlesource.com/1079090
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563061}

When an OpenGL implementation exposes the GL_OES_texture_half_float_linear
extension, the YUV format can be set to L16F. Since OSMesa doesn't
expose this extension, the test currently doesn't fail in this case, but
it fails when ran with SwiftShader. This fixes the issue.

Bug: chromium:848035
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I076ee00ba187f6d89cc51de41f15f0872d4d728c
Reviewed-on: https://chromium-review.googlesource.com/1080030Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Commit-Queue: Alexis Hétu <sugoi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563060}

ASan and CFG leads to slow process startup. Chromium's test runner uses
lots of child processes, so this means things are really slow. Disable
CFG for now. This should help keep the ASan bots from timing out.

BUG=846966
R=brucedawson@chromium.org

Change-Id: Id2d66e97badc67dc29af557ff6bdbbd9cfd3c0b5
Reviewed-on: https://chromium-review.googlesource.com/1074337Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563059}

Previously ServerAliveInterval and ServerAliveCountMax were both set
to 1 in SSH config used to connect to Fuchsia from the runner script.
This means that SSH diconnects after it fails to deliver 1 keep-alive
message within 1 second.
This interval is too short, which was causing timeouts and spurious
test failures in net_unittests. Increase these values to 2 and 5.

BUG=847915

Change-Id: I88d786626512f08da19444615f13285aac461dcb
Reviewed-on: https://chromium-review.googlesource.com/1079325Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563058}

This change removes a synchronous call from browser code into VRDevice,
in anticipation of making VRDevice a mojo interface.

Browser-side now controls whether a device is fallback.

The change here is temporary until further refactors to support XR.
Fallback devices will be removed, and requestSession will have more logic
to determine which device should be returned.

Change-Id: I4707eecf3a0ca8356f7139934c2e1fc79f934d37
Reviewed-on: https://chromium-review.googlesource.com/1080039Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563057}

With the new layout test flag --enable-display-compositor-pixel-dump,
BrowserCompositorMac gets desired viewport size in device pixel from the renderer
through BrowserCompositorMac::SynchronizeVisualProperties(), and convert that
from device pixel to DIP and cache it. However BrowserCompositorMac doesn't know
the overriden device scale factor by test scripts, thus the DIP viewport size
will not be properly divided by the overriden device scale factor.

When next time RenderWidgetHostImpl::SynchronizeVisualProperties is invoked,
it will query the current viewport size, we would get the already scaled value
and multiply it by the overriden device scale factor again. This makes the
viewport size keeps growing until it exceeds the maximum texture size and crash.

This CL makes BrowserCompositorMac to use the device scale factor from the
render frame metadata, so the correct DIP size of the viewport can be derived.

BUG=667551

Change-Id: I21f042ba8c158ce139d1ca6693d135b2fbb7b852
Reviewed-on: https://chromium-review.googlesource.com/1080031
Commit-Queue: ccameron <ccameron@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563056}

Bug: 846478
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr
Change-Id: If825417bb9682cfc98299df85bb3e4960001977c
Reviewed-on: https://chromium-review.googlesource.com/1073871
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563055}

If an embedding is created such that the embedder intercepts events, then the
embedder should get events regardless of capture.

BUG=837692,837696
TEST=covered by test

Change-Id: I8ed3e30ff7973d319bb5ac91323382c1743818c1
Reviewed-on: https://chromium-review.googlesource.com/1080092Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563054}

Update StatisticsProvider to drop pairs received from
crossystem that have "(error)" values. NameValuePairsParser
ignores duplicate values, so we should get rid of these so
they don't prevent us from saving real values later.

Also downgrade a "Statistics loaded after waiting ___ ms"
LOG(WARNING) to VLOG(1), since this seems to be the common
case on a caroline ToT device and it just ends up cluttering
the logs.

Bug: 844258
Change-Id: Idf869617a03992e51a720359b4ebfdac91dec6e9
Reviewed-on: https://chromium-review.googlesource.com/1072706Reviewed-by: Thiemo Nagel <tnagel@chromium.org>
Commit-Queue: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563053}

Also adds an option to sort by hostname on the DataSaver settings page
so that the TalkBack navigation experience is consistent with the other
table headers.

Bug: 836018
Change-Id: Ic837d520ea613185398b0b2214640b80a41bcfa4
Reviewed-on: https://chromium-review.googlesource.com/1077588Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563052}

Currently we create default web request rules registries for the declarative web
request API even if the API is not available to the current environment. This is
wasteful and detrimental to performance, since the initial registry load blocks
the first network request (tracked via Extensions.NetworkDelayRegistryLoad UMA).

This CL changes RulesRegistryService so that the default WebRequestRulesRegistry
is registered only if the declarative web request API is avaialble to the
current environment. This, for example, means that no default web request rule
registries would be created on the stable channel. Rules registries
corresponding to webviews and the default content rules registry would still be
created.

This also helps fix issue 777717 and renderer cache is not cleared redundantly
on each extension load/unload/uninstall when the API is not available.

BUG=693243, 777717

Change-Id: I7384fed71a86aea3f5cc8d2eafd1445b439dd76a
Reviewed-on: https://chromium-review.googlesource.com/1072497Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563051}

This patch changes the logic the list of zoom values are computed for a
given display. The new logic has 2 scenarios for listing the zoom values
for a given display.

1) Displays with device scale factors assigned to them, will now have
   zoom values ranging from the inverse of device scale factor to
   device scale factor. If there are still slider ticks avaiable we use
   them to add zoom levels beyond the device scale factor.
   Doing this allows the user to go to the native resolution of the
   display and on the other hand it also allows them to zoom in if
   required. We no longer allow the user to go to a zoom below the native
   resolution of the display as this is a very unlikely scenario and
   introduces artifacts. This also gives finer control to the user in
   setting the zoom level.
   How this effects a pixelbook for example?
   On pixelbook we used to have a zoom range of 50% to 175%. Due to the
   wide range, the consecutive values were too far apart and users wanted
   zoom values that were mostly in the range of 70% to 100%.
   With the new change, the range will go from 50% to 130%.

2) Displays with no device scale factors assigned to them will use a
   static list of initialized zoom values.

Bug: 845634
Change-Id: I69a761856dab4e5b37b85420f6f6dfebdb2dead5
Component: Display zoom, display util
Reviewed-on: https://chromium-review.googlesource.com/1069561
Commit-Queue: Malay Keshav <malaykeshav@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563050}

Bug: 842402
Change-Id: I0639f8bd383481f8727e149fedb8b46201b895ad
Reviewed-on: https://chromium-review.googlesource.com/1077616Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: Thomas Guilbert <tguilbert@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563049}

- Add "Feedback" item to power button menu if user is logged in and screen is
  unlocked. Since sending feedback was not allowed at login and lock screen.

finch side change:
https://critique.corp.google.com/#review/197648342

spec: https://drive.google.com/file/d/1JNH0ZDknXSvV00C7TeT4xT_rFx48OdZd/view

Bug: 845558
Change-Id: I93dadb2f3e12fd389ed649c2fa5884a31971704b
Reviewed-on: https://chromium-review.googlesource.com/1069627
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#563048}

Update references to ExtensionService in c/b/task_manager to use
extensions::ExtensionService.

There should be no behavior change as a result of this CL.

Bug: 117261
Change-Id: I18111ab851102ba21239b4ae7b7ee54ec0fc1076
Reviewed-on: https://chromium-review.googlesource.com/1080021Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563047}

This is a reland of 888c9108

Original change's description:
> Delete HeadlessBrowserContext::Observer::OnChildContentsCreated.
> 
> This isn't used.
> 
> Change-Id: Id61efee5ce35617c6ab65c6c19a059b36323176f
> Reviewed-on: https://chromium-review.googlesource.com/1065076
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Johannes Henkel <johannes@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#559821}

Change-Id: I52e6f2361da7dd900eef24dea4aefd57fa8dda9a
Reviewed-on: https://chromium-review.googlesource.com/1073619Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Johannes Henkel <johannes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563046}

It was being used to report if it was there or not, and in some dead
functions. The test checking IsSoftware() didn't actually care, (it used
it to pass HARDWARE or SOFTWARE to a funciton that only checks for
RESOURCELESS_SOFTWARE) and the dead code is now removed.

TBR=jam

Bug: 826886
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ia5c19a3ac25dc3d2ae58e44cee25d2c44ec61dff
Reviewed-on: https://chromium-review.googlesource.com/1079688
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563045}

Update references to ExtensionService in c/b/notifications to use
extensions::ExtensionService.

There should be no behavior change as a result of this CL.

Bug: 117261
Change-Id: Ie3133eeb0a9778c909420b3f531e2d34d4270686
Reviewed-on: https://chromium-review.googlesource.com/1079901Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563044}

It was recently enabled in
https://chromium-review.googlesource.com/c/chromium/src/+/1076594, but
it does not pass. I have not debugged it, I'm just trying to get things
back to green now that we are running this test more widely.

TBR=sky@chromium.org, thakis@chromium.org
BUG=848049

Change-Id: Ic0842dce2ddc10951b28e3e095f746c06076ecfe
Reviewed-on: https://chromium-review.googlesource.com/1080073Reviewed-by: Reid Kleckner <rnk@chromium.org>
Commit-Queue: Reid Kleckner <rnk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563043}

URLRequests terminate with a status of canceled if the device is
suspended during download. In order to accommodate for this when
downloading an extension, add this to the cases in which we retry
automatically.

Bug: 824454

Change-Id: Ia3187c0ca0150968d8eae67f8f265bb6f7e7ab6e
Reviewed-on: https://chromium-review.googlesource.com/1079689Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563042}

Bug: 846890
Test: manual
Change-Id: I37b4a89130d282a497058485bcd1c24fd87b326d
Reviewed-on: https://chromium-review.googlesource.com/1074224Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Qiang Xu <warx@google.com>
Cr-Commit-Position: refs/heads/master@{#563041}

GamepadDispatcher caches the last gamepad that was connected
or disconnected as well as its index and connection state.
but The cached value is no longer used.

Bug: 843305
Change-Id: I20b30f88d638f94b4a41f593a6976f7ae5f3d4e8
Reviewed-on: https://chromium-review.googlesource.com/1077879Reviewed-by: Matt Reynolds <mattreynolds@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#563040}