- 02 May, 2018 40 commits
-
-
Jennifer Apacible authored
There are two instances where PictureInPictureWindowController is torn down: 1. Tab is closed (controller is tied to the tab's WebContents). In this case, the player is also deleted, so there are no behavioral concerns. 2. A video on a different tab enters Picture-in-Picture mode. In this case, the player from the earlier PiP'd tab may still be playing in that tab, meaning there may be two(+) videos playing. This change would pause the initial video, as the user has indicated they want to PiP a new video. This behavior will be up for further discussion with UX. BUG: 823172 Change-Id: I3e1a58f496f5814a4a8aae40df3de23cd0ee6702 Reviewed-on: https://chromium-review.googlesource.com/1038303Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#555416}
-
Jennifer Apacible authored
Currently, the PictureInPictureWindowController is reset and torn down whenever a new video goes into Picture-in-Picture mode. This is less than ideal since the PictureInPictureWindowController is attached and scoped to the lifetime of a WebContents via WebContentsUserData. Rather, we should allow the natural teardown of the controller when the initiator tabs is destroyed. BUG: 823172 Change-Id: I7e13b8bf45899fd4ff4b3dbd34781d04ab15dc1d Reviewed-on: https://chromium-review.googlesource.com/1034194 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#555415}
-
Matthew Cary authored
Removes the mNeedsReload flag in Tab.java which was just a thin and partial wrapper around the navigation controller's needs_reload mechanism. This duplication caused at least one race condition (crbug.com/828400) and will also complicate future LifecycleManager work. All of the checking in Tab.java of mNeedsReload was duplicated by the navigation controller's needs_reload flag, as used in NavigationControllerImpl::LoadIfNecessary. Bug: 829381 Change-Id: Id17c9d9f89088c718ae4a927ea5b8dbe95126e68 Reviewed-on: https://chromium-review.googlesource.com/1006958Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#555414}
-
David Reveman authored
Updated spec for system top bar doesn't have this separator. Bug: 838649 Test: Manual Change-Id: I3ef1b914e2ac830978311bf5a446a8a4888232bd Reviewed-on: https://chromium-review.googlesource.com/1039946Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555413}
-
Philip Jägenstedt authored
Only test was removed in https://github.com/w3c/web-platform-tests/pull/9967. No-Try: true Change-Id: I9cb46906d621d25261476f5de414622f694d4173 Reviewed-on: https://chromium-review.googlesource.com/1039191Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#555412}
-
Tom Anderson authored
Also update base::Bind to base::BindRepeating. Background: I tried using the template form of Start() on a base::MockTimer and was confused because it wasn't working. This was because Timer::Start() was getting called instead of MockTimer::Start. BUG=None R=thestig Change-Id: I15341804f364c9d5fd1f590c5e6d02db1728614c Reviewed-on: https://chromium-review.googlesource.com/1038815Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555411}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/dd3fcf9f3eb0..5d4cebe797eb $ git log dd3fcf9f3..5d4cebe79 --date=short --no-merges --format='%ad %ae %s' 2018-05-01 levarum Restore copying cheets_x86_userdebug artifacts Created with: roll-dep src/third_party/chromite The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I9aff48d163a37863611212199a05387b30d734d9 Reviewed-on: https://chromium-review.googlesource.com/1039765 Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555410}
-
Nicolas Pena authored
This CL removes the State member of QueueingTimeEstimator since it is no longer needed. This is the first step in the plan to report EQT by TTI. https://docs.google.com/document/d/19D0f5VGFNmqJDcl5_AqkYOm1iUX24adPloCRO58aiH4/ Bug: 832680, 830882 Change-Id: I571c75a15b51be1f8bff5b105257d6bb0d1092fc Reviewed-on: https://chromium-review.googlesource.com/1035162Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#555409}
-
Koji Ishii authored
Following bot results are included. 5114 5118 5123 5127 5129 5134 5138 5139 5141 1 lines were removed and 2 lines were deflaked by consecutive results since 5080. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I75e4c437e4485caad44eea69eded7d37cfb0341d Reviewed-on: https://chromium-review.googlesource.com/1036868 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#555408}
-
arthursonzogni authored
The class NavigationPostDataHandle doesn't exist anymore. It is not clear to me if it has ever existed. Bug: None. Change-Id: I98d95f02b6e3b03f9f31b6ceeac2e472846dd524 Reviewed-on: https://chromium-review.googlesource.com/1039487Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#555407}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/99550832..1e3401a0 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I1e712b9888c34c7e32309bb50cf15e149a389f8c Reviewed-on: https://chromium-review.googlesource.com/1038918Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#555406}
-
John Abd-El-Malek authored
The test class now works with frame requests when the network service is disabled. Bug: 776589 Change-Id: Iec439f88db2e2daddec350251dc19309a1c2bd5c Reviewed-on: https://chromium-review.googlesource.com/1038651 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#555405}
-
arthursonzogni authored
The histogram is used in NavigationURLLoaderNetworkService as: Navigation.URLLoaderNetworkService.OnCompleteHadSSLInfo But it is declared in histograms.xml as: Navigation.URLLoaderNetworkService.OnCompleteHasSSLInfo The names don't match ("Had" vs "Has"). This CL fixes it. Bug: 783265 Change-Id: I33ea9ae1ba92aaa20dab4b80f3e731b4229f3efa Reviewed-on: https://chromium-review.googlesource.com/1039200Reviewed-by:John Abd-El-Malek <jam@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#555404}
-
Alexander Timin authored
Make PageSchedulerImplTest.DeleteThrottledQueue_InTask faster by reducing the number of tasks it runs. The number got large when we started running tasks after frame detach. R=alexclarke@chromium.org Change-Id: Idf64f179dfafd9edccdff1c69624b5cc9b4694f6 Reviewed-on: https://chromium-review.googlesource.com/1039447Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555403}
-
Matthew Cary authored
Flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=chrome_public_test_apk&tests=testTapInputFieldShowsKeyboardAccessory Bug: 838922 TBR: fhorschig@chromium.org,bauerb@chromium.org Change-Id: I9b55187a8d528a149221075f03186bbaa2b8e789 Reviewed-on: https://chromium-review.googlesource.com/1039826Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#555402}
-
John Abd-El-Malek authored
The test class now works with frame requests when the network service is disabled. Bug: 776589 Change-Id: Ieae2c903860e5263aa73fc3f3521de9f53b0eb4d Reviewed-on: https://chromium-review.googlesource.com/1038621Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#555401}
-
Alexander Timin authored
Instead of disabling throttling for the whole renderer process when audio is enabled, disable it only for the current Page. This will allow to use audio signal when making decisions about loading throttling and throttling dedicated workers. R=alexclarke@chromium.org Change-Id: I78ee861da3e46d12c597294ff8c054bc61b9be6a Reviewed-on: https://chromium-review.googlesource.com/1039426Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555400}
-
https://pdfium.googlesource.com/pdfium.git/+log/c9cd2874278e..5f3e4f1605a5 $ git log c9cd28742..5f3e4f160 --date=short --no-merges --format='%ad %ae %s' 2018-05-02 tsepez Add CPDF_Document::Extension::GetPageCount() Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iec590ce4046816dfc40bada2204b111b5fa6d937 Reviewed-on: https://chromium-review.googlesource.com/1039626 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555399}
-
Dave Schuyler authored
This CL removes a TODO that was left in the code when the to do was done. (That being to separate OmniboxMatchCellView to its own file). There are no logic changes in this CL. Bug: None Change-Id: Idc85e8dfad6a0b15e5458ac09ca92f070aaa923d Reviewed-on: https://chromium-review.googlesource.com/1038662Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#555398}
-
James Cook authored
For mustash (out-of-process ash, see //ash/README.md) code in the browser process cannot call directly into ash. Pin the kiosk app window by setting a window property instead of calling into ash code. Test: * Add logging to ArcKioskAppLauncher and deploy to Chromebook * Enterprise enroll Chromebook to test domain * Move Chromebook to ARC++ test organizational unit * Sign in and allow policy to force-push app * Sign out, observe app auto-launch * Hit escape, see toast saying app is pinned fullscreen * Observe logs in /var/log/ui/ui.LATEST Bug: 756056 Change-Id: I8ac35030bf8b44429096a14ec9a6ad71617e85d8 Reviewed-on: https://chromium-review.googlesource.com/1037775Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#555397}
-
Calder Kitagawa authored
This enforces a stricter patch read in a few ways: - Raw Deltas of 0 are forbidden. These are unused values which have no meaning and should not appear. - Extra Data length must be equal to the size of the patch element minus the total length of equivalences. - Element match headers must have regions of nonzero length. This change also annotates a number of "unsafe" values read from the patch that could be sources of error later if unchecked. It also adds caveats about under what conditions emitted values are considered to be safe/unsafe. Bug: 837096 Change-Id: I1b7614d92b85c0a1546d8dccb7d371d28b2a4cd3 Reviewed-on: https://chromium-review.googlesource.com/1037186 Commit-Queue: Calder Kitagawa <ckitagawa@google.com> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#555396}
-
Allen Bauer authored
Bug: 838523 Change-Id: Ifbe36e9b0a6b1ffad61da0f977ba7660d18f4e55 Reviewed-on: https://chromium-review.googlesource.com/1037904 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#555395}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eaded9d09c31..2050565fe116 $ git log eaded9d09..2050565fe --date=short --no-merges --format='%ad %ae %s' 2018-05-02 herb Add padding back to make msan happy Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I214ab350af953d8fe23c519445c21d0ef4cf231b Reviewed-on: https://chromium-review.googlesource.com/1039625 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#555394}
-
Francois Doray authored
Flakyness was fixed by https://chromium-review.googlesource.com/1033533 Bug: 768436, 792310 Change-Id: I8720a1ae503d096419bcc368c3629bcaa6679e74 Reviewed-on: https://chromium-review.googlesource.com/1039767Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#555393}
-
Daniel Cheng authored
Previously, the plugin completely skipped virtual specifier checks on Gmock objects since it wasn't smart enough to filter out warnings caused by Gmock macros. In preparation for making the plugin smarter, this CL fixes existing virtual specifier warnings in //headless. This CL was uploaded by git cl split. R=dvallet@chromium.org Bug: 837148 Change-Id: I1b20f722f974410fa64cab3bd4c2fc56732bbe42 Reviewed-on: https://chromium-review.googlesource.com/1031199Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#555392}
-
Oystein Eftevaag authored
R=primiano@chromium.org BUG=837758 Change-Id: I2f55f7f4b6ea2f49b7168b2d26ac1b279ead0c79 Reviewed-on: https://chromium-review.googlesource.com/1038155 Commit-Queue: Primiano Tucci <primiano@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Cr-Commit-Position: refs/heads/master@{#555391}
-
Emircan Uysaler authored
Bug: 835752 Change-Id: Ie7664a31c09fff9f77ce614d34b0f61dfb1ed6c1 Reviewed-on: https://chromium-review.googlesource.com/1035903Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#555390}
-
David Reveman authored
After some testing we have determined that the following pattern results in a more appropriate behavior when sending key press/release events to clients: - Send key press events if they have not been handled and are not already pressed. - Send key release events if they are currently pressed. This should reduce the chance that a client ends up with an inappropriate keyboard state where some keys are incorrectly pressed. Bug: 820641 Test: exo_unittests --gtest_filter=KeyboardTest.OnKeyboardKey Change-Id: Ica7b5510928056b6659140cf492e40234a272053 Reviewed-on: https://chromium-review.googlesource.com/1038907Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#555389}
-
Christian Fremerey authored
Besides the test being a redundant implementation of what is tested, we can rely on compile-time checks that all cases of the enum class are handled, so this test is not needed. Bug: 630694 Change-Id: I618a50692b1fc7a643a7863b477a54c6fee9e93f Reviewed-on: https://chromium-review.googlesource.com/1038743Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555388}
-
Emily Hanley authored
Bug: 838302 Change-Id: I41a1640a1415c19e1b48ce442ee309632b7f4c90 Reviewed-on: https://chromium-review.googlesource.com/1036935Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Emily Hanley <eyaich@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#555387}
-
Ricky Liang authored
The Chrome OS HAL VideoCaptureDevice receives the captured data through DMAbuf. On certain platforms the DMAbuf are allocated under some alignment constraints, e.g. on Intel platform the buffer plane width is aligned to 64. Hence when mapped to CPU the memory planes are not contiguous so directly calling libyuv::ConverToI420() with the buffer address and size does not work. BUG=b:78259838 TEST=Make sure camera preview with resolution 2592x1944 displays correctly on DUT. Change-Id: I85cf4fadf24a9374ee837e820dbd89881d14f475 Reviewed-on: https://chromium-review.googlesource.com/1029935 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:Wez <wez@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#555386}
-
Gauthier Ambard authored
This CL changes the blur effect of the toolbar, making it smoother. It also adds a blur effect to the popup menu. Bug: 824920 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic39fe55db2ee508fdf0f835f1af30e4b047afc5f Reviewed-on: https://chromium-review.googlesource.com/1039370 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555385}
-
Dmitry Gozman authored
It's always true, so we can remove some checks and unused code. We can actually remove MaybeCheckCSP method, but it has some valuable comments. We'll remove it either by removing the comments or finding a better place for them. Bug: 789577 Change-Id: I891407ad35230be936164acdfbe26f6123c3a0a9 Reviewed-on: https://chromium-review.googlesource.com/1037804 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#555384}
-
Olivier Robin authored
This reverts commit 1cd5356f. Reason for revert: Breaks tree with error ninja: Entering directory `/b/c/b/ios_simulator/src/out/Debug-iphonesimulator' ninja: error: '../../ios/chrome/browser/ui/authentication/resources/identity_picker_view_arrow_down.imageset/Contents.json', needed by 'gen/ios/chrome/browser/ui/authentication/resources/identity_picker_view_arrow_down.xcassets/identity_picker_view_arrow_down.imageset/Contents.json', missing and no known rule to make it step returned non-zero exit code: 1 Original change's description: > [iOS] Adding unified consent dir > > Moving all files related to unified consent into: > ios/chrome/browser/ui/authentication/unified_consent/ > > Bug: 827072 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I36bbca2d9f3392da5243e524bdc2276ba35d906d > Reviewed-on: https://chromium-review.googlesource.com/1039187 > Commit-Queue: Jérôme Lebel <jlebel@chromium.org> > Reviewed-by: Mihai Sardarescu <msarda@chromium.org> > Cr-Commit-Position: refs/heads/master@{#555375} TBR=msarda@chromium.org,jlebel@chromium.org Change-Id: I7cbba26291b97afbe4206b31fe39ad7c8079b070 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/1039745Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#555383}
-
Danyao Wang authored
This fixes ReloadPostNavigation and ForwardPostNavigation from navigation_and_load_callbacks_inttest with WKBasedNavigationManager. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7fd87c0a04c896570daa0ad35c6324867465702b Reviewed-on: https://chromium-review.googlesource.com/1038655 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#555382}
-
Mihai Sardarescu authored
This CL updates the string used for Unified Consent in the welcome page and in the settings sign-in and sync promos. Bug: 820585 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ib575cd6307440a7e92379940f41c862b13578d1d Reviewed-on: https://chromium-review.googlesource.com/1019324 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555381}
-
Dave Tapuska authored
Now that input mode has shipped in a stable release remove the setting. BUG=642800 Change-Id: I0aecb0261ba17be7bd911fc2c420d0e3c5dd783f Reviewed-on: https://chromium-review.googlesource.com/1037983Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#555380}
-
Eric Stevenson authored
Remove owners who've left Chrome and add myself. Change-Id: Icd28c0432ba688b4e5cff23310425e93f3d7ab09 Reviewed-on: https://chromium-review.googlesource.com/1037934Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#555379}
-
Florent Castelli authored
Only straightforward usage has been removed, identified with regexp "URL.createObjectURL.*stream". Bug: 800767 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I83d563080b2f534e7d9e3062b1633017dc9a01a8 Reviewed-on: https://chromium-review.googlesource.com/878741 Commit-Queue: Florent Castelli <orphis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#555378}
-
Helen Li authored
CreateRequest() needs to take in a traffic annotation. Bug: 837333 Change-Id: Iaa4b8e0cbff89a4ffff4afef9c9cc6accdaba26f Reviewed-on: https://chromium-review.googlesource.com/1039124Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#555377}
-