- 11 Jan, 2017 40 commits
-
-
sadrul authored
Instead of always logging the message ID, log a custom error string. This is necessary for when the messages are converted to mojo messages, where the messages do not have a corresponding ID. BUG=643746 Review-Url: https://codereview.chromium.org/2624613003 Cr-Commit-Position: refs/heads/master@{#442790}
-
dcastagna authored
git log 71db2b55..682d73bd --date=short --no-merges --format='%ad %ae %s' 2016-12-27 gurchetansingh@chromium.org minigbm: cros_gralloc: don't fail BO_USE_SW_*_OFTEN | BO_USE_RENDERING allocation 2016-09-06 hoegsberg@chromium.org rockchip: Add support for AFBC buffers 2016-12-21 henryhsu@chromium.org minigbm: fix size_t type not found 2016-12-19 gurchetansingh@chromium.org minigbm: consolidate flags 2016-12-14 gurchetansingh@chromium.org minigbm: tegra: add blocklinear detiling logic 2016-12-16 dcastagna@chromium.org minigbm: Remove (c) from copyright notice. BUG=chrome-os-partner:56407 Review-Url: https://codereview.chromium.org/2624863002 Cr-Commit-Position: refs/heads/master@{#442789}
-
kinaba authored
android.util.Log does not take formatted string (the third argument is a fixed overload taking a Throwable object), so currently the bare "%s" is emit to the log. Let's drop it. BUG=none Review-Url: https://codereview.chromium.org/2620843003 Cr-Commit-Position: refs/heads/master@{#442788}
-
chrome-cron authored
Cr-Commit-Position: refs/heads/master@{#442787}
-
wangxianzhu authored
Auto generated by //tools/perf/generate_perf_json.py. TBR=eyaich@chromium.org Review-Url: https://codereview.chromium.org/2624963002 Cr-Commit-Position: refs/heads/master@{#442786}
-
reed authored
will enable https://skia-review.googlesource.com/c/6845/ BUG= Review-Url: https://codereview.chromium.org/2623913002 Cr-Commit-Position: refs/heads/master@{#442785}
-
azurewei authored
Add an enum histogram "InputMethod.ImeMenu.EmojiHandwritingVoiceButton" to track the number of times users click emoji, handwriting or voice button in opt-in IME menu. The enum value represents: 1: Emoji 2: Handwriting 3: Voice BUG=676798 TEST=None Review-Url: https://codereview.chromium.org/2600173002 Cr-Commit-Position: refs/heads/master@{#442784}
-
jeffcarp authored
BUG=657117 R=qyearsley@chromium.org Review-Url: https://codereview.chromium.org/2622033002 Cr-Commit-Position: refs/heads/master@{#442783}
-
ssid authored
Revert of Add LevelDB database names to tracing path for easier debugging (patchset #2 id:40001 of https://codereview.chromium.org/2399903004/ ) Reason for revert: We identified the largest consumer of memory in leveldb_proto databases and fixed it crbug.com/662019. It is not safe to add dumps with database names since new clients of leveldb_proto might not update the whitelist and we will miss the memory usage. Original issue's description: > Add LevelDB database names to tracing path for easier debugging > > The data from field trials show large databases, but not sure what are > their names. So, adding names to the path. > > BUG=645126 > > Committed: https://crrev.com/279f8d702e8b2fffda1b7f50b311c5202331e121 > Cr-Commit-Position: refs/heads/master@{#424055} TBR=primiano@chromium.org,nyquist@chromium.org,mathp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=645126 Review-Url: https://codereview.chromium.org/2601233002 Cr-Commit-Position: refs/heads/master@{#442782}
-
caseq authored
- when navigating, add host bindings to the pending frame rather than old frame; - force renderer swap if front-end URL is invalid; - move front-end URL validation to DevToolsUIBindingds This also re-lands https://codereview.chromium.org/2607833002 BUG=662859,678035 Review-Url: https://codereview.chromium.org/2620153002 Cr-Commit-Position: refs/heads/master@{#442781}
-
jialiul authored
crbug.com/676675 Out of memory crash caused by memory alloc inside vector::push_back(). Since vector grows its internal buffer following some kind of geometric progression, it makes more sense to keep pointers inside the vector instead of actual objects. Therefore, change the vector<ReferrerChainEntry> into vector<unique_ptr<ReferrerChainEntry>>. This will help with the memory allocation inside push_back() function. crbug.com/679252 Add additional check on the return of FindNavigationEvent() function to make suer it is valid. BUG=676675,679252 Review-Url: https://codereview.chromium.org/2624463003 Cr-Commit-Position: refs/heads/master@{#442780}
-
tapted authored
Currently it sets a custom close button which is different to the other Harmony dialogs. To keep items aligned, use the standard panel margins from ui/views/layout_constants.h. (13px rather than 16px). This makes the panel slightly more narrow. BUG=640851, 674269 Review-Url: https://codereview.chromium.org/2581493002 Cr-Commit-Position: refs/heads/master@{#442779}
-
chrishtr authored
A previous patch failed to return the composited PaintLayer, which is what GraphicsLayerUpdater expected. BUG=679667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2624843002 Cr-Commit-Position: refs/heads/master@{#442778}
-
ssid authored
This CL makes the check for unregistering dump providers on right thread stricter by checking even if tracing is not enabled. This is made stricter only for new dump providers while the existing ones (except few which are verified correct) are added to a blacklist which does not hit this check. In next CLs this blacklist will be cleared not to cause flakiness on the bots with lots of dump providers failing. BUG=643438 Review-Url: https://codereview.chromium.org/2592233002 Cr-Commit-Position: refs/heads/master@{#442777}
-
jam authored
This in preparation for using this method to grab other schemes that we need to now share across the browser and renderer for PlzNavigate. This change does: -combines AddAdditionalSchemes/AddSecureSchemesAndOrigins/AddServiceWorkerSchemes -standardizes on std::string BUG=627502 Review-Url: https://codereview.chromium.org/2622693002 Cr-Commit-Position: refs/heads/master@{#442776}
-
sashab authored
Changed EUnicodeBidi to an enum class and gave it an unsigned underlying type. Also renamed its members to match the CSS keywords they represent, and added the 'k' prefix in line with the Blink rename to match Chromium style. Changing it to an enum class enforces better namespacing and code practices. Adding the unsigned underlying type is pre-work for when the class is eventually stored as an enum bitfield (it would be done in this patch, except a presubmit warning already exists that prevents that. The presubmit warning needs to be updated before that change can occur.) This is also pre-work to allow EUnicodeBidi to be used by generated fields in ComputedStyleBase. BUG=628043 Review-Url: https://codereview.chromium.org/2625553005 Cr-Commit-Position: refs/heads/master@{#442775}
-
lazyboy authored
BUG=None Test=None, no visible change. Review-Url: https://codereview.chromium.org/2619973002 Cr-Commit-Position: refs/heads/master@{#442774}
-
ananta authored
This test turns off caching for the reload request initiated via the DevTools network agent. Without PlzNavigate, this goes through the normal resource load path, where in RenderFrameImpl::decidePolicyForNavigation is invoked after which the cache policy is set in the WebURLRequest to disabled correctly. With PlzNavigate, the reload request is sent out to the browser via the BeginNavigate IPC in RenderFrameImpl::decidePolicyForNavigation() and we indicate to blink that the client handled the request. As a result the cache policy does not get set to disabled. Fix is to add query the dev tools agent if caching is disabled. To achieve this following changes were needed. 1. Add a virtual function cacheDisabled() to the WebDevToolsAgent class. 2. This function calls to the newly added cacheDisabled() function in the InspectorNetworkAgent class. which checks the state variable for the same. BUG=673745 Review-Url: https://codereview.chromium.org/2611183007 Cr-Commit-Position: refs/heads/master@{#442773}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/854df3eb017b..8b10e7828ad2 $ git log 854df3eb0..8b10e7828 --date=short --no-merges --format='%ad %ae %s' 2017-01-10 bpastene devil: Push devil onto path when running adb_run_shell_cmd.py BUG=672189 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2626903002 Cr-Commit-Position: refs/heads/master@{#442772}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1f92260e..dd4cb049 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2628663002 Cr-Commit-Position: refs/heads/master@{#442771}
-
tombergan authored
On receiving a PUSH_PROMISED, the pushed stream is assigned an IDLE priority because it is "speculative". When the pushed stream matches an actual request, the stream's priority is updated to match that of the request. In addition to unit tests, I tested this against a local HTTP/2 server that served the following page: <html><body> <script type="application/javascript" src="/a.js"></script> <script type="application/javascript" src="/b.js"></script> <script type="application/javascript" src="/c.js"></script> </body></html> The server was configured to push "/b.js" when serving the HTML. I verified that the server's priority tree went through the following sequence: 1. {html -> b.js}, after receiving the PUSH_PROMISE 2. {html -> a.js -> b.js}, after the preload scanner finds a.js 3. {html -> a.js -> b.js}, after the preload scanner finds b.js 4. {html -> a.js -> b.js -> c.js}, after the preload scanner finds c.js Before this change, the final priority tree would have been: {html -> {b.js, {a.js -> c.js}}} BUG=668298 R=rdsmith@chromium.org,bnc@chromium.org Review-Url: https://codereview.chromium.org/2596703002 Cr-Commit-Position: refs/heads/master@{#442770}
-
chenwilliam authored
See bug for screenshots. You can use it with graphviz or d3! BUG=679901 Review-Url: https://codereview.chromium.org/2624873002 Cr-Commit-Position: refs/heads/master@{#442769}
-
yusukes authored
Previously, the instance was prioritized when the OS fully started. However, it turned out that the prioritization caused Chrome UI jank on some boards. This CL changes the way of prioritization more dynamic to prevent such a jank. BUG=chrome-os-partner:60946 TEST=try Review-Url: https://codereview.chromium.org/2624513004 Cr-Commit-Position: refs/heads/master@{#442768}
-
reveman authored
This adds the "--crosh-command" command line switch that cab be used to specify an alternative crosh command. BUG=677267 TEST=chrome --crosh-command=/bin/bash Review-Url: https://codereview.chromium.org/2579833005 Cr-Commit-Position: refs/heads/master@{#442767}
-
chrome://webrtc-internalsdeadbeef authored
Just the SLD-equivalent of: https://codereview.chromium.org/2622453002 Also adds tests. BUG=chromium:677550 Review-Url: https://codereview.chromium.org/2619343003 Cr-Commit-Position: refs/heads/master@{#442766}
-
alokp authored
This patch changes the AudioOutputProxy -> AudioOutputDispatcher reference from raw pointer to a weak pointer to allow the dispatcher to be deleted before AudioOutputProxy instances can be closed. BUG=608049 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2621993002 Cr-Commit-Position: refs/heads/master@{#442765}
-
horo authored
BUG=630495,630496 Review-Url: https://codereview.chromium.org/2620913002 Cr-Commit-Position: refs/heads/master@{#442764}
-
mgiuca authored
The flag was for an old feature that was never launched. Removes the code behind this feature. BUG=540055 Review-Url: https://codereview.chromium.org/2621833003 Cr-Commit-Position: refs/heads/master@{#442763}
-
servolk authored
Typically renderer needs to do Flush + StartPlaying in response to stream status change (i.e. when stream gets enabled or disabled). But since Flush is an async operation we might get another status change of the same stream, while the renderer is still handling the previous one. In the past renderer has simply ignored status changes while another status change was processed. But that was problematic, since we couldn't guarantee that the renderer status will be correct after stream has been enabled/disabled very quickly a few times. This CL fixes that issue by postponing status changes handling if necessary, instead of dropping those notifications. BUG=678031 Review-Url: https://codereview.chromium.org/2605473002 Cr-Commit-Position: refs/heads/master@{#442762}
-
ccameron authored
This moves initialization of parameters to SetSubclassProperties. The next step is to clean up initialization to use a common program descriptor. In that patch, I'll change these functions to CheckSubclassProperties, so that I can DCHECK that I didn't change anything. BUG=667966 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2626823002 Cr-Commit-Position: refs/heads/master@{#442761}
-
rdevlin.cronin authored
Add a histogram to analyze extension initialization time. BUG=677299 Review-Url: https://codereview.chromium.org/2607773003 Cr-Commit-Position: refs/heads/master@{#442760}
-
rdevlin.cronin authored
Listeners can throw exceptions (as with any third-party code). Ensure that we have tests for this. When a listener throws an exception, it should be logged to the console, but not bubbled up to external try- catches (so that JS code that may have triggered the event doesn't receive it). This is the same as we do for web events. BUG=653596 Review-Url: https://codereview.chromium.org/2613093002 Cr-Commit-Position: refs/heads/master@{#442759}
-
caseq authored
Revert of DevTools: move front-end URL handling to DevToolsUIBindingds (patchset #2 id:40001 of https://codereview.chromium.org/2607833002/ ) Reason for revert: A better fix is coming, reverting this one to make it a part of the new fix so that one CL may be merged onto a branch. Original issue's description: > DevTools: move front-end URL handling to DevToolsUIBindingds > > BUG=662859 > > Committed: https://crrev.com/eea3300239f0b53e172a320eb8de59d0bea65f27 > Cr-Commit-Position: refs/heads/master@{#440926} TBR=dgozman@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=662859 Review-Url: https://codereview.chromium.org/2620193002 Cr-Commit-Position: refs/heads/master@{#442758}
-
dmazzoni authored
Chrome now has support for more fine-grained accessibility modes. Individual accessibility APIs now enable parts of accessibility support as needed, but log data is suggesting that lots of clients are calling QueryService with IAccessible2 as the IID argument even though they don't need full accessibility support, so let's delete this particular trigger. BUG=672205,644647 Review-Url: https://codereview.chromium.org/2627733003 Cr-Commit-Position: refs/heads/master@{#442757}
-
yhanada authored
BUG=678558 TEST=Notification doesn't overlap with Uber Tray when ChromeVox is enabled. Review-Url: https://codereview.chromium.org/2625663002 Cr-Commit-Position: refs/heads/master@{#442756}
-
tommycli authored
This fixes a regression where the tooltip to the profile picture is never updated. BUG=676782 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2622973002 Cr-Commit-Position: refs/heads/master@{#442755}
-
chenwilliam authored
Compiling frontend runs in ~13 seconds (including dependency check) instead of 22 seconds. Examples of the RegEx match: http://regexr.com/3etk5 The following CL needs to land before this CL lands: https://codereview.chromium.org/2623743002/ BUG=673445 Review-Url: https://codereview.chromium.org/2588843002 Cr-Commit-Position: refs/heads/master@{#442754}
-
rockot authored
This requirement is missing from content_utility's manifest. BUG=None TBR=ben@chromium.org Review-Url: https://codereview.chromium.org/2621203002 Cr-Commit-Position: refs/heads/master@{#442753}
-
jinsukkim authored
This is to fix the reported bug before branching. Will reintroduce this together with what's being handled in https://crrev.com/2595263002. This reverts commit 603de249. BUG=671967, 671401 TBR=boliu@chromium.org, tedchoc@chromium.org, dtrainor@chromium.org, bshe@chromium.org Review-Url: https://codereview.chromium.org/2626723003 Cr-Commit-Position: refs/heads/master@{#442752}
-
brucedawson authored
VC++ was initializing all of the static PathElement arrays in GetPathForVectorIcon and GetPathForVectorIconAt1xScale at runtime, which meant that these were the largest and sixth largest functions in chrome.dll, and similarly in chrome_child.dll. Tagging the arrays and types as constexpr shrinks these functions down to nothing, saves about ~50 KB of per-process private data, and actually helps them compile slightly faster. The approximate section size changes are: .text: -164224 bytes change .rdata: 51984 bytes change .data: -54976 bytes change .reloc: -23204 bytes change These gains apply both to chrome.dll and chrome_child.dll. BUG=679539 Review-Url: https://codereview.chromium.org/2620653004 Cr-Commit-Position: refs/heads/master@{#442751}
-