GitLab

The HUD layer can just get its scale from the compositor thread rather
than the main thread.  This change makes it possible to remove content
scale calculations off of the main thread once TiledLayer is removed.

Review URL: https://codereview.chromium.org/913243003

Cr-Commit-Position: refs/heads/master@{#316248}

1. Threading logic for the capture thread has been moved to
   ScreenCapturerProxy.
2. Mouse shape handling has been moved to MouseShapePump.

BUG=455818

Review URL: https://codereview.chromium.org/883673004

Cr-Commit-Position: refs/heads/master@{#316247}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f16c00e..f89f60f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/923103002

Cr-Commit-Position: refs/heads/master@{#316246}

BUG=435719
TBR=mattm@chromium.org

Review URL: https://codereview.chromium.org/922533005

Cr-Commit-Position: refs/heads/master@{#316245}

BUG=444163
R=enne@chromium.org
TBR=kbr@chromium.org (trivial change in render_widget_compositor.cc which is really related to cc/)

Review URL: https://codereview.chromium.org/913163004

Cr-Commit-Position: refs/heads/master@{#316244}

This CL's focus is to return the channels synchronously. A next CL will introduce a close() api to message ports so resources can be freed when not used, and then will change the way we post messages in background thread.
At the receive side, we need to deal with messages received when a port is being transferred. this is for a next cl.

The channel ports are created in a different thread. This CL introduces an internal "pending" state that is not visible to users to hide the fact that channels are not ready yet.

BUG=393291

Review URL: https://codereview.chromium.org/920873003

Cr-Commit-Position: refs/heads/master@{#316243}

BUG=417532

Review URL: https://codereview.chromium.org/921913002

Cr-Commit-Position: refs/heads/master@{#316242}

Replace the asan_coverage GYP flag with sanitizer_coverage which is to be used with other sanitizers.
Introduce the SANITIZER_COVERAGE define.

BUG=444896
R=earthdok@chromium.org
TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/868893004

Cr-Commit-Position: refs/heads/master@{#316241}

This is much faster and the extra information wasn't useful anyway.

BUG=456178

Review URL: https://codereview.chromium.org/920263002

Cr-Commit-Position: refs/heads/master@{#316240}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/d05f5ed..91d6112

TBR=senorblanco@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/922263002

Cr-Commit-Position: refs/heads/master@{#316239}

This logic was borrowed from ExploreByTouchHelper, but apparently it's wrong,
because TalkBack sends ACTION_ACCESSIBILITY_FOCUS on a new view id and
then ACTION_CLEAR_ACCESSIBILITY_FOCUS on the old view id, and since we didn't
think the old view had accessibility focus, we never responded with
a TYPE_VIEW_ACCESSIBILITY_FOCUS_CLEARED event, so the framework would sometimes
not update its cache, and TalkBack could think the old view still had
accessibility focus.

BUG=458343

Review URL: https://codereview.chromium.org/916213003

Cr-Commit-Position: refs/heads/master@{#316238}

Revert of Reset Screen moved to ScreenContext. (patchset #7 id:120001 of https://codereview.chromium.org/904163003/)

Reason for revert:
This is faling a compile on ChromeOS bots:

http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/77470

Original issue's description:
> Reset Screen moved to ScreenContext.
>
> BUG=456778
>
> Committed: https://crrev.com/4b77f613917020e58b31975355e4ca2347f216e2
> Cr-Commit-Position: refs/heads/master@{#316212}
>
> Committed: https://crrev.com/ba85904895874b5d82d78bcb499c3c5ee7388e34
> Cr-Commit-Position: refs/heads/master@{#316232}

TBR=dzhioev@chromium.org,merkulova@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=456778

Review URL: https://codereview.chromium.org/928513002

Cr-Commit-Position: refs/heads/master@{#316237}

Obj-C 1.0 only allows to declare ivars in @interface section.

Review URL: https://codereview.chromium.org/917063004

Cr-Commit-Position: refs/heads/master@{#316236}

After this change, the signature of GetLoginsImpl() will be aligned with GetAutofillableLoginsImpl() and GetBlacklistedLoginsImpl().

BUG=437865
NOTRY=true # Unrelated chromevox test failures.

Review URL: https://codereview.chromium.org/911323003

Cr-Commit-Position: refs/heads/master@{#316235}

InProcessAccessibilityBrowserTest.VerifyAccessibilityPass is failing
intermittently on Chromium OS and Win 7 bots. Disabling until the owner can take
a look.

TBR=jcivelli@chromium.org
BUG=458567

Review URL: https://codereview.chromium.org/926653002

Cr-Commit-Position: refs/heads/master@{#316234}

Some change starting in M41 has started causing an existing bug in
GetAndroidToolsStatusAndOutput() to fail in ICS devices. When the
run_pie wrapper needs to be used, the call to `adb push' ends up
overwriting the original command that was going to be run on the device,
and the instrumentation tests fail like this:

> LD_LIBRARY_PATH=/data/local/tmp/forwarder/ /data/local/tmp/run_pie push /path/in/host/out/Release/run_pie /data/local/tmp/run_pie; echo %$?
[...]
[PIE Loader] dlopen() failed: Cannot load library: load_library[1095]: Library 'push' not found.

Fix it by using a different variable name for the `adb push' command
that must be run on the host.

BUG=373219
R=primiano@chromium.org, torne@chromium.org

Review URL: https://codereview.chromium.org/926023002

Cr-Commit-Position: refs/heads/master@{#316233}

BUG=456778

Committed: https://crrev.com/4b77f613917020e58b31975355e4ca2347f216e2
Cr-Commit-Position: refs/heads/master@{#316212}

Review URL: https://codereview.chromium.org/904163003

Cr-Commit-Position: refs/heads/master@{#316232}

This removes all the uses of USE_AURA ifdefs from the _win.cc files (and some
additional removal of dead code).

BUG=none
R=mkwst@chromium.org, sky@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/909183002

Cr-Commit-Position: refs/heads/master@{#316231}

Skia's SkDrawCommand will be changing. This CL prepares Chromium's unit test for the upcoming changes.

BUG=457691

Review URL: https://codereview.chromium.org/919153003

Cr-Commit-Position: refs/heads/master@{#316230}

Revert of Update geolocation permission tests for the permission bubble (patchset #20 id:380001 of https://codereview.chromium.org/787033004/)

Reason for revert:
Still flaky. See https://code.google.com/p/chromium/issues/detail?id=458563

Original issue's description:
> Update geolocation permission tests for the permission bubble
>
> This makes the geolocation permission tests run for both infobars and
> permission bubbles. The tests now run as parameterized tests.
>
> Supercedes parts of:
> https://codereview.chromium.org/411503005/
> https://codereview.chromium.org/341833004/
>
> BUG=438758
>
> Committed: https://crrev.com/f57c61952870c6027dbf220eff8b2d703bfed3c8
> Cr-Commit-Position: refs/heads/master@{#314541}
>
> Committed: https://crrev.com/d9f24fc092eba7accd05df923b1a1aa911a8ca38
> Cr-Commit-Position: refs/heads/master@{#315883}

TBR=mvanouwerkerk@chromium.org,timvolodine@google.com,markusheintz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=438758

Review URL: https://codereview.chromium.org/924043002

Cr-Commit-Position: refs/heads/master@{#316229}

BUG=

Review URL: https://codereview.chromium.org/921553008

Cr-Commit-Position: refs/heads/master@{#316228}

Use the new timer for Profiler:GetProfile (a new histogram).

Of note: the data on chrome://tracing from TRACE_EVENT0("browser", "ProfileManager::GetProfile")
matches up very nicely with the data I get out of  Profile.GetProfile" on chrome://histograms.

Review URL: https://codereview.chromium.org/920963003

Cr-Commit-Position: refs/heads/master@{#316227}

Non metadata trace events should not have zero timestamps, so add a DCHECK
that this is the case.

BUG=456940,456940

Review URL: https://codereview.chromium.org/920963002

Cr-Commit-Position: refs/heads/master@{#316226}

+ New consistent sized icons.
+ Fix bug when page zooming in an out on desktop.
+ Add styling for secondary button for 'Show saved copy' experiment.

BUG=456746,422882

Review URL: https://codereview.chromium.org/916093003

Cr-Commit-Position: refs/heads/master@{#316225}

TextInput_TextInputStateChangedTest.SwitchingAllTextInputTest is flaky on Linux
Chromium OS Ozone bots. Disabling until it can be looked at by owners.

TBR=shuchen@chromium.org
BUG=458549

Review URL: https://codereview.chromium.org/923073002

Cr-Commit-Position: refs/heads/master@{#316224}

This cl change so that the if a capturer is started using MJPEG, the BITMAPINFOHEADER the capture device report that it supports during capability enumeration is used.

BUG=45723

Review URL: https://codereview.chromium.org/913183006

Cr-Commit-Position: refs/heads/master@{#316223}

By not detaching the GL functor until after the teardown, we ran the
risk of stray draw calls occurring that could potentially reinitialize
the hardware renderer, causing the SharedRendererState destructor to
DCHECK.

BUG=

Review URL: https://codereview.chromium.org/920083002

Cr-Commit-Position: refs/heads/master@{#316222}

This is the first of three patches.

The second patch (in blink) will make all existing uses of
window.eventSender.gestureFlingStart pass a source device.
(https://codereview.chromium.org/901323004)

The third patch (in chrome) will change
EventSenderBindings::GestureFlingStart to require a source device.

BUG=456136
TEST=LayoutTests/fast/events/touch/

Review URL: https://codereview.chromium.org/902173003

Cr-Commit-Position: refs/heads/master@{#316221}

This makes its appearance consistent with the permission request, which
asks a user whether the site can show notifications.

BUG=458143

Review URL: https://codereview.chromium.org/919033002

Cr-Commit-Position: refs/heads/master@{#316220}

Previously, TestMockTimeTaskRunner had only supported vending out TimeTicks and TickClocks. Now it supports mock Time and mock Clocks too (they start at the Unix epoch).

This CL also shortens the names of the methods that vend the current time and time ticks to Now() and NowTicks(), respectively; removes using the "base" namespace prefix inside the "base" namespace; and provides a clean implementation for FastForwardUntilNoTasksRemain() instead of a hacky solution.

BUG=329911
TBR=phajdan.jr@chromium.org  # OOO.

Review URL: https://codereview.chromium.org/899863002

Cr-Commit-Position: refs/heads/master@{#316219}

PasswordAutofillAgent::SendPasswordForms is called twice during page load:
On DidFinishDocumentLoad, when it is interested in parsed HTML forms,
and on DidFinishLoad, when it is interested in those forms, which are also visible.

Currently, the method does the visibility check all the times, and throuws out the result in the first situation.

This is not only wasting computational resources, but possibly causing crashes due to not finished rendering computations.

This CL fixes that, and only does the visibility check if needed.

BUG=457243

Review URL: https://codereview.chromium.org/925983002

Cr-Commit-Position: refs/heads/master@{#316218}

BUG=393668

Review URL: https://codereview.chromium.org/690103008

Cr-Commit-Position: refs/heads/master@{#316217}

BUG=418485

Review URL: https://codereview.chromium.org/919393003

Cr-Commit-Position: refs/heads/master@{#316216}

Because there is no signing identity on upstream bots. Omitting this variable is causing at least device bots to assume it should be 1, might as well be explicit on all bots.

BUG=452193

Review URL: https://codereview.chromium.org/918213004

Cr-Commit-Position: refs/heads/master@{#316215}

Cr-Commit-Position: refs/heads/master@{#316214}

Revert of Reset Screen moved to ScreenContext. (patchset #6 id:100001 of https://codereview.chromium.org/904163003/)

Reason for revert:
Conflict with https://codereview.chromium.org/872633008/

Original issue's description:
> Reset Screen moved to ScreenContext.
>
> BUG=456778
>
> Committed: https://crrev.com/4b77f613917020e58b31975355e4ca2347f216e2
> Cr-Commit-Position: refs/heads/master@{#316212}

TBR=dzhioev@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=456778

Review URL: https://codereview.chromium.org/917613005

Cr-Commit-Position: refs/heads/master@{#316213}

BUG=456778

Review URL: https://codereview.chromium.org/904163003

Cr-Commit-Position: refs/heads/master@{#316212}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/5479a76..d05f5ed

TBR=senorblanco@chromium.org,tkent@chromium.org

Review URL: https://codereview.chromium.org/927523002

Cr-Commit-Position: refs/heads/master@{#316211}

In order to make a view vibrant we need to:
1. Place the view inside NSVisualEffectView
2. Return YES from allowsVibrancy

In order to make it possible to use WebContentsViewCocoa in vibrant view hierarchy, we need to implement allowsVibrancy.

From NSView documentation for allowsVibrancy:
"AppKit checks this property when the view is incorporated into a view hierarchy that uses vibrancy."

This means that only returning YES from allowsVibrancy will have no effect on the way view is rendered, we are safe to just return YES here.

Note: returning YES from isOpaque causes problems with vibrancy, that is why a setter is needed on RenderWidgetHostViewCocoa.

Review URL: https://codereview.chromium.org/869563003

Cr-Commit-Position: refs/heads/master@{#316210}

BUG=455705
TEST=Existing tests, manual.

Review URL: https://codereview.chromium.org/872633008

Cr-Commit-Position: refs/heads/master@{#316209}