GitLab

Cleanup open-time histograms to use the sparse framework so that
extended histograms can be recorded - also add entries to the xml
file.

Add a histogram to track close-time failures.  This should never fail,
but if it is it probably leaks memory and file handles, and possibly
locks.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/18978012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=259498
TEST=none

Review URL: https://chromiumcodereview.appspot.com/19872007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213344 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests --gtest_filter="SearchMetadataTest*"

Review URL: https://chromiumcodereview.appspot.com/19871004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213343 0039d316-1c4b-4281-b951-d872f2087c98

Don't put GPU process usage (the total over all processes) in parens
because people thought this meant it was negative. Rather, put an
asterisk next to it.

Also, if multiple tabs are sharing a process, only show the memory usage
for the group once.

BUG=

Review URL: https://chromiumcodereview.appspot.com/19798005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213342 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263240
TEST=browser_tests

Review URL: https://chromiumcodereview.appspot.com/19555005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213341 0039d316-1c4b-4281-b951-d872f2087c98

We don't need the focus-buttons-by-mouse behavior in the extension
settings page.

BUG=257544,262925

Review URL: https://chromiumcodereview.appspot.com/19471002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213340 0039d316-1c4b-4281-b951-d872f2087c98

Currently when dragging an app from the app list outside the bounds of
the app launcher the apps in the launcher continue to re-arrange
themselves even though the cursor may be nowhere near the app launcher,
which looks weird.

This change makes it so that the app launcher animates back to its
original state while the cursor is outside the launcher, and will cause
drops to outside the app launcher to return the dragged app to its
original position, which is consistent with flows such as dragging apps
to the taskbar on Windows / ChromeOS.

BUG=261452

Review URL: https://chromiumcodereview.appspot.com/19382003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213339 0039d316-1c4b-4281-b951-d872f2087c98

Add a new SetNeedsUpdateLayers that triggers the commit flow, but is
abortable if update layers doesn't actually make any changes.  This
allows the main thread to abort a begin frame.  This happens in the case
of scroll updates from the compositor thread or invalidations.

There was previously an abort begin frame call for when a visibility
message and a begin frame message were posted simultaneously, but it
incorrectly applied the scrolls and scales without informing the
compositor thread that these had already been consumed.  To fix this,
the abort message passes back a boolean about whether or not the
commit was aborted (and needed to be sent again) or was handled
(and the scrolls and scales processed).

To avoid a deluge of begin frames (in the commit sense) from the
scheduler, the scheduler has been adjusted to wait until the next begin
frame (in the vsync signal sense) so that these calls can be throttled.
Otherwise, the scheduler will just keep trying to begin frame.

R=brianderson@chromium.org, danakj@chromium.org
BUG=256381

Review URL: https://chromiumcodereview.appspot.com/19106007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213338 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263627
R=mukai@chromium.org

Review URL: https://codereview.chromium.org/19471016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213335 0039d316-1c4b-4281-b951-d872f2087c98

Add support for updating displayed status while the popup window is open, for
both builders and CL try jobs. Encapsulate issue state and sending events on
issue add/update/remove, which are listened for in the popup.

Also, initialize the username for try job monitoring by scraping Rietveld.


BUG=178588

Review URL: https://chromiumcodereview.appspot.com/18401004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213334 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213332 0039d316-1c4b-4281-b951-d872f2087c98

This will fix the PerfProfilerTest.

TBR=tonyg@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213329 0039d316-1c4b-4281-b951-d872f2087c98

Name these clip rects after the space they are in.

R=enne
BUG=263512

Review URL: https://chromiumcodereview.appspot.com/19664009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=261035
TEST=Run the program on link

Review URL: https://chromiumcodereview.appspot.com/19775013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213327 0039d316-1c4b-4281-b951-d872f2087c98

The default profile was being used to set which applications can show
notifications. This has been changed to use the last used profile allowed by 
policy. In case the profile happens to be deleted after the message center 
settings controller is created, we just fail silently. Since full-fledged 
multi-profile support will be rolling out in the near future, this is a 
temporary fix to prevent chrome from crashing.

BUG=263193

Review URL: https://chromiumcodereview.appspot.com/19699014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213326 0039d316-1c4b-4281-b951-d872f2087c98

Cuts number of gyp paths from chrome.dll -> blink from ~2000 to 113. The remaining paths are via ppapi\ppapi_internal.gyp which I'm not sure what to do with yet.

This is intended as a relatively temporary measure so that chrome_multiple_dll=1 has the dependency structure that we want (no browser <-> child) with link errors so we can see what work remains.

This CL causes the link errors below in chrome_multiple_dll=1. I think these will be fixed by jam@s moving of webkit/plugins/ppapi into content.

content_common.lib(content_common.pepper_plugin_info.obj) : error LNK2019: unresolved external symbol "public: __thiscall webkit::ppapi::PluginModule::EntryPoints::EntryPoints(void)" (??0EntryPoints@PluginModule@ppapi@webkit@@QAE@XZ) referenced in function "public: __thiscall content::PepperPluginInfo::PepperPluginInfo(void)" (??0PepperPluginInfo@content@@QAE@XZ)
content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: __thiscall webkit::ppapi::PluginModule::~PluginModule(void)" (??1PluginModule@ppapi@webkit@@QAE@XZ) referenced in function "public: void * __thiscall webkit::ppapi::PluginModule::`scalar deleting destructor'(unsigned int)" (??_GPluginModule@ppapi@webkit@@QAEPAXI@Z)
content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: bool __thiscall webkit::ppapi::PluginModule::InitAsLibrary(class base::FilePath const &)" (?InitAsLibrary@PluginModule@ppapi@webkit@@QAE_NABVFilePath@base@@@Z) referenced in function "private: __thiscall content::PepperPluginRegistry::PepperPluginRegistry(void)" (??0PepperPluginRegistry@content@@AAE@XZ)
content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: bool __thiscall webkit::ppapi::PluginModule::InitAsInternalPlugin(struct webkit::ppapi::PluginModule::EntryPoints const &)" (?InitAsInternalPlugin@PluginModule@ppapi@webkit@@QAE_NABUEntryPoints@123@@Z) referenced in function "private: __thiscall content::PepperPluginRegistry::PepperPluginRegistry(void)" (??0PepperPluginRegistry@content@@AAE@XZ)
content_common.lib(content_common.pepper_plugin_registry.obj) : error LNK2019: unresolved external symbol "public: __thiscall webkit::ppapi::PluginModule::PluginModule(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &,class base::FilePath const &,class webkit::ppapi::PluginDelegate::ModuleLifetime *,class ppapi::PpapiPermissions const &)" (??0PluginModule@ppapi@webkit@@QAE@ABV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@ABVFilePath@base@@PAVModuleLifetime@PluginDelegate@12@ABVPpapiPermissions@1@@Z) referenced in function "private: __thiscall content::PepperPluginRegistry::PepperPluginRegistry(void)" (??0PepperPluginRegistry@content@@AAE@XZ)

TBR=jam@chromium.org
R=jamesr@chromium.org
BUG=237249

Review URL: https://chromiumcodereview.appspot.com/19784010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213325 0039d316-1c4b-4281-b951-d872f2087c98

Ensure we don't crash if user navigates back from NTP to Chrome sign-in page before it has fully loaded.

This CL aims to be simple, so it can be merged back to M29. It changes from DidStopLoading, which is later than needed point in time, to DidNavigateMainFrame. It is safe if we have committed a navigation to delete the previous navigation entry.

I've also added checks to ensure that we don't try to remove a pending navigation entry, as it leads to bugs, as evidenced here.

A follow up CL can completely remove the CurrentHistoryCleaner object, as all it does is store a single bit of state - the history entry index, and monitors for the same navigation events as OneClickSigninHelper.

BUG=257277

Review URL: https://chromiumcodereview.appspot.com/19699007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213324 0039d316-1c4b-4281-b951-d872f2087c98

Bug 261978 tracks re-adding this support correctly.

BUG=261720,261978
R=abodenha@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19528007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213323 0039d316-1c4b-4281-b951-d872f2087c98

DeleteFile may return false is the file to be deleted does not exist
on windows. Don't abort export syncfs folder operation if delete
file fails.

BUG=

Review URL: https://chromiumcodereview.appspot.com/19828006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=263424

Review URL: https://chromiumcodereview.appspot.com/19693018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213321 0039d316-1c4b-4281-b951-d872f2087c98

This updates the comment regarding
WindowOpenPanelTest.ClosePanelsOnExtensionCrash being
disabled on Chrome OS. I don't have any plans to reenable
this test, since it appears to be testing behavior that we
don't use.

BUG=161073

Review URL: https://chromiumcodereview.appspot.com/19594009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160586

Review URL: https://chromiumcodereview.appspot.com/20071002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213319 0039d316-1c4b-4281-b951-d872f2087c98

This imports third_party/WebKit/Source/web/win/WebInputEventFactory.cpp
to content/browser/renderer_host/input/ and updates content/ to use it
instead of the third_party/WebKit version. The code is a straight port
and reformat with no (intentional) functional changes or changes in
dependencies.

BUG=263189

Review URL: https://chromiumcodereview.appspot.com/19676008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213318 0039d316-1c4b-4281-b951-d872f2087c98

[InstantExtended] Changing the histogram name since the definition of the histogram changed when the values used for recording were updated in CL/19772015.


BUG=261681

Review URL: https://chromiumcodereview.appspot.com/19862004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213316 0039d316-1c4b-4281-b951-d872f2087c98

Seems to be related to buildbot failure:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/22366

> Moves calling OnAutoHideState to when exactly the state has changed (2nd)
> 
> This method is called when a window is maximized or fullscreen.
> 
> The first attempt was reverted due to a test failure in LauncherTooltipManagerTest,
> and it turns out that's because the observer method is not emitted
> correctly.
> 
> BUG=249509
> TBR=harrym@chromium.org, jamescook@chromium.org
> TEST=manually
> 
> Review URL: https://chromiumcodereview.appspot.com/20056003

TBR=mukai@chromium.org

Review URL: https://codereview.chromium.org/19974006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213315 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/19981004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213314 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds the D-Bus hook for calling Device.ProposeScan to
NetworkDeviceHandler as well as bindings for and a function to parse
the results of a cellular network scan which are exposed form shill
as a Device property.

BUG=260964

Review URL: https://chromiumcodereview.appspot.com/19509002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213313 0039d316-1c4b-4281-b951-d872f2087c98

The message center still has the arrow because it sets arrow-paint-type
to NONE but further TrayBubbleWrapper's constructor calls
UpdateBubbleViewArrow().

Instead of adding the check before calling UpdateBubbleViewArrow(),
I think it's better to ignore inside.

BUG=260372
R=harrym@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/19843003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213312 0039d316-1c4b-4281-b951-d872f2087c98

This makes host_dispatcher.js and host_native_messaging.js consistent
with the rest of the webapp. Also fix function declaration style.

Review URL: https://chromiumcodereview.appspot.com/19597006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213311 0039d316-1c4b-4281-b951-d872f2087c98

Most suppressed tests have been rebaselined in https://src.chromium.org/viewvc/blink?revision=154755&view=revision.

TBR=robertphillips@chromium.org
BUG=258850

Review URL: https://chromiumcodereview.appspot.com/20063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213310 0039d316-1c4b-4281-b951-d872f2087c98

Fixes some of the memory leaks in those tests.

BUG=222687
R=thestig@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19945010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213309 0039d316-1c4b-4281-b951-d872f2087c98

EnterNotify and LeaveNotify events will be dispatched to event handlers.

BUG=263220

Review URL: https://chromiumcodereview.appspot.com/19664007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213308 0039d316-1c4b-4281-b951-d872f2087c98

Compile failed on buildbot:
http://build.chromium.org/p/chromium.win/buildstatus?builder=Win%20Builder%20%28dbg%29&number=18573

> Add the tracing manager
> 
> BUG=248357
> 
> Review URL: https://chromiumcodereview.appspot.com/19762005

TBR=zork@chromium.org

Review URL: https://codereview.chromium.org/19471017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213307 0039d316-1c4b-4281-b951-d872f2087c98

The Google Test templates provide a default value printer function that naively dumps all bytes in the range [&object, &object + sizeof(object)).  However, due to the memory layout of the TestScenario class (on some platforms), there was a hole of uninitialized memory being read from; and this triggered Valgrind errors.

The solution here is to implement an ostream& operator<<(ostream&, const TestScenario&) function that will not read from uninitialized memory regions.

BUG=263315

Review URL: https://chromiumcodereview.appspot.com/19647013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213304 0039d316-1c4b-4281-b951-d872f2087c98

BUG=179830, 262796, 263548

Review URL: https://chromiumcodereview.appspot.com/19477008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213303 0039d316-1c4b-4281-b951-d872f2087c98

Inside OnDraw, RequestDrawGL can fail and return false, which means
there will not be a follow up DrawGL call to actually trigger the draw,
but the FallbackTick is cancelled anyway. Fix by moving the cancel
inside DrawSWInteral to reflect we only want to cancel when we actually
draw.

BUG=internal b/9978808
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/19509007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213302 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248357

Review URL: https://chromiumcodereview.appspot.com/19762005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213299 0039d316-1c4b-4281-b951-d872f2087c98

This method is called when a window is maximized or fullscreen.

The first attempt was reverted due to a test failure in LauncherTooltipManagerTest,
and it turns out that's because the observer method is not emitted
correctly.

BUG=249509
TBR=harrym@chromium.org, jamescook@chromium.org
TEST=manually

Review URL: https://chromiumcodereview.appspot.com/20056003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213298 0039d316-1c4b-4281-b951-d872f2087c98

When a CopyResult provides a TextureMailbox, the ReleaseCallback must
be called on the TextureMailbox when then client is done with the
CopyResult.

This change ensures that this happens. If the TextureMailbox is never
removed from the CopyResult, then the CopyResult destructor takes care
of it. Since the texture was never used, it uses a sync point of 0.

When the TextureMailbox is removed from the CopyResult, then RWHVAura
makes sure it calls the ReleaseCallback once it has the pixels it needs
in memory. Since the pixels are already available on the CPU, it can
use a sync point of 0 as well.

R=piman
BUG=263483

Review URL: https://chromiumcodereview.appspot.com/19990007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213297 0039d316-1c4b-4281-b951-d872f2087c98

BUG=242290
R=mark@chromium.org

Review URL: https://chromiumcodereview.appspot.com/19960008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@213294 0039d316-1c4b-4281-b951-d872f2087c98