GitLab

SSIA. Considering the memory sensitiveness of strings in Blink
we should make sure that no change can accidentally increase
their size.

Review URL: https://codereview.chromium.org/205583005

git-svn-id: svn://svn.chromium.org/blink/trunk@169750 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353997

Review URL: https://codereview.chromium.org/203193015

git-svn-id: svn://svn.chromium.org/blink/trunk@169749 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Changes to the LRU lists are hidden behind a call to MemoryCache::update(), which adjusts sizes, access count, and LRU list position as appropriate. All of these are to some degree interrelated, since we keep multiple LRU lists and select one to use based access count and resource size.

Also, remove the Resource::inCache() bit in favor of a
MemoryCache::contains()

BUG=none

Review URL: https://codereview.chromium.org/164333008

git-svn-id: svn://svn.chromium.org/blink/trunk@169748 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify VectorMover<true, T>::swap() - use std::swap_ranges instead
of creating the loop ourselves, plus the patch removes a "FIXME"
comment - compiler already produces the most efficient code for POD
types swap, so there is no need to introduce compex algorithms for
that (checked with GCC 4.7.2).

Review URL: https://codereview.chromium.org/208253003

git-svn-id: svn://svn.chromium.org/blink/trunk@169747 bbb929c8-8fbe-4397-9dbb-9b2b20218538

{,un}setPendingActivity relies on RefCounted, which is going to be deprecated in oilpan. This CL removes usage of these methods in SpeechRecognition.cpp, and provide hasPendingActivity() implementation as replacement

BUG=354845
TEST=fast/speech

Review URL: https://codereview.chromium.org/208273002

git-svn-id: svn://svn.chromium.org/blink/trunk@169746 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=353090

Review URL: https://codereview.chromium.org/203683005

git-svn-id: svn://svn.chromium.org/blink/trunk@169745 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make this EventTarget-derived object a garbage collected object.

R=haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/208083003

git-svn-id: svn://svn.chromium.org/blink/trunk@169744 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As a drive-by, shadow DOM editing tests have been extracted into a new HTML

R=aandrey, pfeldman, vsevik
BUG=353910
NOTRY=true

Review URL: https://codereview.chromium.org/206503002

git-svn-id: svn://svn.chromium.org/blink/trunk@169743 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL uses some memoization to avoid unnecessary tree walking when
computing scroll parent. Why memoization and not just passing down the
values? Because sad. It turns out that we recur on the stacking tree (we
have to - squashing demands processing stuff in paint order), but we
walk up the render tree asking questions. Different tree topologies; we
could very easily visit a RenderLayer before its great great
grandparent.

No functionality change -- covered by existing tests.
BUG=None

Review URL: https://codereview.chromium.org/206283003

git-svn-id: svn://svn.chromium.org/blink/trunk@169741 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354791
TBR=vsevik

Review URL: https://codereview.chromium.org/208053005

git-svn-id: svn://svn.chromium.org/blink/trunk@169740 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354849
TBR=alancutter

Review URL: https://codereview.chromium.org/207613006

git-svn-id: svn://svn.chromium.org/blink/trunk@169739 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HeapSnapshotView should be unsubscribed from events it has been subscribed to, otherwise it will leak when corresponding profile is removed.

BUG=None

Review URL: https://codereview.chromium.org/208053003

git-svn-id: svn://svn.chromium.org/blink/trunk@169738 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All old SVGProperties implementations are now all removed. The "New" prefix for distinguishing two implementations are no longer needed.

Changes automatically generated from: sed -i 's/NewSVG/SVG/g' `find . -name \*.cpp -or -name \*.h`

BUG=349370

Review URL: https://codereview.chromium.org/208133002

git-svn-id: svn://svn.chromium.org/blink/trunk@169737 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When URL of an iframe changes from "unset" to "set", we don't want to
create new history entry. This worked for URLs without fragment
identifier but failed with it present.

This change takes the idea from the old code, before it was rewritten
in https://codereview.chromium.org/126453005

BUG=353096

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169665

Review URL: https://codereview.chromium.org/201773002

git-svn-id: svn://svn.chromium.org/blink/trunk@169736 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/166273018

Review URL: https://codereview.chromium.org/166273018

git-svn-id: svn://svn.chromium.org/blink/trunk@169735 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354405
R=ager@chromium.org

Review URL: https://codereview.chromium.org/206333003

git-svn-id: svn://svn.chromium.org/blink/trunk@169734 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With heap supplement{able}s support now in place, follow up and turn
the supplements of these two into garbage allocated objects also.

R=haraken@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/200373003

git-svn-id: svn://svn.chromium.org/blink/trunk@169733 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- HeapSnapshotNode, HeapSnapshotEdge and HeapSnapshotRetainerEdge now store only reference to HeapSnapshot and global index of corresponding item.
- all index boundaries were moved out of these classes into corresponding iterators

BUG=None

Review URL: https://codereview.chromium.org/207523004

git-svn-id: svn://svn.chromium.org/blink/trunk@169732 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org, oilpan-reviews@chromium.org, yhirano@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/205693004

git-svn-id: svn://svn.chromium.org/blink/trunk@169731 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=rwlbuis
BUG=354791

Review URL: https://codereview.chromium.org/198183004

git-svn-id: svn://svn.chromium.org/blink/trunk@169730 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=354787
TBR=tdresser@chromium.org

Review URL: https://codereview.chromium.org/207613003

git-svn-id: svn://svn.chromium.org/blink/trunk@169729 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=fs@opera.com
BUG=354785
NOTRY=true

Review URL: https://codereview.chromium.org/207773002

git-svn-id: svn://svn.chromium.org/blink/trunk@169728 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use Blink Promise instead of MIDIAccessPromise.
BUG=320984
R=toyoshim@chromium.org

Review URL: https://codereview.chromium.org/77773003

git-svn-id: svn://svn.chromium.org/blink/trunk@169727 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Reason for revert:
This have broken browser_tests according to my bisect:
http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2034/steps/browser_tests/logs/TabDestroyed

Original issue's description:
> id of iframe incorrectly sets window name
>
> As per the specification, the iframe's name should be an empty string if unset:
> http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-name
>
> Instead, Chromium was using the iframe's id as window name if the name was
> unset. This change makes us behave like Firefox 27 and IE 11, verified using:
> http://jsfiddle.net/xf5H7/9/
>
> This CL sets the name attribute iframe in a lot of layout tests so that
> testRunner.dumpChildFramesAsText() keeps printing the same result.
>
> R=arv@chromium.org, tkent@chromium.org
> BUG=347169
> TEST=fast/frames/iframe-no-name.html
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168553
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168801
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169304
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169683

TBR=abarth@chromium.org,arv@chromium.org,tkent@chromium.org,ch.dumez@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=347169

Review URL: https://codereview.chromium.org/198183003

git-svn-id: svn://svn.chromium.org/blink/trunk@169726 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Its only use is as a part object of the stack-allocated MediaQueryParser.

R=ager@chromium.org
BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/207743002

git-svn-id: svn://svn.chromium.org/blink/trunk@169725 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=haraken@chromium.org,oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/207763002

git-svn-id: svn://svn.chromium.org/blink/trunk@169724 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Do not trigger new history entry if iframe URL doesn't change (https://codereview.chromium.org/201773002/)

Reason for revert:
This may have broken browser_tests: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2034/steps/browser_tests/logs/TabDestroyed

Original issue's description:
> Do not trigger new history entry if iframe URL doesn't change
> 
> When URL of an iframe changes from "unset" to "set", we don't want to
> create new history entry. This worked for URLs without fragment
> identifier but failed with it present.
> 
> This change takes the idea from the old code, before it was rewritten
> in https://codereview.chromium.org/126453005
> 
> BUG=353096
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169665

TBR=abarth@chromium.org,japhet@chromium.org,rchlodnicki@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=353096

Review URL: https://codereview.chromium.org/207683003

git-svn-id: svn://svn.chromium.org/blink/trunk@169723 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=lushnikov
NOTRY=true

Review URL: https://codereview.chromium.org/207323005

git-svn-id: svn://svn.chromium.org/blink/trunk@169722 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DEPENDS ON: https://codereview.chromium.org/198693002/

BUG=352493,352490

Review URL: https://codereview.chromium.org/199743003

git-svn-id: svn://svn.chromium.org/blink/trunk@169721 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This should fix any tests where done() can be called multiple times.

BUG=333880

Review URL: https://codereview.chromium.org/205893003

git-svn-id: svn://svn.chromium.org/blink/trunk@169720 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Clean up static_cast<CSSFooValue*>.

BUG=309516

Review URL: https://codereview.chromium.org/205273003

git-svn-id: svn://svn.chromium.org/blink/trunk@169719 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Change RenderStyle::setWordSpacing and RenderStyle::setLetterSpacing to
replace the FontDescription instead of modifying the existing instance,
the same way the other font methods already do. This allows us to
remove the mutableFontDescription method from FontDescription.

R=dglazkov@chromium.org
BUG=

Review URL: https://codereview.chromium.org/207573002

git-svn-id: svn://svn.chromium.org/blink/trunk@169718 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Co-authored with Brandon Jones.

This CL continues the work of updating the Gamepad API to latest spec. NavigatorGamepad implements
WebGamepadListener which is the interface chromium will talk to when dispatching gamepad events.
The implementation follows the dispatcher-controller pattern used by device motion and device orientation.
There is some difference though because the gamepad data is polled instead of pushed by the platform.

BUG=344556

Review URL: https://codereview.chromium.org/200783002

git-svn-id: svn://svn.chromium.org/blink/trunk@169716 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL splits the direct compositing reasons into two groups: those that are
determined from style information alone and those that require some non-style
information. This CL simply separates the two groups. A future CL will move the
computation of the style-determined reasons to recalc style.

Review URL: https://codereview.chromium.org/206413009

git-svn-id: svn://svn.chromium.org/blink/trunk@169715 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We always turn this setting on.

BUG=354688
R=ojan@chromium.org

Review URL: https://codereview.chromium.org/206463009

git-svn-id: svn://svn.chromium.org/blink/trunk@169714 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove bogus if check in ShadowTreeStyleSheetCollection::collectStyleSheets().
The condition will always be true as HTMLStyleElement always has a styleTag
for tag name.

R=esprehn, morrita@chromium.org

Review URL: https://codereview.chromium.org/199893006

git-svn-id: svn://svn.chromium.org/blink/trunk@169713 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The default timeout for tests using the w3c test harness is 2 seconds.
For several of these tests that play a little bit of video, this is not
long enough, especially when running using slower builds (like ASAN).
Setting the timeouts to a large value (60s) for both per-test time and
entire test time so that the infrastructure timeouts will be used.

BUG=353770, 353792
TEST=layout tests pass repeatedly using ASAN build

Review URL: https://codereview.chromium.org/205143002

git-svn-id: svn://svn.chromium.org/blink/trunk@169712 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There are two separate bugs that this and the corresponding Chrome patch
aim to address:
- On Linux, files and URLs are transferred in the same MIME type, so
  it's impossible to tell if a filename was set by a trusted source or
  forged by web content.
- DownloadURL triggers the download of potentially cross-origin content.
  On some platforms, such as Windows, the resulting download is treated
  as a file drag by Chrome, allowing web content to read cross origin
  content.

In order to prevent web content from doing this, drags initiated by a
renderer will be marked as tainted. When tainted drags are over web
content, Blink will only allow the resulting filename to be used for
navigation, with Chrome enforcing this with the sandbox policy.

Unfortunately, this does break some potentially interesting use cases
like being able to drag an attachment from Gmail to a file input, but
those will have to be separately addressed, if possible.

BUG=346135
R=abarth@chromium.org, tony@chromium.org

Review URL: https://codereview.chromium.org/193803002

git-svn-id: svn://svn.chromium.org/blink/trunk@169711 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It still doesn't work very well, but you can at least check the
status of the tree and sorta navigate around.

BUG=354543

Review URL: https://codereview.chromium.org/201853004

git-svn-id: svn://svn.chromium.org/blink/trunk@169710 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Constructors of RemoteFontFaceSource, SVGDocumentExtensions, XMLDocumentParserScope, and WorkerScriptDebugServer need to
use *explicit* keyword because they have an argument.

BUG=N/A

Review URL: https://codereview.chromium.org/207103003

git-svn-id: svn://svn.chromium.org/blink/trunk@169709 bbb929c8-8fbe-4397-9dbb-9b2b20218538