- 17 Nov, 2017 40 commits
-
-
Ian Vollick authored
Currently, when the audio permission prompt is shown, the UI is drawn disabled, but because some of it juts further out toward the user than the backplane, you can still interact with this UI. Bug: None Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id3ce1c09b7091cbe955e02abec15198db2355a93 Reviewed-on: https://chromium-review.googlesource.com/776621Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#517475}
-
Christos Froussios authored
Filling will trigger JS events, which can be interpreted by the page as a change in the values. Bug: 784391 Change-Id: I4e9fa8a6ef6a35d545aabd91725e18c69599c77d Reviewed-on: https://chromium-review.googlesource.com/771634Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#517474}
-
Lei Zhang authored
Change-Id: I8347edc5893e51df581dab388b72130f5473d14f Reviewed-on: https://chromium-review.googlesource.com/775042Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#517473}
-
Roman Sorokin authored
For Active Directory users we try to use password to get TGT both from the pod screen and from online auth. Latter is redundant. BUG=chromium:786412 TEST=manual Change-Id: Ia586014ddb1c04f33ae026f08ea5569fcad5786e Reviewed-on: https://chromium-review.googlesource.com/776667Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517472}
-
Yuta Kitamura authored
Upon landing of <http://crrev.com/c/765749>, which tightened up the threading check of WTF::Function, a few assertion failures were reported. The stack traces indicated closures for swap promises (in PaintTiming.cpp and FirstMeaningfulPaintDetector.cpp) might end up getting destructed on the compositor thread. To allow this, WTF::CrossThreadBind() must be used instead of WTF::Bind(). Bug: 786194 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9252eff15ca00e1bc0dfc8f87629ccb9acb56714 Reviewed-on: https://chromium-review.googlesource.com/776343Reviewed-by:
Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517471}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/ba6a850bbb5b..37921f135dc6 $ git log ba6a850bb..37921f135 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 bokan Clarify comment for mean_pixels_approximated means Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I1f9f63fc69bc3b5a147238a2a17ba082bbd8ea6e Reviewed-on: https://chromium-review.googlesource.com/776649 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517470}
-
Katie Dektar authored
Adds sandbox google docs link to the manifest so that aria-hidden will be removed there too. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Iba412f3a1f35a09d3dd403474eb02186c361e2b1 Reviewed-on: https://chromium-review.googlesource.com/775517 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#517469}
-
kylechar authored
With the display compositor running in the GPU process, we need to send a unique id from the host process to the GPU process to ensure that BeginFrameSource::source_ids_ are different after process restart. Pass this value along with the other arguments needed to create a viz::FrameSinkManagerImpl. |restart_id| is plumbed into DelayBasedBeginFrameSources that are created for each viz::Display. There are other BeginFrameSources that are created in the GPU process, but these BeginFrameSources don't produce BeginFrameArgs so their source_id isn't used and isn't important. Bug: 782268 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie3bd4f6bf3a9ba97d370969cae3d7faa396a0f43 Reviewed-on: https://chromium-review.googlesource.com/766512 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517468}
-
Lei Zhang authored
TBR=reveman@chromium.org,dgozman@chromium.org,lfg@chromium.org,sdefresne@chromium.org,rockot@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I2b94ac88777958e132dce4772fda9ba12320c560 Reviewed-on: https://chromium-review.googlesource.com/771053 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#517467}
-
Theresa Wellington authored
BottomToolbarPhone sets tint on its background drawable. Call mutate to avoid sharing state with other uses of modern_toolbar_background.xml. BUG=786283 Change-Id: Ia8ab7000297d03f03edf612dc49047290ae4346f Reviewed-on: https://chromium-review.googlesource.com/777039Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#517466}
-
Tom Sepez authored
This is a small bit of overdue tidying, in that the flags should be in the header with the method that returns them. Change-Id: I8f9e8290a3ec36b53fa64ca69fcc3a11ac3b0e7c Reviewed-on: https://chromium-review.googlesource.com/773508Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#517465}
-
Michael Thiessen authored
The GVR crash has been fixed, so we can remove our workaround (which was to wait 10 seconds before allowing re-entry into VR) The workaround was added in https://chromium-review.googlesource.com/c/chromium/src/+/624294 Bug: 759575 Change-Id: Iad46c0575d15c1eb7d67d46253eea50294243ae8 Reviewed-on: https://chromium-review.googlesource.com/776620 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517464}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/57e0828fade9..3e4d1fde7fab $ git log 57e0828fa..3e4d1fde7 --date=short --no-merges --format='%ad %ae %s' 2017-11-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 1eda27a65..2c7f34c83 (2 commits) 2017-11-17 scroggo Fix webp bug compositing alpha frames on opaque (better fix) Created with: roll-dep src/third_party/skia BUG=735497,784078 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=brianosman@chromium.org Change-Id: I1f45988b72e5268b343dd4f575c23bb0c8ed51fc Reviewed-on: https://chromium-review.googlesource.com/776644Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#517463}
-
Quinten Yearsley authored
This CL: - renames "test-expectations.html" so that it is called "results.html" - renames the old results.html to be "legacy-results.html" blink-dev thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/9NFDSTEzcd4 Bug: 748628 Change-Id: Id8293ed24f680b71cf1bdb3e134cdb130154ee14 Reviewed-on: https://chromium-review.googlesource.com/775973 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#517462}
-
Michael Thiessen authored
The GVR bugs have been fixed, we can remove our workaround. Workaround was added in https://chromium-review.googlesource.com/c/chromium/src/+/682107 Bug: 769005 Change-Id: I2ff8edc388de04fa2c4f662406ab7687c13eb88e Reviewed-on: https://chromium-review.googlesource.com/775864 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#517461}
-
Ran Ji authored
Add an extra to the intent that sent to CCT to indicate where it comes from. Currently the extra is only set by Webapp/WebApk Bug: 769728 Change-Id: I38ddbf9a5e797e602513de098a890645419d90c3 Reviewed-on: https://chromium-review.googlesource.com/751302Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Ran Ji <ranj@chromium.org> Cr-Commit-Position: refs/heads/master@{#517460}
-
Francois Doray authored
The "MinimumProtectionTime" field trial has expired. Not having to read the "AllowMultipleDiscards" param of this field trial will simplify the TabManager refactor. Bug: 775644 Change-Id: Ide53247821bc9753fe8d6ba27614d3591384cbed Reviewed-on: https://chromium-review.googlesource.com/771545 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517459}
-
Sammie Quon authored
Add a minimum distance for windows that get tapped and already in a snap region (windows tapped close too the left or right side of the screen). This is so users do not accidently snap too easily when trying to activate the window. Also fix a bug where you can drag very straight across or down without the overview window moving. Test: ash_unittests SplitViewWindowSelectorTest.Dragging Bug: 778933, 781324 Change-Id: I1b4e993951260f079f85851890854dc217ea95f3 Reviewed-on: https://chromium-review.googlesource.com/757985 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#517458}
-
rnephew authored
This reverts commit d0c9cacb. Reason for revert: 5X AOSP bug is fixed and rolled. https://chromium-review.googlesource.com/c/chromium/src/+/776353 Original change's description: > Disable failing blink_perf.canvas stories on Webview too > > Even though they're failing on 5X webview and they're disabled on 5X, > there's a bug where 5X webview isn't matching the 5X test condition > (https://github.com/catapult-project/catapult/issues/4045). > > TBR=ashleymarie@chromium.org > NOTRY=true > > Bug: 784540 > Change-Id: I100929183b15c1d84ff4e0cecddb15236644bb84 > Reviewed-on: https://chromium-review.googlesource.com/775433 > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Commit-Queue: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#517137} TBR=charliea@chromium.org,ashleymarie@chromium.org Change-Id: Ib48acc82b6fb1b2a1e3aa3c4f3966456cf88103f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 784540 Reviewed-on: https://chromium-review.googlesource.com/777060Reviewed-by:
rnephew <rnephew@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#517457}
-
Scott Chen authored
This CL changes the look of the welcome page for profiles that have DICE fully enabled. Bug: 782155 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ife6f0d2cc661b15d2cf9be9a8577b090707ff57d Reviewed-on: https://chromium-review.googlesource.com/753386 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#517456}
-
Marc Treib authored
The test has some flakes on Win dbg, which is likely just a bit too slow. This CL increases the sleep time from 100 to 200 ms to hopefully resolve the flakes. TBRing this single-character test-only change, so it can accumulate some runs over the weekend. TBR=mastiz Bug: 778248 Change-Id: I9c9d0a39023d76ad4bea05aa8f700bd310d4f284 Reviewed-on: https://chromium-review.googlesource.com/776660Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#517455}
-
Tom Sepez authored
No functional change intended, just duplicate code reduction. Adds the common signal handler to broker_process.cc, since all it does is call back into BrokerProcess methods. Change-Id: Ie8f1604888465fb9996c34a7f0f42811b8cddb30 Reviewed-on: https://chromium-review.googlesource.com/773109 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#517454}
-
Koji Ishii authored
TBR=eae@chromium.org Bug: 714962 Change-Id: I573cac0271e631a79b6c8c9f6f9b2b9477458bf2 Reviewed-on: https://chromium-review.googlesource.com/776515Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#517453}
-
Gauthier Ambard authored
This code is no longer used as ContentSuggestions is enabled. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1cf12abd965840c1f02c137fa4f542057842648d Reviewed-on: https://chromium-review.googlesource.com/776653 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#517452}
-
Jamie Madill authored
Bug: 786044 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8f7cb86b0bdff0b60ffe3d3a1553ff34c262ef1d Reviewed-on: https://chromium-review.googlesource.com/774986Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#517451}
-
Shivani Sharma authored
When a writer transaction gets converted to the reader and it was the transaction that created the network transaction, then it should save the network transaction's info like network received bytes at that point. This was not happening because the condition for saving the network transaction info checked if the transaction was still in Writers but it was not. Removed that condition since its not needed. Bug: 782992 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ie31e803144628612053d232fa4a7df42a984d14e Reviewed-on: https://chromium-review.googlesource.com/771779Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Shivani Sharma <shivanisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#517450}
-
Philip Jägenstedt authored
This isn't needed because: * Fullscreen::FullscreenElementChanged sets the flag when an element becomes the fullscreen element. * Moving a fullscreen element always means first removing it, and removing a fullscreen element should exit fullscreen. The test would hit an assert without this change. Bug: 781527 Change-Id: If57a93efefdd60073e949f823aa58d3f0e148deb Reviewed-on: https://chromium-review.googlesource.com/776599Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#517449}
-
Henrique Nakashima authored
This change is gated by the kIsEditModeTracked flag in pdfium_engine.cc. There should be no functional change yet as the flag is off. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibb6c266a0dbef1b168ef7f52d85ad4b5214ac639 Reviewed-on: https://chromium-review.googlesource.com/769491 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#517448}
-
Gauthier Ambard authored
ContentSuggestions is enabled to 100%, the GoogleLandingMediator won't be used anymore. Saving the favicons for the Content widget should be done from the ContentSuggestionsMediator. Bug: 764720 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31667a896cfdbe378d0efa6b67df5c8e9189d4d7 Reviewed-on: https://chromium-review.googlesource.com/776798Reviewed-by:
Elodie Banel <lod@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#517447}
-
Owen Min authored
Using build-in util URL function to add path and query to the url instead of using StringAppendF. Bug: Change-Id: Ie62bff86da96e62bf41ed6097adbe43956efe99f Reviewed-on: https://chromium-review.googlesource.com/775934Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517446}
-
Louis Romero authored
Simple enough fix, we just have to tell MDC we agree to let footer cells handle interactions when editing, as footers are not editable. Bug: 665425 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I7ada7dd0fd845046753991e548399b2ff29ef543 R: marq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/776834Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#517445}
-
Gauthier Ambard authored
This CL adds the methods to the ToolbarCoordinator to support taking snapshot for Side Swipe. The support for the UI update will be added later. Bug: 784911 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I45170fa89244f5645d3da8dc5e059dcb34ab1f42 Reviewed-on: https://chromium-review.googlesource.com/774280 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517444}
-
Christopher Grant authored
Death tests are prone to flakiness in test environments that fork. This test started failing when a seemingly totally unrelated change affected dynamic library loading. That other change was reverted for more investigation, but on our side, lets just avoid such tests. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia2bce3f7d610949b9f96b62c0df9a6def010ac54 Reviewed-on: https://chromium-review.googlesource.com/775865Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#517443}
-
Christos Froussios authored
DestinationFileSystem is the desktop implemenation of Destination, which sends the data to the file system. Bug: 785237 Change-Id: I034fab562eafde2240dc75743cb2ebbc6f7ec9ac Reviewed-on: https://chromium-review.googlesource.com/776596 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#517442}
-
Allen Bauer authored
Added check for existance of the FindBarController before causing it to be created on demand. This should prevent a startup performance regression. Bug: 783350 Change-Id: Idbf4243e22db833fba8123c6b9e828c8c953ff12 Reviewed-on: https://chromium-review.googlesource.com/764030Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#517441}
-
Gauthier Ambard authored
The updates to the back/forward buttons, related to the tab history presentations are now moved to a new object. The goal of this object is to contain most of the updates of the buttons of the toolbar. Bug: 784846 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idc95d91cfca5a265e661d89550a8b1dc5e40d3ef Reviewed-on: https://chromium-review.googlesource.com/768869 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#517440}
-
Leszek Swirski authored
For V8 logs and UMA, we want to detect whether scripts passed to V8 are from an external file, inline scripts, generated strings or other sources. Previously we were doing this by checking source offsets and the presence of a resource cache handler, but this was inaccurate, not to mention a layer violation. This introduces a ScriptSourceOrigin enum which is made a member of ScriptSourceCode. The ScriptLoader tells the ClassicPendingScript whether its source is coming from an inline script, is generated during a document.write, or more esoteric variants like is from a non-parser generated element. Then, the V8ScriptRunner can use this enum to decide what sort of "no cache handler" reason it should pass to V8, which is logged in UMA. I have also opportunistically updated other users of ScriptSourceCode that don't necessarily use script tags. We may want to track these individually in the future. Bug: chromium:769203 Change-Id: I24f1e7a5b235246e7d4e2b4753b8aec112239832 Reviewed-on: https://chromium-review.googlesource.com/771793Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#517439}
-
Alexei Svitkine authored
Note: Since the last time you were in OWNERS for histograms.xml, we've refactored our OWNERS files and have a central file in base/metrics. So this gives you OWNERS over a lot more files than just histograms.xml - please defer to other OWNERS if reviews come in for code you're not familiar with. And please review the docs we have at: https://chromium.googlesource.com/chromium/src.git/+/HEAD/tools/metrics/histograms/README.md For best practices for histograms that you should hold up during review. Thanks! BUG=none Change-Id: I05441f908958b3312b54c4b1420834f57c8209ef Reviewed-on: https://chromium-review.googlesource.com/776281Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#517438}
-
tanvir.rizvi authored
ReplaceSelectionCommand crashes if InsertHTML content have trailing non visible content. This happens as the nextAncesstorSibling comes as null This CL does the safety check to prevent the crash observed in this scenario. Bug: 781282 Change-Id: Ibb886956dafcdfaadac4dd2ee6b6c1ef70ad8340 Reviewed-on: https://chromium-review.googlesource.com/768550 Commit-Queue: Tanvir Rizvi <tanvir.rizvi@samsung.com> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#517437}
-
danakj authored
This eliminates one set of TextureMailbox uses, toward getting rid of the class, which overlaps with TransferableResource and forces extra plumbing and knowledge of types. We can remove the Android-specific fields from TextureMailbox with this, as they were only used for video, and can now go directly to TransferableResource instead of requiring extra plumbing through TextureMailbox. R=piman@chromium.org Bug: 769423 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I227b16a2073a0b7d27f082d1d650dbb6016246d5 Reviewed-on: https://chromium-review.googlesource.com/773062 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#517436}
-