GitLab

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152119 0039d316-1c4b-4281-b951-d872f2087c98

```---------------------------------------------------------------------
r1472 | sbc@chromium.org | 2012-08-16 15:17:56 -0700 (Thu, 16 Aug 2012) | 7 lines

fix link deadlock when setting LINK.host to $(LINK)

This resulted in double call to flock on linux/make.

BUG=http://code.google.com/p/chromium/issues/detail?id=143274

Review URL: https://chromiumcodereview.appspot.com/10854195
```

---------------------------------------------------------------------
r1471 | iannucci@chromium.org | 2012-08-15 17:05:50 -0700 (Wed, 15 Aug 2012) | 6 lines

Fixes msvs generator for projects with non-default IntermediateDirectories.

Issue was introduced by r1466.

R=bradnelson,scottmg
Review URL: https://chromiumcodereview.appspot.com/10832322
------------------------------------------------------------------------
r1470 | sbc@chromium.org | 2012-08-15 10:11:26 -0700 (Wed, 15 Aug 2012) | 9 lines

Honor $CC_target and friends in make generator.

These get baked into the generated build file if they
are set at gyp time.

BUG=
TEST=compiler-override

Review URL: https://chromiumcodereview.appspot.com/10833021
------------------------------------------------------------------------
r1469 | iannucci@chromium.org | 2012-08-14 13:53:47 -0700 (Tue, 14 Aug 2012) | 17 lines

Prepend 'call' to all non-cygwin commands to prevent incredibuild from aborting
the scripts early.

There are three cases:
  * Command is a batch file
  * Command is an exe/com
  * Command is a builtin (to cmd.exe).

In the first case, call will prevent the overall command action from aborting
when multiple commands are attached to the same file (look for 'and also' in the
msvs generator).

In the second, call does not change the exe's behavior

In the third case, call still performs the requested action correctly. This even
applies to the 'call' builtin, so, 'call call echo foo' is still correct.
Review URL: https://chromiumcodereview.appspot.com/10824293
------------------------------------------------------------------------
r1468 | thakis@chromium.org | 2012-08-13 15:43:17 -0700 (Mon, 13 Aug 2012) | 10 lines

Fix the Android Eclipse CDT generator.

This fixes a couple of problems:
- CONFIGURATION_NAME is now getting set. This seems to be a required
variable now.
- Macro values are now escaped before getting written to the XML out
in order to handle macros with XML syntax.

Review URL: https://chromiumcodereview.appspot.com/10823266/
Patch from Jesse Greenwald <jgreenwald@chromium.org>!
------------------------------------------------------------------------
r1467 | iannucci@chromium.org | 2012-08-10 14:38:59 -0700 (Fri, 10 Aug 2012) | 3 lines

This makes it easier to test combinations of msvs version without having to
muck with environment variables
Review URL: https://chromiumcodereview.appspot.com/10830232
------------------------------------------------------------------------
r1466 | iannucci@chromium.org | 2012-08-09 14:33:12 -0700 (Thu, 09 Aug 2012) | 12 lines

Fixes an issue where OutputDirectory and IntermediateDirectory were being
incorrectly generated without a trailing slash on MSVS 2008.

This only manifested as an issue when running non-cygwin actions under MSVS2008,
where the symptoms would be that a tool using OutDir would write to directories
such as "Releaseobj\\some\\subdir" instead of "Release\\obj\\some\\subdir".

Unfortunately, the wrong path usually wouldn't cause the tool to _fail_, except
when a subsequent step tried to read the output of the previous tool, causing the
secondary tool to fail with confusing errors (reporting that the correct path
could not, in fact, be read).
Review URL: https://chromiumcodereview.appspot.com/10831183
------------------------------------------------------------------------
r1465 | iannucci@chromium.org | 2012-08-09 12:36:02 -0700 (Thu, 09 Aug 2012) | 16 lines

Fix usage of shlex in unit tests on windows.

When shlex was getting an arg like:
  r'"some\interesting\path.file" other_file'

shlex was turning it into:
  ['someinterestingpath.file', 'other_file']

Which _happened_ to work, putting 'someinterestingpath.file' in the working
directory.

This patch doubles up all backslashes prior to splitting, to make the incoming
string conform to shlex's expectations

R=scottmg
Review URL: https://chromiumcodereview.appspot.com/10829252
------------------------------------------------------------------------
r1464 | scottmg@chromium.org | 2012-08-09 11:20:22 -0700 (Thu, 09 Aug 2012) | 4 lines

Use flock-style lock on Windows to limit number of concurrent links

This is mostly for goma builds.
Review URL: https://chromiumcodereview.appspot.com/10837168
------------------------------------------------------------------------

R=cmp, scottmg, Sam Clegg, Nico
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10854178

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152118 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139444
TEST=manually open the page and check if it shows the amount of local free space.


Review URL: https://chromiumcodereview.appspot.com/10827292

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152117 0039d316-1c4b-4281-b951-d872f2087c98

initial ClientHello to work around a Windows SChannel bug.

Cap the record layer version number to TLS 1.0 only for the initial
ClientHello. The record layer version number of the ClientHello in
a renegotiation should use the currently negotiated version number.

R=agl@chromium.org,rsleevi@chromium.org
BUG=141629
TEST=Visit https://solutionscenter.naradana.net/, an IIS server that
requests (but doesn't require) client certificates over renegotiation.
The page should be laid out correctly.

Review URL: https://chromiumcodereview.appspot.com/10828269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152116 0039d316-1c4b-4281-b951-d872f2087c98

Revert 152098 - Landing this again to get more information about the crashes. Doesn't crash locally or on the trybots it seems.

Move more message handlers from NativeWidgetWin to HWNDMessageHandler.

http://crbug.com/142962
R=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152013
Review URL: https://chromiumcodereview.appspot.com/10832345

TBR=ben@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10854205

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152113 0039d316-1c4b-4281-b951-d872f2087c98

Also added 'naclsdk info' command to display more info about a bundle.
Also fixed bug when running 'naclsdk -h' (auto updater bug).

BUG=140361
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10854168

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152109 0039d316-1c4b-4281-b951-d872f2087c98

I was seeing the error: "recipe commences before first target. Stop"
http://www.gnu.org/software/make/manual/html_node/Error-Messages.html

BUG=none
TBR=noelallen@chromium.org
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10828357

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152108 0039d316-1c4b-4281-b951-d872f2087c98

R=rdsmith@chromium.org
BUG=141244


Review URL: https://chromiumcodereview.appspot.com/10830363

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152107 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
Test=compiles

TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10837297

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10834078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137345
TBR=oshima

Review URL: https://chromiumcodereview.appspot.com/10823383

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152104 0039d316-1c4b-4281-b951-d872f2087c98

Let ui_test_utils::FindInPage optionally return the selection rect. This will be used in a future change, but I wanted to break it up.
Review URL: https://chromiumcodereview.appspot.com/10823392

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152102 0039d316-1c4b-4281-b951-d872f2087c98

Non Dev/Canary builds can use --browserless-panels flag to use refactored Panels.

TBR=yoshiki

BUG=127323
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10825396

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152100 0039d316-1c4b-4281-b951-d872f2087c98

Revert 151982 - Revert 151932 (caused gpu_throughput_tests to start failing on Mac GPU bots) - Hook up Mac OSX VSync parameters to compositor thread

Also fixes precision error on Windows.

BUG=137794

Review URL: https://chromiumcodereview.appspot.com/10830347

TBR=jbates@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825406

TBR=kbr@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10824357

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152099 0039d316-1c4b-4281-b951-d872f2087c98

Landing this again to get more information about the crashes. Doesn't crash locally or on the trybots it seems.

Move more message handlers from NativeWidgetWin to HWNDMessageHandler.

http://crbug.com/142962
R=sky@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152013
Review URL: https://chromiumcodereview.appspot.com/10832345

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152098 0039d316-1c4b-4281-b951-d872f2087c98

It will be restarted automatically by the Python script. Note that this CL does
not handle changes to the Python script itself, nor to Xvfb.

BUG=139919

Review URL: https://chromiumcodereview.appspot.com/10857046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152095 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152094 0039d316-1c4b-4281-b951-d872f2087c98

The previous DEPS update was reverted due to failures caused by Gyp
failing to incrementally rebuild some assembly files on Windows and
Mac Xcode.  This should be fixed by r9499.

This pulls in the following Native Client changes:

r9435: (shcherbina) Validator_ragel: move checkdecoder test from Makefile to scons
r9436: (halyavin) Remove commented out code.
r9437: (dschuff) Update pnacl TC revision to 9432
r9438: (kschimpf) Define baseline classes for instruction in table simd_dp of ARM validator.
r9439: (jvoung) Actually ignore -export-dynamic flag from rev r9423, instead.
r9440: (jvoung) Bump gold rev to pull in Tdata change and llvm for cherry pick:
r9441: (bradchen) Update enuminsts/ragel_tester.c to fully check base register usage.
r9442: (mcgrathr) Extend fpu_control_word test for ARM
r9443: (mseaborn) Fix compile-time assertions to check what was intended
r9444: (bsy) LOG_FATAL if NACL_EXE_STDERR style I/O redirection fails. handle /dev/null.
r9445: (mseaborn) Cleanup: Remove unused #defines of "_WINDOWS" and "_CONSOLE"
r9446: (mseaborn) x86-32: Cleanup: Remove "union PtrAbstraction"
r9447: (phosek) Make the NaClVmmapUpdate internal and provide NaClVmmapAddWithOverwrite and NaClVmmapRemove public interface
r9448: (mseaborn) Debug stub: Remove std_types.h, which duplicates NaCl's portability.h
r9449: (mseaborn) Debug stub: Remove unused IPlatform::CreateThread() function
r9450: (mseaborn) Debug stub: Cleanup: Remove IPlatform::Log*() functions
r9451: (mseaborn) Cleanup: Remove unneeded NaClOopDebugger*() hook functions
r9452: (halyavin) Update cygwin version which includes latest crash fixes.
r9453: (halyavin) Update scripts to include new cygwin core libraries snapshot.
r9454: (shcherbina) Validator_ragel build script: properly call python on windows
r9455: (jvoung) Update pnacl version to 9453.
r9456: (jvoung) Add pnacl precise bot to trybots list.
r9457: (khim) Add options argument to the ValudateChunk{AMD64,IA32} function.
r9458: (mcgrathr) Save and restore FPSCR register in ARM trusted<->untrusted context switch
r9459: (mseaborn) Cleanup: Remove NaClAppThread's unused "sysret" field
r9460: (mseaborn) Debug stub tests: Remove disabled pyauto-based browser test
r9461: (khim) Initialize variables in the decoder
r9462: (sehr) Add an API to MCSectionData that tracks known offsets for text emitted into a
r9463: (phosek) Removed NaClMemObj because it is no longer needed and replaced its use with enumerator.
r9464: (jfb) Refactor ARM validator register interfaces.
r9465: (shcherbina) Validator_ragel: factor out ProcessInvalidJumpTargets
r9466: (mseaborn) Debug stub: Switch to a thread-suspension-based model for catching faults
r9467: (mseaborn) Cleanup: Use "#if NACL_WINDOWS" instead of #ifdefs on WIN32 or _WIN32
r9468: (dschuff) Build LLVM from gerrit instead of hg/codesite
r9469: (jvoung) Update llvm rev to pull in revert of MC changes:
r9470: (dschuff) Dont auto-update depot tools when getting pnacl DEPS.
r9471: (noelallen) Fix PyAuto issues on integration bots.
r9473: (mcgrathr) Do not leak VFP/NEON register state to untrusted code
r9474: (mseaborn) Debug stub test: Ignore "Access denied" error from terminating sel_ldr
r9475: (mseaborn) Debug stub: Remove the now-unused IEvent class
r9476: (halyavin) Fix modifying parameters in CommandSelLdrTestNacl.
r9477: (kschimpf) Don't allow rex.w and data 66 prefixes for instructions with default 64 size.
r9478: (ncbray) Fix bug where SConstruct choked on failiures with multiple outputs.
r9479: (dschuff) Add script for merging in LLVM git repo
r9480: (bradnelson) Revert 9471 - Fix PyAuto issues on integration bots.
r9482: (dschuff) add git-has-changes back to common-tools.sh
r9483: (mseaborn) Cleanup: Remove unused "tools/tests" directory and CommandGdbTestNacl()
r9484: (jvoung) Add 1 elem structs to the calling conv test (mainly to test
r9485: (mseaborn) Thread suspension: Remove unused SuspendAllButOne()/ResumeAllButOne() functions
r9486: (phosek) The protection for anonymous mapping is stored incorrectly.
r9487: (khim) Refactoring the R-DFA validator interface.
r9488: (shcherbina) Validator_ragel dfacheckdecoder: change binutils revision
r9489: (mseaborn) Debug stub: Disallow memory accesses outside of the sandbox address space
r9490: (dschuff) Update Pnacl toolchain revision to 9476
r9491: (khim) Disable branch prediction prefixes for loop/loope/loopne.
r9492: (kschimpf) Make loop a conditional jump, and don't allow branch hints on loop, loope,
r9493: (bradnelson) Prefer SCons environment methods for functions acting on environments.
r9494: (mseaborn) x86-64: Undo removal of the "unused_padding" field from r9443
r9495: (mseaborn) Debug stub: Enable tests on x86-32 Windows
r9496: (mseaborn) Cleanup: Remove redundant #defines of "WIN32"
r9497: (bradnelson) Pull out parts of the nacl build that belong in chrome.
r9498: (sehr) Get MCFragment changes.
r9499: (mseaborn) x86-32: Undo changes to NaClThreadContext field offsets from r9446

BUG=none
TEST=nacl_integration

Review URL: https://chromiumcodereview.appspot.com/10823386

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152093 0039d316-1c4b-4281-b951-d872f2087c98

BUG=137351
TEST=none

TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10824355

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152092 0039d316-1c4b-4281-b951-d872f2087c98

This is useful in situations where a checkout excludes some DEPS directories.
In this case, a checkout may include the README.chromium file for a particular
third-party project, but not the license file to which it refers.

This change adds a new require_license_file argument to licenses.ParseDir(), with
a default value of true. When true, there is no change in behaviour and if the
license file is missing, an exception is raised. When false, if the license
file is missing, we simply set the value of the 'License File' field of the
returned metadata to None.

This change also makes use of the new feature in
webview_licenses.GetIncompatibleDirectories() and
webview_licenses.GenerateNoticeFile().

BUG=138921

Review URL: https://chromiumcodereview.appspot.com/10829355

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152091 0039d316-1c4b-4281-b951-d872f2087c98

- Revert 151904 (speculative, possibly broke
login_CryptohomeIncognitoUnmounted on ChromiumOS (amd64)
) - [ChromeDriver] Disable some unnecessary chrome services at startup.

These services make background network requests and aren't needed for
website testing.
BUG=none
TEST=none
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10837271

TBR=kkania@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10857050

TBR=thakis@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10832368

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152090 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142531
Review URL: https://chromiumcodereview.appspot.com/10828360

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152089 0039d316-1c4b-4281-b951-d872f2087c98

TBR=penghuang@chromium.org
BUG=143401
TEST=waterfall.sh

Review URL: https://chromiumcodereview.appspot.com/10837311

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152088 0039d316-1c4b-4281-b951-d872f2087c98

On all platforms:
After this CL there should be zoom icon in the omnibox when on a page with non-default zoom (- for less than default, + for more than default). If the zoom is reset with Ctrl+0, no bubble should show up and the icon should disappear. If tabs with different zooms are switched between, the zoom icon should update itself for each tab without showing a bubble.

On Views and GTK:
While changing zoom with Ctrl +/-, a zoom bubble should show up if you zoomed *to* a non-default level. If you quickly change to a different tab after changing the zoom level, the bubble should disappear.
 
BUG=86817,128817
TEST=Compiles, passes tests, doesn't regress current zoom functionality.
TODO=Zoom *bubble* on Mac.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10736028

TBR=dbeam@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10831372

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152087 0039d316-1c4b-4281-b951-d872f2087c98

Revert 151329 - Temporarily disabling H/W video decode on Windows to see if the crashes in the gpu process
are related.

BUG=142402
R=fischman
Review URL: https://chromiumcodereview.appspot.com/10831291

TBR=ananta@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10825420

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152086 0039d316-1c4b-4281-b951-d872f2087c98

When using peerconnection, the browser will crash when we close down the browser because in media_stream_capture_indicator.cc we delete an iter without updating it to the next iterator in a loop.

TBR=Tommi@chromium.org

BUG=143120
TEST=chrome/test/functional/webrtc_call.py

Review URL: https://chromiumcodereview.appspot.com/10831370

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152084 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152083 0039d316-1c4b-4281-b951-d872f2087c98

Confirmed green in waterfall canary bots; see http://crbug.com/143241 for details
Review URL: https://chromiumcodereview.appspot.com/10837307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152082 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825380

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152081 0039d316-1c4b-4281-b951-d872f2087c98

On all platforms:
After this CL there should be zoom icon in the omnibox when on a page with non-default zoom (- for less than default, + for more than default). If the zoom is reset with Ctrl+0, no bubble should show up and the icon should disappear. If tabs with different zooms are switched between, the zoom icon should update itself for each tab without showing a bubble.

On Views and GTK:
While changing zoom with Ctrl +/-, a zoom bubble should show up if you zoomed *to* a non-default level. If you quickly change to a different tab after changing the zoom level, the bubble should disappear.
 
BUG=86817,128817
TEST=Compiles, passes tests, doesn't regress current zoom functionality.
TODO=Zoom *bubble* on Mac.
NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/10736028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143346
TEST=set index of wallpaper image to -2 in Local State and run chrome with --login_manager

Review URL: https://chromiumcodereview.appspot.com/10832340

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142459

Review URL: https://chromiumcodereview.appspot.com/10827398

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152077 0039d316-1c4b-4281-b951-d872f2087c98

This implements the Mac part of Extension Commands for Browser Actions, Page Actions, Script Badges and Named Commands.

Known issues: Support for specifying Command key as a shortcut is not yet fully implemented.

BUG=27702
TEST=Automated test included.
Review URL: https://chromiumcodereview.appspot.com/10824307

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152076 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104292

Review URL: https://chromiumcodereview.appspot.com/10830216

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152072 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152071 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=compile succeeds.

Review URL: https://chromiumcodereview.appspot.com/10831363

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152069 0039d316-1c4b-4281-b951-d872f2087c98

In the "Cookies and Site Data" section of the Website Settings UI: Make the strings "Allowed" and "Blocked" lower case.

BUG=143125
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10836284

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152068 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140238

Review URL: https://chromiumcodereview.appspot.com/10823313

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152067 0039d316-1c4b-4281-b951-d872f2087c98

BUG=142732
TEST=

Review URL: https://chromiumcodereview.appspot.com/10823344

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152066 0039d316-1c4b-4281-b951-d872f2087c98

As a part of the new constrained window look and feel we're changing the the solid gray overlay to a gradient overlay. The overlay fades in on show and fades out on hide.

Screenshots:
    light background: http://i.imgur.com/GJj6L.png
    dark background: http://i.imgur.com/s37da.png

BUG=140520
TEST=Run with --enable-frameless-constrained-dialogs.
  Navigate to http://www.imagemator.com/
  Click "Click to pick an image."

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152059

Review URL: https://chromiumcodereview.appspot.com/10855151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@152065 0039d316-1c4b-4281-b951-d872f2087c98