- 01 Aug, 2019 40 commits
-
-
Philip Rogers authored
Non-fast scrollable regions are regions on a cc::Layer where the compositor should not handle scroll events. These are primarily for non- composited scrollers but are also used for resize controls and plugins. This patch paints non-fast scrollable regions for plugins that have blocking wheel event handlers. A design doc for this approach of painting non-fast scrollable regions is at: https://docs.google.com/document/d/1IyYJ6bVF7KZq96b_s5NrAzGtVoBXn_LQnya9y4yT3iw/view#heading=h.rrlzkp4v3huj This patch shares the pattern used by non-composited scrollers of emitting ScrollHitTestDisplayItems. ScrollHitTestDisplayItem has a field for supporting both scrolling (kScrollHitTest) and non-scrolling (kPluginScrollHitTest) usecases. This field was required because it will be possible to have two ScrollHitTestDisplayItems for one scroller: one for non-composited scrolling, and a second for a resizer. ScrollingCoordinatorTest::NonFastScrollableRegionsForPlugins is the interesting new test. It shows that PaintNonFastScrollableRegions matches the current behavior for non-fixed plugins, and shows that fixed plugin non-fast regions are now painted in a different layer. Painting the fixed non-fast region into the fixed layer fixes a bug where the non-fast regions would not be updated after compositor changes such as scrolling. Bug: 864567 Change-Id: If72e084241d1684e54d4c02e5d1efc04d91cc858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729551Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683165}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/32eaa7b5baa3..84de3d95cf0e git log 32eaa7b5baa3..84de3d95cf0e --date=short --no-merges --format='%ad %ae %s' 2019-08-01 oprypin@webrtc.org Factor framework dependencies out of audio_device_impl Created with: gclient setdep -r src/third_party/webrtc@84de3d95cf0e The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iea3235882b81a2449173fbb5ddf1c96f0c7cc384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730695Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683164}
-
Tsuyoshi Horo authored
Bug: 980828 Change-Id: Idfcf9c53f0db7e2ab24dcc29ce2d21a10096442a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730892Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#683163}
-
Arthur Hemery authored
This CL removes most of the references to PlzNavigate in the comments of content/. Some problematic cases where further expertise is needed are left out, but this covers more than 90% of the references. Change-Id: I6e060a5a92afe6ad3e078e3e5351020e4a85565f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729082 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683162}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/27e2873765fa..204a410c8c40 git log 27e2873765fa..204a410c8c40 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 bclayton@google.com SpirvShader: Add a single-entry, last-used sampler cache Created with: gclient setdep -r src/third_party/swiftshader@204a410c8c40 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137649247 Change-Id: If5c4128cce57a38454ad3e3ed1df8b70595beb30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730693Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683161}
-
Mohamed Amir Yosef authored
The feature flag has been introduced as kill switch for the change in https://chromium-review.googlesource.com/c/chromium/src/+/1530906 The change stick and then the feature flag isn't needed any more. More details are in the linked bug. Change-Id: I35bd6ff3b221b28e1df14af6156741ff487fca5e Bug: 943579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730160 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#683160}
-
Henrique Grandinetti authored
Bug: 988107 Change-Id: Ia9c12a9342342bc080f73ddbe5ba86531b29997e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724696Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#683159}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenRemoved in O2ATMtest to test that StartRequest triggers DiagnosticsObserver::OnAccessTokenRemoved which is triggered by ClearCacheForAccount, ClearCache and InvalidateAccessToken. Bug: 967598 Change-Id: Icc49cdc4848ca1e2891b21bb0ac945a9902f2648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728710 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683158}
-
Takuto Ikuta authored
Change-Id: Ib765ab8df18b5f05b3d40e45c426ef6e2c9428ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731169 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#683157}
-
vitaliii authored
TBR=hiroshige@chromium.org Bug: 855860 No-try: true No-Presubmit: true Change-Id: Ied837a5647454a324576de77dc7359b8cb280715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730161Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683156}
-
Benoît Lizé authored
This was unused since at least 2016 (see crbug.com/657093). Remove the code to support this both in LegacyLinker and ModernLinker. In the process, further unify the two linkers, and refactor state tracking. Bug: 979638 Change-Id: I4fad98228a841e1959a93f8ef5dbe5d29dfe7f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715485Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#683155}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 21b7351d. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Ia7dcc34fd929aaa29f56815bbd6d8e6c728a2cec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729479Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683154}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnFetchAccessTokenCompleteOnRequestCompleted to test that OnFetchAccessTokenComplete is invoked when a request is completed and OnFetchAccessTokenCompleteOnRequestWithoutRefreshToken to test that it is invoked when a request without a refresh token is started. Bug: 967598 Change-Id: If869a4e3647f496f66c58b6547ddb0e6b15a4eb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728410 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683153}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/470527ec6414..c17e81c243e3 git log 470527ec6414..c17e81c243e3 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 lalitm@google.com base: fix build of UUID on mac Created with: gclient setdep -r src/third_party/perfetto@c17e81c243e3 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I43130b5835a405ee65833d19baee662e3ca583f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683152}
-
Dominic Battre authored
A number of features in autofill depend on the app_locale (e.g. phone number parsing). This CL introduces logging case the locale is impacting the correctness. Bug: 928595 Change-Id: I0801be9271569b0a195b48fa0c7a109d87361d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727291Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#683151}
-
Anders Hartvoll Ruud authored
With the introduction of @property in the spec, we added an at-rule descriptor called "syntax". It is very confusing to have two slightly different things named "syntax descriptor" in the same spec, hence we renamed the first syntax descriptor concept to syntax definition [1], in order to avoid confusion with the at-rule descriptor named "syntax" [2]. There is no web-facing or behavior change in this CL; it's just to align our naming with the spec. [1] https://drafts.css-houdini.org/css-properties-values-api-1/#consume-syntax-definition [2] https://drafts.css-houdini.org/css-properties-values-api-1/#the-syntax-descriptor Change-Id: Ib0183950a49c156ee844c2eadf4208bac47a4d51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722947 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#683150}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db2e0c7d..14cf766b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idf590aa017e4d4a9f5d10e010a2ac9f1e1386869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729892Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683149}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenRequested in O2ATMtest to test that StartRequest triggers DiagnosticsObserver::OnAccessTokenRequested. Bug: 967598 Change-Id: Ia6b9a85d646571d7039d94a1d047cfed02fef1b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727112 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683148}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7d5085a0056a..682bc0e14c7a Created with: gclient setdep -r src-internal@682bc0e14c7a The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None,chromium:954450 Change-Id: I06b34bf37e936aae8a97c919f30c6328342f66bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730691Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683147}
-
François Beaufort authored
This CL adds the "readonly-storage-buffer" bind group layout binding type. When used though, it currently raises a validation error as Dawn doesn't support it yet. It also removes the unused `dynamic-uniform-buffer` bind group layout binding type. Bug: 877147 Change-Id: I3266b8931fee3e3f66dd170771195374132feaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730911Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#683146}
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //sandbox/mac. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I4d0ef55ee27bda9a8abd502d639db3f80bce9fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730771Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683145}
-
Miyoung Shin authored
This CL renames *_struct_traits.* to *_mojom_traits.* in //components/translate. *_struct_traits.* => *_mojom_traits.* Bug: 806965 Change-Id: I177733c24c2b6ff37144a9127a1c2509a0a01101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730518Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hajime Hoshi <hajimehoshi@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#683144}
-
Nico Weber authored
Bug: 989932 Change-Id: I6b85d7401a00fd58a89bbe8153eace2b3c2192e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731289 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#683143}
-
Henrique Grandinetti authored
Bug: 988490 Change-Id: Ib26f0315a6fcebec7e25b6f2b3139b34f5221c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724697Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Henrique Grandinetti <hgrandinetti@chromium.org> Cr-Commit-Position: refs/heads/master@{#683142}
-
vitaliii authored
Disable SingleClientSessionsSyncTest.NavigationChainForwardBack on Mac, because fails flakily. TBR=treib@chromium.org Bug: 972871 Change-Id: Ibfe85c4fa768a1a06ff31eb06fb8b70fdcb106cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730420Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683141}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It introduces OnAccessTokenFetchedOnRequestCanceled and OnAccessTokenFetchedOnRequestCompleted in O2ATMtest to test that OnAccessTokenFetched is invoked when a request is canceled or completed. Bug: 967598 Change-Id: Iebb3a2c6e601e385f8a3288130f39b249b616b34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727769 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#683140}
-
Arthur Hemery authored
This CL removes all of the references to PlzNavigate in the comments of extensions/. Change-Id: I89b3510b32e61d2bb4f737ff5705b5f1a47f9746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729085Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#683139}
-
François Beaufort authored
This CL adds `dispatchIndirect` to GPUComputePassEncoder and `drawIndirect` and `drawIndexedIndirect` to GPURenderPassEncoder. Bug: 877147 Change-Id: Idd5344c112fc2df6564e5091ca0ef86dc8f8bcc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731113Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#683138}
-
Edvard Thörnros authored
This is the first commit in the series of updating all the old svg animation tests. The usage of testharness has replaced the older SVGAnimationTest.js for all where it's suitable. No functionality should have changed and the tests should cover almost the same. In all of the animations where there is a sampling at T=0, where it was assumed that no animations had started. Which didn't work flawlessly when moved to the new system. Bug 985335 Change-Id: Icd94f4345cda61f9328abfb18caeed2b747dde93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729088 Auto-Submit: Edvard Thörnros <edvardt@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#683137}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/11243c3b6292..1532d22050cb git log 11243c3b6292..1532d22050cb --date=short --no-merges --format='%ad %ae %s' 2019-08-01 senorblanco@chromium.org Dawn: fix supportedWritePixelsColorType(). Created with: gclient setdep -r src/third_party/skia@1532d22050cb The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I8e51ee44801f5e5e01975949489f89b48542915b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731013Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683136}
-
Rune Lillesveen authored
We were able to SetNeedsReattachLayoutTree() on a Text node where none of the ancestor elements had a LayoutObject and the Document had a <br> as a documentElement. The reason is that LayoutView does not allow a LayoutBr child which meant we recomputed styles for the whole subtree, but no LayoutObjects were created. Setting the text data on the text node would mark it for re-attachment (in case it didn't have a LayoutText because it used to be a non-rendered white-space). If it was in a display:none subtree we wouldn't have reached the text node during recalc, but because of LayoutView rejecting the LayoutBr, we already had ComputedStyle all the way. Bug: 989827 Change-Id: I72ae371466e607baf4caffad9ed634beb2a66bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731112Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#683135}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLBodyElement> and DynamicTo<HTMLBodyElement> as new downcast helper. 2. Use IsA<HTMLBodyElement>(element) in place of IsHTMLBodyElement(element) Bug: 891908 Change-Id: I375e68ef0d03ed6119a22bf71b6e7cceeeca29f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729389 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#683134}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: If61c81302aa9f87cbba919dfbb71487abf807899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683133}
-
Juan Antonio Navarro Perez authored
The new options_for_unittests.GetRunOptions function now factors out all of the details required to build an options object. This removes all remaining references in tools/perf to the Add-/ProcessCommandLineArgs functions from the telemetry.benchmark module. Depends on catapult CL: https://chromium-review.googlesource.com/c/catapult/+/1713636 Bug: 985712 Change-Id: I49403b437a5e5e992328199372e4d9db57740906 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720834 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#683132}
-
Findit authored
This reverts commit bef7a422. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 683057 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2JlZjdhNDIyZTk4N2U1NTcxYWYxZjZhNWM0MGEzMjQxMzFlNjk3ZDAM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/34678 Sample Failed Step: unit_tests Original change's description: > [Dolphin] Add a sequence checker > > The RecurrenceRanker isn't threadsafe, so we should formalize this. > This CL adds a sequence DCHECK to all public methods (and a couple > of private callbacks, for clarity). > > Bug: 921444 > Change-Id: Ib52f8e33be82de147efd23e67c424083ff980184 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729991 > Reviewed-by: Charles . <charleszhao@chromium.org> > Commit-Queue: Tony Yeoman <tby@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683057} Change-Id: Idfac688d72ba6a356259a575209b755ec340b7ac No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730620 Cr-Commit-Position: refs/heads/master@{#683131}
-
vitaliii authored
Followup to https://chromium-review.googlesource.com/c/chromium/src/+/1730154 TBR=yhirano@chromium.org Bug: 989717 Change-Id: I060adb383fed7b911cfc602ced6831da2a424d61 No-try: true No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730898Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683130}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/e02102755a5b..470527ec6414 git log e02102755a5b..470527ec6414 --date=short --no-merges --format='%ad %ae %s' 2019-08-01 treehugger-gerrit@google.com Merge "processor: Export thread instruction counts to JSON" Created with: gclient setdep -r src/third_party/perfetto@470527ec6414 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: Ib27cce382de999ab0037471a3869ac3594408cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730614Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683129}
-
Chromium WPT Sync authored
Using wpt-import in Chromium fbf6c023. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I5dcd194bc6e011d9c6355109c13a5d94fc5c8ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729890Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#683128}
-
vitaliii authored
This reverts commit 3ed48d07. Reason for revert: Broke src-internal rolls. See crbug.com/989897. Original change's description: > desktop-pwas: OpenApplication called using Launch Service > > The Launch Service is used to open a new application > window. > > TBR=avi@chromium.org > > Bug: 966288 > Change-Id: Ibc7c1f49fa109335e81744ddda292a08f36b80a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723794 > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#683074} TBR=ericwilligers@chromium.org,reillyg@chromium.org,loyso@chromium.org,dominickn@chromium.org Change-Id: Icfc62bcaea99c6d38797138e49632800aceb1de4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966288, 989897 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730418Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#683127}
-
Yasmin authored
Bug: 988461 Change-Id: I2cc57ddd1ee3b93036a10a7243045a3f7320d8e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725635 Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#683126}
-