- 21 Feb, 2020 40 commits
-
-
Nico Weber authored
...and enable Wbitwise-conditional-parentheses on android. https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libunwind.git/+log/43bb9f8722..d999d54f4b Fix a -Wbitwise-conditional-parentheses warning in _LIBUNWIND_ARM_EHABI libunwind builds 11b0129 [libunwind] Treat assembly files as C on mingw 76f6916 [libunwind] Fix building standalone after c48974ffd7d1676 aea9f89 [libunwind] Set LIBUNWIND_ASM_SOURCES to the ASM source language from C e4cbc26 Bump the trunk major version to 11 e12b248 [libunwind] Fix evaluating DWARF operation DW_OP_pick c3889d9 [unwind] Don't link libpthread and libdl on Fuchsia 81f7e17 [libunwind][RISCV] Add 64-bit RISC-V support baf07ac Reland "Enable `-funwind-tables` flag when building libunwind" 2ef1190 Revert "Enable `-funwind-tables` flag when building libunwind" 2fd0a70 Enable `-funwind-tables` flag when building libunwind f939ab7 [libunwind] Emit dependent libraries only when detected 4cd4dca [libunwind] Adjust the signal_frame test for Arm 0b1d80f change LLVM_VERSION_SUFFIX default from svn to git b6a6639 Correctly update isSignalFrame when unwinding the stack via dwarf. e7f96ac unwind: restore the LINKER_LANGUAGE e24563d unwind: reflow some of the build rules (NFC) f2c3035 unwind: disable RTTI during the build of libunwind a4a7180 Revert "build: explicitly set the linker language for unwind" ccff66b build: explicitly set the linker language for unwind a914ec1 [libunwind] [Windows] Add a log message if EnumProcessModules fails 2a4f136 [libunwind][Android] Fix findUnwindSections for ARM EHABI Bionic b6bfd8b [libunwind][Android] Improve workaround for PIE zero-dlpi_addr bug 1073ad9 [libunwind] Fix issues introduced in r374606 cfb6df8 [libunwind] Refactor CMake flag checks to match libc++ and libc++abi 57be2d2 [libunwind] Adjust libunwind_01.pass.cpp test for ARM EHABI 5342138 Unwind: avoid warning about unused typedef 78b42cc Unwind: prevent unw_get_proc_info from returning stale data 2aa34a8 unwind: remove a could of extraneous `else` (NFC) c699521 [runtimes] Don't depend on libpthread on Android 9d72a29 [libunwind][ARM] Fix types in _Unwind_VRS_Get. d003462 [libunwind][ARM] Fix loading FP registers on big-endian targets 558e694 Bump the trunk version to 10.0.0svn 8d9ed37 [libunwind] Fix Unwind-EHABI.cpp:getByte on big-endian targets 0baf612 [libunwind][AArch64] Fix libunwind::Registers_arm64::jumpto b5b4a50 [Docs] Modernize references to macOS 7aecb76 [CMake] Use find_package(LLVM) instead of LLVMConfig e2fa4a0 [runtimes] Use -Wunknown-pragmas for the pragma check 0e59516 [runtimes] Check if pragma comment(lib, ...) is supported first 7b72703 [runtimes] Support ELF dependent libraries feature 06a69dc [libunwind] [test] Fix inferring source paths 1f9c24d [runtimes] Move libunwind, libc++abi and libc++ to lib/$target/c++ and include/c++ 7611bf2 [PPC] Fix 32-bit build of libunwind 8a6fc69 [PPC64][libunwind] Fix r2 not properly restored 7f90e76 Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force 22e7c0c [gn] Support for building libunwind 103afa4 [NFC] Fix typo in debug log f5d6a44 Add support for ARMv7-M architecture which uses the Thumb 2 ISA (unified syntax) f8c730d [NFC] Move the export attribute after extern "C". 59d0c60 [NFC] Correct outdated links to the Itanium C++ ABI documentation 01fc413 [libunwind] Fix the typo in unw_save_vfp_as_X alias 2b63e62 Move the alias definition of unw_getcontext to within !defined(__USING_SJLJ_EXCEPTIONS__) 2ec9ffc [libunwind] Export the weak alias in Mach-O 9bbfad5 [libunwind] Export the unw_* symbols as weak symbols e63f955 [libunwind] Do not share an object library to create the static/shared libraries 2a2b62e Revert "[runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/" 9021011 [runtimes] Move libunwind, libc++abi and libc++ to lib/ and include/ 4287808 [CMake][libunwind] Define add_target_flags which is missing 3674fe4 [CMake] Don't cache LLVM_MAIN_SRC_DIR 99b7c05 [CMake] Support compiler-rt builtins library in tests a6a888a [CMake] Support CMake variables for setting target, sysroot and toolchain 5f5036e Provide a placement new definition for the SEH version of UnwindCursor 36f6154 [libunwind] Provide placement new definition f50a5ed [libunwind] Remove the remote unwinding support 370ec3f [CMake] Use correct visibility for linked libraries in CMake a0f0700 Revert "[CMake] Use correct visibility for linked libraries in CMake" d6e1714 [CMake] Use correct visibility for linked libraries in CMake 809c2b5 [libunwind] Support building hermetic static library ac0d9e0 Drop the dependency on <algorithm>, add placement new inline 8835912 Adjust documentation for git migration. fafb21e Don't define unw_fpreg_t to uint64_t for __ARM_DWARF_EH__ a9ccb4e Revert "[libunwind] Drop the dependency on <algorithm>, add placement new inline" cf8d0d6 Revert "[CMake] Use __libc_start_main rather than fopen when checking for C library" b31f294 [libunwind] Drop the dependency on <algorithm>, add placement new inline 6a3a019 [CMake] Use __libc_start_main rather than fopen when checking for C library 1f978e9 [libunwind] Use placement new to avoid dependency C++ library 06be328 [libunwind] Don't abort if encoutering invalid .eh_frame_hdr 059a163 Silence warnings about unused parameters 13d23c8 Remove an unused variable 688e594 Add casts to avoid warnings about implicit conversions losing precision 985a1d1 Fix warnings about printf format strings 55b1c00 Enable LLVM_ENABLE_WARNINGS when building standalone out of tree 0dc7999 Fix typos throughout the license files that somehow I and my reviewers 61860a5 Update more file headers across all of the LLVM projects in the monorepo 60b38b7 Install new LLVM license structure and new developer policy. 9180f77 [SjLj] Don't use __declspec(thread) in MinGW mode 14d9c7b Bump the trunk version to 9.0.0svn b9268be Update year in license files 9f2f07a [Sparc] Add Sparc V8 support 38d0a65 Revert "[Sparc] Add Sparc V8 support" d71bc56 [Sparc] Add Sparc V8 support ce15011 [SEH] Add initial support for AArch64 cba83c3 [AArch64][libunwind] Unwinding support for return address signing with B Key 4d8e431 [AArch64][libunwind] Unwinding support for return address signing Bug: 1016947 Change-Id: I37d815a111ce4a5cf4a246fc4558d8c7ba5f7fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062638 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#743604}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d3aad0f4d106..a18f414547c9 git log d3aad0f4d106..a18f414547c9 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 jmadill@chromium.org Trace/Replay: Add uniform location type. Created with: gclient setdep -r src/third_party/angle@a18f414547c9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ic4bbc3d1374438042a849d997dc09937744fe4d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068498Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743603}
-
Liquan (Max) Gu authored
Before change: * PH UI WebContents was not resized on phone rotation. * WebContents was larger than the visible area of the PH UI's Content container. * PH UI used BottomSheetHeightFraction as a MVC state to determine its view. After change: * PH UI WebContents is resized on phone rotation. * WebContents fits just right into the visible area of the PH UI's Content container. * PH UI uses the visible height of the Payment Handler UI's content container as a MVC state to determine the view. Change: * Listen to phone rotation by tab view layout change, in order to resize ThinWebView. * Change a way to calculate the visible area of PH UI content container. * Change the MVC state from BottomSheet height fraction to "visible content height". Bug: 1053923 Change-Id: I6dfd02b7d953561d4cbb2ca84b844f1c14a817d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067917 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#743602}
-
Bo Liu authored
Android will soon only allow retrieving the display from a "display" Context. In practice for chromium, this means retrieving the WindowManager or Display is only allowed on Activity (or a ContextWrapper wrapping an Activity). In particular, it will cause problems to use ContextUtils.getApplicationContext() to retrieve the Display, which unfortunately happens in a lot of places. This CL converts ui/display to store a default display, and return that if any code tries to use an illegal Context to get the display. This is really going against the intentions of the Android change and will keep allowing chromium to do the wrong thing. However the ui/display library (in both java and native) are already set up to force code to do things the right way already, which is the correct long term solution. Bug: 1042063 Change-Id: Iea12bcea9d0b7b99bd35bdf2a4de7d6f08272d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064472Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743601}
-
Sven Zheng authored
These two flags were new added. TEST: Tested works locally and can correctly post comments on gerrit. Bug: 958242 Change-Id: Ie01e1dda6e56210eb0e1686ff920bc3ee67ccf6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067285 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#743600}
-
Colin Blundell authored
HostContentSettingsMap will shortly be required in WebLayer for reuse of //chrome's SSLHostStateDelegate implementation. This CL enables that by creating a BrowserContextKeyedServiceFactory implementation for HostContentSettingsMap in //weblayer. The implementation is modeled after that in //chrome but can be significantly simpler. Two relevant differences (see discussion in comments on the CL for more details): 1. In WebLayer, we do not reply on the //chrome-level feature to determine whether to set migrate_requesting_and_top_level_origin_settings to true but simply set it to true. The feature has been enabled by default for 2+ years and is shortly set to be cleaned up, so it is not worth componentizing. 2. We did not bring over the Android-specific code from //chrome's factory (which would need componentizing). The features in question are not currently supported in WebLayer. HostContentSettingsMap requires a PrefRegistrySyncable in order to register its prefs. To facilitate this, this CL changes //weblayer's BrowserContextImpl to use a PrefRegistrySyncable (as //chrome's ProfileImpl does), rather than its previous usage of a PrefRegistrySimple. This change should have no meaningful behavioral impact as WebLayer does not use sync. Bug: 1030692 Change-Id: I86053d749141b7e223812b042949aaf7ff5ecee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062342 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#743599}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f8f9cd84fa04..828a7ef39d72 git log f8f9cd84fa04..828a7ef39d72 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 benjaminwagner@google.com [infra] Switch iOS to updated libimobiledevice. 2020-02-21 brianosman@google.com Make it easier to add vector versions of byte code instructions 2020-02-21 benjaminwagner@google.com [infra] Add ios-dev-image-11.4 asset 2020-02-21 reed@google.com Make SkM44 public Created with: gclient setdep -r src/third_party/skia@828a7ef39d72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I3c3885b8ec311d1aa7acac445fd991e0cc405e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068503Reviewed-by:
-
Josh Karlin authored
To be cautious we landed this patch behind a feature to make sure it wasn't hurting performance. We're not seeing anything in 28 day data on canary/dev to suggest that it's problematic, so launching via waterfall. Bug: 851531 Change-Id: I77fc899170d8b5f76e7d50a4db3a4e33e88b40ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053411Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743597}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/84d733f34b73..1a0338a1175b git log 84d733f34b73..1a0338a1175b --date=short --first-parent --format='%ad %ae %s' 2020-02-21 tvanderlippe@chromium.org Reland "Build Karma test with Ninja" 2020-02-21 aerotwist@chromium.org Reland "Updates performance timeline for long tasks" 2020-02-21 tvanderlippe@chromium.org Disable Multi-Worker e2etest Created with: gclient setdep -r src/third_party/devtools-frontend/src@1a0338a1175b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1011811,chromium:1054447 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie0aca0632e4c56f561af28e649dec77ab04ae4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068435Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7e4c38a48b04..1eb16f67982b git log 7e4c38a48b04..1eb16f67982b --date=short --first-parent --format='%ad %ae %s' 2020-02-21 brucedawson@chromium.org Fix build summary to classify *.mojom*.obj as .obj Created with: gclient setdep -r src/third_party/depot_tools@1eb16f67982b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I105fd6192854747c100c8240a97cc5b4aa6fb88e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068504Reviewed-by:
-
Mia Glaese authored
TabCreator: -selects TabModel and shows StartSurface HomePage instead of launching NTP if applicable. ChromeTabbedActivity: -restores active tab if StartSurface is shown on start and not incognito. -InternalIntentDelegate and shouldShowTabSwitcherOnStart updated StartSurfaceMediator: -trigger tabswitcher update when active tab is restored to load tab carousel Change-Id: I45809c1cd604bd035c008375c1b68a2aba8ba715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032038 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#743594}
-
Xida Chen authored
In this previous CL: https://chromium-review.googlesource.com/c/chromium/src/+/2037836 We changed the throughput UMA from Graphics.Smoothness.Throughput to Graphics.Smoothness.PercentDroppedFrames. But there are some places in the histograms.xml that were left out. This CL corrects it. Bug: 1048780 Change-Id: I2a884a3ff4fdec47ecb28273218feb53ae00eb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064464Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#743593}
-
Ioana Pandele authored
This fix restores the handling of current_forms from before the fix for crbug.com/1041374. Bug: 1053651 Change-Id: Ibc726e840e32addb9a042dc8173f7c76952a7128 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066740 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#743592}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I89d1fff0bd85ad9c3bd259a259d52bfc9962c40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066926 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#743591}
-
Paul Moy authored
Now that cros_healthd collects memory information, use it to fetch and report the information in DeviceStatusCollector. DeviceStatusCollectorTest.TestCrosHealthdInfo and chromeos_unittests --gtest_filter= CrosHealthdServiceConnectionTest.* Bug: chromium:1054198 Test: browser_tests --gtest_filter= Change-Id: I23617c2184fc49859b25faf35ae7574af96240c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067252Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Ben Kelly authored
Experimentation on stable shows an ~8% progression on CacheStorage match time during FetchEvent handling at P95. Bug: 913107 Change-Id: Ia81a59b1ad13db3c613b7198adffd576e7cf7264 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036025 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#743589}
-
Owen Min authored
Bug: 10487447 Change-Id: Ic1521f63db6ffa6d8e0b1f1ce5fe617c6c7170ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036799Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#743588}
-
Nektarios Paisios authored
On platforms other than Chrome OS, Views objects are exposed to assistive software directly via an associated ViewAXPlatformNodeDelegate. To reduce code complexity and allow better text navigation in Views, we are planning to expose Views as an AXTree, in the same way as we currently expose web contents to accessibility. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I988437501a2ca8dfba06f4eb927b65a363f3bb42 Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068041 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743587}
-
Mason Freed authored
This is an in-progress API, part of the declarative Shadow DOM proposal [1], with the I2P at [2]. The new getInnerHTML() function gets the innerHTML property, but with additional options. At the moment, there is a single bool argument, which if true, serializes any contained `#shadowroot` nodes into declarative shadow root markup: <template shadowroot="mode">. [1] https://github.com/mfreed7/declarative-shadow-dom/blob/master/README.md [2] https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/nJDc-1s3R9U Bug: 1042130 Change-Id: I25ee40479e74d8d5aceb10b0b790d401f638e593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063891Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743586}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Id065c6a115ede775da9f57459d484b45ffb54acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068432Reviewed-by:
-
Josh Nohle authored
The current SystemInfoAPI logic does not account for multiple event listeners in the same browser context. The result was that when a listener was removed from the last relevant browser context, storage and display-changed events were not being dispatched. This is particularly deadly when lazy listeners still exist, listening for events while the background browser extensions lie dormant. The consequence is that, after roughly 15s, the browser extension handling display-changed and storage events goes dormant, all listeners except the lazy listeners are removed, the event dispatchers stop dispatching, and the Settings > Displays UI does not respond to changes such as monitor (un)plug or (un)mirroring. Here, we utilize the EventRouter::HasEventListeners() to ensure that events are dispatched if and only if at least one browser context has the relevant listeners attached. Tested "system.display.onDisplayChanged" events manually with debug logging (see patchset #3). Note: "system.storage.onAttached" and "system.storage.onDetached" event handling from SystemInfoAPI is only used in extensions browser tests. Fixed: 966053 Change-Id: Iaeb0406539971d87505bd44ae60e44553a9fc104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037955 Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#743584}
-
Robert Phillips authored
This reference into Skia's include/private directory is preventing SkDeferredDisplayList.h being moved to include/core. SkDDLTmpRedirect.h acts as a redirection to allow the following Skia-side CL to land: https://skia-review.googlesource.com/c/skia/+/272343 (Move SkDeferredDisplayList.h into include\core) Change-Id: I4960712be5a4af372b285bc125ee65c2bdee2469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067386Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#743583}
-
Mason Freed authored
This reverts commit 4486011f. Reason for revert: See crbug.com/1054837 Original change's description: > Add tests to Fuchsia ARM64 CI builder. > > Use the same test exceptions for Fuchsia ARM64 as fuchsia-fyi-arm64-rel. > > Bug: 1042512 > Change-Id: I7b9333e49151975b4bfecb98dd6d36d954b514ef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067673 > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#743555} TBR=martiniss@chromium.org,jbudorick@chromium.org,steveroe@google.com Change-Id: Id61a07e464d238b7007e18625f19a549cd249b05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067091Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#743582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/694b74b82673..1dea1ea41202 git log 694b74b82673..1dea1ea41202 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 ilnik@webrtc.org [VP9 encoder] Set temporal id also on disabled spatial layers Created with: gclient setdep -r src/third_party/webrtc@1dea1ea41202 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1051476 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I394403e169eb862ce5b59749470b7f8f6d83c5c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068426Reviewed-by:
-
Aaron Leventhal authored
Intent to Ship thread on blink-dev with 3 approving reviewers: https://groups.google.com/a/chromium.org/g/blink-dev/c/2uume_z0n8M Bug: 1006767 Change-Id: I08eb0468d69d9c989d08b53c83c71dde2d0dab87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067471 Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#743580}
-
Jose Lopes authored
The decrypt callback is called to indicate that the decrypt operation has completed: * https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=253e14fadbd228088575647ae333ca4ba974b021&l=60 The decrypt operation is defined in: * https://cs.chromium.org/chromium/src/media/base/decryptor.h?rcl=253e14fadbd228088575647ae333ca4ba974b021&l=76 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 714018 Change-Id: I4fe39c6e5159438d80895df6c85432db38a4d789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050367 Commit-Queue: Jose Lopes <jabolopes@google.com> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#743579}
-
Hui Wang authored
TransientEntry will chang to a general entry when we restore it from the state which was saved before. while TransientEntry usually used for InterstitialPage(eg. blocking pages) then an TransientEntry will be created again when we restore and load with the entry. Use the LastCommittedEntryIndex as selected entry index same with chrome. BUG: None Change-Id: I56146535799a6cbaa367b9f9de9485fa870b4640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068218 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#743578}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f33bae87..79f0359a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I526e63f15af466367f0e6295de9fbbf3b74a6c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067360Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743577}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e4fe70d. With Chromium commits locally applied on WPT: d5cd6b98 "SharedWorker: Assign unique names to SharedWorkers to avoid unintentional matching" 76ee218c "Split html/.../query-encoding/ tests" c07550c4 "Fix ResolvedUnitType() in CSS min/max with both integers and floats" 86c2cff8 "Don't make anchor clicks cancel form submission when href=#" 1ce9585a "Clear-Site-Data must uncontrol affected service worker clients" f1545e0e "webrtc: add wpt for validating ice-ufrag and ice-pwd syntax" afc2a4ab "WPT: Fix bogus use of assert_object_equals()" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I38c7652896f71d21925a5effb62ae0b693ff2254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067199Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743576}
-
Jose Lopes authored
This is meant to be called every time the buffering state changes: * https://cs.chromium.org/chromium/src/chromecast/media/cma/pipeline/media_pipeline_client.h?rcl=177e90911c8bcb0c547c7974acdf4b249fa67062&l=31 This is a documented example: * https://cs.chromium.org/chromium/src/chromecast/media/cma/pipeline/media_pipeline_impl.cc?rcl=177e90911c8bcb0c547c7974acdf4b249fa67062&l=406 This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 TBR=jam@chromium.org Bug: 714018 Change-Id: I915667489e660da38387747f91e1c2a42a84c6d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047228 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
-
Fredrik Söderquist authored
All attribute accesses here use the underlying object model, so there's no need to synchronize the attributes. Bug: 109212 Change-Id: I14448b23fe61eedbf0e8de3479c8b48331830371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2066750 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Philip Rogers <pdr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743574}
-
Patrick Monette authored
Bug: 1054596 Change-Id: Ifa36d10be3188a8e0636e48d8cac170f1a1999d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067383Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#743573}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a139c005963b..137ae16f4e3f git log a139c005963b..137ae16f4e3f --date=short --first-parent --format='%ad %ae %s' 2020-02-21 lamontjones@chromium.org sdk.py: Honor build_source with no board list. 2020-02-21 vapier@chromium.org Revert "cbuildbot_launch: switch to python3 only" 2020-02-21 vapier@chromium.org export_to_cloud_trace: get it working under Python 3 2020-02-21 vapier@chromium.org scripts: convert random standalone programs to python3 only 2020-02-21 vapier@chromium.org cros_generate_breakpad_symbols: migrate to python3 only 2020-02-21 lamontjones@chromium.org api: refresh python files 2020-02-21 lamontjones@chromium.org toolchain: support Kernel CWP AFDO verify builders. 2020-02-21 lamontjones@chromium.org toolchain: Implement Chrome VerifyReleaseAfdoFile endpoints 2020-02-21 lamontjones@chromium.org toolchain_util: Pass all locations to _FindLatest* 2020-02-21 bsheedy@chromium.org Add option to snapshot VM 2020-02-20 gbiv@google.com simplechrome: simplify thinlto/cfi special cases 2020-02-20 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@137ae16f4e3f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: If6e09e8d6ff49300eea5008b942fd6526d2d2076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068421Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/706851dc99d9..f8f9cd84fa04 git log 706851dc99d9..f8f9cd84fa04 --date=short --first-parent --format='%ad %ae %s' 2020-02-21 kjlubick@google.com [canvaskit] Expose bindings to particles uniforms. 2020-02-21 robertphillips@google.com Revert "Remove copies for wrap modes in GrTextureProducer." 2020-02-21 kjlubick@google.com [canvaskit] Expose parseColorString 2020-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2801bf43716e..94ec1e5f8df5 (24 commits) 2020-02-21 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 74d3f371f201..f50cc82b3bed (6 commits) 2020-02-21 csmartdalton@google.com Split uniform and texture uptades to different methods in GrGLProgram 2020-02-20 bsalomon@google.com Revert "Remove GrDeviceSpaceTextureDecalFragmentProcessor." 2020-02-20 bsalomon@google.com Remove GrDeviceSpaceTextureDecalFragmentProcessor. 2020-02-20 bsalomon@google.com Remove copies for wrap modes in GrTextureProducer. Created with: gclient setdep -r src/third_party/skia@f8f9cd84fa04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC lovisolo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: lovisolo@google.com Change-Id: I4a9605c6893e22c135a5e6973c8a04dcd7890b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068422Reviewed-by:
-
Daniel Libby authored
This CL adds plumbing of an ExecutionContext into the creation of MediaQueryExp objects. This will allow RuntimeEnabledFeatures that are slated for origin trial experimentation to pass the ExecutionContext to the REF::*Enabled check so that origin trials can appropriately enable new media features based on experimentation status per origin. Callsites that perform media query parsing now pass an ExecutionContext, except for tests, media_feature_overrides, and html_preload_scanner. The overrides don't need an ExecutionContext since they are used to produce emulated values - parsing/setting the new features/values would still need to be enabled for this to have any effect. Not having the ExecutionContext for the preload scanner means that if experimental media features are gating resources, they may not be preloaded. However, given that these features are experimental, will eventually get loaded, and the fact that the amount of extra plumbing required is non-trivial, I've decided not to add the plumbing here. This CL also adds a test-only media feature that is enabled by the basic sample API origin trial feature in order to test various aspects of the plumbing. Bug: 1051382 Change-Id: Ifaafa2816f65a04f9cdd87bab8b1f216b54a348c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062699Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#743570}
-
kylechar authored
In preparation for enabling finch experiment on beta channel. This CL also flips skia_renderer_screenshot_sync_tests to be gl_renderer_screenshot_sync_tests on Windows/Linux. GPU telemetry tests will flip to use SkiaRenderer by default now so this maintains limited test coverage for GLRenderer in CQ. Bug: 809722 Change-Id: I5ea506566db874f5a83aa6c6bd82980f5196536f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988154 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Chris Harrelson authored
is an effect on the root element. The only reason to do so is to preserve blending. A more complete fix might be to always allocate an isolation effect node for the HTML element, but that will cause a very large number of rebaselines and introduces some risk of its own. (This CL needs to be merged into M81.) While not perfect, it returns us to the situation before landing [1]. Bug: 1050462 [1] https://chromium-review.googlesource.com/c/chromium/src/+/1979258 Change-Id: Id7b51837c0d36c426c1042bb9c6c0e5f81e64a36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067288Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#743568}
-
Vasiliy Telezhnikov authored
During destruction of WebView it's possible that not every observer has unsubscribed from BeginFrameSource in RootFrameSink (the latest it will happen in dtor RootFrameSink). This leads to situation when RootFrameSinkProxy is still observing BrowserViewRenderer's BeginFrameSource in dtor which leads to DCHECKs. This CL adds explicit RemoveObserver in RootFrameSinkProxy dtor to handle sutiation correctly. Bug: 1054777 Change-Id: I00811c79ae430872964075c83a308cad17a8694a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067087Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/95fa3e68d355..f67f959012ef Created with: gclient setdep -r src-internal@f67f959012ef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I99b617de5f75940ee34db1083685d04d47661d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2068423Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#743566}
-
Aga Wronska authored
User app activity data should only be uploaded to the server when app activity collection toggle is enabled. If collection is disabled Per-App Time Limits feature will still work 'locally', but without uploading activity data. As a consequence parent nor child will not be see activity data in Family Link app. Bug: 1042477 Change-Id: I93382b654e490e2f8431dbd345f242ed2cc44f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2067662Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Henrique Grandinetti <hgrandinetti@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#743565}
-
