- 21 Nov, 2018 40 commits
-
-
Aiden Benner authored
- Move golden/javap files to jni_generator/golden/ - Make method capitalization more consistent with jni_generator py files - Split proxy native tests to a different test suite - Decouple utility functions from TestGenerator into a base test class - Fix bug where tests would fail if ran from a different directory - Adds tests for enable/disable/require mock flags Bug: 898261 Change-Id: Ieae930c73539b00653dfcf32c89d9a79a3ceecf6 Reviewed-on: https://chromium-review.googlesource.com/c/1345239 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#610266}
-
Alice Boxhall authored
Bug: 906310 Change-Id: I62438e397d3551c7cc0787df4ff5faa985fb3f56 Reviewed-on: https://chromium-review.googlesource.com/c/1345714 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#610265}
-
Ken Buchanan authored
This is a speculative fix to flakiness on SitePerProcessBrowserTest.CrossProcessInertSubframe, yielding the UI thread after navigation but before sending the script to test for inertness. This should ensure the inertness bit propagates to the new frame before the script is sent for execution. Bug: 792477 Change-Id: Iee370a863003045399730ba4a49831051d20316c Reviewed-on: https://chromium-review.googlesource.com/c/1347617Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#610264}
-
Aiden Benner authored
Adds the REQUIRE_MOCKS flag to GEN_JNI. If both the REQUIRE_MOCKS and TESTING_ENABLED flags are set, calls to native implementations must have had a mock instance set first through TEST_HOOKS, otherwise an UnsupportedOperationException will be thrown. If only TESTING_ENABLED is set, calls to the native implementation will use a test mock if it is provided, and otherwise fallback to the native implementation. This is used for instrumentation tests that may want to mock out some native implementations but not all. In the annotation processor version of GEN_JNI both these flags are mutable and so they can be set by a JNI test rule for unit tests. Instrumentation tests that want to mock a native implementation can pass flags to JNI registration generator to set the corresponding GEN_JNI flags. Bug: 898261 Change-Id: I6a90e91a29368df692d458f35c9ea92f8898064b Reviewed-on: https://chromium-review.googlesource.com/c/1344554 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
-
Alexei Svitkine authored
On a recent review [1], I wasn't happy with the exact comment that was being used and requested changes, but turns out the author had used the sample comment we have in the header file. Update that comment to improve it. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1337297 Bug: None Change-Id: I49bc65b64824839a5ffe112a6e1bc5ae6447e75e Reviewed-on: https://chromium-review.googlesource.com/c/1346732Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#610262}
-
Stephen McGruer authored
Upstream, the spec has changed to remove 'auto' as a value for ScrollDirection. TBR=majidvp@chromium.org Bug: None Change-Id: I5fa47e0f31c5229b5d734dc39d0717973936543e Reviewed-on: https://chromium-review.googlesource.com/c/1347033Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#610261}
-
Nicolás Peña Moreno authored
This reverts commit 5d945012. Reason for revert: FindIt thinks this is causing Layouttest failures Original change's description: > Unify input delay computations > > This CL unifies the timestamp computations for FID as reported to UMA and FID as > exposed in the Web Perf API. It moves the UMA reporting from the > PageWidgetDelegate to the EventTiming class. After this CL, the same types of > events are logged by both the UMA metric and the webexposed metric. In addition, > this CL removes the check that there are default actions or event handlers from > EventTiming, which means that now the webexposed API will expose events even if > they have no associated event handlers. In particular, this means that a click > will now trigger mousedown, click, and mouseup entries, in that order. This is > reflected in changes to the layout tests. > > Bug: 897656 > Change-Id: Ibeee0ffe9ff1fc0df74585da96a8fd3a6f2d17dc > Reviewed-on: https://chromium-review.googlesource.com/c/1334564 > Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> > Reviewed-by: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Timothy Dresser <tdresser@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610201} TBR=tdresser@chromium.org,dtapuska@chromium.org,npm@chromium.org Change-Id: I27e189ee26fb04fa92e8ca6232c8c70730b0c373 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897656 Reviewed-on: https://chromium-review.googlesource.com/c/1347692Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#610260}
-
Jia authored
It will be enabled in experiments later. Bug: 881215 Change-Id: Ic1664d82810311b69658a279661624f285493bbb Reviewed-on: https://chromium-review.googlesource.com/c/1347629Reviewed-by:
Marti Wong <martiw@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#610259}
-
Brian Sheedy authored
This reverts commit 41ee7d38. Reason for revert: Cause of https://crbug.com/907602 Original change's description: > Android: Factor InProductHelp UI out of Tab > > This CL moves the methods handling InProductHelp UI in Tab to > ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and > Tab page load observing mechanism. Now the methods are handled by > ChromeTabbedActivity only. > > Bug: 889682 > Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1 > Reviewed-on: https://chromium-review.googlesource.com/c/1272779 > Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609881} TBR=tedchoc@chromium.org,twellington@chromium.org,mdjones@chromium.org,jinsukkim@chromium.org,robertogden@chromium.org Change-Id: I539d82b07ee8f6a3012ad72e1f2ba35eda613d72 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 889682 Reviewed-on: https://chromium-review.googlesource.com/c/1347199Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610258}
-
John Budorick authored
Tbr: martiniss@chromium.org Bug: 904636 Change-Id: I7e8d7ed29da753a1813f304d17efccb8a327f441 Reviewed-on: https://chromium-review.googlesource.com/c/1347612Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#610257}
-
Hiroshige Hayashizaki authored
This reverts commit 02c7f5d5. Reason for revert: I expect crbug/906964 is fixed by reverting another CL, so relanding this. Original change's description: > Revert "Add referrer-policy module worker tests" > > This reverts commit ec589a5c. > > Reason for revert: crbug.com/906964 > > Original change's description: > > Add referrer-policy module worker tests > > > > This CL adds WPT tests for referrer policy applied to > > module worker top-level script fetch. > > > > The only manual changes are > > - referrer-policy/generic/common.js > > - referrer-policy/generic/referrer-policy-test-case.js > > - referrer-policy/spec.src.json > > and all other modifications are made by > > referrer-policy/generic/tools/generate.py. > > > > Bug: 880027 > > Change-Id: Ib1f9136161e8efacf317fb9b7e9ba0651a103c41 > > Reviewed-on: https://chromium-review.googlesource.com/c/1330906 > > Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> > > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#609589} > > TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org > > Change-Id: I0931159c0494b981a1d6b07232af55b20f68f559 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 880027, 906964 > Reviewed-on: https://chromium-review.googlesource.com/c/1344213 > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609731} TBR=hiroshige@chromium.org,nhiroki@chromium.org,jochen@chromium.org Change-Id: I48d40a578e06526558fc7a4733395e1e505b9694 Bug: 880027, 906964 Reviewed-on: https://chromium-review.googlesource.com/c/1344267 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#610256}
-
Ryan Hansberry authored
Bug: 907312 Change-Id: If3efbb895fa8ed77330e5879c8608ee92b8497ef Reviewed-on: https://chromium-review.googlesource.com/c/1345126 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#610255}
-
khachatryan authored
Disabling failing tests testDownloadDirectoryOverridesExistingPreferences and testExistingDevToolsPortFile on Waterfall on Windows build bot Bug: 907608:chromedriver:2673 Change-Id: I74adcfa17f6349aa74805e6905fa630661ea4a9b Reviewed-on: https://chromium-review.googlesource.com/c/1347613Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610254}
-
Toni Barzic authored
Removes oauth2_token_fetcher_ and auth_url_loader_factory_ from OAuth2LoginManager, as they are no longer used - the usage was removed in CL:1212962 BUG=None Change-Id: Ia025818376f239e406dd285cdd288dca164c0ed2 Reviewed-on: https://chromium-review.googlesource.com/c/1347447Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#610253}
-
Xi Cheng authored
Change-Id: I07f07f12c0799e1e93d648419ff2488fff5db2da Reviewed-on: https://chromium-review.googlesource.com/c/1347580Reviewed-by:
Xi Cheng <chengx@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#610252}
-
Owen Min authored
The option is read from the Registry with the same key as the enrollment token. The value is CloudManagementBlockOnFailureEnabled. Bug: 904983 Change-Id: Ia8bada4e79d236fb9f85320e38ed6588f34a5ad8 Reviewed-on: https://chromium-review.googlesource.com/c/1345211Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610251}
-
Darwin Huang authored
Helps fix errors in apps which prefer text/plain content while pasting over img, even though it is less spec-conformant to provide fewer types than possible. As noted in the crbug, these apps (ex. Messenger) generally prefer text/plain content due to compatibility issues with Microsoft Word. This does also make us more consistent with other platforms (ex. Windows/Linux), where we don't provide the text/plain field. Also moved a browser test to a layout test for future ease of testing. The browser test wasn't able to generate text/plain to reproduce the bug, due to images only previously producing text/plain output on images with alt text, and execCommand only operating on iframe DOM objects (not image DOM objects) Bug: 838808 Change-Id: I28b2d8d223c2448f47e887323afccae73d6bcf44 Reviewed-on: https://chromium-review.googlesource.com/c/1319032Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610250}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/eacc22d07da8..e89f85283d4c Created with: gclient setdep -r src-internal@e89f85283d4c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I90152301df4986c82048f98057fa78848fa65544 Reviewed-on: https://chromium-review.googlesource.com/c/1347076Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610249}
-
Antonio Gomes authored
BUG=907533 Change-Id: Ib8714aa26040bbfb9338454c5c327f9194a20d32 Reviewed-on: https://chromium-review.googlesource.com/c/1347149Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#610248}
-
Sean Kau authored
Bug: None Change-Id: If683748053284fd0912c4652481de1b37783f033 Reviewed-on: https://chromium-review.googlesource.com/c/1345547 Commit-Queue: Sean Kau <skau@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#610247}
-
Eric Karl authored
We currently track various GL values (format/type/swizzle) for each viz::Format on SharedImageBackingFactoryGLTexture. Depending on whether we plan to use TexStorgae2D or TexImage2D, we calculate these differently. With the ability to upload data at texture creation time, we need to dynamically chose TexStorage2D or TexImage2D. Rather than duplicate the calculate format/type/swizzle, this CL ensures that these were actually the same all along (and fixes some cases where they weren't). This lets us simplify our format info calculation logic a bit. Bug: 906794 Change-Id: I4c97aade94ecf267df8a1adfb45aeda8e14d1c12 Reviewed-on: https://chromium-review.googlesource.com/c/1345538 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#610246}
-
Joe Mason authored
Now there are an extreme number of permutations of test params, so this also splits off all the tests where the cleaner process does not start to cut down on redundant tests. R=csharp@chromium.org Bug: 907443 Change-Id: I015c02dd9ed72e3c5951acbdfc8163c89b1bc3ea Reviewed-on: https://chromium-review.googlesource.com/c/1347437Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Joe Mason <joenotcharles@google.com> Cr-Commit-Position: refs/heads/master@{#610245}
-
Xiaocheng Hu authored
This patch changes |PreviousSentencePosition()| to utilize |TextSegments| class to make it work with LayoutNG. Since the original implementation is a duplicate of |StartOfSentence|, so is the new implementation. Bug: 778507 Change-Id: I7ba9fe19c74ff87c121d6c2bfce7f28765976ca1 Reviewed-on: https://chromium-review.googlesource.com/c/1337282 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610244}
-
Jesse McKenna authored
Replace Sequence reference held by Sequence::Transaction from a scoped_refptr to a raw pointer, and replace the call to WrapUnique() in Sequence::BeginTransaction() to a move-constructor invocation. This change addresses a speed regression caused by https://chromium-review.googlesource.com/c/chromium/src/+/1327548. Bug: 889029 Change-Id: I7037f5863d4a9189a78434781e8593c10ac42713 Reviewed-on: https://chromium-review.googlesource.com/c/1340584 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#610243}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ea02708e078c..2ed782097044 git log ea02708e078c..2ed782097044 --date=short --no-merges --format='%ad %ae %s' 2018-11-21 reed@google.com use SkFont in a lot of places 2018-11-21 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-11-21 brianosman@google.com Use GrVertexColor in various oval ops 2018-11-21 bsalomon@google.com Disable sampler objects when using ES2 shading language on ES3 contexts. 2018-11-21 benjaminwagner@google.com Upgrade Windows in Skolo. 2018-11-21 caryclark@skia.org fix bookmaker Created with: gclient setdep -r src/third_party/skia@2ed782097044 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: Ib264c4a8c29f6add0a35bf3b3dc45fe3973d47a9 Reviewed-on: https://chromium-review.googlesource.com/c/1347513Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#610242}
-
Jesse McKenna authored
TaskScheduler: Move Sequence::traits() behind lock and add non-lock-protected shutdown_behavior() accessor Bug: 889029 Change-Id: I045aea22fb8d5a32fee3e3bd64c0b091c9336dd3 Reviewed-on: https://chromium-review.googlesource.com/c/1343178 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
-
Eric Willigers authored
Test computed values for various properties from - css-animations - css-shapes - css-transitions - css-ui - css-writing-modes - filter-effects Change-Id: Iad28fe2030f922bdcaa80d6ade383c69106b8822 Reviewed-on: https://chromium-review.googlesource.com/c/1345955 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#610240}
-
Becky Zhou authored
Bug: 907308 Change-Id: I472fdf61148d8f023a4b670d041593d3455c9f9f Reviewed-on: https://chromium-review.googlesource.com/c/1347048Reviewed-by:
-
Eugene But authored
This is a step in multistep refactoring. The next steps will be: 1.) web::NavigationContext::URL is never set to placeholder URL and always represents navigation URL 2.) Same web::NavigationContext will be reused for placeholder navigation to extend it's lifetime. 3.) WebStateObserver::DidFinishNavigation will be caller after placeholder navigation is finished and will use original web::NavigationContext passed to WebStateObserver::DidStartNavigation This will partially fix crbug.com/903497 and will call WebStateObserver::DidFinishNavigation after committed URL actually changed. Originally Reviewed-on: https://chromium-review.googlesource.com/c/1331044 Bug: 903497 Change-Id: I0ee2ecdfb4d20d2f14fd62e99028e8de1b81ff3b Reviewed-on: https://chromium-review.googlesource.com/c/1347212Reviewed-by:Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#610238}
-
siyua authored
This CL patched another CL by jsaul@ https://chromium-review.googlesource.com/c/chromium/src/+/1334834 1) Added No thanks button as required by legal. 2) Changed the title to better explain its usage. Uploaded screenshot in the bug comment#4. Bug: 905393 Change-Id: Idc6e2e89a9cad9d4f5530ea4d4a1b2731feeff5e Reviewed-on: https://chromium-review.googlesource.com/c/1343281Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#610237}
-
Max Moroz authored
1) Avoid using std::string as a container for non-string data. The problem is that the underlying std::string buffer is bigger than the data we put inside (at least by 1 byte (null terminator), and might be even bigger). This may hide buffer overflow errors from ASan. 2) Make FuzzedDataProvider portable (remove //base dependency). 3) Make the types it returns more explicit (e.g. `int32_t` instead of `int`). Bug: 907103, 906080 Change-Id: Ibe1cd5ef6cb72140459a8ba3ac301f8c2bef48b9 Reviewed-on: https://chromium-review.googlesource.com/c/1344993 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610236}
-
Gang Wu authored
Specifics: +62,440 bytes main lib size +467,552 bytes main dex size +745,805 bytes normalized apk size InstallSize: +280,953 bytes APK size +827,989 bytes Estimated installed size (Android Go) +2,169,863 bytes Estimated installed size InstallBreakdown (+2,168,374 bytes): +2,700 bytes unwind_cfi (dev and canary only) size +2,146 bytes Non-compiled Android resources size +62,440 bytes Native code size +353 bytes Package metadata size +2,086,323 bytes Java code size +14,412 bytes Compiled Android resources size Dex: +2,396 entries fields +3,284 entries methods +772 entries types +1,681 entries strings Change-Id: I173abfb7ba5c75d10ade40de047b7f0bba257763 Reviewed-on: https://chromium-review.googlesource.com/c/1344292Reviewed-by:Filip Gorski <fgorski@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#610235}
-
Kristi Park authored
Thumbnails have been deprecated as of M69. Removing the multi-iframe thumbnails used in third-party NTPs. Bug: 893362 Change-Id: I6dbc1ddf8a204d9661f437bb0b0db30888ec48dd Reviewed-on: https://chromium-review.googlesource.com/c/1324449 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#610234}
-
Becca Hughes authored
Add seek backwards and forwards buttons to the media notification. BUG=893296 Change-Id: If4a0263295e0b824a78f214e63a9747ba89db4c9 Reviewed-on: https://chromium-review.googlesource.com/c/1306734 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
-
Tony de Luna authored
The goal is to make Mobile network status be more apparent to the user, even when WiFi or Ethernet network is connected. To do this we now have independent tray network icons. One Tracks Wi-Fi, the other Mobile network state. This cl adds different rendering strategies for network icons in the system tray. In the future we may also want to allow Tethering icon to be displayed on its own. We can add a new strategy when the spec is ready. Feature is developed behind feature flag 'SeparateNetworkIcons'. Bug: 902409 Change-Id: I878aa4fbe02676bd235eba60979155fb57207175 Reviewed-on: https://chromium-review.googlesource.com/c/1340807 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mitsuru Oshima (OOO till 11/26) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#610232}
-
CJ DiMeglio authored
This CL makes using ReleaseSoon with scpoed_refptr easier. It encapsulates the call to AddRef, and forces the uses to use std::move when calling ReleaseSoon with a scoped_refptr. Both are required to make ReleaseSoon run safely (and correctly), but it isn't obvious that they are needed. An example of its use is included with this CL. Bug: 900010 Change-Id: Ic1de31d0433ffeee52d98b630cafe643c223ed18 Reviewed-on: https://chromium-review.googlesource.com/c/1306639 Commit-Queue: CJ DiMeglio <lethalantidote@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Bothing ScriptingPermissionsModifier and PermissionsAPI unittests convert URLPatternSets to strings for easy comparison (using gmock utilities). Extract this functionality into a shared method in permissions_test_util. Bug: None Change-Id: I54f681bc69d87c4ba20c8b2973159ef671f1bbe0 Reviewed-on: https://chromium-review.googlesource.com/c/1347100Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#610230}
-
Meilin Wang authored
Record the number of users who enabled/disabled Assistant service on their devices, the sum would be the number of all eligible users. Note that we simply report this metrics with every UMA upload and should only depend on unique users count to take advantage of the de-dupe logic implemented on the server-side. Ignore potential reboot or crash for now. Test: local compile and manually test. Bug: b:117518834 Change-Id: I5cee656db986f60104999502b4feebb8d072c79f Reviewed-on: https://chromium-review.googlesource.com/c/1292111 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#610229}
-
bsheedy authored
Removes three sources of flakiness in the existing VR RenderTest: 1. Switches the test page to a blank one, as the text on the original one sometimes resulted in several pixels being different due to AA. 2. Removes the flaky sleep while waiting for the permission prompt to appear in favor of a new waitForUiQuiescence. 3. Ensures that the UI is quiescent after accepting the permission before dumping the second image. Also drive-by changes several methods in NativeUiUtils to try/catch the call that throws an InterruptedException to make it less annoying to chain multiple actions together. Bug: 904012 Change-Id: Ic25432c947adeeba210c6c63b355a53c5c63ef14 Reviewed-on: https://chromium-review.googlesource.com/c/1344905Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#610228}
-
kylechar authored
HardwareDisplayController::GetRefreshInterval() was using the integer rounded refresh rate instead of a float value. The rounded refresh was used to construct PresentationFeedback, which ultimately gets used to set the begin frame and exo vsync interval. On veyron_minnie this changed the interval from 16819us to 16666us incorrectly. Bug: 907625 Change-Id: I0e7a2a776cdadfa0bb99b67735ab93beb90a0f63 Reviewed-on: https://chromium-review.googlesource.com/c/1347444Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#610227}
-
