- 15 Jan, 2021 40 commits
-
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610647094-405a32bcf15e5a84949640f99f84a5b9f61e2f2e.profdata to chrome-linux-master-1610668478-7d09cc584bcf96e72cb1514828da986e69ab213c.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ifb708c0149949bc5adf4a12566fda3eb650ad3fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631785Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843913}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610647094-3e6a9456ec2a4877d37636e99663c09557aba29f.profdata to chrome-mac-master-1610668478-7094d9e47d32a574227817d5f93a8aaa3dc9b368.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ia6540ce6ce0140b882460854ee99cae021153964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631210Reviewed-by:
-
David Black authored
Previously a ui::Layer was directly owned which doesn't handle the case of layer recreation which is handled by ui::LayerOwner. Bug: 1166959 Change-Id: I92efce13e7a8a48423547cf134214d6b23b5c371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631298Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843911}
-
Matt Menard authored
This ensures when the print-server-scaling flag is disabled that print servers acts identically for >16 servers as it does for <=16 servers. This fixes a regression. Bug: b:168650771 Change-Id: I6ed183bdb87fdd2440dea7893884310ccf5e60cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626118 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#843910}
-
Ted Meyer authored
Bug: 1109397 Change-Id: I3dbc859a10632cf2448c4f6f3bd28db6b708e8cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631468Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#843909}
-
Alan Cutter authored
This CL makes the "capture_links": "new-client" web app manifest setting behave like the existing experimental tabbed web app link capturing. This behavior is hidden behind the WebAppEnableLinkCapturing flag. Screencast: https://bugs.chromium.org/p/chromium/issues/attachment?aid=484716&signed_aid=tplWTvCmrc2w7LVRH_JXdA==&inline=1 Bug: 1163398 Change-Id: I34c525bb35b09f25b2dfca3237d8baec9d5a1010 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626618 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#843908}
-
Peter Kasting authored
Bug: 1159562 Change-Id: Iee1a5be31833c43b68e2516c0ee1872e0a567384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631351 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#843907}
-
David Black authored
Per UX instructions, the only UI appearing on hover should be the pin. Bug: 1166920 Change-Id: Ibdda78b1a60e83ec62ac381b30212dc57854c82e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631452Reviewed-by:
-
chromium-autoroll authored
Roll ChromeOS Bigcore AFDO profile from 89-4374.0-1610361443-benchmark-89.0.4386.0-r1 to 89-4374.0-1610361443-benchmark-89.0.4387.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-bigcore-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ia9a70820fe6d4d426a4c4702c0fc0ecaa994a8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631908Reviewed-by:
-
Ahmed Fakhry authored
BUG=1157997 TEST=Manual Change-Id: I1079920b3d3530f6ba263f7d2b8b2a92fd39e59c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631286Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#843904}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/5255c465bbba..aedd133cd85f 2021-01-14 amaiorano@google.com VulkanBenchmarks: fix memory leaks If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I87703384d27acc39eebbab56c252e6efc7ab136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629854Reviewed-by:
-
Xiaodan Zhu authored
This CL implements the unittest for reodering desks by drag & drop. This CL adds three helper functions: - LongTapOnDeskPreview - StartDragDeskPreview - DragDeskPreviewTo - DropDeskPreview The CL adds two unittests: DesksBentoTest.ReorderDesksByMouse and DesksBentoTest.ReorderDesksByGesture which test - Trigger drag & drop and reorder desks by mouse. - Trigger drag & drop and reprder desks by gesture. Change-Id: I295e393ef4fdcf94a242ba4ecb011bb8f44515d3 Bug: 1154038 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2609587Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Xiaodan Zhu <zxdan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843902}
-
Nancy Wang authored
Add browser tests for AppLaunchHandler to verify the restoration process. BUG=1146900 Change-Id: Ibeaf262080a24c680718888ee081cc62c5b21a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619245 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843901}
-
Lei Shi authored
Previously, resume_() will read content from the current sentence start to the end of the current paragraph, regardless of user-selected boundaries. This CL enables STS to read content from the current position to the end of the user-selected content. We use NodeUtils.Position as the anchors for start and end positions. This CL also refactors getNextNodesInParagraphFromNodeGroup, which is broken into getPositionFromNodeGroup and getNextNodesInParagraphFromPosition. Bug: 1166440 Change-Id: Iaad1b4d6c23f2508478f6547a6b0b95019518672 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627335 Commit-Queue: Lei Shi <leileilei@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843900}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 89-4380.0-1610362181-benchmark-89.0.4386.0-r1 to 89-4380.0-1610362181-benchmark-89.0.4387.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Idd1eb98c614f5f14862ea7fb1ca3ca1d1925c81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631907Reviewed-by:
-
Michael Thiessen authored
Implements LaunchCauseMetrics for launch types that don't involve intents - Recents, Back, and Power button. It's not possible to distinguish between Back and Recents in all cases. However, when the Activity is killed in the background, and then restored from Recents, Android adds a flag to the intent we can look at. Also, when Chrome does not receive a UserLeaveHint when going to the background, we can be sure that the Back button will not return the user to that Chrome Activity. We can detect resume by power button by looking at whether the screen is off when Chrome is paused. (If Chrome happens to be killed while the screen is off, the launcher is shown on screen on) These changes range from extremely difficult to impossible to integration test as you would need control of multiple apps for some, and the ability to manipulate the Recents screen in others. I've opted for unit testing here, and have manually tested every situation I could think of in both CTA and CCT. Bug: 1163961 Change-Id: I86a00dcf7333a22da724a1b26be2c5bcf5236cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625909 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843898}
-
Esmael El-Moslimany authored
The callout can be included in the initial OGB response. Whether or not a callout is included can depend on the number of impressions. By using the cached OGB, a user can see callout one more time than intended. Bug: b/176955522 Change-Id: I915370948339a8315a5024e79967defe5aa4c46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628743 Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#843897}
-
Benjamin Beaudry authored
This is a reland of 7d29603f Original change's description: > Expose NameProperty for listitems on UIA > > Elements with the listitem role should always expose their accessible > names with UIA. This was causing an issue with Narrator on Windows when > navigating by list item - Narrator would only announce "element x of N" > when it should actually announce "[listitem name], element x of N". > > This is per spec: https://docs.microsoft.com/en-us/dotnet/framework/ui-automation/ui-automation-support-for-the-listitem-control-type > > Bug: N/A > Change-Id: I4f2d1a999d00cc8f5b23989d3ade90c907764152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610264 > Reviewed-by: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Victor Fei <vicfei@microsoft.com> > Reviewed-by: Aaron Leventhal <aleventhal@chromium.org> > Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#843553} TBR=nektar@chromium.org TBR=aleventhal@chromium.org TBR=vicfei@microsoft.com Bug: N/A Change-Id: I0e6484ac768c06c21782ec119772659071d60027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628022Reviewed-by:
Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843896}
-
Keishi Hattori authored
Including const-char rewrites added lots of build errors and needs more time to be resolved. Bug: 1069567 Change-Id: Ib862d60d74c8501b937ad8071e3fc78d78b4054d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626691Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843895}
-
Jacques Newman authored
We currently dump when unserialize fails in BrowserAccessibilityManager::Unserialize, but I think having an aggregate count of each unserialization type will aid in catching and debugging these issues. Bug: 1131848 Change-Id: I32a122cfcc9d6f29bad69a4b8e8d022fd1518dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621958 Commit-Queue: Jacques Newman <janewman@microsoft.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Yuheng Huang authored
Bug: 1164464 Change-Id: I1bc7f4b5aaa1a3d1cf1b484e9e116039458b51c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625975Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843893}
-
Liquan (Max) Gu authored
Motivation: Now, payment handler supports pages of any mime type on Android. This exposes payment handlers to the vulnerabilities of some less maintained mime-types. In order to make payment handlers safer to use, this CL limits the mime types of payment handlers on Android by allowlisting. Changes: * Moved the WebContents user data setting logic into markPaymentHandlerWebContents() to payment_handler_navigation_throttle.cc. * Let both Android & desktop's payment handler coordinators use the method to annotate a payment handler web-contents. * Moved the throttle from //chrome/browser to //components to make it more convenient to depend on. Bug: 1165367, 1159267 Change-Id: Ibc75bad9b47b2586e4222c2556c4bf6fb6bd28cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614918 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843892}
-
Dominic Mazzoni authored
Bug: 1161541 Change-Id: Ie6c0614bc7fc4c53e341639a0b2635dd8414362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622654 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#843891}
-
David Black authored
Addresses two issues: 1. When shelf alignment/config changed any previews that were in the process of being removed were appropriately destroyed. However, we failed to call `OnOldItemsRemoved()` after so any new/existing items weren't animated/shifted into position. The result was missing and misplaced previews. 2. The translation calculation in `OnShelfConfigChanged()` was slightly off. Fixed with index based calculation. Bug: 1166804 Change-Id: Ifda6a6a4fa527bfc6753840a7257fc92c9446a20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631293Reviewed-by:
David Black <dmblack@google.com> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#843890}
-
Andre Vincent authored
Screenshots: screenshot/PJsKP6DzT2ecYab screenshot/3NPEiJuMVCY75hL Bug: 1166737 Change-Id: I94f7e714beb85550658f9c57d8030b4a52160c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630407Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
-
Anders Hartvoll Ruud authored
The DependsOnContainerQueries flag was already added to ComputedStyle, but until now nothing actually set it (outside unit tests). This CL sets the flag whenever we match a container query-dependent rule (regardless of the result of the query). Note that I'm deliberately avoiding mutation of ComputedStyle directly from ElementRuleCollector, since we're trying to get rid of the mutable reference. Hence the flag is transported via MatchResult instead. Note also that this doesn't quite work correctly for pseudo-elements: we need to mark in PseudoStyleForElements, and also handle dynamic_pseudo matches in ElementRuleCollector, but that will be done in a separate CL. Bug: 1145970 Change-Id: Id48bd88d3f0580c8f58802565bc77a7ff1497d2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627150 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#843888}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/d3664703dfa9..e75ecf38f24b 2021-01-14 tsepez@chromium.org Add tagging for fxjs per-isolate data. 2021-01-13 tsepez@chromium.org Fix typo in cpdf_occontext.cpp If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: Idf49e7def4bd8a567bb51bb7cc677021949629e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631207Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2241db8a1f6c..091f5ac0a64c 2021-01-14 sokcevic@google.com Use real default branch in gclient If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1156318 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I4e0ac49a960d915304ea662f02ce1bbb31bb208f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631585Reviewed-by:
-
David Van Cleve authored
This change disables RepeatableQueriesServiceTest.SignedIn_DefaultSearchProviderChanged because it's been failing every now and then on multiple platforms since at least November. R=mahmadi Bug: 1158533 Change-Id: I32acb06a8e55e99f0a504f94c4c73e6def1596da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631625 Commit-Queue: David Van Cleve <davidvc@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843885}
-
Keishi Hattori authored
cbor decoder's ELEMENT() macro is rewriting CheckedPtr without going through BackupRefPtrImpl::WrapRawPt() because it is reinterpreting the CheckedPtr memory as void*. This causes AddRef/Release mismatch so when we try to decrement the refcnt, we cause a UseAfterFree. Bug: 1154799 Change-Id: Ica91c688a310ce6e3e0f2c5d9f6fa2988699bb12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626608Reviewed-by:
-
Darren Shen authored
NativeInputMethodEngine can now commit some text and move the cursor to the beginning of the committed text in the same atomic operation. Bug: 1155331 Change-Id: I85007fc84af1574f834467a4bc0fd4df2c5fac10 Fixed: 1155331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626680Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#843883}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I27785425caddb41455f9007d567cf5e7daebb2e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630589Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - actions_controller.js - import_controller.js - import_controller_unittest.js Conversion of externs: //ui/file_manager/externs/command_handler_deps.js Bug: 1133186 Change-Id: I65d231c4c82fe92ac956845ab19b601b1636c8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629328 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843881}
-
Dominic Mazzoni authored
Android ignores AssistData from Chrome that doesn't arrive within 3.0 seconds. The Assistant team reports that this frequently times out with Chrome or WebView. To maximize the chances results are returned in time, set a timeout of 2.0 seconds to get the accessibility tree snapshot. Our underlying assumption here is that some results are better than no results. Note that we already had been using a limit of 5000 nodes, but the time to populate 5000 nodes wasn't very consistent. Using a timeout will be much more reliable. Bug: 1161541 Change-Id: I6dfa7c37f5dc11c5a4ccd69de8533b833de00e99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629406Reviewed-by:
-
Leo Zhang authored
Skip decoder check for the ime_spec when it's M17N request. Bug: 1166064 Change-Id: Ib02db10805d5c222c9767e54c46367b00096587d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626864Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843879}
-
My Nguyen authored
This reverts commit bca5f7be. Reason for revert: Tree is closed because of https://ci.chromium.org/ui/p/chromium/builders/ci/android-marshmallow-arm64-rel/24224/overview Original change's description: > Declare T as a base class of the BrowserAssociatedInterface<T> helper. > > When a class uses BrowserAssociatedInterface<T>, it should implement the > mojo interface T. Force that to be the case by making T a suclass of > BrowserAssociatedInterface<T>. > > Change-Id: Ide8ecd46c298ec86de57b229593ec7d6c4b6a3a7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629670 > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843845} TBR=avi@chromium.org,dcheng@chromium.org,reillyg@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I0dea0f28378f7256bdd09f8196315905b8803da8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631806 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843878}
-
Ajit Narayanan authored
While Select-to-speak uses the global TTS speech rate by default, it now allows users to override this rate if they want to use a specific rate for a specific type of content. This CL records the override speech rate multiplier used when speaking. AX-Relnotes: n/a Bug: 1143814 Change-Id: Ia2a5e8313d17f8abfbffc7b293af19e3b7b65018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606678 Commit-Queue: Ajit Narayanan <ajitnarayanan@google.com> Reviewed-by:
-
Henrique Ferreiro authored
The enum values were all in uppercase. This CL changes them to conform to the style guide: https://google.github.io/styleguide/cppguide.html#Enumerator_Names. Bug: 711332 Change-Id: I4bf4cff76d15509a088df2e022942e2f87b1b5f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626652 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#843876}
-
Toni Barzic authored
Also, clear the tray icon when hiding previews (as this cancels any pending update timers). BUG=None Change-Id: I9647ff70b3359bd803a434d39b64d3cd6f1186b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631193Reviewed-by:
-
Jeffrey Kardatzke authored
This fixes multi-slice content. The proper way of doing it is to aggregate all of the encryption parameters into one buffer for all the slices and send that. Previously it was sending an encryption parameter buffer for each slice. BUG=b:153111783 TEST=Encrypted H264/HEVC work with single and multi-slice Change-Id: I57abbc839d1c6878da7c6a13b8b6da9889329179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631466 Auto-Submit: Jeffrey Kardatzke <jkardatzke@google.com> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Commit-Queue: Jeffrey Kardatzke <jkardatzke@google.com> Cr-Commit-Position: refs/heads/master@{#843874}
-
