GitLab

The Autofill Recorder Extension records an action when a new page is
loaded as part of a button/link click, etc (in addition to the action
that performs that click).

I found that desktop no-ops this action, and that on iOS it also does
not need to be explicitly replayed, so I no-op it here as well. I am
discussing with Yiming the reason it is no-op'd on desktop, and will
add that information here when I receive it.

Change-Id: If5a2f49cf60995831dfae357c97de28266771ea2
Reviewed-on: https://chromium-review.googlesource.com/c/1307994Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604061}

This makes screen reader users aware that we've created bookmarks.

R=scottchen@chromium.org

Bug: 881937
Change-Id: I36f246768d6dfbf631860d1da0c043a6b7d20781
Reviewed-on: https://chromium-review.googlesource.com/c/1302494
Commit-Queue: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604060}

Benefits:
- No need to create a one-off base::Process instance, which involves
  duplicating the handle, to perform operations on the process.
     Existing use case: https://chromium-review.googlesource.com/c/chromium/src/+/1298345/6/chrome/browser/ui/hung_plugin_tab_helper.cc
     Upcoming use case: https://chromium-review.googlesource.com/c/chromium/src/+/1273257
- No need to use #ifdef in child_process_data.h/.cc.
- Less lines of codes overall.

Bug: 885293
Change-Id: I5f3434c1b0dc3985733764931d9d791dd60f2589
Reviewed-on: https://chromium-review.googlesource.com/c/1298345
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Brad Nelson <bradnelson@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604059}

https://webrtc.googlesource.com/src.git/+log/3b149e4be880..1a92cd7312ca


git log 3b149e4be880..1a92cd7312ca --date=short --no-merges --format='%ad %ae %s'
2018-10-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 34bb9a91..0cb3899c (603839:603959)
2018-10-30 mellem@webrtc.org Create a MediaTransportState enum and add a state callback to MediaTransport.
2018-10-30 emircan@webrtc.org Remove event wait logic from DesktopConfigurationMonitor
2018-10-30 alessiob@webrtc.org AGC2: renaming GainCurveApplier to Limiter.
2018-10-30 ilnik@webrtc.org Revert "Use only first payload timestamp for RTCP SR generation for audio"
2018-10-30 crodbro@webrtc.org Fix for clock reset repair.
2018-10-30 nisse@webrtc.org Delete StreamInterface::ReadLine.
2018-10-30 Peter) Slatala Update media transport settings struct
2018-10-30 terelius@webrtc.org Add support for field trials in peerconnection_client|server
2018-10-30 ilnik@webrtc.org Use only first payload timestamp for RTCP SR generation for audio
2018-10-30 terelius@webrtc.org Add field trial to enable the new RTC event log format.
2018-10-30 artit@webrtc.org Revert "Disabled TestPacketBuffer.SeqNumWrapOneFrame test due to clang update"
2018-10-30 robert@bares.me Always call ConvertToI420 with positive crop_height
2018-10-30 nisse@webrtc.org Delete OptionsFile class. Refactored only user, TurnFileAuth.
2018-10-30 srte@webrtc.org Makes PacketResult::GetSentPacket const.
2018-10-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 89ed1da2..34bb9a91 (603733:603839)
2018-10-30 nisse@webrtc.org Delete unused function rtc::Flow.
2018-10-30 artit@webrtc.org Add iOS SDK unit tests for nalu_rewriter
2018-10-30 kron@webrtc.org Propagate SDP negotiation of extmap-allow-mixed to RtpHeaderExtensionMap
2018-10-30 oprypin@webrtc.org Remove likely obsolete entries from WATCHLISTS
2018-10-30 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 03b56190..89ed1da2 (603619:603733)
2018-10-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 55624cc6..03b56190 (603513:603619)


Created with:
  gclient setdep -r src/third_party/webrtc@1a92cd7312ca

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:796889,chromium:none,chromium:887464,chromium:None,chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I6de52c483d648ac07efede2b984bc1b7228e6754
Reviewed-on: https://chromium-review.googlesource.com/c/1308696Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604058}

Also, adds some more logging.

TBR=sergeyberezin@chromium.org

Change-Id: I5649b748f193271538d049e0d4a1a013b910cd69
Reviewed-on: https://chromium-review.googlesource.com/c/1308992Reviewed-by: Sergey Berezin <sergeyberezin@chromium.org>
Commit-Queue: ericale <ericale@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604057}

Bug: 896790
Change-Id: I8fef79fbbd3790d344ad92170f506fe46feefdd6
Reviewed-on: https://chromium-review.googlesource.com/c/1308600Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#604056}

This changes AuthenticatorImpl to not erase the AAGUID from attestation
statements (but do erase the attestation object) whenever the request
was handled by a platform authenticator and
attestationConveyancePreference = "none".

Further, The TouchIdAuthenticator gets back its non-zero AAGUID that was
erased in 73a4f93c. Note that this means
TouchIdAuthenticator no longer performs "true" Self Attestation in the
sense of the WebAuthn spec or
AuthenticatorMakeCredentialResponse::IsSelfAttestation.

Hence, the existing behavior that self-attestation statments never get
erased, even if attestationConveyancePreference = "none", no longer
applies to Touch ID. Instead the new behavior applies, i.e. the
attestation object is erased but not the AAGUID.

Bug: 898233
Change-Id: I79f7957679c661a6d3b0fb54a3a48163b387d764
Reviewed-on: https://chromium-review.googlesource.com/c/1300687
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604055}

Removing paper-input, paper-textarea, iron-autogrow-textarea, paper-listbox.

paper-input was only used by paper-slider, if an "editable" boolean is set to
true, which is not the case for any usage of paper-slider. Removed that dependency
in the local paper-slider copy. Also remaining usages of paper-slider will be
replaced with cr-slider sometime soon anyway.

Also remove local patch for paper-input and paper-textarea from chromium.patch.

Bug: 899982,843350
Change-Id: If2e7815259034748db890ac736c32f064ff3c968
Reviewed-on: https://chromium-review.googlesource.com/c/1306346Reviewed-by: Scott Chen <scottchen@chromium.org>
Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604054}

Migrates the data_decoder service and its consumers away from
ServiceContext and onto ServiceBinding. This effectively changes
all DataDecoderService instances to be explicitly owned by their
embedders rather than being owned by a ServiceContext.

To support this, a simplified TestConnectorFactory setup is also
added, allowing tests to construct a factory which simply proxies
Service calls to service instances with no specific ownership
constraints.

Service and ServiceKeepalive have also been amended to better
support ServiceBinding usage in place of ServiceContext usage.

Finally, since it's relevant to data_decoder, this also begins
moving utility-embedded services away from the old and
unnecessary EmbeddedServiceInfo/Runner crud.

Bug: 891780
Change-Id: Iaa26ef0f47aa0b1dde9c69d64dda4caff36c7b82
Reviewed-on: https://chromium-review.googlesource.com/c/1298020Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#604053}

There are no flags to be updated.

(n/a) fix typos in comments.

Merge internal change: 218594881

https://chromium-review.googlesource.com/c/1307582/


Add a QUIC_BUG if QuicConnection::ProcessUdpPacket is called reentrantly.

Merge internal change: 218585302

https://chromium-review.googlesource.com/c/1307581/


This QUIC change includes two main changes:
1) Remove member variable is_last_packet_ietf_quic_ and last_header_format_ from QuicFramer. Instead, always use the form in QuicPacketHeader and add necessary plumbings
2) Stop exposing framer() to subclass in QuicDispatcher. No functional change expected, not protected.

Merge internal change: 218576597

https://chromium-review.googlesource.com/c/1307580/


Deprecate flag FLAGS_quic_reloadable_flag_quic_stream_too_long.

Merge internal change: 218374901

https://chromium-review.googlesource.com/c/1307579/


In QUIC, close a client connection when a version negotiation packet is received. Protected by FLAGS_quic_reloadable_flag_quic_no_client_conn_ver_negotiation.

It is the higher layer's responsibility to do the reconnection.

Note, this is mostly auto-merged, except 2 manual changes are needed in
net/quic/quic_chromium_client_session.cc and
net/quic/quic_chromium_client_stream_test.cc.

Merge internal change: 218334028

https://chromium-review.googlesource.com/c/1307578/


In QUIC, store connection version for buffered packets when CHLO arrives, and use this version when server processes buffered chlo to create connections. Protected by gfe2_restart_flag_quic_no_server_conn_ver_negotiation2 which replaces gfe2_restart_flag_quic_no_server_conn_ver_negotiation.

Merge internal change: 218329982

https://chromium-review.googlesource.com/c/1307593/


Change QuicEpollClock::Now() to monotonic. Protected by FLAGS_quic_reloadable_flag_quic_monotonic_epoll_clock.

Note the changes in quic/platform/impl are manually merged.

Merge internal change: 218268839

https://chromium-review.googlesource.com/c/1307577/


Quartc decides what to consume from QUIC's sequencer buffers.

Removes QuartcStream::deliver_on_complete and passes all readable data to
QuartcStream::Delegate::OnReceived() whenever OnDataAvailable() is called.

QuartcStream::Delegate::OnReceived() now takes a pointer to the first readable
region, the number of readable regions, and whether the FIN bit is present.  It
returns the number of bytes consumed by Quartc.

Quartc implements its current deliver_on_complete behavior by returning 0 bytes
consumed until |fin| is true, then reading and consuming all available bytes.

This gives Quartc the flexibility to handle data as it arrives without removing
it from QUIC's buffers.  Quartc will not consume data until an entire message
arrives.  Then it will consume the message, but leave any "extra" data (eg. the
start of the next message) in the sequencer.  Leaving incoming data in the
sequencer protects against OOM errors (flow control prevents unbounded buffers).

See go/quartc-data-channels (Wire Format and Ordered Delivery) for how this will
be used.

n/a (Quartc only)

FIG_CHANGESET=bf381313ab840c12b349c4b9f596867ebf189ead

Merge internal change: 218212797

https://chromium-review.googlesource.com/c/1307573/

R=rch@chromium.org

Change-Id: I6e24b9e984a3911648e9129688dab1ceadc48f7b
Reviewed-on: https://chromium-review.googlesource.com/c/1307584Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bin Wu <wub@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604052}

BUG=889545

Change-Id: I26c7a1425e793835107b34681596a9ad16f6a360
Reviewed-on: https://chromium-review.googlesource.com/c/1299781
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604051}

Change-Id: I5ebd8f06b073088e3f31927cb2cc9f166ef0038d
Reviewed-on: https://chromium-review.googlesource.com/c/1308015
Commit-Queue: Mike Reed <reed@chromium.org>
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604050}

Some GpuMemoryBufferPlatformHandle union members are used only on one
platform but are defined for all platforms. This CL restricts
platform-specific members to desired platform.

Bug: 863011
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I6c09e49db157d9d91dc5caeac939ca334f9054ba
Reviewed-on: https://chromium-review.googlesource.com/c/1290917Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Alexandr Ilin <alexilin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604049}

Bug: 863846
Change-Id: I391a15458f540165e78b86a306a782254d317727
Reviewed-on: https://chromium-review.googlesource.com/c/1306593Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joey Arhar <jarhar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604048}

Extracted cleanup from https://chromium-review.googlesource.com/c/chromium/src/+/1305891
after that CL avoided interacting with AtExitManager altogether in PS7+.

R=fdoray@chromium.org

Bug: None
Change-Id: I68cf448027784e3a8e7a907c04fb475a29c7ace5
Reviewed-on: https://chromium-review.googlesource.com/c/1308080
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604047}

This prevents the app being installed with bad metadata if something
isn't quite right.

Bug: 899088
Change-Id: If56c5096982a79e3172dc38f897e8a54af6857ec
Reviewed-on: https://chromium-review.googlesource.com/c/1303316Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604046}

Reviewed as part of https://chromium-review.googlesource.com/c/chromium/src/+/1161541

TBR=skyostil@chromium.org

Change-Id: I81973d090fe632b63a2cb5d501f32df13de795e2
Reviewed-on: https://chromium-review.googlesource.com/c/1308656Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604045}

This reverts commit c8ac2e2a.

Reason for revert: It seems like others are running into a problem caused by this. I'll investigate why I didn't see those same issues locally.

Original change's description:
> Reenable Vulkan validation
> 
> The Vulkan validation layer used to error when a platform-specific
> surface (in this case, a X11 surface) was used.
> 
> A build flag which enables the validation layer to recognize that
> platform-specific surface was missing.
> 
> When the Vulkan validation layers moved to ANGLE they also added this
> build flag. As a result, we can re-enable the validation layers on X11.
> 
> BUG=843346
> 
> Change-Id: Ifb634a60a1cd9698b5cf51e03b426a58b4387a5d
> Reviewed-on: https://chromium-review.googlesource.com/c/1300335
> Reviewed-by: Eric Karl <ericrk@chromium.org>
> Commit-Queue: Chris Blume <cblume@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#602961}

TBR=cblume@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 843346
Change-Id: I28d17d41426102380c7cb246514c08ba462ae248
Reviewed-on: https://chromium-review.googlesource.com/c/1308770Reviewed-by: Chris Blume <cblume@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604044}

sequence<AuthenticatorTransport> in allowCredentials is an optional
field. We should treat empty lists as if the transport option was
undefined.

Bug: 899045
Change-Id: Ifb45a505e428676b2c72b063f3c94d10f227d912
Reviewed-on: https://chromium-review.googlesource.com/c/1302014Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604043}

https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/1c1e749f0b51..6647884a130d


git log 1c1e749f0b51..6647884a130d --date=short --no-merges --format='%ad %ae %s'
2018-10-30 stevenperron@google.com Remove MemberDecorateStringGOOGLE during stript-refect. (#2021)


Created with:
  gclient setdep -r src/third_party/SPIRV-Tools/src@6647884a130d

The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I72b4fade1901838b21ed4f17ff530da64b0e73e3
Reviewed-on: https://chromium-review.googlesource.com/c/1308697Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604042}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I4643fef5a4ad5c43328131553f79484bd2f4a11f
Reviewed-on: https://chromium-review.googlesource.com/c/1309075Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604041}

A line was missing from android_chrome_strings.grd listing the
translation file for the 'bn' locale. The .xtb file is already
present and thus doesn't need to be added.

BUG=899819
TBR=govind@chromium.org, abdulsyed@chromium.org, jshin@chromium.org

Change-Id: I92c73465ebe0b965194f4e78ad2c17e6728800de
Reviewed-on: https://chromium-review.googlesource.com/c/1308937Reviewed-by: David Turner <digit@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604040}

The SDP negotiation operations - createOffer(),
setLocalDescription(offer), setRemoteDescription(offer), createAnswer(),
setLocalDescription(answer) and setRemoteDescription(answer) - can be
used in a "safe" or "unsafe" way when thinking about the default of
sdpSemantics changing from Plan B to Unified Plan.

In particular, it is "unsafe" to use complex SDP without explicitly
setting sdpSemantics, since this case results in SDP that is
incompatible between Plan B and Unified Plan clients.

This CL adds histograms for "safe", "unsafe" and "unknown" usage of SDP
for each operation.

Bug: 899747
Change-Id: I9a21e3190c3f35153e6e8f31fb63f775d2ea8d31
Reviewed-on: https://chromium-review.googlesource.com/c/1304558
Commit-Queue: Henrik Boström <hbos@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604039}

This relands commit 1e9af071.

The original commit and subsequent test failure uncovered a real
bug which only impacted Mash. In classic mode, frameless windows
don't act as a WindowState observer so they don't inform the app
of OS-triggered fullscreen changes and therefore
ShouldEnableImmersive() doesn't return true, allowing the test to
pass. It seems like a bug that the app doesn't know it's in
fullscreen just because it's frameless, but I will err on the side
of preserving existing behavior there.

In contrast, in Mash, frameless windows do update the app object
wrt changes in window state, therefore the implementation of
ShouldEnableImmersive must be enhanced slightly to explicitly
rule out frameless windows from being placed in immersive (as the
briefly failing test verifies).

The test passed before 1e9af071 simply because
the two different immersive mode properties lagged in respect to
one another.

TBR=tsepez@chromium.org
Bug: 640365

Original change's description:
> Merge two immersive mode window properties.
>
> aura::client::kImmersiveFullscreenKey is folded into
> ash::kImmersiveIsActive
>
> No bug here currently, but it's confusing to have two different
> properties that are both meant to indicate immersive mode is active.
>
> Also removed some unnecessary ash:: prefixes from //ash.
>
> Change-Id: I0c43873fa8f128c3799d32f2c479a1f2caa9a7cf
> Reviewed-on: https://chromium-review.googlesource.com/c/1298493
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: Evan Stade <estade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603778}

Change-Id: Id4a498cf7d6f721d6459bd75392564abbfda60b5
Reviewed-on: https://chromium-review.googlesource.com/c/1307842
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604038}

Android and iOS don't have the File security chip, and therefore still need to show
the file scheme. (Follow-up from https://chromium-review.googlesource.com/c/chromium/src/+/1274985.)

Bug: 818528
Change-Id: Ib42601f637a513d21c965bcbd48f8c66fcc5cc99
Reviewed-on: https://chromium-review.googlesource.com/c/1308077
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604037}

Passing profile allows us to create the profile on the fly
which is needed for using contact details from Payment Request.

Bug: 806868
Change-Id: Ia90efadc0e26304110b60fd930320c0f6111f9fa
Reviewed-on: https://chromium-review.googlesource.com/c/1301595
Commit-Queue: Lukasz Suder <lsuder@google.com>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604036}

This is a reland of 3b214250

Original change's description:
> Reland "[base] Harden base::JSONWriter::BuildJSONString"
>
> This is a reland of bbe71c7f
>
> Original change's description:
> > [base] Harden base::JSONWriter::BuildJSONString
> >
> > This change simplifies and hardens base::JSONWriter::BuildJSONString().
> > It replaces the old base::Value API with the new one, thus implicitly
> > replacing DCHECKs with CHECKs.
> >
> > Bug: 859477
> > Change-Id: I5aa68cbc1e5e241d7b7061da2fe7078ac2904ec8
> > Reviewed-on: https://chromium-review.googlesource.com/c/1304477
> > Reviewed-by: Robert Sesek <rsesek@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#603508}
>
> Bug: 859477, 900041
> Change-Id: I0111b5ac553736cdec5b7a163527bf3bb7cb9233
> Reviewed-on: https://chromium-review.googlesource.com/c/1306356
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#603889}

TBR=rsesek@chromium.org

Bug: 859477, 900041
Change-Id: I1a825493332a6889afe61897ee9007b651fe86e8
Reviewed-on: https://chromium-review.googlesource.com/c/1308196
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604035}

Added ability to create a DnsConfigOverrides with all values overridden
with DnsConfig defaults.  Makes it easier to override the full config
and not use any values from the base config at all.

Also improved handling within HostResolverImpl when the full config is
overridden (through the new flag or by having all values). When
everything is overridden, system config changes are ignored (do not
cancel pending requests) and we skip reading system config entirely.

Bug: 846423
Change-Id: I310b221caee2fc52443991a79597e162fc4354a8
Reviewed-on: https://chromium-review.googlesource.com/c/1307592
Commit-Queue: Eric Orth <ericorth@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604034}

Merge internal change: 218906384

R=zhongyi@chromium.org

Change-Id: Ieccc6cd9751574bb7b6f81c7bb285f7b84ddb555
Reviewed-on: https://chromium-review.googlesource.com/c/1306638
Commit-Queue: Victor Vasiliev <vasilvv@chromium.org>
Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604033}

Remove previous owners who are no longer involved with Smart Lock.

Change-Id: Ie66d361db1ce44e883d0e30cb5011069488710ce
Reviewed-on: https://chromium-review.googlesource.com/c/1308493Reviewed-by: Jeremy Klein <jlklein@chromium.org>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604032}

Instead of overriding AddChild in the box fragment builder to collect
break tokens, we can collect them in the base class when there is a
break token. Since line box children should not have break tokens
this should be fast.

Using the break tokens is still handled by the box fragment builder.

Change-Id: I3812f7d75730421a96d0c0f1c41a8d1794f59c71
Reviewed-on: https://chromium-review.googlesource.com/c/1289673
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604031}

When fragment-based BiDi reordering was implemented in
r524977 (CL:827043), we chose to run the reordering to ensure
more test coverage of the code.

As the code is now stabilized, change to run BiDi reordering
only when needed.

|ComputeInlinePositions()| can be optimized further by
computing positions as NGInlineLayoutAlgorithm adds children,
but it diverges RTL code further. We may consider it in
future if needed.

Bug: 636993
Change-Id: Ie7e2a365e50618678b4e08b176bf27e99a37cecf
Reviewed-on: https://chromium-review.googlesource.com/c/1306948Reviewed-by: Emil A Eklund <eae@chromium.org>
Commit-Queue: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604030}

Introduce a (yet) empty Mojo API between the browser and the
diagnosticsd daemon. Add implementation that bootstraps this Mojo
communication via a D-Bus call.

BUG=chromium:869377
TEST=manual

Change-Id: I49ab831768e305754d0f3db786861e92b60f46c7
Reviewed-on: https://chromium-review.googlesource.com/c/1288273
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604029}

https://android.googlesource.com/platform/external/perfetto.git/+log/2bc2ea919048..1b114f20625d


git log 2bc2ea919048..1b114f20625d --date=short --no-merges --format='%ad %ae %s'
2018-10-30 treehugger-gerrit@google.com Merge "perfetto: Add proto message for opaque chrome system traces"


Created with:
  gclient setdep -r src/third_party/perfetto@1b114f20625d

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I5f2635920de238dc6883571eff2ba8b3c0b48418
Reviewed-on: https://chromium-review.googlesource.com/c/1308694Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#604028}

This is the first step in adding a new cloud print interface, which will
communicate with the C++ CloudPrinterHandler.

Bug: 829414
Change-Id: I01c8cb25a7e42dae433833e6a6c0245ef6180626
Reviewed-on: https://chromium-review.googlesource.com/c/1308613Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604027}

Currently Bluetooth DBus clients use CallMethodWithErrorCallback which
takes two callbacks one for success and one for failure.

This patterns is hard to use for clients that implement a Mojo
interface for example BluetoothSystem, so this CL deprecates the methods
that take two callbacks and introduces one that takes a single callback.

BluetoothSystem will soon replace all other clients of these DBus
clients so it makes sense to move away from the two callbacks pattern and
to the single callback pattern which BluetoothSystem can more easily
use.

Bug: 870192
Change-Id: I703a8b8ed277bf94de6adbef6cb954ac66f2b602
Reviewed-on: https://chromium-review.googlesource.com/c/1293292Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604026}

Bug: 900301
Change-Id: I11ccd4325c0db0763f85dab45c0c242b5ed1491f
TBR: lazyboy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1308973Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604025}

This CL moves blocking policy to an anonymous function. It has no
intended behavior change.

Bug: None
Change-Id: I3ba807562a20d6a6fa59d633510b7c04a590e753
Reviewed-on: https://chromium-review.googlesource.com/c/1308433Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604024}

Fixes:

1. The timestamp field in the event traces has been made consistent
(between the Capture and OnBufferReceived trace events). This allows
pipeline tracking of individual frames (and fixes the 97-100% drop rate
bug).

2. Add BUILD.gn target dependencies to build browser PAK/resources that
are required in order to run the binary.

3. Allow thread-blocking in media::cast::test::UDPProxyImpl.

Bug: 789192, 816466, 806238
Change-Id: If606989e8ea5eea34fd25e58246ecb7dd9cb75d1
Reviewed-on: https://chromium-review.googlesource.com/c/1308103Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604023}

The CL for updating the visuals of how a deprecated operating system
should be displayed did not correctly pass along enough information to
be able to always have an up to date content description, which is
important for accessibility.

The state of whether an update badge should be visible or not is always
known at the time it has to be updated, so the state should be passed
in. The reason is that whether the badge is really visible or not might
be correct in all cases when the check happens.

This CL therefore goes back to how things were before the visual update
by passing the state in.

In addition, the menu item itself did not always have a correct
content description, but now it is forcefully set during decoriation
of the item.

Bug: 899695
Change-Id: I9f7e2d4cc6b60ccfaf95d7c07fc351c5c9e2a8ac
Reviewed-on: https://chromium-review.googlesource.com/c/1306399
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604022}