GitLab

[gcc] Fix build failure caused by error: multi-line comment [-Werror=comment] in focus_traversal_unittest.cc

gcc toolchain throws a warning for using a trailing '\' in a comment which begins with '//'.

clang toolchain doesn't throw any warning for this hence its not captured by our bots.

Compiler option -Wno-comment appended after -Wall fixes the above issue but results in having inconsistent
comments.

The code snippet at [1] cleverly avoids these warnings as shown.

[1] https://code.google.com/p/chromium/codesearch#chromium/src/extensions/browser/content_hash_tree.h&l=23

R=mgiuca@chromium.org
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/874663003

Cr-Commit-Position: refs/heads/master@{#314745}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/12753cc..a9d9de4

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/893233005

Cr-Commit-Position: refs/heads/master@{#314744}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/895083003

Cr-Commit-Position: refs/heads/master@{#314743}

There are two changes to make this work:
-Set the plugins width/height to 100%. We will soon be using this for the material layout as well.
-Allow MimeHandlerViewGuests to handle pinch gestures when they are full-page plugins.

BUG=453729

Review URL: https://codereview.chromium.org/904553002

Cr-Commit-Position: refs/heads/master@{#314742}

Also ship the LTO plugin header so we can build LLVM against it.

BUG=453195
R=thakis@chromium.org
CC=thestig@chromium.org

Review URL: https://codereview.chromium.org/899783003

Cr-Commit-Position: refs/heads/master@{#314741}

Revert of Move tracing namespace from base::debug to base::trace_event. (patchset #7 id:120001 of https://codereview.chromium.org/882673002/)

Reason for revert:
broken Memory.FYI TSan bot.
crbug.com/455530

Original issue's description:
> Move tracing namespace from base::debug to base::trace_event.
>
> After having transitioned all the tracing headers from base/debug/ to
> base/trace_event, this CL addresses the namespace move.
> In principle, this CL should only change the namespace of the
> base/trace_event files but the namespace used by the tracing clients.
> In order to achieve this, namespace aliases are appended to the
> trace_event headers, to make it so that clients can still refer to
> base::debug::TraceFoo, with that being aliased to
> base::trace_event::TraceFoo.
> The upcoming CLs will gradually migrate the clients to use the
> base::trace_event namespace and will remove the ns aliases.
> Unfortunately, this CL has also to update few tracing clients,
> in particular the ones having forward declarations. Forward
> declarations, in fact, cannot be aliased as the compiler sees them
> before the alias itself.
>
> See crrev.com/837303004 and the related bug for motivations and design doc.
>
> BUG=451032
> TBR=skyostil@chromium.org,jam@chromium.org
>
> Committed: https://crrev.com/97c5abba36f5ce473cd996fab74fbf5aa9bb5464
> Cr-Commit-Position: refs/heads/master@{#314657}

TBR=dsinclair@chromium.org,picksi@chromium.org,primiano@chromium.org,skyostil@chromium.org,ssid@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=451032

Review URL: https://codereview.chromium.org/904573002

Cr-Commit-Position: refs/heads/master@{#314740}

Resource message requests can be relatively expensive, particularly in
the induced work on the browser IO thread. Currently, there is no bound
on the rate with which such requests are dispatched from the renderer.
This leads to situations where the browser IO thread is flooded with
requests, potentially causing scroll jank and otherwise undesirable
stalls in the browser pipeline.

Introduce a ResourceMessageThrottler which intercepts and defers a given
resource message stream, depending on the state of the RendererScheduler.
When the RendererScheduler indicates that high priority work is
imminent/likely, requests will be throttled according to a configurable
dispatch rate.

Hook this throttling mechanism up to the ResourceDispatcher, limiting
the number of resource message requests/second during user interaction
to 180 (3 per frame at 60 fps) on Android, and 480 on desktop.

See goo.gl/H42AgQ for more design details.

BUG=440037,402136

Review URL: https://codereview.chromium.org/847883002

Cr-Commit-Position: refs/heads/master@{#314739}

r314575 removed a default `files` array on the `Internet Plug-Ins` Mac
bundle subfolder, so it was only added with disable_nacl=0

This adds an empty default array to match the targets below.

Review URL: https://codereview.chromium.org/877553010

Cr-Commit-Position: refs/heads/master@{#314738}

BUG=chromium:448415
TEST=validate_format, pretty_print

Review URL: https://codereview.chromium.org/901783002

Cr-Commit-Position: refs/heads/master@{#314737}

 - InputMethod.PkCommit.Index
 - InputMethod.PkCommit.Type

BUG=367631
TEST=None

Review URL: https://codereview.chromium.org/893313003

Cr-Commit-Position: refs/heads/master@{#314736}

Reverting back to using BGRA_8888 format to fix the following errors:
[0204/075331:ERROR:gl_image_linux_dma_buffer.cc(79)] Invalid format:
6408
[0204/075331:ERROR:vaapi_drm_picture.cc(110)] Failed to create GLImage

BUG=447798
TEST=Ran ./video_decode_accelerator_test and verified that the above
error isn't present anymore

Review URL: https://codereview.chromium.org/886353005

Cr-Commit-Position: refs/heads/master@{#314735}

This separates the code used to "host" the setuid sandbox binary from
the code used to run underneath it (i.e., the client).  The primary
motivation for this is so that lightweight clients (e.g., the BMM
non-SFI sandbox) can avoid all of the additional dependencies required
only for hosting the setuid sandbox.

TBR=mseaborn@chromium.org,nasko@chromium.org
BUG=455087

Review URL: https://codereview.chromium.org/877153005

Cr-Commit-Position: refs/heads/master@{#314734}

This removes some unused code and simplifies some dependencies. I'm planning to pull the audio code out into its own component, and it'll be clearer if I do minimal refactoring along the way.

Review URL: https://codereview.chromium.org/901753002

Cr-Commit-Position: refs/heads/master@{#314733}

Revert of Make Reflector Use Main Thread MessageLoop when in SingleThread (patchset #1 id:1 of https://codereview.chromium.org/899073003/)

Reason for revert:
Reason for revert:
Speculatively reverting to try to fix broken Mac 10.8 retina layout tests in Blink:
compositing/iframes/iframe-composited-scrolling-hide-and-show.html
compositing/iframes/overlapped-iframe-iframe.html
svg/as-border-image/svg-as-border-image-2.html
and more.

Original issue's description:
> Make Reflector Use Main Thread MessageLoop when in SingleThread
>
> When in using single thread with browser compositor, make reflector use
> main thread MessageLoop instead.
>
> Test with forced SW mirrored display on both Linux-cros build and Pixel.
> BUG=453732
>
> Committed: https://crrev.com/0b88b2372f1ad82c12656a4b9a17098470e576a1
> Cr-Commit-Position: refs/heads/master@{#314665}

TBR=danakj@chromium.org,weiliangc@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453732

Review URL: https://codereview.chromium.org/900133002

Cr-Commit-Position: refs/heads/master@{#314732}

Previously: when multiple permissions were requested, they could only
be toggled individually if the user clicked on "Customize."

Now: the bubble will always allow for customization if there are
multiple permissions in the request. it will be the default state.

BUG=440563

Review URL: https://codereview.chromium.org/885373004

Cr-Commit-Position: refs/heads/master@{#314731}

Recent changes (merging PDFium) have pushed some binaries over the limit.

BUG=453844
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/897163002

Cr-Commit-Position: refs/heads/master@{#314730}

7061d1a  Update GN files from previous commit as well.
1be2034  Initialize V8 outside of PDFium.
62120b7  Prevent base::CheckedNumeric from leaking outside of pdfium.
c32dac1  Replace CFX_SmartPointer cast operator with Get() method.
0c01ad0  Fix stack exhaustion in CPDF_DataAvail::HaveResourceAncestor()

BUG=455399
TBR=tsepez

Review URL: https://codereview.chromium.org/904513006

Cr-Commit-Position: refs/heads/master@{#314729}

This allows callers to pass a char* (string literal) or StringPiece
(lightweight substring) without having to explicitly construct a string
object.

Refactored the implementation to avoid an ugly const_cast and Boolean to
avoid mutating a const pointer. Updated tests to use char* literals, and
added some new tests to test the new edge cases.

BUG=455068

Review URL: https://codereview.chromium.org/895913004

Cr-Commit-Position: refs/heads/master@{#314728}

BUG=351501
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/875073004

Cr-Commit-Position: refs/heads/master@{#314727}

This CL makes StartPageView subclass View instead of
SearchResultContainerView. A new SearchResultContainerView has been
added as a child of StartPageView instead. This change will facilitate
further refactoring.

BUG=455059

Review URL: https://codereview.chromium.org/896063002

Cr-Commit-Position: refs/heads/master@{#314726}

Added max_transform_feedback_separate_attribs, max_uniform_buffer_bindings,
and uniform_buffer_offset_alignment to Capabilities.
These were introducted in GLES 3.0.

BUG=429053
TEST=gpu_unittests

Review URL: https://codereview.chromium.org/885013002

Cr-Commit-Position: refs/heads/master@{#314725}

This patch enables the following flow for throttled plugins:
1. Place real plugin on page, preroll for a few seconds until a keyframe is extracted.
2. On throttle, replace the plugin with a PluginPlaceholder. Set the extracted keyframe as the poster. Meanwhile, the real plugin is hidden, throttled, but still alive.
3. On clicking the placeholder, replace the placeholder with the original throttled plugin.

BUG=443810,403800

Review URL: https://codereview.chromium.org/866173002

Cr-Commit-Position: refs/heads/master@{#314724}

Revert of Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits (patchset #2 id:20001 of https://codereview.chromium.org/860283005/)

Reason for revert:
Speculatively reverting to try to fix broken layout tests in Blink:
compositing/iframes/iframe-composited-scrolling-hide-and-show.html
compositing/iframes/overlapped-iframe-iframe.html
svg/as-border-image/svg-as-border-image-2.html
and more.

Original issue's description:
> Set defaultPageScaleLimits before setIgnoreViewportTagScaleLimits
>
> setIgnoreViewportTagScaleLimits copies the default limits into the UA
> constraints. This was happening before the defualt limits were set during
> initialization so it was clamping page scale at [1,1].
>
> BUG=453377
>
> Committed: https://crrev.com/ebbcc53e21fbfe15a76fa7fbf6d14c84095880ee
> Cr-Commit-Position: refs/heads/master@{#314668}

TBR=aelias@chromium.org,sievers@chromium.org,bokan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453377

Review URL: https://codereview.chromium.org/897173003

Cr-Commit-Position: refs/heads/master@{#314723}

In case of an abort, a memory corruption was occuring because of a call to
Queue::Complete() after an operation is aborted, which is invalid according to
both documentation and a DCHECK.

This CL fixes the issue by avoiding calling Queue::Complete() for aborted
tasks.

TEST=Tested manually. Try to copy files from a ZIP archive with thousands of
     files, and abort during the operation.
BUG=454310

Review URL: https://codereview.chromium.org/882153006

Cr-Commit-Position: refs/heads/master@{#314722}

This is effectively a revert of http://crrev.com/136205 , switching back to
searchdomaincheck "format=domain" from "format=url", but this time using HTTPS
instead of HTTP. Note that in general this should have no visible effect, since
for Chrome 25+ searchdomaincheck is supposed to be sending "https..." URLs
anyway. The only difference is that, if searchdomaincheck is never accessed,
the "out of the box" default value for the Google homepage switches from
"http://www.google.com/" to "https://www.google.com/".

This shouldn't cause any additional bustage to existing users, since Google
search over HTTP will just redirect to HTTPS anyway, so anyone whose network
doesn't support HTTPS accesses is already seeing broken behavior. (For the same
reason, this means even the "out of the box default" change noted above
shouldn't really be visible to end users.)

It's still possible for users to "downgrade" Google searches to HTTP using the
nosslsearch mechanism, but that's not in scope for Chrome to address.

BUG=364183
TEST=none
TBR=isherman

Review URL: https://codereview.chromium.org/263023002

Cr-Commit-Position: refs/heads/master@{#314721}

Prior to this change bookmark apps were created as soon as the user
started the process. If the user quit the process the app was then
removed. This made the flow feel strange, and also caused any matching
app that previously existed to be deleted if the user quit the process.

BUG=438019

Review URL: https://codereview.chromium.org/899443002

Cr-Commit-Position: refs/heads/master@{#314720}

linux and android should share same yasm defines and include_dirs,
just as src/third_party/libjpeg_turbo/libjpeg.gyp does.

BUG=455151

Review URL: https://codereview.chromium.org/893413002

Cr-Commit-Position: refs/heads/master@{#314719}

Changes in https://codereview.chromium.org/807593005/ broke Closure Compilation.

BUG=427670, 452870

Review URL: https://codereview.chromium.org/895283002

Cr-Commit-Position: refs/heads/master@{#314718}

BUG=450268
R=inferno@chromium.org,tsepez@chromium.org

Review URL: https://codereview.chromium.org/900483002

Cr-Commit-Position: refs/heads/master@{#314717}

Added code to open autofill settings page.

If "Chromium Autofill Settings" option" is selected from autofill menu
autofill forms settings page should be opened.

Please enter the commit message for your changes. Lines starting

BUG=454779

Review URL: https://codereview.chromium.org/896653007

Cr-Commit-Position: refs/heads/master@{#314716}

This will help in tracking down window resize bugs.

R=enne, vmpstr
BUG=454333

Review URL: https://codereview.chromium.org/864713004

Cr-Commit-Position: refs/heads/master@{#314715}

To match the recent change in MathUtil::AddToTracedValue,
pass name as parameter and Begin/End internally.

R=danakj

Review URL: https://codereview.chromium.org/898663003

Cr-Commit-Position: refs/heads/master@{#314714}

[DOMStorage] (recommitting) Offset the session storage namespace ids generated by different contexts to help identify when an id from one is mistakenly used in another.

>> Committed: https://crrev.com/36dcef3da5317365ab95e50a5f6b7fa98ada1d5e
>> Cr-Commit-Position: refs/heads/master@{#314256}
>
> Reverted: https://crrev.com/7bdc4a49e605261b60ee1339f93e835d853bf645
> Cr-Commit-Position: refs/heads/master@{#314274}

Review URL: https://codereview.chromium.org/881253004

Cr-Commit-Position: refs/heads/master@{#314713}

Initial checkin for the app remoting test driver tool.  The external pieces of the test driver will consist of a common library which will build the dependencies and core helper classes and a minimal version of the tool which will include a minimal number of tests.  An internal version of the tool will include the common library and pull in additional tests from src-internal.

The tool uses the GTest framework and this CL is to set up the foundation
so I can start adding functionality.  I am not hooking it into the public gyp
files yet, that will come in a future change as more changes to the
remoting GYP files are expected.

BUG=

Review URL: https://codereview.chromium.org/900973002

Cr-Commit-Position: refs/heads/master@{#314712}

Currently keystrokes while a menu is open are sent to the window hosting
the menu, since it remains `key`. Menus are a different window, so this
causes all the Menu* interactive_ui_tests to fail since they simulate
pressing ESC to dismiss the menu in the tests.

Other platforms insert an event dispatcher into the message pump for the
nested run loop that shows a menu, and redirect KeyDown events to the
MenuController.

On Mac, events need to be mapped to "Action" messages by an NSResponder
to obey platform behaviour and user customizations (e.g. a "Home"
keypress should be interpreted as beginning of document, not beginning
of line).

The approach in this CL is to check in BridgedContentView, an
NSResponder, for an active menu that should be receiving events instead.
Action messages are mapped to the KeyCode that toolkit-views expects for
that action, and the MenuController is given an opportunity to swallow
the event or have it sent on to the key window.

Gets the following interactive_ui_tests passing:
MenuControllerMnemonicTest*{NoMatch,TitleMatch,MnemonicMatch}
MenuItemViewTestRemoveWithSubmenu{0,1}*
(and all Menu interactive UI tests pass after this).

BUG=403679

Review URL: https://codereview.chromium.org/866983006

Cr-Commit-Position: refs/heads/master@{#314711}

BUG=450601
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/901583003

Cr-Commit-Position: refs/heads/master@{#314710}

BUG=454834
TBR=ppi@chromium.org

Review URL: https://codereview.chromium.org/897173002

Cr-Commit-Position: refs/heads/master@{#314709}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/d2a6f4e..12753cc

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/903503003

Cr-Commit-Position: refs/heads/master@{#314708}

There are some UMA strings, enum constants in iOS repository
that can be shared with Android, so moved to components.

BUG=452254

Review URL: https://codereview.chromium.org/891493003

Cr-Commit-Position: refs/heads/master@{#314707}

It looks like the GetFontData patch for PDFium is only used on XP/Vista now. Previously PDFium was in a separate binary so we were just calling the real GetFontData from chrome_child.dll. That doesn't work anymore, so use the original function pointer.

BUG=455399

Review URL: https://codereview.chromium.org/903583002

Cr-Commit-Position: refs/heads/master@{#314706}