GitLab

Both Chrome and Firefox pass the test

Bug: 1034538
Change-Id: I3e43cf22a1ed9ce8d4d10aca5250dcbf243ebb84
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985813Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Hao Sheng <haozhes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729438}

Crash reports show a crash occurring in PrintRenderFrameHelper when
OnPrintPreviewDialogClosed() is called. Add CHECKs to determine the
cause of the crash.

Bug: 1019847
Change-Id: I0110438b3b1db93bebdd0122a32ea34b064875d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1979011
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729437}

In order to investigate page-loading performance it is helpful to get
the First Contentful Paint message. This is emitted in the loading
category of chrome://tracing events. This change adds loading to the
list. A separate change modified UIforETW to add this and the recently
added media flag so that these categories can be conveniently
requested, and this change was used to test the loading flag.

Bug: 927165
Change-Id: I0c0a41d3fae1a8aa33ee0771c013821dd888684a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990421Reviewed-by: Jesse McKenna <jessemckenna@google.com>
Commit-Queue: Jesse McKenna <jessemckenna@google.com>
Auto-Submit: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729436}

Adds WebState as a parameter to InfobarBadgeTabHelperDelegate's addInfobarBadge:.
Then BadgeMediator returns early if the WebState passed is not the same as the
WebStateList's active WebState. This prevent a situation where an inactive WebState
gets a new Infobar and the BadgeViewController then adds its badge to the UI
even though there is no such Infobar for the currently active WebState.

Fixed: 1039668
Change-Id: I1eaf5aae4385d372d025dddce72a362e521fece0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989993
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729435}

Extend the lifetime of the histogram until M90, and update owners.

Bug: 1036997
Change-Id: I9a52049a5403422c7737ee44304954ec3e565d6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985959Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Auto-Submit: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729434}

https://chromium.googlesource.com/catapult.git/+log/28c4ea91f668..9506caf2ea1f

git log 28c4ea91f668..9506caf2ea1f --date=short --first-parent --format='%ad %ae %s'
2020-01-08 sullivan@chromium.org Fixed speed index computation in case of zero visible area.
2020-01-08 khokhlov@google.com Revert "telemetry: Increase timeout for trace collection."

Created with:
  gclient setdep -r src/third_party/catapult@9506caf2ea1f

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1027667,chromium:1039734
Tbr: oysteine@google.com
Change-Id: I4aad96525abcf98ab436ac740de182fcef3e0259
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992001Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729433}

Now that viz hit testing has been launched, some of the related metrics
should be deleted.

Note that the following metrics could help with future improvement by
making more hit tests synchronous therefore they are not deleted.

 - Event.VizHitTest.AsyncHitTestReasons
 - Event.AsyncTargeting.AsyncClientDepth
 - Event.AsyncTargeting.ResponseTime

Bug: 1037067, 1037081
Change-Id: I2f416e629804ca150c515513cd23fcd31de3cfc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988413Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729432}

This reverts commit ea98315a.

Reason for revert: Did not fix the test failures

Original change's description:
> Revert "Add media_devices.typemap Blink variant"
> 
> This reverts commit 086dd4c4.
> 
> Reason for revert: Suspecting it to cause the consistent crash of several media_unittests on Linux CFI. See crbug.com/1040107 for more info.
> 
> Original change's description:
> > Add media_devices.typemap Blink variant
> > 
> > Now the conversion between
> > blink.mojom.FacingMode <-> media::VideoFacingMode is allowed.
> > 
> > BUG=704136
> > R=​dcheng@chromium.org, haraken@chromium.org
> > 
> > Change-Id: Ida3e7a47ea915f0747b64c004ad044c67b078035
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989927
> > Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> > Reviewed-by: Kentaro Hara <haraken@chromium.org>
> > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> > Cr-Commit-Position: refs/heads/master@{#729202}
> 
> TBR=dcheng@chromium.org,haraken@chromium.org,tonikitoo@igalia.com
> 
> Change-Id: I5dcd9fd57b29f88c8f0ffb114f0cd3135e562220
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 704136
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990312
> Reviewed-by: sebsg <sebsg@chromium.org>
> Commit-Queue: sebsg <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729340}

TBR=dcheng@chromium.org,haraken@chromium.org,sebsg@chromium.org,tonikitoo@igalia.com

Change-Id: I185e76b268183a68e7607e4ec072d030ce741aaa
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 704136
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992262Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729431}

When start surface is enabled, click back button may close the last tab and show start surface

Bug: 1035338
Change-Id: I8c00458696f215047af28091ec9d099c3236b939
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974811Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729430}

Set enable_swiftshader_vulkan = false can save build time on Linux.

Bug: 1001433
Change-Id: I55a60e6f3f2f47fc339a794aa27c221ab7309a95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991088
Commit-Queue: Peng Huang <penghuang@chromium.org>
Commit-Queue: Saman Sami <samans@chromium.org>
Reviewed-by: Saman Sami <samans@chromium.org>
Auto-Submit: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729429}

When the --export-tagged-pdf flag is enabled and
when exporting a PDF using Chrome Headless, generate
a tagged (accessible) PDF instead of an untagged one.

The details are described in the design doc:
https://docs.google.com/document/d/1ku6QNtAHEqVnRGqFzpmlMe1fowkjCX9miHj8Kx1cFlk

In a nutshell, PrintRenderFrameHelper captures a
snapshot of the accessibility tree for the page and
returns it in the metafile. This snapshot includes
blink DOMNodeIds. In addition, we ensure that all
text drawing commands captured for printing also
include DOMNodeIds (this was originally added to
support content capture). Finally,
printing::MakePdfDocument is modified to convert the
accessibility tree into a structure tree and pass
this through to Skia.

A follow-up change adds an end-to-end test of
generating a tagged PDF using Chrome Headless:
http://crrev.com/c/1970744

Bug: 607777

Change-Id: Ib2bfa2de94f622c766c4b4c73c013437e404bbde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970742
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729428}

Encountered this while working on emulator test failures. The current
logic parses parameterized test failures as UNKNOWN because of the
GetParam() portion of the log line. This CL updates and documents
the regex responsible for parsing those lines.

Change-Id: Ia4339a6c03cd928bdd46f1103f0d6964f12935d0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990474Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729427}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/622690c9..07c5cd8f

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: Iee3473867300fe856d15fbe36883f1bb413ec03c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991406Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729426}

Bug: 1040153
Tbr: ryansturm@chromium.org
Change-Id: Ib35e85fd6583ad4894956902b036c6a71dd025ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991922Reviewed-by: sebsg <sebsg@chromium.org>
Commit-Queue: sebsg <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729425}

https://skia.googlesource.com/skia.git/+log/fa424b2e6a34..403c80797189

git log fa424b2e6a34..403c80797189 --date=short --first-parent --format='%ad %ae %s'
2020-01-08 reed@google.com Revert "Revert "Extend SkCanvas matrix stack to be 4x4, but with (basically) the same public API.""
2020-01-08 michaelludwig@google.com Revert "Avoid loop-dependent behavior in GrMemoryPoolBench"
2020-01-08 michaelludwig@google.com Avoid loop-dependent behavior in GrMemoryPoolBench

Created with:
  gclient setdep -r src/third_party/skia@403c80797189

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC jvanverth@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: jvanverth@google.com
Change-Id: I217b1e36b2e7e69025ad3ff090f4287289313cb1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991720Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#729424}

BUG=1028382
R=twellington@chromium.org

Change-Id: I13654e36ffa86507872507258e53a5345a1358de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990489Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729423}

This is part of a code cleanup effort to make callbacks explicitly Once or
Repeating.

dbus::PropertySet objects will call PropertyChangedCallback objects repeatedly
when properties are upaded.  The PropertyChangedCallback type is already
a base::RepeatingCallback.  base::BindRepeating is appropriate for any clients.

Also, several unecessary static_casts were removed.

Bug: 1007780
Change-Id: Id1f145a3cfff2dcb7ec8f80b5ae0fffae0e081ed
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984708
Commit-Queue: Vincent Scheib <scheib@chromium.org>
Reviewed-by: Miao-chen Chou <mcchou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729422}

Reorder methods so that order in .h and .cc files matches.

Remove unused private method MaybePrependErrorCode.

Remove bogus comment from MakeResponseHeadersPacket() definition.

Change-Id: Ie28bae97ee9d3a3c0c14cf613641b9cf7fedaf23
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987499
Auto-Submit: Bence Béky <bnc@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729421}

Bug: 1035361
Change-Id: Ica3738aefd81e287e4fdafd0a46c6afa42fb5d05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986692Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729420}

The computed color stop position difference can snap to float infinity.

Clamp to FLT_MAX to avoid triggering DCHECKS.

Bug: chromium:1038236
Change-Id: Ie3f34281aba9c4a9d3d5b7bc2361fbe64cea2198
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990857
Commit-Queue: Florin Malita <fmalita@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#729419}

Change-Id: I7ce6db2f85bd0261304935e4f3aa062de51f1783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981110
Commit-Queue: Nathan Parker <nparker@chromium.org>
Reviewed-by: Bettina Dea <bdea@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Auto-Submit: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729418}

When a navigation request was redirected, and the redirect uses an
interceptor, we did not call ResetForFollowRedirect() on the
ThrottlingURLLoader. This is necessary when a redirect will be handled
by restarting the loader instead of continued by calling
FollowRedirect().

Bug: 996940
Change-Id: Ib6ce7f133ae4c5ab5704a6a3c19a4788c85b5227
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989992Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729417}

This reverts commit 32a046ff.

Reason for revert: Fixed bug that broke test.

Original change's description:
> Disable system_health.common_mobile/browse:news:washingtonpost:2019 on android-go
> 
> NOTRY=true
> TBR=crouleau@chromium.org
> CC=​charliea@chromium.org,sullivan@chromium.org,tdresser@chromium.org,chrome-speed-metrics-dev@chromium.org
> BUG=1039734
> 
> Change-Id: I0a112a23ea6100bd244fc07a5de05f052aa5c2f6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989749
> Reviewed-by: Stephen Nusko <nuskos@chromium.org>
> Commit-Queue: Stephen Nusko <nuskos@chromium.org>
> Auto-Submit: Stephen Nusko <nuskos@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#728962}

TBR=crouleau@chromium.org,nuskos@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1039734
Change-Id: Ibeb4c3ee867048eabdf02c465bf93e2f0dd7cc12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991943Reviewed-by: Annie Sullivan <sullivan@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Annie Sullivan <sullivan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729416}

Bug: 1033461, 1037786, 1038213, 1038863
Change-Id: I22b98c909e9af632818bed4e49f96b028f1dcf28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990216Reviewed-by: Chris Mumford <cmumford@google.com>
Commit-Queue: Darwin Huang <huangdarwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729415}

Convert the initiator into a SiteForCookies object in order to be able
to take advantage of the IsFirstParty() member function. This change
allows us to replace the existing code which performs a similiar check.

Change-Id: I942cd96b37c21bf47403e6507938b95cbe207890
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990222Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Commit-Queue: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729414}

During GLES2DecoderImpl::Initialize, we must call Destroy in any failure
case. This used to be done manually, which lead to us missing it in a
couple places.

This CL adds a helper class DestroyOnFailure, which ensures we always
call Destroy on exiting.

Bug: 1039884
Change-Id: I135092f4194d6470239b3ff40ebca63be8d2fa67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989889
Commit-Queue: Khushal <khushalsagar@chromium.org>
Auto-Submit: Eric Karl <ericrk@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729413}

This supported out of process profiling but this is now back
in the browser, so this sandbox type is not needed.

Also removes |g_use_localtime_override| from libc interceptions
which was the only thing controlled by the kProfiling sandbox type.
This global defaulted to true so it is safe to remove it from the
compound checks that used it.

BUG=772503

Change-Id: Id1639c595d10ef414be36fc1d62fd58864db002c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988916
Commit-Queue: Alex Gough <ajgo@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729412}

apkbuilder.py was failing with:
  zipfile.BadZipfile: File is not a zip file

Regressed in b2706770

NOTRY=true  # Expediting. All relevant tryjobs have passed.

Bug: 1039832
Fixed: 1039832
Change-Id: I0b5b0979bcf9d3f7924129034a62c28937c0424b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989494
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729411}

The new message is not so confusing and gives concrete recommendations
on how to fix the error.

Bug: 1040118
Change-Id: Ic6bb80505da6118045a55f643ae9529630cb0d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991430
Commit-Queue: Mikhail Khokhlov <khokhlov@google.com>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729410}

Remove TODO(crbug.com/919536) and add a setTimeout(0) (as
requestAnimationFrame() used in runAfterLayoutAndPaint doesn't
work in a hidden page). We used setTimeout before we changed the
test in crrev.com/c/1395193/16/third_party/blink/web_tests/fast/webgl/webgl-composite-modes-tabswitching.html.

Bug: 919536
Change-Id: I50ce99ad684c06eea58d9c8cedf71d21c649c0f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1991942Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729409}

Change-Id: I9a52f0d269b5d28592f48d13c8aba6d723562ac2
Bug: 1036503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978879Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729408}

This CL removes the buildflag as component/exo target can be built
when ozone is enabled.

Bug: 138682668
Test: CQ
Change-Id: I9cadbf54825ae53faa8b6beee84d9ca7dfbe8333
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989378Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Jiaqi Han <jiaqih@google.com>
Cr-Commit-Position: refs/heads/master@{#729407}

The TSAN log shows that the issue is that the test's WriteFDWrapper
is using the |pipefds_| on |io_thread_| unsynchronized with the main
thread closing the pipe from TearDown().

Joining the test's |io_thread_| solves the issue.

R=fdoray@chromium.org

Bug: 955440
Change-Id: Ifc4966518d2e6abce4d0a3cd8b301e3241a057f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1990340
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729406}

This patch effectively relands the logic reverted in
https://chromium-review.googlesource.com/c/chromium/src/+/1864800 which
caused crashes in the past (CHECK failures).

In this new form, the underlying issue is addressed: for users that
don't use GUID-based merging of bookmarks, local GUIDs are reassigned
randomly to avoid GUID collisions in the local bookmark model.

Bug: 978430,1004205
Change-Id: I812d1cfe1c12b766799e6c5ec238f95fd16139ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983231
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729405}

Pointer Capture in Exo was initially implemented by using SetCapture()
on the aura::Window. This delegates all input events (touch, keyboard,
mouse, etc.) to the capture window, meaning that the user will not be
able to interact with anything outside the window with any form of
input.

Rather than relying on SetCapture(), we set a pre-target handler that
receives and consumes all mouse events when pointer capture is enabled.

  exo_unittests

Bug: b/146164376
Test: manual testing on ARC++ P using ArcPointerCaptureTestApp.apk;
Change-Id: I99bcda823ce662e39a91920af98ae09d715bbc38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966007
Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org>
Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729404}

As discussed in [1], cookies with empty names and empty values should be
rejected. This patch removes the carveout made in https://crbug.com/601786,
and adjusts unittests accordingly.

This patch does not change the WPT expectations; we'll do that at the same
time we change the spec. In the meantime, we'll check in local expectations
matching the behavior we believe is correct.

[1]: https://github.com/httpwg/http-extensions/issues/159#issuecomment-569233866

Bug: 1037996, 601786
Change-Id: I53319cee385efff019b313479184236c53b1d783
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982549Reviewed-by: Lily Chen <chlily@chromium.org>
Commit-Queue: Mike West <mkwst@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729403}

Some tweaks to the MacOS permission wizard:
* Reduced icon size in the dialog (without affecting the dock icon).
  This selects the 64x64 icon from remoting_host.icns.
* Reduced vertical spacing between buttons and text.
* Horizontally centered the "All Set" text within the area occupied by
  the instruction text. Currently, the window does not shrink when the
  text is replaced with shorter text (because resizing the window
  causes it to jump somewhere else).
* Fixed incorrect vertical position of "OK" button on final page.

Bug: 1032157
Change-Id: Iedc9a0640200bc2a4152b931f572d35fb3e76312
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980973
Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org>
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729402}

This CL fixes the bug that TemplateURLObserver and
TabmodelSelectorObserver are not added correctly.

Before:
Logo visibility is not updated with SearchProvider.
Incognito state is not updated before toolbar is first shown.

Bug: 1039587, 1039616
Change-Id: If0775117ac35a61c61f34d5de8e42ca91b895491
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989000
Commit-Queue: Mia Glaese <glamia@chromium.org>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729401}

Skip global-interface-listing.html on linux_layout_tests_layout_ng_disabled bot
since it needs to be updated frequently but people forget.

Bug: 1034944
Change-Id: Iaff55bf2d3ab9a110137ff6d8e64b7325c3b684f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988359
Commit-Queue: Rob Buis <rbuis@igalia.com>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729400}

This adds some CHECKs to help investigate issue 1034017.

It also includes some cleanup of ResourceBundle and updates some
header comments to make it more clear that null might be returned.

Bug: 1034017
Change-Id: I4b5717253b379c9d92aa8bd9bc9732df1ff880f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1974950Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Dan Beam <dbeam@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#729399}