- 23 Nov, 2020 40 commits
-
-
Victor Hugo Vianna Silva authored
If the kSendTabToSelfWhenSignedIn feature is enabled, IsReceivingEnabledByUserOnThisDevice() will now return true both for signed-out and signed-in but not syncing users. This WAI since this information will never be sent to other clients unless the user is actually signed-in and sync-the-transport is running. It's hard to use to the SyncService API in this layer due to cyclic dependencies between DeviceInfoSyncService and ProfileSyncService. So the code still relies on the state of SyncPrefs, particularly IsFirstSetupComplete and SyncRequested. Bug: 956722 Change-Id: I60318e730a250c48d73417b71a2f23b263d665ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526426Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#830204}
-
Antonio Sartori authored
The Content-Security-Policy keyword 'self' in a source expression is a placeholder for allowing sources with the same origin as the document. Even if the document is sandboxed (i.e. has a unique opaque origin), the keyword 'self' should match the document URL's origin. This test checks that a document with CSPs: Content-Security-Policy: sandbox; frame-src 'self' can still embed a frame delivered by the same document URL's origin. Bug: 1151323 Change-Id: Icba5fb8a15bca30ab807ca81ae97152122efb292 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552593 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830203}
-
Maria Kazinova authored
Replacing a DCHECK in PasswordAutofillAgent::InformAboutFormClearing() with a condition check and return, since this condition might be true and the method should not proceed, but it shouldn't cause a crash. Bug: 1151915 Change-Id: Ib23746cb1e063f8539a5812fcd8105b799e636b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553553Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#830202}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202011230600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/TQZeWYEoU6kk_nvBNEUoTxcbn05BDdKuAT2yGqC9r0IC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/138961540,b/150642729,b/168069888,b/173695073 Tbr: media-app@grotations.appspotmail.com Change-Id: Ib63c40f7129a12a4005cd51fe83742a942deec0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554823Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830201}
-
Felipe Andrade authored
Remove duplicate import("//tools/polymer/polymer.gni") from a BUILD.gn file in webui resources. This is simply a clean up work. Bug: 11509326 Change-Id: I8f386a46086ede1a8d37de0352b21b4590d28aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550742Reviewed-by:Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Cr-Commit-Position: refs/heads/master@{#830200}
-
Chris Sharp authored
Add jamiewalch@ as a second owner to policies only owned by remoting/OWNERS. Bug: 1018157 Change-Id: Ie9bbb06445be136ef2ccf295b31654e074152e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550262 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#830199}
-
Denis Kuznetsov authored
This CL also removes empty OWNERS file left from DIR_METADATA migration Bug: None Change-Id: I5bb93de2d287b2caab71c20ffc52ed7e399a8343 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552917 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830198}
-
Pavol Marko authored
Looks like this was introduced in https://codereview.chromium.org/2111563002 and then renamed in https://codereview.chromium.org/2711553002 but the introduced "plumbing" (https://codereview.chromium.org/2144313002) never actually used it. Instead, this is used through a pref. Bug: 1151389 Test: compiles Change-Id: Idd809a01c3e9ea0eb69bb61db44e32cd9ad2cc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2555017Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830197}
-
Denis Kuznetsov authored
Bug: 1150430 Change-Id: I7227d9d8f0918765f8e18c0bf7dc95294405065b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552916 Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1606110698-fe2030373d9d56b0c47d89f10e41d9fcfb737790.profdata to chrome-win64-master-1606121381-2f0d1c6311931d551e9bebe8758016318ab6fd23.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iaa8d017cef19bfbd0b8ce72365f4ce1c7942454a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554821Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830195}
-
Michael Checo authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I739d658e711973a9b10277f09aff07a6678dc712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547943 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830194}
-
Karandeep Bhatia authored
Extend expiry of Extensions.NetworkDelay and Extensions.NetworkDelayPercentage. These are used to monitor webRequest API performance. BUG=1149464 Change-Id: I26f5e6ef460c4677fc8d0fc85890aedbfab4dc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553697Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830193}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b3fe92cab62c..c4685cb937df 2020-11-23 aerotwist@chromium.org [TS] Handle remaining TS errors in CodeMirrorUtils.js 2020-11-23 aerotwist@chromium.org TypeScriptify EventListenersUtils.js If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I92513cb71de43cbaa26d5a4e05205b69cc055fcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553792Reviewed-by:
-
Wolfgang Beyer authored
frontend CL: https://crrev.com/c/2519702 tests re-enabled in: https://crrev.com/c/2553549 Bug: chromium:1140540, chromium:1140481 Change-Id: I73755a7bc1566bb890f8accc3243ce0461101a2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552595Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830191}
-
Stephan Hartmann authored
Change-Id: I1b6b07ebb397a29c84d3ed51ae41523e3ecab497 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552862Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#830190}
-
Clark DuVall authored
If the chrome process is killed, when it gets recreated it may try to restore fragments from feed. This causes a crash since the fragment classes are in the feedv2 class loader, and the FragmentManager uses the Activity's class loader by default. This change prevents the crash, but a more flexible solution will be needed long term to solve this problem. Bug: 1151456 Change-Id: I0edb8f9dd13b2089b700612217e550830669ff70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554394Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#830189}
-
Clark DuVall authored
This allows loading services which may be in other splits besides the chrome split. This falls back to the chrome split to prevent breaking if the enable_chrome_child_modules gn arg is turned off. This will be used to fix a crash in the chime module in //clank. Bug: 1151810 Change-Id: Icabaa21c63b492ec19dd30076c87f93477a59e52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553978Reviewed-by:
-
Stephen McGruer authored
Point them at the right bug and mark them as non-flaky FAIL. Bug: 1144677, 1151922 Change-Id: Ia40eff251a4f7cd6439e5556c0583e587ddfddea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554213 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#830187}
-
Nektarios Paisios authored
When using VoiceOver, focus is often erroneously placed in Chrome's toolbar instead of the web contents as soon as the user navigates to a new page and after the page has loaded. If the page includes logic that moves the focus to a specific item as soon as it loads, that logic often has no effect on the location of the VoiceOver cursor. For example, after visiting a user's Gmail inbox, VoiceOver often neglects to automatically move to the list of emails, even though the page has logic to do that after load. The same problem often occurs when an iframe is inserted in the page and focus programmatically moves to somewhere inside it. For example if the user presses "h" and then "c" to focus the list of chat conversations in Gmail and then selects and opens one of the conversations, the VoiceOver cursor might not move to the edit field in that conversation. This patch: 1. Removes the logic that prevents the firing of a focus event if the page has not loaded, or has no content. A) The page is marked as loaded as soon as the HTML is parsed, i.e. extremely quickly, so in 99% of cases this condition has no effect. B) Even if the page is empty, user confusion does not occur, because everything happens too fast. I tested with Jaws and NVDA, which were the AT for which this second condition was added in the first place. C) This logic of preventing some focus events has caused bugs in the past, so I think simplifying it should improve the health of our codebase, given that it doesn't cause any regressions. 2. Adds accessibilityFocusedUIElement to BrowserAccessibilityCocoa. It was implemented in Views, but was missing from Web. I suspect that the reason that this patch seems to fix the bug is because VoiceOver monitors the load progress on the web contents, and expects a focus event to arrive as soon as the page has loaded. AX-Relnotes: VoiceOver focus should be in sync with browser focus, if the user has chosen this setting. R=dmazzoni@chromium.org, abigailbklein@chromium.org Change-Id: I9ae7b69fc3c7872bbbb39ffdd13562c97b8d1174 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551814 Auto-Submit: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#830186}
-
Pavol Marko authored
Since CL:2193900, attestation service ignores the 'domain' in EMK challenge signing requests. Instead, attestation relies on 'customer id' which is extracted from device policy by the daemon. Consequently, stop sending 'domain' in EMK. Bug: 1073974 Change-Id: I08592ea2674071e68400761d911f0b6358a1b917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2543393Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#830185}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9304577415d5..46823b0ba3d6 2020-11-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from ec5cd38a0ca6 to 0ec6b066bfbc (2 revisions) 2020-11-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from de9e649438ed to 6d612051c083 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Change-Id: I9d8d03c54ee515c64f15c5c9b13d0d9ec762ae6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553946Reviewed-by:
-
Josh Nohle authored
Nearby Share supports upgrading the transfer medium during a payload transfer--from Bluetooth to WebRTC, for example--for faster transfer speeds. In this CL, we add metrics to * allow slicing transfer-rate and payload-size metrics by the upgraded medium, * record if the transfer medium was successfully upgraded after an explicit bandwidth upgrade request from the client (note: automatic upgrades from the Nearby Connections library are also possible), and * record whether a transfer succeeded, failed, or was cancelled when transmitted over upgraded transfer medium. Manually tested send and receive flows, with and without a bandwidth upgrade. Bug: 1105579 Change-Id: I0fcefdbfbe79b4191a7ccd552fe398d7076f5bbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551657Reviewed-by:Mark Pearson <mpearson@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#830183}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1606110698-4a9b21f116e6eb433edc251fc3084d03e39a6c23.profdata to chrome-linux-master-1606132785-400a323c4dba2e607a1a56a52382b70a24e1d779.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I63007b4013864d321122b2d8c16f007f24794ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553791Reviewed-by:
-
Alexander Hendrich authored
This CL is part of a larger refactoring/clean-up of policy_test_cases.json. The code used to only looks for the field "policy_pref_mapping_test", even though the template defined to use "policy_pref_mapping_tests". Some test were actually using the plural version, which caused them to be skipped. Even though the singular version of the field name is used more often, I've decided to update all occurrences to the plural version since it should contain a list and already caused confusion multiple times where the field value was an object instead (see next CL). This is just a trivial global rename, except for the test case for DeviceLoginScreenPrivacyScreenEnabled, which had to be disabled for now. Bug: 1151251 Change-Id: I454c86ca8d91abe260606ff1f0c86438c4cdebb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552407Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#830181}
-
Mark Cogan authored
Prior to this CL, one of the BVC's numerous responsibilities was to save the session when each web state navigation completes. Because this has nothing to do with the UI layer, this CL moves that responsibility to the SesionRestorationBrowserAgent, which already handles session updates when a new web state becomes active. Change-Id: I0f17a39e3efc244513200c0f5225ce59b99fae40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550716 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Javier Flores <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#830180}
-
ssid authored
Perfetto JSON exporter will only be able to write processed graphs in legacy format. So, enable graph computation by default to verify other consumers can handle this format. Change-Id: Id39814653767acfff27d8c4dd939b69ba116f864 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552820Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#830179}
-
Christoph Schwering authored
This CL replaces unique_name() with unique_renderer_id in FormField's ParseFormField() and its return value. Since unique_name() and unique_renderer_id both uniquely identify a field within a given const FormStructure object, this change is equivalence preserving and hence not behind a feature flag. Bug: 896689, 1151473 Change-Id: I0fd4e8dc292b1a9f7fcc7642fd3cde1558be9e3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523173Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#830178}
-
Matthias Körber authored
Currently, on profile assignment the finalization routine is called that causes side effects that may be root cause for some crashes. Change-Id: Ib6e6a2d11e1b9c8763df591cd262bb67686ed866 Bug: 1140131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550743 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#830177}
-
Maksim Moskvitin authored
HTTP_BAD_REQUEST status needs to be special-cased, because it can be used to distinguish inactionable (potentially transient) errors from the case when local data is outdated and user action is required to go out from this state. Bug: 1113598 Change-Id: If7389a7ecf534139e7a610b1f7c8b93fdc25ce1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526348 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
-
Benoit Lize authored
macOS has futex()-like locks in pthread, meaning that SpinningFutex can be useful there, the same way it is on Windows. Use pthread to implement it. Bug: 998048 Change-Id: I77df835baf2f099eedcfcee675f7a56ed6b3bb2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550797Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#830175}
-
Morten Stenshorne authored
TBR=ikilpatrick@chromium.org Change-Id: I10ca71e1ba26ef7082c698b21590c5b2923b98fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554606Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830174}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1810c4a6af75..b3fe92cab62c 2020-11-23 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-11-23 tvanderlippe@chromium.org Typecheck sdk/CPUProfileDataModel.js with TypeScript 2020-11-23 jacktfranklin@chromium.org Land new theme colours and docs example If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1122511 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0c6aac3ae110585e393525276f5341523d7e4fa7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554817Reviewed-by:
-
Tanmoy Mollik authored
Unsetting the 'Allow Chrome Sign-in' toggle should not show the promo on the main settings page. This bug was created when moving all the promos to a single class and is due to not registering the class for SigninAllowedState changes. This cl fixes that issue. Bug: 1151229 Change-Id: If79c09193bb9e40cbca63770074ea77f5bae22d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554567Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#830172}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/33ae0b2d78ac..d44407ce07e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC hendrich@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: hendrich@google.com Change-Id: I1a2db53f7fb2b46df7fd52e16b2aad09c80b194c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553944Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1606110698-ec2190f26d45d9121b82315791a0ce2334cbfdfd.profdata to chrome-mac-master-1606132785-843754305781d29437145aed34be0b0fdd2b3c82.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3fbd71d28b518ed736f96b251d5a318617702278 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554822Reviewed-by:
-
Jan Wilken Dörrie authored
This change modifies base::MakeFixedFlatMap to only compare keys. This fixes a bug where repeated keys wouldn't be detected if their values differed. Furthermore, this also now supports values that are not comparable. Bug: 682254 Change-Id: I598406dee0fe47a4601a122369bc3d88de520abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549622 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#830169}
-
Evan Shrubsole authored
Experimentation has shown no crash increases (UMA) and thus this path is a no-op on non-Cros platforms. Cros will continue to rollout with behind this feature flag. Bug: 1134165 Change-Id: I191ca3c8891e94032654ca75bb6fcd64a90e7cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549762Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Evan Shrubsole <eshr@google.com> Cr-Commit-Position: refs/heads/master@{#830168}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/847989b5..c6ca1b95 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I853b48cac753db72cb2efbde14688bc3d81b5973 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2554034Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830167}
-
Jérôme Lebel authored
-[SceneController openUrlFromSettings:] is only used by -[SceneController closeSettingsUIAndOpenURL:]. So the code from |openUrlFromSettings:| is moved into |closeSettingsUIAndOpenURL:|. Change-Id: Idd6c58f0d813f3b6412148e21d424ec9c4567c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550813 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#830166}
-
Henrik Boström authored
The investigation of https://crbug.com/1148964 has concluded, the bug fixed, and this crash is no longer reproducible. Cleaning up these CHECKs that were added during the investigatiton of that issue. Bug: chromium:1148964 Change-Id: I45cd82bcfd8ec12c455927cd12f622e09f895e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552398Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
