- 14 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e7c4f9065168..bd710dbacd8f git log e7c4f9065168..bd710dbacd8f --date=short --first-parent --format='%ad %ae %s' 2020-02-14 xalep@google.com Removing dead code 2020-02-14 jakobi@webrtc.org Update transport overhead the first time the network connects. Created with: gclient setdep -r src/third_party/webrtc@bd710dbacd8f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8ebc810bd6557daf196d997ee59cbd96920ac91d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056988Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741436}
-
Stephen McGruer authored
This reverts commit 223a600d. Reason for revert: Strong suspect for failures in Linux CFI bot; crbug.com/1052348 Original change's description: > Desktop PWAs and shortcut windows use WebAppBrowserController > > We enable the flag DesktopPWAsUnifiedUiController > > Web apps (PWAs and shortcuts) now use WebAppBrowserController > instead of HostedAppBrowserController. > > Bug: 966290 > Change-Id: I2cdf4bc8161e263838d22fc84ba793174eef0db4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056163 > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Commit-Queue: Eric Willigers <ericwilligers@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741324} TBR=ericwilligers@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I311b06dc8862281434ff9d85ad4189e57195348f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 966290 Bug: 1052348 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057105Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#741435}
-
Antonio Gomes authored
... throughout the source base. Today both enum classes exist (see [1] and [2]) [1] //third_party/blink/public/common/frame/sandbox_flags.h [2] //third_party/blink/public/mojom/feature_policy/feature_policy.mojom ... and clearly duplicate each other. There are also typemap and trait files that translate between the two when doing mojo calls [3]. [3] third_party/blink/common/feature_policy/feature_policy.typemap This CL is a follows up of [4], and merges blink::WebSandboxFlags and blink::mojom::WebSandboxFlags, in favor of the later. The respective typemap declarations and trait files were also removed. [4] https://crrev.com/c/2050140 R=dtapuska@chromium.org, haraken@chromium.org, kinuko@chromium.org TBR=reillyg@chromium.org Bug: 1047273 Change-Id: I058db724b309657ca157aca4c05ea069c87912db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054664Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#741434}
-
Paul Wankadia authored
https://chromium.googlesource.com/external/github.com/google/re2.git/+log/6c109e908aa4..b0a41e52137a $ git log 6c109e908..b0a41e521 --date=short --no-merges --format='%ad %ae %s' 2020-02-13 junyer MSVC also doesn't like casting lambdas with `+'. Sigh. 2020-02-13 junyer Only the latest MSVC allows designated initalisers. 2020-02-13 junyer Provide instrumentation points called "hooks". 2020-02-11 junyer Tidy up some GCC-only guards. 2020-02-04 junyer Tidy up the SWIG guard around LazyRE2. 2020-02-03 junyer Tweak some of the comments about FilteredRE2. 2020-01-31 junyer Avoid using the forward DFA in "ANCHOR_END" cases. Created with: roll-dep src/third_party/re2/src R=mmoroz@chromium.org Change-Id: I3cbdc7e574b22907aebd6c31bc7220c7bbb6b8d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055505Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#741433}
-
Brian White authored
A change to histograms.xml was needed to validate the presubmit so <obsolete> messages had "deprecated" changed to "removed". "Deprecated" means it still exists (but is in disfavor) when in fact the histograms have been completely removed. Removal of an expires_after triggered the presubmit error but the file was otherwise okay. Bug: 1030096 Change-Id: I07422aabc6b1fdcf9e65ce1abc792239c865e64c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052623 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#741432}
-
Xida Chen authored
Right now we report throughput to UMA whenever the number of expected frames are >= 100. This CL added a condition to prevent underflow. That is, the frames expected could be decremented to be < 0, but given that the type of frames_expected is uint64_t, we will get a very large number instead of < 0. Bug: 1021963 Change-Id: I2ec718545fa4913e941d2492c622df8144477512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010183Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#741431}
-
Peng Huang authored
PageFlipComplete() is not trivial, so call FinishSwapBuffers() before it to kick off next frame in viz thread earlier, and compositor will have more time budget to render the next frame. Bug: None Change-Id: Ie6e0f87d75d81b405447757585ec291887ca0063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057043 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#741430}
-
Yuki Shiino authored
Makes union's component "core" if the union is used in "core". Bug: 839389 Change-Id: Ic097aec9eb8c7dd6c176714421f7a61bbe0c7de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056524 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#741429}
-
Luca Hunkeler authored
At the moment when the keyoboard is showing tapping the continue button will make autobot proceed to the next step, which is a unintuitive behaviour. With this change we hide all the chip except for cancel when the keyboard is showing. Bug: b/146551893 Change-Id: I36d70f841fd45ea9192cbf4fd0491c6ac8f4d35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2051927 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#741428}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ab2696d1. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio jsbell@chromium.org: external/wpt/encoding external/wpt/resources rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Iefca917a09b26573f1bd81abcbc17d14db70f36d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057003Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741427}
-
Ioana Pandele authored
There are 2 pieces of information that are stored: 1. Whether the origin was blacklisted when the cache was populated (upon navigating to the page). 2. Whether the origin is currently blacklisted. The difference between the two is that the user can unblacklist the origin while being on the page. Thus, the first will be used to determine whether a toggle to re-enable saving for the origin should be shown to the user, while the second will be used to determine whether the toggle is on or off and whether Chrome should show the save password infobar. Bug: 1044930 Change-Id: Ic5de843ab843337c52502ec718916d39fd42186f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2043841 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#741426}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/15d4c9308d6b..e245d1a20821 git log 15d4c9308d6b..e245d1a20821 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jacktfranklin@chromium.org Include `test/e2e` in ESLint checks. Created with: gclient setdep -r src/third_party/devtools-frontend/src@e245d1a20821 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5b1bd57ed6d148fe1d991612375edccdf7ac9bcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056987Reviewed-by:
-
Maks Orlovich authored
This avoids code dupes and properly handles the case where experimental web platform features are turned on but the particular feature is disabled. Change-Id: Ic2d5394d1380d129b04f2c5f0dda059c2570a510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053127Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#741424}
-
Tom Anderson authored
The preference native_notifications.disabled has been renamed to native_notifications.allowed (and is not logically negated) since policies cannot have "Disabled" appearing in their name. This fixes a presubmit check of the form: Error: Boolean policy NativeNotificationsDisabled uses negative polarity, please make new boolean policies follow the XYZEnabled pattern. See also http://crbug.com/85687 The new policy maps to the native_notifications.allowed preference. R=thestig Bug: b/72535204 Change-Id: Ib57a6f5c95e89213f507f496e3ca1904694ad965 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055391 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#741423}
-
Stephen Nusko authored
We also change to using HeapBuffered to prevent forgetting to finalize the message which caused msan errors. git log f440b92c2422..02808dc0a181 --date=short --first-parent --format='%ad %ae %s' 2020-02-12 treehugger-gerrit@google.com Merge "TrackEvent: Add configuration for TrackEvent" 2020-02-12 fmayer@google.com Merge "Roll trace_to_text to pick up aosp/1232924" 2020-02-12 skyostil@google.com Merge "TrackEvent: Implement dynamic categories" Created with: gclient setdep -r src/third_party/perfetto@02808dc0a181 Bug: 1052142 Change-Id: I9c646c586ff6ea86426d88d383219e23f80239eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056725 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#741422}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4adc7359f66e..379d0c30470e Created with: gclient setdep -r src-internal@379d0c30470e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I759f90d6b64332ca92c814e83aa3f7908ba48689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056986Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741421}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2e9b53763fee..eaff904e7260 git log 2e9b53763fee..eaff904e7260 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src db0a1553991d..fb2272297f00 (2 commits) 2020-02-14 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader ac4e1d236088..f9f999f5a2eb (6 commits) Created with: gclient setdep -r src/third_party/angle@eaff904e7260 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: courtneygo@google.com Change-Id: Ib140dfa76e2afe8cc26e2a5b7a565805af3706e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056984Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d2e26f01..142ac8d3 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I36c51fb5bbbf683e98a527a7e3a39a51ab10ea25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057004Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741419}
-
Olivier Li authored
The time bomb is never armed since https://crrev.com/c/2042292 and even back the the results had been discarded for years. There is no plan to reactivate it. This is the process of of being replaced by HangWatcher. Bug: 1034046 Change-Id: I40d7c874000abc04ba327c0c483733ee4795460f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054044Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Oliver Li <olivierli@chromium.org> Cr-Commit-Position: refs/heads/master@{#741418}
-
Stephen McGruer authored
This reverts commit 1d73a2eb. Reason for revert: Worker variant of tests appears to consistently timeout on WebKit Linux Leak (crbug.com/1052322) Original change's description: > Worker: Add data URL tests for nested dedicated workers > > This CL renames data-url.html to data-url.any.js in order to run the > tests on a dedicated worker. Previously these tests only ran on window. > > Bug: n/a > Change-Id: I4be0cfdddc01fa4865763868c4947ea63e62d491 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054656 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741367} TBR=nhiroki@chromium.org,shimazu@chromium.org Change-Id: I00481f9a51c672b4041364674d0bcad00d959c63 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: n/a Bug: 1052322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057046Reviewed-by:
-
Stephen McGruer authored
This reverts commit 2117f1ba. Reason for revert: Suspecting of causing CRASH failures on Linux MSAN/ASAN bots - crbug.com/1052328 Original change's description: > Ash Tray: Add more observer callbacks to notifications for metrics collection. > > This CL adds more hooks into MessageView and MessagePopupCollection > to log when certain user actions occur, so we can log them. > > BUG=1050809 > > Change-Id: Ic2e23d0c8169e588d2d86556685f0e4549ed128c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045191 > Commit-Queue: Tim Song <tengs@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Peter Beverloo <peter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741354} TBR=peter@chromium.org,tengs@chromium.org,holte@chromium.org,amehfooz@chromium.org Change-Id: Ie1a07268ff021b55ac57cc56e0a830e1559675f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1050809 Bug: 1052328 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057103Reviewed-by:
-
Henrik Boström authored
TBR=zmo@chromium.org Bug: 1045339 Change-Id: I59415b03778f89edbae331c9a0a0197257133f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056724Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Auto-Submit: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741415}
-
Rayan Kanso authored
Since each related app is checked in its own background thread, the order they are merged in might be scrambled. Rather than fix this on the test end, I made sure the order is preserved to be spec compliant. Also re-enable the flaky test. I ran the test with --gtest_repeat=50, it is no longer flaky. Bug: 1051557, 1043970 Change-Id: I5746f3c4c00c0bd281b9edfb37c66c6234abc945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054947 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#741414}
-
Nico Weber authored
Bug: none Change-Id: I0959f2efe5d9ff3da67615c25faaa3061bd702ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052064 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#741413}
-
Josh Karlin authored
What: Make AsyncTaskId non-copyable/non-movable Why: The address of an AsyncTaskId is what's used to keep track of them. So if they move after they've been registered then corruption ensues. How: This is a trivial change. I did have to make a small change to XrFrameRequestCallbackCollection to prevent the AsyncTaskId from being copied. Bug: 1051938 Change-Id: Idf751369c831a9130462b4eb2aa83be121df1fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053409Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741412}
-
Tim van der Lippe authored
Required for https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2055065 TBR=aerotwist@chromium.org Bug: 1006759 Change-Id: I2d422e89822b13b136e012c459036f7fc12132c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056804Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#741411}
-
Joel Hockey authored
Test neds ThemeChangeWaiter to ensure DidChangeThemeColor is invoked across renderer to browser in AppBrowserController. Flake revealed in crrev.com/c/2045278 TBR=pkasting@chromium.org Bug: 1033339 Change-Id: Ifba4671d4ca0e25159d3cd257b60744b658d3d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056505Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#741410}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/27a4c55af35c..15d4c9308d6b git log 27a4c55af35c..15d4c9308d6b --date=short --first-parent --format='%ad %ae %s' 2020-02-14 jacktfranklin@chromium.org [Unittests] Tidy up Karma config variables Created with: gclient setdep -r src/third_party/devtools-frontend/src@15d4c9308d6b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3f95c0f088ec8106191d1e11197d6630ea18ef03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056983Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts FrameHostMsg_UpdateRenderThrottlingStatus to RemoteFrameHost blink interface. It removes UpdateRenderThrottlingStatus from WebRemoteFrameClient. Bug: 1047362 Change-Id: Icc479058169016353dc58039aa4f311c5d1534da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053872Reviewed-by:
-
Vasilii Sukhanov authored
Bug: 1049185 Change-Id: I58f077854bed11eebd70849ac1477b41ec1a4ace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054983Reviewed-by:
-
Marijn Kruisselbrink authored
When using the new origin scoped permission model this makes sure to revoke permissions if no top-level tabs remain with that origin open. Every time a tab/window is navigated away from an origin we start a timer to check if that was the last tab/window for that origin, and if so revoke all its permissions. Bug: 984769 Change-Id: I3840f1885f3a8794baa09316ab1930068e808baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028179 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#741406}
-
Hazem Ashmawy authored
Filling up the WebView package/version field in the crash bug report template, thus shortening the length of the URL query field to solve the URL redirection problem. Fixed: 1015923 Bug: 991594 Test: Manually test that url redirects to the bug opening page after signing in Change-Id: I2018d74dce443174d0974a5c7fea4c3f8b599d66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054885 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741405}
-
sreejakshetty@chromium.org authored
This is a reland of 7466ee73 Original change's description: > [bfcache] Record NextPaintTime on bfcache restore > > Add "BackForwardCache.Restore.NextPaintTime" histogram to > record next paint time on restoring a page from > bfcache. > > Update RecordContentToVisibleTimeRequest to include parameter > |show_reason_bfcache_restore|. > Bug: 1034353 > Change-Id: I0b4d63b787017efe40caed9af7f3742b11cb43f5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968977 > Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> > Reviewed-by: Camille Lamy <clamy@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741037} TBR=altimin@chromium.org Bug: 1034353 Change-Id: Icbcb141bf4ba23bccfdac10074af89487feecb86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055204 Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#741404}
-
Swapnil authored
UploadAppInstallReport method was used for AppInstall Reporting so that DMServerJobConfiguration is created and events are reported to Chrome Reporting API using DM server as a proxy. Now the events are reported directly to Chrome Reporting API. UploadAppInstallReport is no longer used. Bug: 1051464 Change-Id: Ic13f334fa207499852f52d433b08c083799975fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049861Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Askar Aitzhan <askaraitzhan@google.com> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#741403}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4416f6a. With Chromium commits locally applied on WPT: acd8a467 "SharedWorker: Use CSP headers to outside settings" ec83d167 "Update performance.measureMemory to the latest proposal" ce4a5462 "[css-scroll-anchoring] Add WPT for zero scroll offset suppression." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I252837e5ebd88bebdc6492eb9d9888c760a7aef8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056643Reviewed-by:
-
Alex Danilo authored
Reflects the classes applied to the search box up to the wrapper element around the search button and search box as a prerequisite for styling the wrapper itself. Bug: 992823 Change-Id: I41d91a06f456c9f9bc27524fa61a3a1388decf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054473Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#741401}
-
Clemens Arbesser authored
This will let the backend know whether the UI was shown to the user or not. Change-Id: I836fba76d322fc5989919323ccb4a50947a498e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056545 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#741400}
-
Alex Danilo authored
This changes the placeholder text color to make it visible with a light background. Changes the non-focussed underline color as a temporary fix, this will be replaced by styling the entire search area with a grey box in a follow up CL. Bug: 992823 Change-Id: I5d97ccd700950f995309afd54888ebfb60036a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2054655Reviewed-by:
-
Side Yilmaz authored
|Profile#getLastUsedProfile| is deprecated and replaced with |Profile#getLastUsedRegularProfile|. This CL updates PaymentRequestImpl class. Note: This change is only code clean-up, does not change any behavior. Bug: 1041781 Change-Id: I799acc986566e41846fe0ea7d71c14990ae72bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050373Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#741398}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd356bb63f57..4adc7359f66e Created with: gclient setdep -r src-internal@4adc7359f66e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I1686d7db7f51e6ced8351cbb367e5099907479f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056483Reviewed-by:
-
