- 25 Nov, 2020 20 commits
-
-
Charlene Yan authored
When a tab is dragged into a new window, its bounds should be the same. This is a regression test/check for crbug.com/1140808 Because tabs can be different widths by one pixel, we need the test to get the width of the tab before dragging then when the tab is detached, verify this width is the same. Bug: 1140808, 1141674 Change-Id: I2ed53d6101ea50999b706a6e050e5c732bbd9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2539251Reviewed-by:
Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830805}
-
Anne Lim authored
Screenshot with feature enabled in light mode: https://screenshot.googleplex.com/6V8VaPzxTCNTaKg Screenshot with feature enabled in dark mode: https://screenshot.googleplex.com/76j9FRyHMug7JUd Bug: 1135847 Change-Id: Ied72725636b0c91ac3c418f8d7161c4f8e972270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546600 Commit-Queue: Anne Lim <annelim@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#830804}
-
Mike Taylor authored
This is the first of a handful of CLs rewriting the legacy tests in the ported wpt http-state tests. The plan is to continue to refine and refactor and eventually rewrite (or delete) them all. Bug: 1145300 Change-Id: I8a50939f4e2c95c1293ba5423577693ab2a10d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550362 Commit-Queue: Mike Taylor <miketaylr@chromium.org> Auto-Submit: Mike Taylor <miketaylr@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#830803}
-
Vaibhav Raheja authored
For ARCVM to support APK sideloading, we need to query Sideloading value from Session Manager, and then use it to write the property ro.boot.enable_adb_sideloading while upgrading the ARC. This CL creates a session manager client to first query the sideloading value, and then sets the upgrade parameter appropriately. Companion CL for rvc-arc that starts ADBD - http://ag/13066710. BUG=b:136040493 TEST=Tested with following: 1. Reboot the DUT. 2. Command - stop ui 3. Flip the flag in Dbus using: bootlockboxtool --action=store --key=arc_sideloading_allowed --data=1 4. Command - start ui 5. Login into DUT 6. Command - android-sh -c 'getprop | grep ro.boot.enable_adb_sideloading' should show appropriate value Unit Test: testing/xvfb.py ./out/Debug/components_unittests --gtest_filter="ArcVmClientAdapterTest.*" Change-Id: I24305afa8e144f0e45bd37307c6f1ecefcfae777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525605 Auto-Submit: Vaibhav Raheja <vraheja@chromium.org> Commit-Queue: Vaibhav Raheja <vraheja@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Victor Hsieh <victorhsieh@chromium.org> Cr-Commit-Position: refs/heads/master@{#830802}
-
Tomasz Wiszkowski authored
Bug: 1151850 Change-Id: I01f64377ac2a3e34213697709e9cf7eb68b9b0a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558956Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#830801}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bc75ebb1afc4..95ab83f6fe25 2020-11-24 egdaniel@google.com On QComm to vulkan partial clears as draws. 2020-11-24 brianosman@google.com Reland "SkSL: Test/implement "geometric" intrinsics" 2020-11-24 jlavrova@google.com Make sure maxIntrinsicWidth is always no less than minIntrinsicWidth 2020-11-24 brianosman@google.com SkSL: Add test for scalar versions of geometric intrinsics 2020-11-24 michaelludwig@google.com Revert "Move conservative bounds tracking from SkCanvas to SkNoPixelsDevice" 2020-11-24 egdaniel@google.com Fix hazard in vulkan from resetting fActiveCommandPools. 2020-11-24 jmbetancourt@google.com move SkottieAnimation out of SkottieRunner to top level 2020-11-24 csmartdalton@google.com Hardcode offsets to zero in GrMockOpTarget If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC adlai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1148230 Tbr: adlai@google.com Change-Id: I5496f7a6816056953b4278eb9747235b1a7e11f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559275Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830800}
-
Kent Tamura authored
overflow:hidden In PaintLayerPainter, a layer bounding rectangle for a such LEGEND was incorrect, and nothing was painted if the anonymous fieldset content box has a layer. This CL fixes the issue by handling a rendered LEGEND in PaintLayer::ContainingLayer(). Bug: 1151295 Change-Id: If133d9179d8ab4c70d9b958aef61cedf547f704f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556626 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#830799}
-
David Tseng authored
R=dmazzoni@chromium.org Fixed: 1101496 Change-Id: I05693c9d6a5b21b0875c14f9e664337121651734 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558745 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#830798}
-
Mounir Lamouri authored
At the moment, this is only moving a call around. Bug: b/170751292 Change-Id: I5a991a95afabd5e42df667a66c5984dbe6f24d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548697Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Auto-Submit: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#830797}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: Ied06c46395129b142f5242c90f772e888605d31a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556857 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Auto-Submit: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#830796}
-
Michael Hansen authored
When some number of contacts are not eligible to use Nearby Share, we will show a message indicating this at the top of the contact list. Screenshot: https://screenshot.googleplex.com/B3gP2HbCSea5Hu4.png Fixed: 1143837 Bug: b:168841167 Change-Id: Ib10843e94a8c86d4bd6346bc4f9b720cb313a80c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552847 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#830795}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3b5297a4..0652fd72 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id1150a0ee7b3b817bfdd4cfb0f6a14579e73041a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558845Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830794}
-
Allen Bauer authored
Bug: N/A Change-Id: I1a50b0913369f3fbc5988a7f73c236f1e45755f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553289Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#830793}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/64e80769c4c7..295dd1879f8e 2020-11-24 ehmaldonado@google.com [owners] Add SuggestOwners to OwnersClient. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id0ee9f6d934bff1b3c5948356f54ee3d132ce900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559282Reviewed-by:
-
Yi Gu authored
The test is also flaky on win rel: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=All/DeclarativeNetRequestBrowserTest.BlockRequests_UrlFilter/1 Change-Id: Ib2729cf31a5ae11c2b5e1dc215a000b5425e00da TBR: kelvinjiang@chromium.org Bug: 900447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559376Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830791}
-
Yuheng Huang authored
Bug: 1099917 Change-Id: I1eaf5e9c70961d98cf0fe2fbc11d3455b5e892bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558912 Commit-Queue: Yuheng Huang <yuhengh@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#830790}
-
John Chen authored
Headless Chrome works on Windows CQ bots again. Re-enable tests. Bug: 1011095 Change-Id: I6d83b33c02d51f4f3c8fa9953deb6411a1dff792 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559220 Commit-Queue: John Chen <johnchen@chromium.org> Commit-Queue: Shengfa Lin <shengfa@google.com> Auto-Submit: John Chen <johnchen@chromium.org> Reviewed-by:
Shengfa Lin <shengfa@google.com> Cr-Commit-Position: refs/heads/master@{#830789}
-
Mehran Mahmoudi authored
This updates the page info controller message when displaying a paint preview. Bug: 1131497 Change-Id: I68ec838c746ac8797b59245fc73cdf246e2cae8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532727Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830788}
-
My Nguyen authored
New UIL decoder doesn't have this feature. Adding metrics to see if we can deprecate the feature. Histogram-emitting code: http://cl/342535563 Bug: 1136724 Change-Id: Ic0d2adeadcbe0243b7536f9e8010e1476ae7fbe0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536514 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#830787}
-
Moe Ahmadi authored
Sets the z-index value of dragged MV tiles to that of the realbox input. Fixed: 1122894 Change-Id: I1b3cfd2469c62edfedd0335f0fb4aef483bbf12d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556447Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#830786}
-
- 24 Nov, 2020 20 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b1da4494cc50..377448c7bd4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ezemtsov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1144488 Tbr: ezemtsov@google.com Change-Id: I34dfd872d3ff2f6891eea94edb03bf5873a3bc07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559007Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#830785}
-
Nicholas Hollingum authored
This infrastructure will hopefully form the basis of the state management for the borealis system. The important concepts are: - State is managed by manager objects, which can be in exactly two states (on/off) - State is conceptualized with state objects, that are constructed or destroyed during state transitions, based on what those transitions are defined as. - The state manager owns the instance of the state object, so we force designs that work a bit like an onion/stack in the sense that if state C is a descendant of P then we model this by having P own the *state manager* for C (as opposed to having C own/inherit/extend P itself). Bug: b/172178036 Change-Id: I2b065f71972d11e3212509f2f4c569e598ca9c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526865Reviewed-by:
David Munro <davidmunro@google.com> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#830784}
-
adoneria authored
Also, adds win7 32-bit testers to test these builds. Bug: 1151458 Change-Id: Iaacac3d1e0ecf4336cf0c9f29cb2be12973ee109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552944 Commit-Queue: Anjali Doneria <adoneria@google.com> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#830783}
-
Abigail Klein authored
visible. On Windows, there is a bug where the caption bubble is focused after the tab model changes, even if the caption bubble had previously been deactivated. When the tab model changes, it causes focus to advance to the next focusable view and activate that view's widget. The fix for the caption bubble is to ensure that the caption bubble cannot be activated by the focus manager unless the caption bubble is visible. The stack trace of this behavior is: Browser::OnTabStripModelChanged Browser::OnTabDetached BrowserView::OnTabDetached views::WebView::SetWebContents views::WebView::UpdateCrashedOverlayView views::View::SetFocusBehavior views::View::AdvanceFocusIfNecessary views::FocusManager::AdvanceFocusIfNecessary views::FocusManager::AdvanceFocus views::FocusManager::SetFocusedViewWithReason views::Widget::Activate ...leading to... captions::CaptionBubble::OnWidgetActivationChanged One outstanding question is whether the focus manager should ever activate a widget that is not visible. This will be explored in a follow-up. Bug: 1055150, 1123635 Change-Id: I9b5eaee54a5f78592c320b18282a726f9e0980eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558721 Commit-Queue: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#830782}
-
Eugene Zemtsov authored
Fails on ios-simulator-full-configs bot TBR=marq@chromium.org BUG=1146303 Change-Id: I1f613b0ae47cd8512cf6f8d442a0bd5dda83fe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558768 Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Reviewed-by:
Eugene Zemtsov <ezemtsov@google.com> Cr-Commit-Position: refs/heads/master@{#830781}
-
Yi Gu authored
The test is also flaky on CrOS: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=DownloadTest.SaveLargeImage TBR=jam@chromium.org Bug: 1141263 Change-Id: I534a8e08e22bf98960041c1e1ffca83e335ccb1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2559378 Commit-Queue: Yi Gu <yigu@chromium.org> Reviewed-by:
-
Brandon Maslen authored
Currently the HTTP 2 protocol will limit data frames to 2,852B (2*MSS - frame header). Unfortunately this leads to excessive amounts of data frames during large H2 uploads. On resource constrained clients or servers this leads to a significant drop in throughput. In tests this has been observed to lead to H2 performing up to 136% slower than HTTP 1.1 with large transfers. This change updates the max data frame size to be 16,376B (16KB - frame header). This more closely aligns with HTTP 1.1 that uses 16KB and QUIC that uses a larger chunk size also. The TLS layer will also chunk data at 16KB so this is a good boundary to align to. In tests this led to significant improvements in the above scenario. It's not expected that all H2 uploads will see throughput improvements as an abundance of processing resources could sufficiently keep up with the smaller frames to maintain throughput at the cost of more compute. It does seem that most large uploads would benefit from a lower CPU/Byte cost on the client and server sides due to the increase in frame size. Bug: crbug.com/143193 Change-Id: Ifadbe7ffc075130ee690cd168a1b60b7abdbfcc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551284 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#830779}
-
Christoph Schwering authored
The number of times a value is filled into different fields is limited. The exception are state fields because websites sometimes have one state select box for each country and display the relevant select box once the respective country has been selected. This CL simplifies this mechanism and makes it more explicit by encoding the type-dependent limits in TypeValueFormFillingLimit(). As a side effect, the limits apply not just to filled fields but also unfilled fields of the same type. Bug: 1075734, 1084903 Change-Id: Icc5e8e082850ed44d9c7fbbc911d03a95033d81f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557977 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Auto-Submit: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#830778}
-
Jae Hoon Kim authored
|OnInstall()| accidentally was using a moved variable when a status of busy is returned from the platform dlcservice. This change fixes the previously incorrect double move of a variable. BUG=chromium:1152219 TEST=./unit_tests Change-Id: I1f526d808ef3cf571dbe61516340dc69c35f32d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558953Reviewed-by:
-
Yi Gu authored
The test has been flaky on Linux: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=PDFExtensionClipboardTest.CombinedShiftArrowPresses%2F TBR=thestig@chromium.org Bug: 1121446 Change-Id: Ibb0a5bb8f17e0d41a16f105d5ed6d4c3f1236dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558849Reviewed-by:
-
Vincent Boisselle authored
Bug: 1152438 Change-Id: Ifa99673cbb51a13a56a7bb146c304a39e579cfdd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557226Reviewed-by:
Arthur Wang <wuwang@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Vincent Boisselle <vincb@google.com> Cr-Commit-Position: refs/heads/master@{#830775}
-
Chris Harrelson authored
content-visibility:auto elements have different sizing behavior when near the viewport vs not. This sizing behavior is an intentional part of the platform, and should not be considered a layout shift for the the first time the elements' subtrees become unskipped (*). There are two cases of "first time": * The very first paint when a content-visiblity:auto element is in the DOM, and in which the element is found in that frame to be near the viewport. * The first paint *after* a content-visiblity:auto element has been found to be near the viewport, but was was found for at least one frame previously not to be near it. These two cases are handled in somewhat different ways in Blink - the former is a synchronous relayout, whereas the second is async. In both cases, CLS should not be impacted. In the future, we could consider in the future whether layout shifts for subsequent unskips should also not count for CLS. Bug: 1151526 (*) https://drafts.csswg.org/css-contain-2/#skips-its-contents Change-Id: I9421452430dd572ed87bb20b0bd20e9a7e3501a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556211 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830774}
-
Michael Checo authored
- Final strings TBD Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I78e4f4fa8138322d800fe1144ecd594caa141ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552286 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#830773}
-
Gayane Petrosyan authored
In some cases PlainText might return a single space " ". The case found is when a selection starts with an element that is nested within inline-block element. This combination creates extra spaces that is selectable and is not fully collapsed by PlainText. Bug: 1151474 Change-Id: Id855e9847efc5f70cedb3c58d72b33191c4771b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558914 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830772}
-
Zhaoyang Li authored
https://chromium.googlesource.com/external/github.com/google/eDistantObject.git/+log/e8a984232246..91c532d921e1 $ git log e8a984232..91c532d92 --date=short --no-merges --format='%ad %ae %s' 2020-11-23 haowoo Retrieve block signatures directly from block headers. 2020-11-21 mobile-devx-github-bot Add signature to blocks in EDO 2020-11-10 albertbow Fix Swift Array objectAtIndex: failure on eDO since iOS 13.4. 2020-11-02 albertbow Fix eDO TSAN issue caused by __block variable. 2020-10-14 albertbow Enable ASAN and TSAN Travis tests in external CI. 2020-10-14 albertbow Fix eDO ASAN issue captured by Xcode 10. 2020-10-06 albertbow Fix TSAN warning on EDOListenSocket. 2020-10-03 haowoo Remove the unneeded cancel block. Created with: roll-dep src/ios/third_party/edo/src Bug: 1152551 Change-Id: I74d20d4a29ac6a4aeccbb47bcdc10f57d43c2070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558784Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#830771}
-
Xianzhu Wang authored
The bug is caused by integer overflow and DCHECK/CHECK failure when calculating the area of a layout shift region containing rects with geometry values like 2^31-1. The situation happens only during printing when layout shifts should not be reported because in normal cases the viewport clip limits the geometry of the region. Bug: 1151591 Change-Id: I3fd080eab1be31815668486dc555c227ff2cf4f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2557883 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#830770}
-
Emircan Uysaler authored
This CL addresses hangs we see after a hide/show sequence. Merging primary and overlay fences imposes the one-Image-in-flight limitation of primary plane on overlays. However, overlays might be presenting the same image after hide/show. Therefore, skip merging fences until we can do updates independently, after |supports_commit_overlay_planes| is supported. Bug: 1151042 Change-Id: Icf8a629ce700c63559f036bd2c1c9dab0a58d888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552945Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#830769}
-
Tibor Goldschwendt authored
Previously, we requested fake data via a triggering GWS experiment ID. However, that does not work on Chrome OS. After this CL, we request fake data by appending an async fake_data:1 to the data request. + Move AppendToAsyncQueryParam to Google utils so that it can be used by both the logo and the task module service. Bug: 1149880 Change-Id: If449c3d05eeac8bd1124514dfc8539199bfb25a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551329Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#830768}
-
chrome://weblayerKen Rockot authored
Simple adaptation of this WebUI to use JS modules in lieu of manually managing dependency imports. Bug: 1004256 Change-Id: Ib9e5477f1a1578772f9a2d657d41aa5c36aee516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2556700 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#830767}
-
Elly Fong-Jones authored
The original change assigned "N" as the accelerator for this item, but that is already in use by "minimize"; have "Name Window" use "W" instead, which is free in this menu. Bug: 1152079 Change-Id: Ibebe8331c3580a6db76808791056677550d293c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558748 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#830766}
-
