- 16 May, 2019 40 commits
-
-
Collin Baker authored
This reverts commit ad6eabaf. Reason for revert: causing error in Linux CFI builder: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/13578 Original change's description: > Update V8 to version 7.6.202. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/09be7f2f..8e003ab0 > > Please follow these instructions for assigning/CC'ing issues: > https://v8.dev/docs/triage-issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel > CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel > > TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com > > Change-Id: Ib6654e2255046cfbda0dd00bed069859aa4f0241 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615624 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#660530} TBR=bcwhite@chromium.org,hablich@chromium.org,v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iedb5a41536b34d11313dc2a8d928ec2d00703fd8 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614701 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#660554}
-
Jun Mukai authored
Bug: 958467 Test: trybot Change-Id: I10b01e432d6f2301931852b31f6ef76412f4e933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614685Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660553}
-
Elly Fong-Jones authored
Bug: None Change-Id: I1ee41d1b8c13fd5a25445fe4e4b5bbf658e71a9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614148 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#660552}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/31136552bc0c..226d32fcf4fa git log 31136552bc0c..226d32fcf4fa --date=short --no-merges --format='%ad %ae %s' 2019-05-16 tsepez@chromium.org Remove some bare |delete| from tests in favor of unique_ptr<>. 2019-05-16 thestig@chromium.org Make FPDF_StructElement_GetTitle() handle UTF-16BE correctly. Created with: gclient setdep -r src/third_party/pdfium@226d32fcf4fa The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Id4fab00b84598f78ca762f07ae966fb3838db575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614528Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660551}
-
Eric Willigers authored
The CSS WG is proposing to order the overflow values by block/inline instead of x/y https://github.com/w3c/csswg-drafts/issues/2988 Use count to investigate feasibility of the proposed change. Change-Id: I4e41e7b48ce1b4afa75852ac2288aeba5ff02342 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615404Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#660550}
-
Robert Liao authored
All thread checking code in Chromium should use the modern THREAD_CHECKER API, which automatically gets removed when !DCHECK_IS_ON(). BUG= Change-Id: I70d3f12915445dc14be7f03c554c32c7fc12e2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612377Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#660549}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/72ee2533b189..ea05691e76b6 git log 72ee2533b189..ea05691e76b6 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 crouleau@chromium.org [Telemetry] Deflake unittest Created with: gclient setdep -r src/third_party/catapult@ea05691e76b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:963978 TBR=simonhatch@google.com Change-Id: If4f0e9ca697c546215ceb23c5be999df55e217e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614524Reviewed-by:
-
Ross McIlroy authored
Multiple flags can be passed to V8 using --js-flags="--flag1 --flag2", however the requirement to quote the flags can make passing these flags via telemetry and other scripts difficult where the quoting might be lost. This CL adds the ability to pass multiple flags as --js-flags=--flag1,--flag2 to avoid the need for quoting. Change-Id: If5fcc9b3d88d933ce63068bb6e6bd138ac1c4cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614185 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#660547}
-
Ehsan Karamad authored
Frame-based MHV does not respect permissions now. This CL disables the test to unblock adding a test config and tracks permission support in its own bug. TBR=wjmaclean@chromium.org Bug: 963694 Change-Id: Idcf99cfcd1caa42ed82adda519892c8e97aa7f4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615500Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#660546}
-
Madeleine Barowsky authored
This change defines the logic to do WebP YUV decoding only for lossy, non-alpha images without color profiles and only when the kDecodeLossyWebPImagesToYUV flag is on. For now, we continue to veto YUV decoding until all data is received because supporting "incremental" YUV decoding in Chromium is a separate task crbug.com/943519. It also adds a few initialization calls to ImageFrameGenerator to set up plane sizes. The YUV decoding path will initially be implemented for in-process GPU rasterization and later for OOPR (Out of Process Rasterization). See bit.ly/webp-decoding-into-yuv for the design document and crrev.com/c/1338461 for a prototype CL summarizing all changes. Bug: 900589 Change-Id: I7f40517273a62288a9bf0060176f864bf30d5aca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1393003 Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Leon Scroggins <scroggo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#660545}
-
Weiliang Chen authored
OverlayCandidateValidator is used to validate overlay and is only used inside OverlayProcessor. This is the first CL to move the ownership of the validator to the overlay processor. This reduces the usage of trying to get the validator from the output surface. R=rjkroege Bug: 963597 Change-Id: I3541b8c4210db98862e430d23479eb8cb83698ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613581 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#660544}
-
chrome://discardsSigurdur Asgeirsson authored
Change-Id: I22847d87db876b27bc424fc53afdccf1d85b4903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611112 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#660543}
-
Yusuke Sato authored
When the user clicks a removable storage volume on the left pane, this CL shows a toast when the user has to change the ARC preference for ARC apps to access the storage. UI mock: go/filesapp-arc-extdriveaccess BUG=936814 TEST=browser_tests --enable-pixel-output-in-tests --use-gpu-in-tests \ --gtest_filter='*fileDisplayUsb*' TEST=ninja -j1500 -C out/Release ui/file_manager:closure_compile Change-Id: Id86de321c076493ed65fd2131e4a092c3f3dcc92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610507 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#660542}
-
Daniel Nicoara authored
views::Widget no longer checks for a ViewsDelegate, so create a stub so any widgets created don't cause crashes. Bug: b/132715995 Test: Run cast_shell_browsertests Change-Id: Ie9578fbff050da4c5f9f08e717953770578dbdd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615498 Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#660541}
-
Eric Roman authored
Change-Id: I4f42113c0c44209347dede29e768844299e214b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613751Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660540}
-
Adrienne Walker authored
The new rounded corner feature on quads should prevent quads with such effects from being turned into CA layers. In the future, we could special case times where the rounded corner applies to the quad's corners directly and set this on the CA layer itself. Bug: 952137 Change-Id: Iddf7905f9558e6f606ad2bed5ead5d9af0a6907e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614498 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#660539}
-
Jun Mukai authored
TBR=tsepez@chromium.org Bug: 958198 Test: trybot Change-Id: If8f75baae9b1a9677c53bfb8d7620def30fb100f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613699Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#660538}
-
Dave Tapuska authored
Add some details how freezing and pausing works. Change-Id: I4777c3e8107d7170f90721d8d71734263934f573 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615362 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#660537}
-
Tom Anderson authored
This change just removes some python files from the sources of a static_library/source_set. No behavior changes. BUG=gn:77 R=pkasting Change-Id: I3fa44e01bf4e59b3a82090b256cd4cf8269871d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614147 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Brandon Jones authored
Adds a new 'none' value to the XREye enum to indicate times when a view is not instrinsically associated with any specific eye. Ensured that views for inline sessions report an eye of 'none'. Bug: 963158 Change-Id: I6c091240d1c68cf658bb5f496308c08bde35e541 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615541 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#660535}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1091f02b40de..c6568afa0b63 git log 1091f02b40de..c6568afa0b63 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 brianosman@google.com Remove Nima from DEPS, experiments, Viewer, etc. 2019-05-16 jvanverth@google.com Revise Mac windowing and context creation. Created with: gclient setdep -r src/third_party/skia@c6568afa0b63 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Change-Id: Id551796c8d547165ff042fe6b0556b94f44b4473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614970Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: I3fd98deca2b4d054613ebc678d2a79680c68d98c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615677 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#660533}
-
Peng Huang authored
This CL uses _NET_WM_SYNC_REQUEST to synchronize with desktop compositor during resize. Without this CL, resize steps are: 1. Desktop compositor(WM) resizes chrome browser window. 2. Desktop compositor draws a new frame with the current browser window without waiting chrome to complete handle the ConfigureNotify event. For SW rendering, compositor uses the content before resizing. It will out of synced size between compositor and chrome. For GPU rendering, compositor uses the framebuffer before resizing, the behavior is undefined. It cause weird artifacts. 4. Desktop compositor go to step 1, to issue a new resize. 5. Chrome finished handle the ConfigureNotify and rendered a new frame. 6. Desktop compositor draws a new frame again with right size. With this CL, resize steps are: 1. Desktop compositor sends client message _NET_WM_SYNC_REQUEST to notify about the incoming resize 2. Desktop compositor WM resizes chrome browser window. 3. Desktop compositor waits on an alert on value change of a XSYNC counter on chrome window. 4. Chrome handles the ConfigureNotify event, and renders a new frame. 5. Chrome increases the XSYNC counter on chrome window. 6. Desktop compositor gets the alert of counter change, and draws a new frame with new content from chrome. 7. Desktop compositor responses user mouse move events, and starts a new resize process, go to step 1. Change-Id: I51aafe03b8aac73ce6570976bbe36c6f4d86531a Bug: 961858 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602285 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#660532}
-
Antonio Gomes authored
This CL is the third out of N CLs that phase out the use of CrossThreadBind in favor of CrossThreadBindOnce. Similarly to the first one [1] and [2], in this CL the uses of CrossThreadBind that are being phased out are the ones used combined with PostCrossThreadTask. Reasoning: when a task is posted, it only executes once. Hence it is logical to cross-thread the callback once. [1] https://crrev.com/c/1615444 [2] https://crrev.com/c/1615446 R=haraken@chromium.org, hiroshige@chromium.org BUG=963574 Change-Id: Ibf11b6ee52950c08f31ba77431c67b8ab630afaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615447Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09be7f2f..8e003ab0 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ib6654e2255046cfbda0dd00bed069859aa4f0241 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615624Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#660530}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/769221674ac8..7cac1ef36965 git log 769221674ac8..7cac1ef36965 --date=short --no-merges --format='%ad %ae %s' 2019-05-16 lalitm@google.com Merge "trace_processor: switch to using getopt to parse command line" 2019-05-16 hjd@google.com Merge "Rename Android kill switch" 2019-05-16 hjd@google.com Merge "perfetto_cmd: Avoid indefinite length Dropbox traces" 2019-05-16 fmayer@google.com Merge "Fix heap_profile with enabled packages list" Created with: gclient setdep -r src/third_party/perfetto@7cac1ef36965 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I671b9c8a826f4e96ae00c04a6b358b5bffdfdf03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615628Reviewed-by:
-
Elly Fong-Jones authored
Bug: 963990 Change-Id: If098e949fc42e66df7678fdea0084a6e7d0ad313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615663 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#660528}
-
Dominik Laskowski authored
This CL makes TestNativeDisplayDelegate::SetHDCPState stateful to allow validating HDCP state in unit tests, and defers ActionLogger logging in the asynchronous case. Bug: 929449 Test: display_unittests Change-Id: Ic12703e440ba4a8a6fb0733e44a29e739beb4f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597697 Commit-Queue: Dominik Laskowski <domlaskowski@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#660527}
-
Antonio Gomes authored
This CL is the second out of N CLs that phase out the use of CrossThreadBind in favor of CrossThreadBindOnce. Similarly to the first one [1], in this CL the uses of CrossThreadBind that are being phased out are the ones used combined with PostCrossThreadTask. Reasoning: when a task is posted, it only executes once. Hence it is logical to cross-thread the callback once. [1] https://crrev.com/c/1615444 R=haraken@chromium.org, hiroshige@chromium.org BUG=963574 Change-Id: Ic1d039494bcb745935bae35fa5ba5ecf0b82b82a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615446Reviewed-by:
-
Brian White authored
This reverts commit b4401935. Reason for revert: This is the only CL in the range between successful build and the broken one: https://ci.chromium.org/p/chromium/builders/ci/fuchsia-x64-cast https://chromium.googlesource.com/chromium/src.git/+log/8c47a2d664d4e2524b6ae0de86e346dce97d81ae..b440193535de9ce630b43e55497b52d61eb15214 Original change's description: > [Chromecast] Add a basic stub for ViewsDelegate > > views::Widget no longer checks for a ViewsDelegate, so create a stub so > any widgets created don't cause crashes. > > Bug: b/132715995 > Test: Run cast_shell_browsertests > Change-Id: I6e3038370748c36abd1801628687728e8c602a72 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615644 > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Reviewed-by: Sean Topping <seantopping@chromium.org> > Cr-Commit-Position: refs/heads/master@{#660494} TBR=dnicoara@chromium.org,halliwell@chromium.org,seantopping@chromium.org Change-Id: Ia1fac69915884eaf50afc032ab96279821106b42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/132715995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1613749Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#660525}
-
Darwin Huang authored
Initialize FORMATETC using an initializer list, so that data_ may be const in the future. From comment here: https://chromium-review.googlesource.com/c/chromium/src/+/1606765/1/ui/base/clipboard/clipboard_format_type_win.cc Change-Id: Ideccd9ca2e2d5228db70c675d79ed5ca3fede7ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612697 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
-
Kehuang Li authored
It is done through AudioProcessing::Config anyway in WebRTC internal code. This change remove the last piece of code that is not configuring APM through AudioProcessing::Config. Bug: webrtc:9878 Test: Pass unittest that checks default configurations. Change-Id: Idcc9c9f1b5b084682f8bed7bf1f0b85f95143d34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1607303Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Kehuang Li <kehuangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#660523}
-
Antonio Gomes authored
This CL is the first out N CLs that phase out the uses of CrossThreadBind in favor of CrossThreadBindOnce. Particularly in this CL, the uses of CrossThreadBind that are being phased out are the ones used combined with PostCrossThreadTask. Reasoning: when a task is posted, it only executes once. Hence it is logical to cross-thread the callback once. Exception: PostCrossThreadTask(FROM_HERE, CrossThreadBind(a_repeating_callback_)); ... where the function being bound is essentially a base::BindRepeating ivar. R=haraken@chromium.org, hiroshige@chromium.org BUG=963574 Change-Id: I1bd2d624f393af6456b165c7c07b2f440c681e8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615444Reviewed-by:
-
Anna Malova authored
This CL refactors access to AwBrowserContext to reduce the number of places that it is used as a singleton. Bug: 963875 Change-Id: I4c599d8dd5648d60e886de8e7e2c8689b3500e28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615201Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Commit-Queue: Anna Malova <amalova@chromium.org> Cr-Commit-Position: refs/heads/master@{#660521}
-
Patrick Noland authored
The main change here is that PageViewObserver now uses the canonical URL if it exists, even for non-AMP pages. PageViewObserver will also update its current URL if it detects a subframe navigation that looks like an AMP page. Bug: 961814 Change-Id: Ia086e5da5711c11407638f51ca54aad23527c7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606081Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#660520}
-
Martin Kreichgauer authored
The WebAuthn spec says that during a WebAuthn get() request, if an authenticator returns an error in response to the request, the browser should simply ignore that device and let the user try a different one until the user cancels or the request times out, at which point the browser returns a "NotAllowedError" DOMException. Chrome diverges from the WebAuthn spec a little in that errors from the authenticator can cause termination of the entire request (depending on the exact nature of the authenticator's response). Originally, this resulted in the WebAuthn request's promise to be rejected with an error immediately. To allow the relying party (RP) to distinguish a request that was terminated due to a security key not recognizing any of the presented credential IDs from other errors (such as the user clicking "Cancel" in the UI), Chrome therefore returned an InvalidStateError for this particular case, such that the RP could then inform the user that the security key that they tapped wasn't registered with the site. Later, Chrome's WebAuthn implementation added an error to its own UI for this case that informs the user that their security key wasn't recognized. But Chrome still returns the InvalidState error with a special message. This change aligns Chrome's behavior with the spec and makes it return NotAllowedError in this case. Change-Id: Ib2a3c3134555cfc87da451a5c5738b59df674139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602745 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#660519}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a24d934ee476..f0792ce4107c git log a24d934ee476..f0792ce4107c --date=short --no-merges --format='%ad %ae %s' 2019-05-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 609f581d..0d85f6ad (660301:660414) Created with: gclient setdep -r src/third_party/webrtc@f0792ce4107c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I015f41205be1c7c53d57ad83938b965024d3e8ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615643Reviewed-by:
-
Nate Chapin authored
This callback is only used for tests. Two testRunner APIs use it, dumpResourceLoadCallbacks() and dumpResourceResponseMIMETypes(). dumpResourceLoadCallbacks() listens to others, but dumpResourceResponseMIMETypes() is now dead. Most of the tests that use these callbacks have other hooks to verify the state they are trying to test. Change-Id: I6a9cac99fde986d751216b1eb093b99f23adb928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610594Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#660517}
-
David Tseng authored
This is a revert of three ChromeVox options page changes. Unfortunately, the changes below caused major regressions in 74 in many crucial options: - braille options no longer work - audio strategy select is broken The change to snake-casing-style did not account for prefs that were usingCamilCase among other issues. The UI changes itself also added buttons without any labels. The first two changes were necessary because of the last (original) change, which caused the above problems. 108a5913 ChromeVox WebUI: replace paper-icon-button* with cr-icon-button 7d60484c Fix regression in msg id for ChromeVox f08ad04a Update ChromeVox Braille settings to conform to material design. TBR=sarakato@chromium.org,yoshiki@chromium.org Bug: 928185,962705 Change-Id: Ic32175ea0a6ffd2f54796ac44f526177d13aee75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615625Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#660516}
-
Peter Wen authored
Since we now use d8 for dexing, it allows multidex without passing a main dex list: https://developer.android.com/studio/command-line/d8 Bug: 961382 Change-Id: Ied996e816f87f89078fc6664d4aaea77d46254b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615622 Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#660515}
-
