GitLab

Bug: 507755
Change-Id: I369d942e9c9afe3d600885377ce79e09f91ccaea
Reviewed-on: https://chromium-review.googlesource.com/818529Reviewed-by: Evgeniy Stepanov <eugenis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523154}

Convert the native event location to the target's host if it's different
from the source's host.

BUG=714578

Change-Id: I09d64fe043c9d872331dd35babd41ca62280f9c7
Reviewed-on: https://chromium-review.googlesource.com/804954Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523153}

Fix reporting a size of 2x2 on the video element during the loading
phase.

Bug: 684288
Change-Id: Id4adceefaf4c3df57a1ba41fd285862d72792b1a
Reviewed-on: https://chromium-review.googlesource.com/806215
Commit-Queue: Florent Castelli <orphis@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523152}

Caching the network state is dangerous, because a single missed network
connection update can indefinitely block all subsequent requests. Moreover,
there is no benefit to caching the state – it's just extra overhead.

R=pauljensen@chromium.org

Bug: 793103
Change-Id: I21d6318b3b85fb7125cc53b8e3d54842c2ce7564
Reviewed-on: https://chromium-review.googlesource.com/818527Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523151}

Remove a test-only method from DataReductionProxyServer, and update
the callers.

Bug: 760294
Change-Id: Ib90a4fb896df9b14839373aa8741ac8ca2ff8ed1
Reviewed-on: https://chromium-review.googlesource.com/814855
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: rajendrant <rajendrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523150}

X11 header files are infamous for creating macros with common
names such as None, True, False, Status, Bool, ...

To save oursaves the mess that creates, they are now wrapped
in a header, ui/gfx/x/x11.h, which puts those symbols in the
x11 namespace and removes the global macros.

This means we can remove various undefs in files that have had
problems in the past.

Bug: 782184
Change-Id: Ie48fe619e3101344d53ea837b0b21570516185ca
Reviewed-on: https://chromium-review.googlesource.com/814676Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#523149}

Adds recordBoolean and recordEnumerationValue to metricsPrivate.

Bug: 792744
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id4f3e2baf8f15b6010af1115b34c89f542712f66
Reviewed-on: https://chromium-review.googlesource.com/815296Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Katie D <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523148}

This change removes the functions using TestRunner from
bluetooth-helpers.js and places them in a separate
bluetooth-fake-adapter.js file. For the mean time, the new file will be
loaded in loadChromiumResources until all the tests that depend on
TestRunner are converted to use Web Platform Tests. This will allow us
to migrate tests that use bluetooth-helpers.js into the wpt/ directory
since references to TestRunner should not exist in wpt/.

This change also updates the cross-origin-iframe.html test to load the
new bluetooth-fake-adapter.js file in order for the test to run
properly.

BUG=509038

Change-Id: Ic0bc7f5309123f77d7627abf7b63dbd0e6e9dadd
Reviewed-on: https://chromium-review.googlesource.com/817694
Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
Reviewed-by: Conley Owens <cco3@chromium.org>
Reviewed-by: Vincent Scheib <scheib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523147}

cache_storage and notifications both had "CurrentWorkerId()" with
the same (trivial) implementation but used differently. For
jumbo builds to not have those clash, this patch renames the
one in notifications -> NotificationWorkerId()

Bug: 746953
Change-Id: Ic00a4e23448bd2d50315a5561f798ed40be56fdc
Reviewed-on: https://chromium-review.googlesource.com/819558
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523146}

The issue is that during initialization HistoryBackend passes raw pointer of
HistoryDatabase to TypedURLSyncBridge. Later when database error is detected
HistoryBackend resets HistoryDatabase object leaving TypedURLSyncBridge with
invalid pointer. When updates from server arrive TypedURLSyncBridge tries to
write them to database causing crash.

The fix is to notify TypedURLSyncBridge about database error, reset
sync_metadata_database_ pointer and report error to sync so that datatype is
disabled and doesn't receive updates from server.

BUG=789876
R=skym@chromium.org

Change-Id: Ic62709f37eef24f19e7f729998cee56943024084
Reviewed-on: https://chromium-review.googlesource.com/815880Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523145}

SyncService::TriggerRefresh() and ProfileSyncService::RefreshTypesForTest() did the exact same
thing, eventually unifying on the sync thread inside SyncBackendHostCore::DoRefreshTypes. This
change just replaces the less frequently used version of the two with the other.

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I4de6c51f3290d7c8324053cd4cf3379bac35acdd
Reviewed-on: https://chromium-review.googlesource.com/818201Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Mike Baxley <baxley@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523144}

The plumbing was added in 94f2d621
(https://chromium-review.googlesource.com/c/chromium/src/+/693518)

BUG=v8:6827

Change-Id: Id29b36d702eb0857fdfb63d52c3494871ee06501
Reviewed-on: https://chromium-review.googlesource.com/819632Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523143}

In jumbo many files compile together in the same translation
unit and then they share anonymous namespace so if they
use the same constant name, such as kMaxNumberOfBuffers or
kDefaultNumberOfBuffers, they will clash.

Bug: 746953
Change-Id: I0ce707eac13d4f928e482ee62f0d112c69900dae
Reviewed-on: https://chromium-review.googlesource.com/819830
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523142}

LayoutSVGText would not compute the correct transform if subjected to a
transform-origin (or transform) with percentages, since the transform
had to be computed early in UpdateLayout in order to allow a font to be
chosen based on the current transform.

Rearrange the code in LayoutSVGText::UpdateLayout a bit to allow the
transform computation to use the correct bounding box, but also compute
a tentative transform before updating the font and its metrics.

Remove the special-case in SVGElement::CalculateTransform and simplify
accordingly.

Bug: 225799
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I34728dfeaafba72c9f3195a29fbdd14673d186c2
Reviewed-on: https://chromium-review.googlesource.com/817734Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#523141}

At the moment autofill refuses to fill anything if the web site is asking
for a complete phone number but what user has saved is considered as
invalid by libphonenumber.

We should relex this restriction and fill the phone field with exactly what
the user has saved, as long as it's a field expecting complete number.

Phone number components field will still be left empty.

Bug: 793400
Change-Id: Ief7689185dfdf8c29526f620f80f95fed9a6d69c
Reviewed-on: https://chromium-review.googlesource.com/818015
Commit-Queue: Hui Wu <wuandy@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523140}

Debian builds require this package to be installed in order to build.

Change-Id: I6066fb1f3a39842ec076ec82495f0a44a2e17e93
Reviewed-on: https://chromium-review.googlesource.com/817649Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Conley Owens <cco3@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523139}

Reland 37bd8dbf with changes:

1. Destroy the NotificationDisplayServiceTester before the profile goes
   down (to fix the error).
2. Make the extension storage monitor depend on the notification service
   (for correctness --- doesn't help fix this error).
3. Don't explicitly remove notifications when the profile goes down. The
   NotificationDisplayService should remove all transient notifications
   for its profile when it's destroyed, which happens when the profile
   is destroyed. This part is necessary because when you remove a testing
   factory it doesn't reinstate the normal, non-testing factory, so we
   get a null deref. See KeyedServiceFactory::testing_factories_

TBR=stevenjb@chromium.org

Bug: 793548
Change-Id: I834091ad6c53aaf923756e723a234013f92b1cd9
Reviewed-on: https://chromium-review.googlesource.com/817657
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523138}

This method avoids casts from RenderWidgetHost to
RenderWidgetHostImpl.

Bug: 668690
Change-Id: I9618a61d9582e104b3041698d8368a8b14525d7f
Reviewed-on: https://chromium-review.googlesource.com/797010
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523137}

This bug is introduced when adding 'user-hint'.
Add more tests to cover it.

Bug: 793476
Change-Id: I16f4c965a0982ec0015a0a6ecd0aab9fda2b6282
Reviewed-on: https://chromium-review.googlesource.com/818120Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Ganggui Tang <gogerald@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523136}

In https://crrev.com/c/748983 , sidebar implementation is added to
WebNotificationTray behind the flag. Unfortunately, null check condition
in WebNotificationTray::HideMessageCenter() was changed in a way that
affects environment with the flag disabled.
As a result, several crash bugs are introduced becuase
|message_center_bubble_| is not freed even after the tray is closed.

TEST=manual
BUG=792583

Change-Id: I96de43ca3e2bbdfc19519c3b296d29d445a17fcf
Reviewed-on: https://chromium-review.googlesource.com/816778
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523135}

This test did not fail on flaky device bots recently. Perhaps because of
recent fixes in detecting pending navigations.

Bug: 787872
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ic47a3e174d3c7fc923b9aaa1dea957012f22e63b
Reviewed-on: https://chromium-review.googlesource.com/819910Reviewed-by: Yuke Liao <liaoyuke@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523134}

Bug: 792557
Change-Id: Ic1ae08f42822a54707b76bcfd54b450f9ef04008
Reviewed-on: https://chromium-review.googlesource.com/815538Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Katie D <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523133}

This reverts commit baf563db.

Reason for revert: Crash in SkPngEncoder::onEncodeRows (crbug.com/793571)

Original change's description:
> Remove ImageData from toBlob/toDataURL code path
> 
> This change removes ImageData usage from toBlob/toDataURL code path
> from HTMLCanvasElement calls down to the CanvasAsyncBlobCreator.
> 
> Bug: 792110, 657870
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I3e222a68767c1a476f09c1b6188699f62449b95a
> Reviewed-on: https://chromium-review.googlesource.com/809097
> Reviewed-by: Justin Novosad <junov@chromium.org>
> Reviewed-by: Olivia Lai <xlai@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#522248}

TBR=kbr@chromium.org,junov@chromium.org,fserb@chromium.org,xlai@chromium.org,zakerinasab@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 792110, 657870
Change-Id: Ie3e35ab6149a1602ee023f01e8e2eea0dd1b2208
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/819491Reviewed-by: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Commit-Queue: Mohammad Reza Zakerinasab <zakerinasab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523132}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/b987e09a..d34224be

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ib53f0e23bbbb6d64e2e4ff423ea8958efe0c3414
Reviewed-on: https://chromium-review.googlesource.com/819590Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523131}

The mus-backend for aura sometimes does things differently depending
on whether mus is hosting viz or not. So run the unit-tests with mus
hosting viz (which is the case when chrome is run with --mash), and
also with mus not hosting viz (which is the case when chrome is run
with --mus).

Make sure context_fatory(), context_factory_private() are set up
correctly when mus is not hosting viz.

BUG=786453

Change-Id: Icb968cb1fff386f174ffe798315fa7e2301aa341
Reviewed-on: https://chromium-review.googlesource.com/818546Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523130}

We haven't been calling these for a while now (since GPU process
started using leaky approach to shut down faster, and we fixed
window code to pick right size from start).

Bug: None
Test: Build + Run on Luther
Change-Id: I5280628b32c8122a3f86756e3739f5a42bdbf7a4
Reviewed-on: https://chromium-review.googlesource.com/714458Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523129}

The latter was the first time where odd configuration differences were seen
between bots on different waterfalls with the same name, and between gtests
and instrumentation tests with the same names.

Functionality was added to the generation script to be able to target these
cases precisely, so that the existing JSON files could be autogenerated
exactly as they are. (A couple of shortcuts were made in the coverage test
in the meantime and left as TODOs.)

Includes refactorings to several test suites for better reuse.

BUG=662541

Change-Id: I91975c6b9ab0a7fa378de79f32c12709531c2bbe
Reviewed-on: https://chromium-review.googlesource.com/818210Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523128}

There is a working theory that task observers might be too expensive for
worklet thread tasks (0.3ms overhead for a 0.6ms task).

Add tracing to get a better understanding of this theory.

R=skyostil@chromium.org, kraynov@chromium.org
CC=nhiroki@chromium.org, majidvp@chromium.org

Bug: 
Change-Id: If13e769bcdd41baa88b17d93be7a1f18bd3c8580
Reviewed-on: https://chromium-review.googlesource.com/817016
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523127}

The tests broke due to changes on the Chromium side. Specifically,
those changes optimized when the prefs are written. With the changes,
the prefs may not be written in certain cases.

This CL forces the value of effective connection type
as Slow2G in the tests. This causes the prefs to be always written.

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Bug: 793154
Change-Id: Ie09261da07ed44a78b37d02527e105a1dc72ca6c
Reviewed-on: https://chromium-review.googlesource.com/815949
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523126}

This allows us to separate the public NDS interface from the
implementation details that need to be available to the notification
platform bridges.

In addition, by having the message center be a bridge as opposed to it's
own implementation of the NDS interface, supporting the message center
as a fallback becomes much cleaner.

TBR=dtrainor for downloads

Change-Id: Ib4f14197841cafe1835d6a56aa1e0b058e4dc44c
Reviewed-on: https://chromium-review.googlesource.com/793691
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523125}

Bug: 714676
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I80fc5393b8967d15fb3ff44cea51b5c3a9e85f4b
Reviewed-on: https://chromium-review.googlesource.com/816855Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523124}

Bug: 791470
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I85999d1b04f1272011bf5034630cb704b676b67a
Reviewed-on: https://chromium-review.googlesource.com/818569
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523123}

Creates a new ChromeHomeIphBubbleController that contains the logic for
showing help bubbles. BottomSheet still exposes help bubble methods, but
these are simple pass-through methods now.

BUG=793403

Change-Id: If65105821157f53dd1792bba1a66743848e69778
Reviewed-on: https://chromium-review.googlesource.com/817894
Commit-Queue: Theresa <twellington@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523122}

X11 headers pollute the global namespace with macros with
common words like None, Status, False. To avoid problems
because of that we now wrap X11 includes in ui/gfx/x/x11.h
and move all problematic words to the x11 namespace.

Bug: 782184
Change-Id: I81859c8aabae677c40614d3c26036c5d4d1e715a
Reviewed-on: https://chromium-review.googlesource.com/819731Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#523121}

Callers don't need to know the number of capturers.

This change is a prerequisite to expose IsBeingCaptured() on
RenderWidgetHostDelegate, to let RenderWidgetHostViews
determine by themselves whether they need to render
content.

Bug: 788827
Change-Id: If1f7d6b51901bf845d3ec3c8bb93a16f48fefaf1
Reviewed-on: https://chromium-review.googlesource.com/796932
Commit-Queue: François Doray <fdoray@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523120}

DidStartNavigation is called more often than
webDidUpdateSessionForLoadWithURL, which is not a problem in practice.

OmniboxGeolocationController checks every navigation item for update
eligibility, so this CL does not cause any functional changes.

Bug: 674991
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I49a23342e41463766791adc2a7d7edafba2b1575
Reviewed-on: https://chromium-review.googlesource.com/818082
Commit-Queue: Eugene But <eugenebut@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523119}

When a mouse button is pressed an EnterNotify / LeaveNotify XEvent is
generated for the nested XWindow used by the GPU process. The
EnterNotify ends up becoming a ET_MOUSE_DRAGGED event which is wrong. In
general, we want to just ignore the EnterNotify / LeaveNotify events for
nested XWindows.

Bug: 792322
Change-Id: I59af57199c0567001256026332823350b4a45d9e
Reviewed-on: https://chromium-review.googlesource.com/819595Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523118}

R=asvitkine@chromium.org

Bug: none
Change-Id: Ic61c7eabd922c0c5c542c382ad7fd11ba8750f40
Reviewed-on: https://chromium-review.googlesource.com/818729
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523117}

Many files define their own STATIC_ASSERT_ENUM macro. When
those files, in a jumbo build, end up in the same translation
unit, there will be clashes.

For macros that clash, the simplest fix is to undef them after
use to reduce the scope where the symbol is available.

Bug: 746953
Change-Id: Id0d22ed46663c79ce5a43e5f09420b1758bf1d88
Reviewed-on: https://chromium-review.googlesource.com/819633
Commit-Queue: Daniel Bratell <bratell@opera.com>
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523116}

The ContentSuggestions UI target should have been named
content_suggestions_ui. The content_suggestion target is the one for the
coordinator layer.
For now the coordinator/mediator are living in the ios/chrome/browser
folder. They will be moved in a future CL.

Bug: 764720
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I3d2444a4b4caa7897886f69c65774a1b07c8eaa0
Reviewed-on: https://chromium-review.googlesource.com/813755Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523115}