- 30 Apr, 2012 40 commits
-
-
bauerb@chromium.org authored
This allows us to show a nicer placeholder when loading a plug-in fails then the one coming from WebKit. BUG=123580 TEST=manual Review URL: http://codereview.chromium.org/10093011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134620 0039d316-1c4b-4281-b951-d872f2087c98
-
mseaborn@chromium.org authored
I moved sel_ldr_launcher_chrome.cc into the Chromium repo in r134552 but I forgot to update build.scons. This update is necessary for removing sel_ldr_launcher_chrome.cc from the NaCl repo because it ensures that the 'launch_nacl_process' variable (which module_ppapi.cc assigns to) will be defined. (The alternative would be to conditionalise the assignment of 'launch_nacl_process' in module_ppapi.cc.) BUG=http://code.google.com/p/nativeclient/issues/detail?id=2750 TEST=NaCl's Scons build Review URL: http://codereview.chromium.org/10261016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134619 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@google.com authored
Win fix for CL: http://codereview.chromium.org/10235010/ TBR=sadrul BUG=124269 TEST=win aura compiles Review URL: https://chromiumcodereview.appspot.com/10269015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134616 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134615 0039d316-1c4b-4281-b951-d872f2087c98
-
zmo@google.com authored
BUG= TEST=tree Review URL: https://chromiumcodereview.appspot.com/10261018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134614 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@google.com authored
The following cleanup was done in preparation for notifications which may require multiple SystemTrayBubble instances: * Separate out SystemTrayBubbleView from SystemTrayBubble * Move SystemTray.popup_ -> SystemTrayBubble.bubble_widget_ * Remove scoped_ptr for views (views are owned by the view hierarchy) * Changed behavior to not close when focus is lost so that the default view can be reused. BUG=124269 TEST=All tests should pass; system tray behavior should be unchanged. Review URL: https://chromiumcodereview.appspot.com/10235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134612 0039d316-1c4b-4281-b951-d872f2087c98
-
kevers@chromium.org authored
BUG=102482 TEST= Review URL: http://codereview.chromium.org/10260016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134611 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=124843 TEST=as in bug Review URL: http://codereview.chromium.org/10269003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134610 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
The function is no longer used. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/10263012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134609 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Host will have host-specific port allocator, so PortAllocator creation has to be moved out of protocol code. Since PortAllocator needs to be configured with network settings (nat traversal and port range), I refactored how these settings are passed between layers. BUG=103991 Review URL: https://chromiumcodereview.appspot.com/10233021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134608 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
Revert 134604 - Add unit_tests_run that (mostly) works for all of linux, OSX and Windows. Reverted because of build failures. E.g.: make: *** No rule to make target `chrome/test/data/osdd/bogus.xml', needed by `out/Release/unit_tests.results' Revert r134508 "Revert 134507, broke the main builders:" This reapplies r134507. The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py. Manual edits: - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck. - Removed testserver.log and unit_tests.log. - Added copyright. - Removed *.db-journal files. R=rogerta@chromium.org BUG=98636 TEST= Review URL: http://codereview.chromium.org/10271012 TBR=maruel@chromium.org Review URL: https://chromiumcodereview.appspot.com/10274016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134607 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
Revert r134508 "Revert 134507, broke the main builders:" This reapplies r134507. The dependencies were retrieved with trace_inputs.py and merged with merge_isolate.py. Manual edits: - Added <(EXECUTABLE_SUFFIX) to two executables: unit_tests and xdisplaycheck. - Removed testserver.log and unit_tests.log. - Added copyright. - Removed *.db-journal files. R=rogerta@chromium.org BUG=98636 TEST= Review URL: http://codereview.chromium.org/10271012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134604 0039d316-1c4b-4281-b951-d872f2087c98
-
vclarke@chromium.org authored
BUG=125480 TEST=none NOTRY=true Review URL: http://codereview.chromium.org/10269011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134603 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
window message. This is done by overriding the WindowImpl::OnWndProc virtual function in the BrowserFrameWin class which subclasses the NativeWidgetWin instance for the browser frame. BUG=118641 R=sky,cpu Review URL: https://chromiumcodereview.appspot.com/10275002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134602 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://tcmallocnirnimesh@chromium.org authored
Also, restart the browser so that each URL gets a fresh instance in the test. BUG=88574 TEST= Review URL: https://chromiumcodereview.appspot.com/10178028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134601 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
On Windows XP, the new font must be picked such that the font height, not the font size, is the same as the previous font. Add a PlatformFontWin::DeriveFontWithHeight() function that provided the functionality needed for the above and modifies PlatformFontWin to support the above by not assuming LOGFONT.lfHeight is always negative. Instead, it now gets the font size from TEXTMETRIC. One side effect of this change is that the GetFontSize() will now return the actual font size that will be used, rather than the input parameter when creating the font. A test in label_unittest.cc depended on this and is updated as part of this CL. BUG=122143, 105550 TEST=Run Chrome on English Windows XP with CJK languages installed. Go to a website with a Chinese title. The size of the Chinese text in the tab title should be the same as in Chrome 19 (which has use_canvas_skia=0 setting). Also, existing unit tests and newly-added platform_font_win_unittest.cc. Review URL: http://codereview.chromium.org/10228009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134600 0039d316-1c4b-4281-b951-d872f2087c98
-
scottmg@chromium.org authored
Avoids spurious rebuilds when building with ninja on Windows, as it's expecting "yasm" to exist, rather than "yasm.exe". In VS, the dependency check happens to work because there's a directory named "yasm" parallel to yasm.exe which it seems to accept. Also fix minor typo in compile message. Review URL: http://codereview.chromium.org/10206010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134599 0039d316-1c4b-4281-b951-d872f2087c98
-
dennisjeffrey@chromium.org authored
When perf.MemoryTest used to log out/in (for a fresh ChromeOS login), this caused a problem running the test via autotest because the log out cannot be done as user chronos. However, in discussions with nirnimesh@ and sonnyrao@, the agreement is that there's no strong need for a fresh login anyway in this test. This has now been removed from the test. BUG=chromium-os:29815 TEST=None Review URL: https://chromiumcodereview.appspot.com/10273015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134598 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
R=nirnimesh@chromium.org Review URL: https://chromiumcodereview.appspot.com/10272016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134597 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
Manifest restriction violations are now warnings instead of fatal errors. Add background.persistent subkey and restrict it to dev mode. BUG=122459 TEST=no Review URL: https://chromiumcodereview.appspot.com/10217017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134596 0039d316-1c4b-4281-b951-d872f2087c98
-
binji@chromium.org authored
BUG=none TEST=none Review URL: https://chromiumcodereview.appspot.com/10271013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134595 0039d316-1c4b-4281-b951-d872f2087c98
-
wez@chromium.org authored
* MouseInputFilter is moved from remoting/client/ to remoting/protocol/. * ClientSession now implements clamping using MouseInputFilter. * EventExecutors no longer drop out-of-bounds events. BUG=118511 Review URL: http://codereview.chromium.org/10255007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134594 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=chromium-os:30248 TEST=make sure that canceling downloads does not cause stack overflow (crash) Review URL: https://chromiumcodereview.appspot.com/10262015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134593 0039d316-1c4b-4281-b951-d872f2087c98
-
sheu@chromium.org authored
Guest logins in ChromeOS cause Chrome to restart itself through dbus. Some debugging flags aren't propagated through the restart -- these include: * --disable-gpu-watchdog * --no-sandbox * --gpu-startup-dialog * --renderer-startup-dialog Add these to the list of propagated flags. Change-Id: I977eabe322447174ca7281137838012d042bac6f BUG= TEST= Review URL: http://codereview.chromium.org/10228020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134592 0039d316-1c4b-4281-b951-d872f2087c98
-
krisr@chromium.org authored
BUG=None Test=Ran it Review URL: https://chromiumcodereview.appspot.com/10264012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134591 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=None TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10271020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134590 0039d316-1c4b-4281-b951-d872f2087c98
-
satorux@chromium.org authored
In preparation for removing GetFileInfoByPath(), which is a synchronous function. The new function is not used in production code yet. BUG=chromium-os:30066 TEST=add unit tests Review URL: https://chromiumcodereview.appspot.com/10270018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134589 0039d316-1c4b-4281-b951-d872f2087c98
-
benjhayden@chromium.org authored
Review URL: http://codereview.chromium.org/10103004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134588 0039d316-1c4b-4281-b951-d872f2087c98
-
tbreisacher@chromium.org authored
BUG=122002 TEST=presubmit Review URL: https://chromiumcodereview.appspot.com/10007041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134586 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This breaks the multi-line date/day-of-week and battery text in the uber system tray across multiple labels so we can add a bit more spacing between the lines. A side effect (maybe a slight improvement?) is that some of the longer strings (e.g. "Calculating remaining time") now get elided instead of getting wrapped and clipped. Since I needed to change the battery-related strings anyway, I'm also splitting the "2h 23m"-style string into "2h 23m remaining" and "2h 23m until full". BUG=124664,124074 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10209038 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134585 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This debugger traps in debug mode due to the locks held at the time that the callback is made. BUG=125299 TEST=none Review URL: http://codereview.chromium.org/10221018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134584 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
TBR=cpu Review URL: https://chromiumcodereview.appspot.com/10271017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134583 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=122753 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10202025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134582 0039d316-1c4b-4281-b951-d872f2087c98
-
jsbell@chromium.org authored
IndexedDB allows key paths to be strings or arrays of strings (or null, for object stores). Implement the new WebKit API that uses a dedicated type instead of strings, and implement appropriate IPC plumbing. This change is dependent on: https://webkit.org/b/84631 R=darin@chromium.org,tkent@chromium.org,dgrogan@chromium.org,michaeln@chromium.org BUG=112308 Review URL: http://codereview.chromium.org/10204003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134581 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
R=rogerta@chromium.org BUG=98636 TEST=committing r134507 again would work Review URL: http://codereview.chromium.org/10261010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134580 0039d316-1c4b-4281-b951-d872f2087c98
-
jianli@chromium.org authored
BUG=123176 TEST=existing tests Review URL: http://codereview.chromium.org/10209037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134579 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=None TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10260019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134578 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=122753 TEST=manual Review URL: http://codereview.chromium.org/10238016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134577 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
SDCH is used to fetch a dictionary for decompression, and is generally not protected (and generally has no PII). It specifically does not use SSL in handling compressed content, and so other than plausibly gathering stats, there is no reason to use, or save cookies during a dicitonary fetch. r=rtenneti bug=118952 Review URL: http://codereview.chromium.org/10271011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134576 0039d316-1c4b-4281-b951-d872f2087c98
-
jamiewalch@google.com authored
BUG=None TEST=Manual Review URL: https://chromiumcodereview.appspot.com/10265011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@134575 0039d316-1c4b-4281-b951-d872f2087c98
-