Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 31 Jan, 2015 8 commits
    • sudarsana.nagineni's avatar
      Move chrome.alarms API from chrome/ to extensions/. · 745ff1db
      sudarsana.nagineni authored 
      This CL allows app_shell to use chrome.alarms.

Also it includes the following changes related to unit tests:
- Moved chrome.alarms tests to extensions/
- Moved a helper function CreateEmptyExtensionWithLocation()
  from extension_function_test_utils.h to api_test_utils.h.
- Moved CreateBackgroundPage() from extension_api_unittest.h to
  api_unittest.h.
- Creates WebContents for the extension that can be used to associate
  a RenderViewHost in extension unit tests.

BUG=443622

Review URL: https://codereview.chromium.org/789643004

Cr-Commit-Position: refs/heads/master@{#314040}
      745ff1db
    • tfarina's avatar
      Cleanup: Presubmit API is built into depot_tools. · 78bb92f4
      tfarina authored 
      Not in gcl, which probably these days nobody working on Chromium uses.

BUG=None
R=maruel@chromium.org
TBR=maruel@chromium.org
NOPRESUBMIT=true

Review URL: https://codereview.chromium.org/887033002

Cr-Commit-Position: refs/heads/master@{#314039}
      78bb92f4
    • vadimt's avatar
      Undoing instrumentations since the bug is fixed. · 500c3d5d
      vadimt authored 
      BUG=422489
TBR=mmenke

Review URL: https://codereview.chromium.org/889653004

Cr-Commit-Position: refs/heads/master@{#314038}
      500c3d5d
    • maruel's avatar
      Roll tools/swarming_client/ to c698ea2a7781c493a8e09d0e89415a4aab8e1f62. · aa02e0fc
      maruel authored 
      $ git log d863df383..c698ea2a7 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2015-01-30 maruel Add back -H since it's actively used.
2015-01-28 maruel Remove 1_local.py as it was not relevant anymore.
2015-01-28 maruel Rename --hash to --isolated and -i to -s.

R=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/884473007

Cr-Commit-Position: refs/heads/master@{#314037}
      aa02e0fc
    • jiayl's avatar
      Fix webrtcAudioPrivate API to handle requests from <webview>s. · 77c6128e
      jiayl authored 
      BUG=424762

Review URL: https://codereview.chromium.org/880393002

Cr-Commit-Position: refs/heads/master@{#314036}
      77c6128e
    • fsamuel's avatar
      Move Color Picker Plumbing From WebViewGuest to GuestViewBase · 9549ee3b
      fsamuel authored 
      This allows all GuestView types to have access to a color picker.

BUG=451737

Review URL: https://codereview.chromium.org/889873004

Cr-Commit-Position: refs/heads/master@{#314035}
      9549ee3b
    • tedchoc's avatar
      Revert of media: Enable Opus support in Clank <video> and MSE (patchset #5... · 2da6713c
      tedchoc authored 
      Revert of media: Enable Opus support in Clank <video> and MSE (patchset #5 id:100001 of https://codereview.chromium.org/866573004/)

Reason for revert:
This is breaking downstream builders on L:

C 1029.038s Main  [FAIL] MediaCanPlayTypeTest.CodecSupportTest_webm:
C 1029.038s Main  [ERROR:unix_domain_server_socket_posix.cc(106)] Not implemented reached in virtual int net::UnixDomainServerSocket::GetLocalAddress(net::IPEndPoint*) const
C 1029.039s Main  [WARNING:proxy_service.cc(898)] PAC support disabled because there is no system implementation
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:278: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp8, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.039s Main  Expected: kOpusProbably
C 1029.039s Main  Which is: ""
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:279: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp8.0, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.039s Main  Expected: kOpusProbably
C 1029.039s Main  Which is: ""
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:285: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp9, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.039s Main  Expected: VP9AndOpusProbably
C 1029.039s Main  Which is: ""
C 1029.039s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:287: Failure
C 1029.039s Main  Value of: CanPlay("'video/webm; codecs=\"vp9.0, opus\"'")
C 1029.039s Main    Actual: "probably"
C 1029.040s Main  Expected: VP9AndOpusProbably
C 1029.040s Main  Which is: ""
C 1029.040s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:296: Failure
C 1029.040s Main  Value of: CanPlay("'audio/webm; codecs=\"opus\"'")
C 1029.040s Main    Actual: "probably"
C 1029.040s Main  Expected: kOpusProbably
C 1029.040s Main  Which is: ""
C 1029.040s Main  ../../content/browser/media/media_canplaytype_browsertest.cc:297: Failure
C 1029.040s Main  Value of: CanPlay("'audio/webm; codecs=\"opus, vorbis\"'")
C 1029.040s Main    Actual: "probably"
C 1029.040s Main  Expected: kOpusProbably
C 1029.040s Main  Which is: ""

Spoke with vigneshv@ and reverting for now is the best thing to do while a fix is prepared.

Original issue's description:
> media: Enable Opus support in Clank <video> and MSE
>
> Opus audio codec is supported by the android platform starting from Lollipop.
> This CL enables canPlayType() support for Opus on Clank and MSE playback of Opus
> in Clank. This brings Opus feature parity with Desktop Chromium.
>
> BUG=318436
>
> Committed: https://crrev.com/95fcf214b5a9ba718d53efbf509c9d92e2514e4f
> Cr-Commit-Position: refs/heads/master@{#313549}

TBR=tomfinegan@chromium.org,wolenetz@chromium.org,rsleevi@chromium.org,qinmin@chromium.org,jschuh@chromium.org,vigneshv@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=318436

Review URL: https://codereview.chromium.org/889053003

Cr-Commit-Position: refs/heads/master@{#314034}
      2da6713c
    • Scott Hess's avatar
      [sql] Fix CRLF in some SQLite source code. · 64ce04c6
      Scott Hess authored 
      Sometimes CRLF sneak into SQLite's code, and then causes patch errors
when landing in Chromium.  Add an import step for cleaning this up and
clean things up.

None of these files are in the Chromium build.  They just gum up the
works.

BUG=340757
TBR=michaeln@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/880533004

Cr-Commit-Position: refs/heads/master@{#314033}
      64ce04c6
  3. 30 Jan, 2015 32 commits