GitLab

Previously

  a = [
    "x",
    "y",   # Comment1
           # Comment2
  ]

would turn into
  a = [
    "x",
    "y",   # Comment1# Comment2
  ]

(Child of https://codereview.chromium.org/606123002/)

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/613473002

Cr-Commit-Position: refs/heads/master@{#297235}

Review URL: https://codereview.chromium.org/586103004

Cr-Commit-Position: refs/heads/master@{#297234}

BUG=None

Review URL: https://codereview.chromium.org/608133002

Cr-Commit-Position: refs/heads/master@{#297233}

$ git log 79940aeee..37bcce2f5 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-09-29 jam Make isolate_format.py handle integer variables.
2014-09-24 maruel Update HttpServeri.json_request() to accept all request() arguments.
2014-09-24 maruel Rename examples to have more specific names.

This is needed for https://codereview.chromium.org/605063004/.

R=maruel@chromium.org
BUG=414808

Review URL: https://codereview.chromium.org/595183004

Cr-Commit-Position: refs/heads/master@{#297232}

With this, gn format //BUILD.gn results in no changes, other than to
make 'deps += [ "a" ]' turn into one line instead of multiline.

(Child of https://codereview.chromium.org/608593006/)

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/606123002

Cr-Commit-Position: refs/heads/master@{#297231}

This service doesn't need any Chrome dependencies after all and so it
can move into //extensions. This will make it possible for the USB
extensions API code to directly depend on it. In the process I have
rewritten the service with a couple improvements:

* C++11 for-each loops are used instead of explicit iterators.
* The DevicePermissions object is no longer an inner class (so it can
  be forward declared) and it is explicitly copied when requested so
  that the ownership of data on the FILE and UI threads is clear.

BUG=

Review URL: https://codereview.chromium.org/606503002

Cr-Commit-Position: refs/heads/master@{#297230}

This will disable the keyboard accelerator on all OSes and will disable
the File menu item on Mac.

BUG=413932, 103846

Review URL: https://codereview.chromium.org/601283003

Cr-Commit-Position: refs/heads/master@{#297229}

(Child of https://codereview.chromium.org/607173002/)

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/608593006

Cr-Commit-Position: refs/heads/master@{#297228}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/47c548a..656f2cd

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/615603002

Cr-Commit-Position: refs/heads/master@{#297227}

Fixes comments at the end of a block like:

  stuff() {
    sources = []
    # wee
  }

This is done by storing an EndNode (instead of just a Token) as the
end of Block and List nodes. This means there's a node in the tree
traversal for the trailing ], and gives a place to attach the comment.

Also collapses some of the expression output code to reuse Sequence.

R=brettw@chromium.org
BUG=348474

Review URL: https://codereview.chromium.org/607173002

Cr-Commit-Position: refs/heads/master@{#297226}

Change the pre-handshake idle timeout to 5s from 120s, and the default
idle timeout is 30s.

This ensures clients don't wait more than 5s if the connection has UDP
blackholed.

Merge internal change: 76444120
https://codereview.chromium.org/610073002/

Add a convenience method to check for client supplied options in
QuicSentPacketManager.

Merge internal change: 76423808
https://codereview.chromium.org/607803004/

Add a QUIC tag to connection options to allow negotiating 1 connection
emulation in congestion control algorithms.

Merge internal change: 76351810
https://codereview.chromium.org/606503004/

Allow the number of connections QUIC's send algorithms simulate to
change, either initially or throughout the connection.

Merge internal change: 76297032
https://codereview.chromium.org/610053002/

Remove support for QUIC_VERSION_16.

Merge internal change: 76286812
https://codereview.chromium.org/601663004/

QUIC server max streams is now at least 10 streams larger than
configured limit. Protected by existing
FLAGS_quic_allow_more_open_streams.

Merge internal change: 76269911
https://codereview.chromium.org/607763007/

No functional change.  Rename QuicConfig methods from lowercase with
underscores to CamelCase, since they're not direct field accessors.

Merge internal change: 76185470
https://codereview.chromium.org/608453007/

Add a test to ensure QUIC's TcpCubicSender always allows packets to be
sent when there is less than a packet in flight.

Merge internal change: 76165601
https://codereview.chromium.org/608003002/

Merge QuicSentPacketManager::DebugDelegate's OnSentPacket,
OnRetransmittedPacket, and OnSerializedPacket into one OnSentPacket.

Merge internal change: 76088200
https://codereview.chromium.org/607983002/

Remove OnPacketRetransmitted from QuicConnectionDebugVisitor.

Merge internal change: 76084748
https://codereview.chromium.org/605263003/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/605163004

Cr-Commit-Position: refs/heads/master@{#297225}

This also removes the android_webview GpuMemoryBuffer
implementation.

BUG=418553

Review URL: https://codereview.chromium.org/608263002

Cr-Commit-Position: refs/heads/master@{#297224}

R=ncbray@chromium.org

Review URL: https://codereview.chromium.org/608613003

Cr-Commit-Position: refs/heads/master@{#297223}

Previously we were only doing this if the --new-avatar-menu was flipped.
This is a two-part CL. This CL removes the usages of the strings, but not
the strings themselves, since that involves some renaming and I'd like
to merge this to M39.

The CL that actually removes the unused strings is:
https://codereview.chromium.org/603023004/

XIB changes: use a different string ID for the profiles menu in the menu bar.
BUG=405988

Review URL: https://codereview.chromium.org/611033002

Cr-Commit-Position: refs/heads/master@{#297222}

This is part of a long-running background task to remove the remaining
uses of the unchecked IPC_ENUM_TRAITS() macro.

BUG=246708

Review URL: https://codereview.chromium.org/601153002

Cr-Commit-Position: refs/heads/master@{#297221}

The AudioBuffersState object doesn't appear to be necessary anymore.
Most code either completely ignores this information or doesn't actually
care about the difference between pending_bytes and hardware_delay_bytes.
Also usually only one of the 2 fields was actually being used at a time.
This change removes the class and simply uses an int that represent the
total number of delay bytes.

BUG=125685

Review URL: https://codereview.chromium.org/481193003

Cr-Commit-Position: refs/heads/master@{#297220}

This commit resolves build errors that occur when ENABLE_MANAGED_USERS is not
defined:

1. Managed/supervised code for various components are now conditionally
   excluded in gyp files.
2. Added #ifdef guards in source files that include files in the
   chrome/browser/supervised_user folder.
3. Add missing include to supervised_users.h in files in the
   supervised_user folder to force compiler errors when not guarded properly.
4. Added an include in create_profile_handler.cc to web_ui.h, since it is
   indirectly included by the supervised_user* .h files.

BUG=389611

Review URL: https://codereview.chromium.org/355233002

Cr-Commit-Position: refs/heads/master@{#297219}

The previous attempt was reverted due to a Valgrind false positive
that's now suppressed.

BUG=410810,418234
TBR=thakis

Review URL: https://codereview.chromium.org/612093003

Cr-Commit-Position: refs/heads/master@{#297218}

The flag is set on all platforms and adds uneeded complexity to the
scheduler.

BUG=418368

Review URL: https://codereview.chromium.org/609003002

Cr-Commit-Position: refs/heads/master@{#297217}

See also https://groups.google.com/a/chromium.org/d/msg/chromium-dev/utDItV2a7aE/IeVDbl5L77cJ

Review URL: https://codereview.chromium.org/605243003

Cr-Commit-Position: refs/heads/master@{#297216}

In Widget::OnMouseEvent(), do not handle MOUSE_MOVED
events as MOUSE_DRAGGED events, and do not handle
MOUSE_DRAGGED events as MOUSE_MOVED events; instead
trust that the mouse event type has been set correctly
before arriving at Widget. This also allows us to
remove the member |is_mouse_button_pressed_|
from Widget.

BUG=412929, 412931
TEST=WidgetTest.DragIntoView, WidgetTest.DragOutOfView

Review URL: https://codereview.chromium.org/560053002

Cr-Commit-Position: refs/heads/master@{#297215}

This makes the use of Pass() similar to how std::move() would be used
to make this code act as it should when using unique_ptr.

R=sky@chromium.org
BUG=418297

Review URL: https://codereview.chromium.org/609083002

Cr-Commit-Position: refs/heads/master@{#297214}

BUG=416206
TEST=None
R=tfarina,tony
TBR=oshima

Review URL: https://codereview.chromium.org/608683003

Cr-Commit-Position: refs/heads/master@{#297213}

R=rch@chromium.org
BUG=

Review URL: https://codereview.chromium.org/518593002

Cr-Commit-Position: refs/heads/master@{#297212}

Control with use_openssl, not with per-platform special-cases.

BUG=416683

Review URL: https://codereview.chromium.org/569683003

Cr-Commit-Position: refs/heads/master@{#297211}

- kEmptyPakContents was malformed; fix it
- chrome.pak was deleted half a year ago for iOS Chrome; don't try to load it

BUG=410411
TEST=no visible change

Review URL: https://codereview.chromium.org/611103002

Cr-Commit-Position: refs/heads/master@{#297210}

FrameBuffer::GetStatus() was spending most of the time doing in printf,
I've modified it to generate signatures using a binary representation
instead. Now most of the time is spent allocating memory. If further
optimization is necessary we can precalculate the signature size
as well.

BUG= https://code.google.com/p/chromium/issues/detail?id=338035
TEST= profile FrameBuffer::GetStatus()

Review URL: https://codereview.chromium.org/593233002

Cr-Commit-Position: refs/heads/master@{#297209}

Remove loss detection from QuicConfig now that connection options has
replaced it.

Merge internal change: 75952172

Chromium specific changes:
+ Deleted enable_quic_time_based_loss_detection from
  NetworkSession params.
+ Deleted enable-quic-time-based-loss-detection and
  disable-quic-time-based-loss-detection command line
  switches.

https://codereview.chromium.org/591323003/

Do not timeout QUIC connections when settings the timeouts from
InitializeSession(). Protected by FLAG_quic_timeouts_only_from_alarms

Removes FLAG_quic_timeouts_require_activity which was somewhat broken.

Merge internal change: 75927669
https://codereview.chromium.org/605903002/

Factor out the QUIC timeout alarm setting logic from the CheckForTimeout
method into a new SetTimeout method.

- no behavior change, simply moving QUIC timeout alarm code.

Merge internal change: 75915264
https://codereview.chromium.org/593193005/

Add a timestamp field to QUIC's CachedNetworkParams proto message.

Context in b/17357338, follow-up CL will store CachedNetworkParams and
copy into newly created STKs.

Merge internal change: 75897792
https://codereview.chromium.org/604173002/

Call QuicSentPacketManager's OnPacketSent method and make
OnRetransmittedPacket and OnSerializedPacket private.

Merge internal change: 75830237
https://codereview.chromium.org/593193004/

Change the return type of QuicConnection::CheckForTimeout from bool to
void since it is unused.

Merge internal change: 75724127
https://codereview.chromium.org/604163002/

Test-only.  Remove calls to OnSerializedPacket from
QuicSentPacketManagerTest, in preparation for OnSerializedPacket to be
removed.

Merge internal change: 75716236
https://codereview.chromium.org/600823006/

R=rch@chromium.org, sky@chromium.org

Added sky@ for OWNERS approval for chrome/browser and chrome/common
changes

Review URL: https://codereview.chromium.org/605733006

Cr-Commit-Position: refs/heads/master@{#297208}

BUG=

Review URL: https://codereview.chromium.org/603273003

Cr-Commit-Position: refs/heads/master@{#297207}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/4ceb039..47c548a

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=robertphillips@google.com

Review URL: https://codereview.chromium.org/613773002

Cr-Commit-Position: refs/heads/master@{#297206}

BUG=417528
TEST=bots

Review URL: https://codereview.chromium.org/604423006

Cr-Commit-Position: refs/heads/master@{#297205}

Record the number of loaded profiles when a profile is erased from the profiles map kept by profile manager.

The reason behind is, UMA is observing a significant amount of times when GetLoadedProfiles returns an empty list (multiple times during one session). We hope that recording such a histogram would help to find out the reason for it, or at least eliminate one possibility.

BUG=412794

Review URL: https://codereview.chromium.org/605333002

Cr-Commit-Position: refs/heads/master@{#297204}

BUG=

Review URL: https://codereview.chromium.org/612753005

Cr-Commit-Position: refs/heads/master@{#297203}

We want the invalidations code to exist as a component
independent of sync (see bug). This CL seeks to move toward
that for the Android invalidations codebase.

Generally, things moved from //chrome/browser/invalidation
to //components/invalidation, even if git didn't mark them
as moves.

To accomplish this, I had to unify where the JNI occurred.
In Java, InvalidationService was renamed to
InvalidationClientService as the class that communicates
with GCM.

A new InvalidationService class was introduced to handle JNI
and other Java entry points to the component. Several
methods from ProfileSyncService and InvalidationController
moved to it.

InvalidationController is now the bridge between sync and
the invalidation component, and has no JNI nor C++
counterpart.

InvalidationServiceFactory was added to assist in the
creation and management of InvalidationService objects
across the JNI boundary.

BUG=259559

Review URL: https://codereview.chromium.org/459513002

Cr-Commit-Position: refs/heads/master@{#297202}

This rolls to a version of our mesa library that does not have the
CL, GLES2, EGL or VG headers.  We should never use CL/VG headers, we
should always use GLES2 and EGL headers from khronos.

Review URL: https://codereview.chromium.org/612523002

Cr-Commit-Position: refs/heads/master@{#297201}

Unset LDFLAGS before building. Otherwise we override the default LDFLAGS in the
makefile, breaking the build. We want to append our flags to the default flags
instead.

BUG=418175
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/611083003

Cr-Commit-Position: refs/heads/master@{#297200}

This fixes a DCHECK failure on chrome://print, where no handler was
registered to handle chrome.send("dialogClose").

BUG=416783

Review URL: https://codereview.chromium.org/614683002

Cr-Commit-Position: refs/heads/master@{#297199}

If the fling update is close to the final state, then stop the fling. The
threshold for this used to be 1e-5f, but change it to 1e-1f, since there
won't be any visual changes for subsequent fling-update steps.

BUG=none
R=jdduke@chromium.org

Review URL: https://codereview.chromium.org/606093002

Cr-Commit-Position: refs/heads/master@{#297198}

It is a proprietary extension of the Web Manifest.

BUG=414873

Review URL: https://codereview.chromium.org/580513002

Cr-Commit-Position: refs/heads/master@{#297197}

Also, remove pepper_31 (the current oldest SDK) such
that the total number of SDKs we publish stays constant.

R=binji@chromium.org

Review URL: https://codereview.chromium.org/615573002

Cr-Commit-Position: refs/heads/master@{#297196}