GitLab

BUG=341275
NOTRY=true

Review URL: https://codereview.chromium.org/213673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=357683

NOTRY=true

TESTED= try jobs passed

Review URL: https://codereview.chromium.org/217303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260305 0039d316-1c4b-4281-b951-d872f2087c98

R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/217403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260304 0039d316-1c4b-4281-b951-d872f2087c98

Document the "remote get nexe <path>" and
"remote get irt <other-path>" commands.
Also document the --nacl-debug-mask=<pattern_set> flag.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=3765
NOTRY=true

Review URL: https://codereview.chromium.org/217683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260303 0039d316-1c4b-4281-b951-d872f2087c98

TODO: Add a regression test to cros repository or figure out how credentials.json
can be used for a unit test.

BUG=308757
TEST=manual
NOTRY=True

Review URL: https://codereview.chromium.org/205763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260302 0039d316-1c4b-4281-b951-d872f2087c98

Include the disk serial number as a factor that is neither easily predictable nor known to the server side as well as a quantized time stamp, so the identifiers become invalid after a while.

BUG=chromium:352599
TEST=Forced re-enrollment still works.
R=joaodasilva@chromium.org, stevenjb@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/212653004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260301 0039d316-1c4b-4281-b951-d872f2087c98

> Give localserver time to shut down
> 
> On machines with slow I/O, the localserver might not shut down immediately,
> wait for it if necessary.
> 
> BUG=
> 
> Review URL: https://codereview.chromium.org/145873004

TBR=sigbjorn@opera.com

Review URL: https://codereview.chromium.org/217913002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260300 0039d316-1c4b-4281-b951-d872f2087c98

Still trying to track down cause of MultiProfileFileManagerBrowserTest failures:
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%282%29/builds/22674


> Separate audio player tests from special file test of Files.app (2nd)
> 
> I have a plan to add more audio player tests. Before that, make audio player tests
> separated for readability.
> 
> This is the 2nd (last) part of the work of crrev.com/214463002. First part is committed as crrev.com/260069.
> 
> BUG=none
> TEST=browser_test passes
> TBR=hirino@chromium.org
> 
> Review URL: https://codereview.chromium.org/212123008

TBR=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/217743002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260298 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Broke build.

http://build.chromium.org/p/chromium.linux/builders/Linux%20Builder%20%28dbg%29/builds/71042/steps/compile/logs/stdio#error1

Original issue's description:
> Rename PrivateMode enum values:
> 
> kPrivacyModeDisabled => PRIVACY_MODE_DISABLED
> kPrivacyModeEnabled  => PRIVACY_MODE_ENABLED
> 
> To match the chromium style guide:
> 
> Though the Google C++ Style Guide now says to use kConstantNaming for enums,
> Chromium was written using MACRO_STYLE naming.  Continue to use this style for consistency.
> 
> R=mef@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260281

TBR=mef@chromium.org,zea@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/217053010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260296 0039d316-1c4b-4281-b951-d872f2087c98

to QuicStreamFactory.

Review URL: https://codereview.chromium.org/209413005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260295 0039d316-1c4b-4281-b951-d872f2087c98

Bonus Fix:
fillFromChromeLocalStorage now handles undefined defaults correctly.

BUG=353703
R=rgustafson@chromium.org, skare@chromium.org, xiyuan@chromium.org

Review URL: https://codereview.chromium.org/217263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260294 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=jam@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/211383007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260293 0039d316-1c4b-4281-b951-d872f2087c98

The link is not underlined and there is 10px padding between the link and the right edge.

BUG=354893

NOTRY=true

Review URL: https://codereview.chromium.org/208643004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260290 0039d316-1c4b-4281-b951-d872f2087c98

BUG=164681, 171271

Review URL: https://codereview.chromium.org/211543008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260289 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260288 0039d316-1c4b-4281-b951-d872f2087c98

Enable the brightness keys unconditionally (i.e. also on
systems that lack internal displays).

BUG=chromium:315371
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/214643005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260287 0039d316-1c4b-4281-b951-d872f2087c98

https://codereview.chromium.org/214593010/ is missing 200 percent resource. This CL replaces it.

BUG=357351
TBR=mgiuca@chromium.org

Review URL: https://codereview.chromium.org/217593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260286 0039d316-1c4b-4281-b951-d872f2087c98

I suspect that this caused the VerifyEncryption failure here:
http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%283%29/builds/25821


> Relanding Switched main WebRTC browser tests to use a more realistic video
> 
> > Switched main WebRTC browser tests to use a more realistic video.
> 
> > After switching to fake device flags instead of software webcams, we
> > noticed a ton of video-related metrics changed. This is because the
> > spinning green ball is an unrealistic encode/decode example. This patch
> > will use the new fake device file flag to play a more realistic video.
> 
> > BUG=352261, 343504
> > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259887
> 
> TBR=tommi@chromium.org
> BUG=352261, 343504
> 
> Review URL: https://codereview.chromium.org/216773002

TBR=phoglund@chromium.org

Review URL: https://codereview.chromium.org/217553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260284 0039d316-1c4b-4281-b951-d872f2087c98

[ RUN      ] VideoCaptureDeviceTest.FakeCaptureVariableResolution
Received signal 11 SEGV_MAPERR 000000000000
...
06:57:35 memcheck_analyze.py [ERROR] FAIL! There were 2 errors:
InvalidRead
Invalid read of size 4
  FontNameCacheNodeProc(DLCacheTree const*, void*, void*, void*, unsigned char*)
  FindInDLCacheTree
  FindEntryInNameCache
  _eFOFindName
  FindNameAsCFString
  ATSFontGetPostScriptName
  TBaseFont::GetPlatformFont() const
  CTFontRef_to_SkFontID(__CTFont const*)
  NewFromFontRef(__CTFont const*, char const*)
  NewFromName(char const*, SkTypeface::Style)
  create_typeface(SkTypeface const*, char const*, SkTypeface::Style)
  SkFontMgr_Mac::onLegacyCreateTypeface(char const*, unsigned int) const
  SkFontMgr::legacyCreateTypeface(char const*, unsigned int) const
  SkFontHost::CreateTypeface(SkTypeface const*, char const*, SkTypeface::Style)
  SkTypeface::create_default_typeface(SkTypeface::Style)
  _ZL12sk_once_slowI10SkSpinlockPFvN10SkTypeface5StyleEES2_EvPbPT_T0_T1_PFvvE
  void SkOnce<SkSpinlock, void (*)(SkTypeface::Style), SkTypeface::Style>(bool*, SkSpinlock*, void (*)(SkTypeface::Style), SkTypeface::Style, void (*)())
  void SkOnce<void (*)(SkTypeface::Style), SkTypeface::Style>(SkOnceFlag*, void (*)(SkTypeface::Style), SkTypeface::Style, void (*)())
  SkTypeface::GetDefaultTypeface(SkTypeface::Style)
  SkScalerContext::MakeRec(SkPaint const&, SkDeviceProperties const*, SkMatrix const*, SkScalerContextRec*)
  SkPaint::descriptorProc(SkDeviceProperties const*, SkMatrix const*, void (*)(SkTypeface*, SkDescriptor const*, void*), void*, bool) const
  SkPaint::detachCache(SkDeviceProperties const*, SkMatrix const*) const
  SkAutoGlyphCache::SkAutoGlyphCache(SkPaint const&, SkDeviceProperties const*, SkMatrix const*)
  SkAutoGlyphCache::SkAutoGlyphCache(SkPaint const&, SkDeviceProperties const*, SkMatrix const*)
  SkDraw::drawText(char const*, unsigned long, float, float, SkPaint const&) const
  SkBitmapDevice::drawText(SkDraw const&, void const*, unsigned long, float, float, SkPaint const&)
  SkCanvas::drawText(void const*, unsigned long, float, float, SkPaint const&)
  media::FakeVideoCaptureDevice::OnCaptureTask()
Address 0xd11a5aaa is not stack'd, malloc'd or (recently) free'd

BUG=344108
TBR=mcasas@chromium.org
NOTRY=TRUE

Review URL: https://codereview.chromium.org/217503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260282 0039d316-1c4b-4281-b951-d872f2087c98

kPrivacyModeDisabled => PRIVACY_MODE_DISABLED
kPrivacyModeEnabled  => PRIVACY_MODE_ENABLED

To match the chromium style guide:

Though the Google C++ Style Guide now says to use kConstantNaming for enums,
Chromium was written using MACRO_STYLE naming.  Continue to use this style for consistency.

R=mef@chromium.org

Review URL: https://codereview.chromium.org/215023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260281 0039d316-1c4b-4281-b951-d872f2087c98

current input method.

BUG=335368

Review URL: https://codereview.chromium.org/187313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260280 0039d316-1c4b-4281-b951-d872f2087c98

- Creates repack_pack.gypi action
- Updates all the call-sites of repack.py
- Removes chrome_repack_pseudo_locales.gypi to instead use
  chrome_repack_locales.gypi
- Remove unused repack_locales_cmd list

BUG=338759
R=tfarina@chromium.org, thakis@chromium.org
TBR=asargent@chromium.org, benm@chromium.org, blundell@chromium.org

Review URL: https://codereview.chromium.org/216013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260279 0039d316-1c4b-4281-b951-d872f2087c98

BUG=160900
R=creis@chromium.org, joi@chromium.org, thestig@chromium.org, tsepez@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/185393012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260276 0039d316-1c4b-4281-b951-d872f2087c98

This is a Windows-specific stat tracking mechanism that uses the Windows
registry and update mechanism. It isn't appropriate on Linux. We already
have UMA stats for the App Launcher (including Linux); see
app_list_service_impl.cc.

BUG=357447

Review URL: https://codereview.chromium.org/216163002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260275 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351836
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/217493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260274 0039d316-1c4b-4281-b951-d872f2087c98

R=vandebo@chromium.org
BUG=343968

Review URL: https://codereview.chromium.org/215433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260273 0039d316-1c4b-4281-b951-d872f2087c98

The only dependency here is on some static methods that
are only used by ExtensionPrefs. These should live inside
the ExtensionPrefs module.

(clang_format also applied, pardon the dust)

BUG=357634,162530
R=scheib@chromium.org

Review URL: https://codereview.chromium.org/217053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260272 0039d316-1c4b-4281-b951-d872f2087c98

Cacheinvalidations retries sending messages when network becomes available
and some time has passed since last attempt to send message. This change
is to notify cacheinvalidations about network status change.

Switch to transient error only when sending message failed.
Switch to INVALIDATIONS_ENABLED to let cacheinvalidations retry when
network changes.

BUG=325020
R=rlarocque@chromium.org

Review URL: https://codereview.chromium.org/215073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260271 0039d316-1c4b-4281-b951-d872f2087c98

When Forward Error Correction (FEC) packets arrive, jitter buffer
will consider them missing. The jitter buffer needs to use the
picture ID to see if a new frame is continuous to the previous
frame. Without picture ID, the jitter buffer will not determine
any frame decodable after FEC. Video will hang until the jitter 
buffer drops all packets and requests a key frame.

BUG=347477
TEST=Run apprtc.appspot.com between Linux and CrOS.
Run apprtc.appspot.com loopback on CrOS.

Review URL: https://codereview.chromium.org/216793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260269 0039d316-1c4b-4281-b951-d872f2087c98

On 10.6-10.8, there is a brief flicker of corruption when the
RWHVCocoa (which has a CALayer) is added to the already-visible
window's NSView hierarchy. I suspect that this is a mini-seizure
that the window system has when transitioning the window from
a "does not have layers" mode to a "has layers" mode. Adding a
layer to the window's NSView hierarchy before the window is made
visible makes this seizure not happen.

BUG=356627

Review URL: https://codereview.chromium.org/215593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260268 0039d316-1c4b-4281-b951-d872f2087c98

This change tests for overlays inside DirectRenderer::DrawFrame and if
new overlay passes were produced, it skips rendering them and forwards the
information to FinishDrawingFrame to allow subclasses like GLRenderer and
SoftwareRenderer to schedule overlays in a manner specific to their
implementation.

GLRenderer schedules overlays via ContextSupport.

Adds more tests to ensure overlay quads are not drawn and if no overlays
are present, no quads are skipped.

BUG=

Review URL: https://codereview.chromium.org/208213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260267 0039d316-1c4b-4281-b951-d872f2087c98

This way there isn't possible race conditions if main is run before
the page finishes loading.

BUG=none
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/215373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260266 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Remove ExtensionService Garbage-Collecting methods. (https://codereview.chromium.org/204983020/)

Reason for revert:
Launch the browser and just wait a bit, eventually it crashes with:

[6912:6955:0328/131903:FATAL:weak_ptr.cc(26)] Check failed:
sequence_checker_.CalledOnValidSequencedThread(). WeakPtrs must be checked on
the same sequenced thread.

Commenting out that check then gets you to:

[12009:12077:0328/133048:FATAL:extension_garbage_collector.cc(232)] Check
failed: content::BrowserThread::CurrentlyOn(content::BrowserThread::FILE). 

Reverting the patch fixes the issue.

Original issue's description:
> Remove ExtensionService Garbage-Collecting methods.
> 
> Make a new class, ExtensionGarbageCollector, which performs:
> - ExtensionService::GarbageCollectExtensions(),
> - extension_file_util::GarbageCollectExtensions() (the file-thread impl of
>   ExtensionService::GarbageCollectExtensions()),
> - ExtensionService::GarbageCollectIsolatedStorage()
> 
> BUG=351891
> TBR=rkc@chromium.org (for c/b/chromeos/kiosk_mode - no functional changes, but the TODO has moved from ExtensionService to ExtensionGarbageCollector).
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260207

TBR=yoz@chromium.org,jyasskin@chromium.org,rkc@chromium.org,rdevlin.cronin@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=351891

Review URL: https://codereview.chromium.org/217233004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260265 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=True

Review URL: https://codereview.chromium.org/216883007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260263 0039d316-1c4b-4281-b951-d872f2087c98

No changes are required beyond removing a stale include and componentizing
FakeAuthStatusProvider (which can be componentized as-is).

BUG=334000
TBR=jochen

Review URL: https://codereview.chromium.org/216943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260262 0039d316-1c4b-4281-b951-d872f2087c98

Holding off on this change until after the m35 branch.

This reverts commit 31b59d61.

BUG=258676
R=kbr@chromium.org, piman@chromium.org, zmo@chromium.org

Review URL: https://codereview.chromium.org/215053004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260261 0039d316-1c4b-4281-b951-d872f2087c98

BUG=239656

Review URL: https://codereview.chromium.org/217133006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260259 0039d316-1c4b-4281-b951-d872f2087c98

BUG=351251
TBR=bauerb@chromium.org

Review URL: https://codereview.chromium.org/206513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260258 0039d316-1c4b-4281-b951-d872f2087c98

BUG=332115

Review URL: https://codereview.chromium.org/185863003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260257 0039d316-1c4b-4281-b951-d872f2087c98

PERF SHERRIFS: This patch can change the metrics of smoothness up or down.
The new values should be more accurate than what we had before. If there are
large changes on a platform, we should still sanity check that everything works
as expected.

Switch smoothness benchmark to use rendering stats from the top level
compositor; i.e. if data from a browser compositor is available, use that.
Otherwise use the data from the renderer compositor.

The re-land fixes the problem where a browser compositor was present, but
didn't record rendering stats. That was the case with the reference
builds (that didn't have the patch that enabled recording) and on Android.
The new version checks if the browser compositor rendering stats events
actually have frames in them. If not, the render compositor stats will be used.
There is also a fix on the way to enable the recording on Android
(https://codereview.chromium.org/168193004/).

R=tonyg@chromium.org,nduca@chromium.org
BUG=340753

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254811

Review URL: https://codereview.chromium.org/174663008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260256 0039d316-1c4b-4281-b951-d872f2087c98