GitLab

Added a utility function to NetworkState to query if a network
requires activation. All UI code should use this instead of comparing the
Cellular.ActivationState property themselves, as this utility function
handles the "unknown" case as well.

BUG=289470
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/23532065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223472 0039d316-1c4b-4281-b951-d872f2087c98

Found by the Mac OS X 'leaks' tool; fixed on a plane.

BUG=292905

Review URL: https://chromiumcodereview.appspot.com/23606034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223471 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288991
R=koz@chromium.org

Review URL: https://codereview.chromium.org/23970005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223470 0039d316-1c4b-4281-b951-d872f2087c98

I was working on the Windows build and having problems finding why a file was loaded that shouldn't have been. This adds the source of the invocation to the verbose logging so you can find this information.

I removed an assert which caused a debug assertion for random punctuation and isn't harmful (a real error will be reported).

I moved the location-to-string conversion code into the location class so I can share it for my new logging command, and moved a bunch of other logging functions to the new .cc file.

BUG=288991
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/23532076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223469 0039d316-1c4b-4281-b951-d872f2087c98

Also, remove some uneeded dependencies from LoginState tests.

BUG=NONE

Review URL: https://chromiumcodereview.appspot.com/23444061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223468 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223466 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=157831:157846&mode=html
TBR=
BUG=

Review URL: https://chromiumcodereview.appspot.com/24184002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223465 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/23757050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223464 0039d316-1c4b-4281-b951-d872f2087c98

BUG=267983
TEST=compiles
R=estade@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23629046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223463 0039d316-1c4b-4281-b951-d872f2087c98

BUG=292727

Review URL: https://chromiumcodereview.appspot.com/23621045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223462 0039d316-1c4b-4281-b951-d872f2087c98

Enables most of the test cases on windows. Adds TODOs and bug numbers for those still disabled.


BUG=245594

Review URL: https://chromiumcodereview.appspot.com/23614016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223460 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org, jamesr@chromium.org
TBR=jamesr@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23533057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223459 0039d316-1c4b-4281-b951-d872f2087c98

Clean the machine by uninstalling Chrome (if it's installed) for now. This allows the test slave to work properly. Eventually, we should read the clean state from the config file and clean the machine according to it.

NOTRY=True
BUG=264859
TEST=
1) Install Chrome at user level (if it's not installed already.) 
2) Build Chrome with Release mode and make sure that mini_installer.exe is created. 
3) Go to src\chrome\test\mini_installer 
4) Run "python test_installer.py config\config.config --build-dir=<build-dir> --target=Release" where <build-dir> is the path to main build directory (the parent of the Release directory). The test should pass.
5) Repeat steps 1-4, but install Chrome at system level instead. The test should still pass.

Review URL: https://chromiumcodereview.appspot.com/23523045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223458 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://chromiumcodereview.appspot.com/23464075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223457 0039d316-1c4b-4281-b951-d872f2087c98

> Enable GPU blacklist in tests.
> 
> Partial re-land of https://codereview.chromium.org/22198004/) -- Always enable FCM on Windows -- Part 1/3.
> 
> On top of fixing some of the issues there; only lands the part that enables the GPU blacklist in tests as the former CL is too hard to land all at once.
> 
> Also keeping --skip-gpu-data-loading around for now to be able to deal with failures caused in layout_tests by this on their own later (this needs to land ASAP and layout_tests don't need this ASAP).
> 
> Another CL will follow to always enable FCM on non-blacklisted Windows machines.
> 
> This part re-enables loading the blacklist in tests (and adds a content_browsertest to make sure that the configuration we expect to be testing is indeed the one we are testing -- this uncertainty is basically the only reason the blacklist was explicitly disabled before).
> 
> This CL also cleans up compositor_util.cc which was enforcing the blacklist twice.
> 
> The original plan was to do this only for Windows as Mac/Linux was causing trouble, but it turns out to be harder to do it only on Windows; so taking care of http://crbug.com/277242 in this CL too after all... 
> 
> BUG=233830, 267038, 190942, 277242
> TBR=jcivelli, piman 
> 
> Originally Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=219132 
> Then Reverted: https://src.chromium.org/viewvc/chrome?view=rev&revision=219159
> 
> Then re-committed (part 1/3): https://src.chromium.org/viewvc/chrome?view=rev&revision=221114
> Reverted in: https://src.chromium.org/viewvc/chrome?view=rev&revision=221145
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222105
> 
> Review URL: https://chromiumcodereview.appspot.com/23534006

TBR=gab@chromium.org

Review URL: https://codereview.chromium.org/24074005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=248597



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223452 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes the last usage of clientlogin tokens for 'chromiumsync'
on Android.

BUG=264503

Review URL: https://chromiumcodereview.appspot.com/23686014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223450 0039d316-1c4b-4281-b951-d872f2087c98

ProfileInfoCache.

Otherwise if the usernames are only being hashed by appending "-hash", extra
dictionaries are created and written out to the LocalState file. In particular,
the ProfileInfoCache stores some extraneous information.

This change should have no impact when running on real machines.

BUG=289772

Review URL: https://chromiumcodereview.appspot.com/23528008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=292960
NOTRY=true
TBR=zhaoqin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23480079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223444 0039d316-1c4b-4281-b951-d872f2087c98

This will allow us to keep images in drawable-mdpi in the source tree.

BUG=289843

Review URL: https://chromiumcodereview.appspot.com/23944009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223443 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
TBR=yangguo@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23950008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223441 0039d316-1c4b-4281-b951-d872f2087c98

Use the ability to track activity changes by registering a listener on
the application.

Also, this will manage the state of various activities on the java side.

BUG=286071

Review URL: https://chromiumcodereview.appspot.com/23522032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223437 0039d316-1c4b-4281-b951-d872f2087c98

R=asargent@chromium.org
BUG=None

Review URL: https://chromiumcodereview.appspot.com/23452031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223436 0039d316-1c4b-4281-b951-d872f2087c98

This also makes a minor change to WifiConfigView to update the 'Connect'
button enabled state after receiving wifi properties by calling
UpdateDialogButtons().

BUG=289642
R=pneubeck@chromium.org

Review URL: https://codereview.chromium.org/23872021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223435 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes a redundant class in the form of
media::VideoCapture::VideoFrameBuffer, and replaces it with
media::VideoFrame.  Also: as media::VideoFrame has an embedded
destruction callback, use this to handle buffer returns on
the video capture stack, and remove the explicit
VideoCapture::FeedBuffer entry point.

BUG=None
TEST=local build, content_unittests, run on desktop Linux with
     screen capture and webcam

Review URL: https://chromiumcodereview.appspot.com/23587018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223434 0039d316-1c4b-4281-b951-d872f2087c98

More specifically, we were not allowing the user to import chrome://chrome
and chrome://about. We add the necessary checks and now the user can import
those urls too.

BUG=283715
TEST=launch chrome, go to bookmarks manager, select "Import Bookmarks from HTML
file", choose an html file that contains either chrome://chrome or chrome://about
or both, verify that now we can import those.
R=isherman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23449036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223432 0039d316-1c4b-4281-b951-d872f2087c98

BUG=290552,292913
NOTRY=true
TBR=groby

Review URL: https://chromiumcodereview.appspot.com/24189002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223430 0039d316-1c4b-4281-b951-d872f2087c98

Remove unnecessary includes from headers and move them to implementation files, and use TestBrowserThreadBundle.

BUG=none

Review URL: https://chromiumcodereview.appspot.com/24120005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223429 0039d316-1c4b-4281-b951-d872f2087c98

BUG=288367,289770
TEST=Ran on Daisy, checked Pepper Flash gets 2048 now instead of 1024.

Review URL: https://chromiumcodereview.appspot.com/23672035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223428 0039d316-1c4b-4281-b951-d872f2087c98

service and thread can be shut down in proper order.

BUG=274705

Review URL: https://chromiumcodereview.appspot.com/23463033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223427 0039d316-1c4b-4281-b951-d872f2087c98

For the blue button focused state.

R=xiyuan@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/23480078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223424 0039d316-1c4b-4281-b951-d872f2087c98

They no longer work on Chrome.

BUG=none
TEST=none
R=craigdh@chromium.org

Review URL: https://codereview.chromium.org/23439005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223423 0039d316-1c4b-4281-b951-d872f2087c98

Cache the views::Widget* instead of the views::NonClientFrameView* that the FrameMaximizeButton acts on

BUG=None
TEST=None

Review URL: https://chromiumcodereview.appspot.com/24048003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223422 0039d316-1c4b-4281-b951-d872f2087c98

BUG=254066
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/23934009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223421 0039d316-1c4b-4281-b951-d872f2087c98

This patch is a small clean-up to the schedule tasks.

BUG=none
R=reveman@chromium.org

Review URL: https://chromiumcodereview.appspot.com/23619048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=54748
TEST=on Windows open a password-protected PDF; a password dialog should appear

Review URL: https://chromiumcodereview.appspot.com/23498038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223419 0039d316-1c4b-4281-b951-d872f2087c98

BUG=232657
TEST=none
R=beaudoin@chromium.org

Review URL: https://codereview.chromium.org/23536053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=291251

Review URL: https://chromiumcodereview.appspot.com/24052004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223417 0039d316-1c4b-4281-b951-d872f2087c98

See bug for context. This change makes calling
an IAccessible2 API on the web content's root
accessible object enable full web accessibility
support. This supports popular Windows screen readers
but won't enable accessibility under other
circumstances when we don't need it.

However, this doesn't always detect the screen
reader right away when the app opens, so we also
modify Views accessibility to detect IAccessible2
and query the IAccessible2 API on each web view.
That catches use of IAccessible2 immediately.

BUG=292719

Review URL: https://chromiumcodereview.appspot.com/23531055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=285083

Review URL: https://chromiumcodereview.appspot.com/23503056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@223415 0039d316-1c4b-4281-b951-d872f2087c98