GitLab

This is my attempt to fix the flakiness of this browsertest by having the UI thread wait for the report to be sent on the IO thread.

BUG=613883,638316

Review-Url: https://codereview.chromium.org/2250163003
Cr-Commit-Position: refs/heads/master@{#414252}

https://codereview.chromium.org/2263733002 added 80% zoom to the list of presets, but I forgot it in the settings dropdown. And it looks like 250% was missing from the settings too, for some reason. I can't find anything to indicate this was intentional, so I included it as well. Also updated the comments so that no one else makes this mistake.

BUG=632323
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2278783002
Cr-Commit-Position: refs/heads/master@{#414251}

BUG=639823

Review-Url: https://codereview.chromium.org/2269143005
Cr-Commit-Position: refs/heads/master@{#414250}

TEST=https://docs.google.com/a/google.com/document/d/1P0WslUXMUO9azLmWZ0AtQ-sGExWbHttr_2gQWDXf3MY/pub
BUG=624086

Review-Url: https://codereview.chromium.org/2270243002
Cr-Commit-Position: refs/heads/master@{#414249}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

Please review the expectation changes, and LGTM as normal. The recipe roller
will *NOT* CQ the change itself, so you must commit the change manually.

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/caa4e0ba756e8a3b5592a604d53ddaf9ba92dfbf Make chromium_tests recipe module explicitly set GIT_MODE (agable@chromium.org)

R=agable@chromium.org
BUG=640251

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2272213002
Cr-Commit-Position: refs/heads/master@{#414248}

This patch converts "editing/execCommand/format-block-with-braces.html" to use
w3c test harness to simplify test script for improving readability.

BUG=n/a
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2277683002
Cr-Commit-Position: refs/heads/master@{#414247}

Remove the sub-page. Add a simple dialog to select new languages. Add an
option to the language list to remove a language.

A search box will be added to the dialog next.

BUG=630982
TEST=SettingsLanguagesPageBrowserTest
R=stevenjb@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2265253002
Cr-Commit-Position: refs/heads/master@{#414246}

This seam allows us to reuse our existing network connection factories for
hypothetical future non-BlimpConnection connection objects.

Also modified/rewrote existing unit tests to accommodate new API.

R=wez@chromium.org,lethalantidote@chromium.org
BUG=635711

Review-Url: https://codereview.chromium.org/2236093002
Cr-Commit-Position: refs/heads/master@{#414245}

Revert of DevTools: merge devtools target with devtools host, part 1 (patchset #11 id:200001 of https://codereview.chromium.org/2263843002/ )

Reason for revert:
Caused compile errors on Linux ChromiumOS GN: https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/44628

Original issue's description:
> DevTools: merge devtools target with devtools host, part 1
>
> BUG=627517
> TBR=
>
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Committed: https://crrev.com/fcf3423ed3619dcf8005510650ea5c31ea995f79
> Cr-Commit-Position: refs/heads/master@{#414208}

TBR=dgozman@chromium.org,asargent@chromium.org,skyostil@chromium.org,pfeldman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=627517

Review-Url: https://codereview.chromium.org/2277473007
Cr-Commit-Position: refs/heads/master@{#414244}

BUG=639166

Review-Url: https://codereview.chromium.org/2257173005
Cr-Commit-Position: refs/heads/master@{#414243}

While the backing Blink implementation gets further fleshed out, loosen ChromeVox's output of active descendants by reading it on children change events.

The change makes it so that active descendants are read out when:
- the focused node (node with state focused), has an active descendant
- the incoming event is either children changed or active descendant changed

TEST=drive.google.com; tab to one of the popup buttons; up/down arrow reads options.

Review-Url: https://codereview.chromium.org/2273133002
Cr-Commit-Position: refs/heads/master@{#414242}

Moving most of Schema, Runtime, Debugger, Profiler and Emulation out of experimental.

BUG=635947

Review-Url: https://codereview.chromium.org/2272503002
Cr-Commit-Position: refs/heads/master@{#414241}

BUG=640828

Review-Url: https://codereview.chromium.org/2272223002
Cr-Commit-Position: refs/heads/master@{#414240}

And use it to update filter animations directly instead of routing the
updates through layers.

BUG=638297
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2270273002
Cr-Commit-Position: refs/heads/master@{#414239}

BUG=638744
R=kbr@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2276123002
Cr-Commit-Position: refs/heads/master@{#414238}

https://pdfium.googlesource.com/pdfium.git/+log/63af2c64b4ea..156de02596e9

$ git log 63af2c64b..156de0259 --date=short --no-merges --format='%ad %ae %s'
2016-08-24 dsinclair Removing CPDF_Parser::CloseParser.
2016-08-24 dsinclair Cleanup some PWL_FontMap methods
2016-08-24 npm Allow CPDF_Font to use fallback fonts
2016-08-24 dsinclair Flip document and parser ownership
2016-08-24 tonikitoo Lazy generate an "AP" when an Annot's hidden state changes
2016-08-24 dsinclair Move parser out of IndirectObjectHolder

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2276193002
Cr-Commit-Position: refs/heads/master@{#414237}

See go/zero-touch-chrome for design. (The author hasn't updated the name of the protos, but the document explains the signed request.)

BUG=624187
TEST=unit tests

Review-Url: https://codereview.chromium.org/2261763002
Cr-Commit-Position: refs/heads/master@{#414236}

A sentinel file is placed in the ruleset version directory just before indexing
commences, and removed afterwards. Therefore, if a sentinel file is found on
next start-up, it is an indication that the previous indexing operation may
have crashed, and indexing will not be attempted again.

This CL also slightly refactors unit tests so that we no longer have specific
tests verifying histograms values, but instead we have tests exercising error
scenarios, and verifying histogram values is performed as part of that.

TBR=rkaplow@chromium.org
BUG=609747

Review-Url: https://codereview.chromium.org/2272593002
Cr-Commit-Position: refs/heads/master@{#414235}

As discussed in blink-dev@ (https://groups.google.com/a/chromium.org/d/topic/blink-dev/kk4VX0xRB7I/discussion)
and platform-architecture-dev@ (https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/Zc12k91NTFk/discussion),
there is no reason we have to shut down the renderer gracefully.
It's just causing use-after-free bugs and wasting performance.
This CL stops calling blink::shutdown in content/ tests.

BUG=639244

Review-Url: https://codereview.chromium.org/2268283004
Cr-Commit-Position: refs/heads/master@{#414234}

Pull package lists from both trusty and trusty-updates, and give
precedence to the packages in trusty-updates when deciding which
packages to add to the sysroot.

BUG=638394

Review-Url: https://codereview.chromium.org/2270253002
Cr-Commit-Position: refs/heads/master@{#414233}

The checks were added in https://codereview.chromium.org/2163683004/
but are no longer needed because I already removed blink::shutdown
from the renderer's shutdown sequence.

BUG=628999

Review-Url: https://codereview.chromium.org/2271953002
Cr-Commit-Position: refs/heads/master@{#414232}

These metrics provide more granular information about the CPU usage of chrome
for performance benchmarks.

BUG=640054

Review-Url: https://codereview.chromium.org/2270093002
Cr-Commit-Position: refs/heads/master@{#414231}

For some reason the toolbar title text size is not font scale dependent.
Increasing the font size in Accessibility->Font Size will change the text
size everywhere except the app title. This CL fixes this problem by defining
the title text size explicitly in sp.

BUG=635584

Review-Url: https://codereview.chromium.org/2270283003
Cr-Commit-Position: refs/heads/master@{#414230}

Pretty trivial as they were already implemented and just needed to be
hooked up.

BUG=639949

Review-Url: https://codereview.chromium.org/2263423002
Cr-Commit-Position: refs/heads/master@{#414229}

add toString() funtion in DOMMatrixReadOnly.
refer to detail spec([1])

[1] = https://drafts.fxtf.org/geometry/#dom-dommatrixreadonly-stringifier

BUG=388780

Review-Url: https://codereview.chromium.org/2273663002
Cr-Commit-Position: refs/heads/master@{#414228}

Though ComputeTranslation should result in a translation transform, we
can end up with non-translation transforms when we have noisy transforms.

BUG=639203
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2271273003
Cr-Commit-Position: refs/heads/master@{#414227}

This CL also makes the AddToHomescreenDataFetcher::Observer overrides private

BUG=627250

Review-Url: https://codereview.chromium.org/2278693002
Cr-Commit-Position: refs/heads/master@{#414226}

This is more of a kill switch than a feature flag, so it deserves to be
enabled until deemed harmful.

BUG=

Review-Url: https://codereview.chromium.org/2273873002
Cr-Commit-Position: refs/heads/master@{#414225}

BUG=639095

Review-Url: https://codereview.chromium.org/2274223003
Cr-Commit-Position: refs/heads/master@{#414224}

This was temporarily introduced to A/B test MultibufferDataSource
which has been stable since M52 now. Time to delete!

BUG=588903
TEST=compile

Review-Url: https://codereview.chromium.org/2272163002
Cr-Commit-Position: refs/heads/master@{#414223}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/74225cd7..d09641f4

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2271313003
Cr-Commit-Position: refs/heads/master@{#414222}

The user action pseudo classes rely on affectedBy bits to be correctly
set on ComputedStyle in order to recalculate style for such changes
later on. If two elements may otherwise share style, but will have the
affectedBy bits set differently, they may not share style.

Example:

  <style>[attr]:hover {}</style>
  <div></div>
  <div attr></div>

The second div may share style with the first one when none of them is
hovered. However, matching the selector against the first div will fail
on the attribute selector before we try to match :hover, hence the flag
for affectedByHover will not be set. If we share that ComputedStyle
object with the second div, hovering the second div later will have no
effect.

Instead we always match :hover/:active/:focus/:-webkit-drag when
matching rules for style sharing (attribute and sibling rules). That
will lead to the attribute selector in the example above to match which
will cause style sharing to be rejected for the second div.

R=meade@chromium.org
BUG=639561

Review-Url: https://codereview.chromium.org/2272683002
Cr-Commit-Position: refs/heads/master@{#414221}

The surface is fully transparent when alpha is 0 and we can then
avoid to create a texture quad completely. Failing to do so
currently results in unnecessary compositing.

BUG=640805
TEST=exo_unittests

Review-Url: https://codereview.chromium.org/2277833004
Cr-Commit-Position: refs/heads/master@{#414220}

Previously the restoreBreakpoints method implictly relied on the inspected URL being set
to the current inspected URL. This CL simplifies the logic for setting the inspected URL
and ensures that the inspected URL is always accurate in the process of restoring breakpoints.

BUG=627296

Review-Url: https://codereview.chromium.org/2277543002
Cr-Commit-Position: refs/heads/master@{#414219}

The code is mistaking a missing reader for an error, but readers are now destroyed and re-created on demand.
Adding a new variable to explicitly track failures fixes the problem.

BUG=639690

Review-Url: https://codereview.chromium.org/2271313002
Cr-Commit-Position: refs/heads/master@{#414218}

Security review recommends explicitly setting the 'exported' property
in the Android manifest. This avoids exposing private items on older
versions of Android.

According to
https://developer.android.com/guide/topics/manifest/activity-element.html#exported
this setting defaults to true for Activities with Intent filters, false
otherwise.

BUG=638032

Review-Url: https://codereview.chromium.org/2272883003
Cr-Commit-Position: refs/heads/master@{#414217}

Revert of clang plugin: Remove check-templates toggle. (patchset #1 id:1 of https://codereview.chromium.org/2267713003/ )

Reason for revert:
This broke the weak_ptr_factory.cpp test: https://build.chromium.org/p/chromium.fyi/builders/ClangToTLinux/builds/6121/steps/gclient%20runhooks/logs/stdio

I think this check effectively always disabled the check-templates flag instead of always enabling it.

And it sucks that we didn't notice for two days :-(

Original issue's description:
> clang plugin: Remove check-templates toggle.
>
> It's been on by default for a long time.
>
> BUG=441916
>
> Committed: https://crrev.com/bbf42267e353275827a33ca603e3dba48b81814f
> Cr-Commit-Position: refs/heads/master@{#413546}

TBR=dcheng@chromium.org,thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=441916

Review-Url: https://codereview.chromium.org/2278603004
Cr-Commit-Position: refs/heads/master@{#414216}

This is mostly a follow-up to an unintentional behavior change in
https://codereview.chromium.org/2255403002/ .  I decided to treat 0 size as
invalid as well.

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2278743002
Cr-Commit-Position: refs/heads/master@{#414215}

This UMA records the time taken between sending an event IPC from
the browser process to a Service Worker and executing the event
handler in the Service Worker.

This CL depends on https://codereview.chromium.org/2249063004/.

BUG=561209

Review-Url: https://codereview.chromium.org/2218943002
Cr-Commit-Position: refs/heads/master@{#414214}

set the callback. Should help explain how we're crashing in
http://crbug.com/640288

BUG=640288

Review-Url: https://codereview.chromium.org/2267283003
Cr-Commit-Position: refs/heads/master@{#414213}