- 20 Jun, 2018 40 commits
-
-
Kent Tamura authored
Remove dependency to encoded_form_data.h and security_origin.h. resource_request.h is used in 4,400+ compilation units, and this CL reduces its estimated expanded size by 0.24MB. Bug: 242216 Change-Id: Ief70b318e39c508b75791db3d708ed7cee40c277 Reviewed-on: https://chromium-review.googlesource.com/1107030Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568734}
-
Koji Ishii authored
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9300bd5c5565fc143bf315d892c003870b314187 Reviewed-on: https://chromium-review.googlesource.com/1098903 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568733}
-
Wenzhao Zang authored
1) The new wallpaper picker relies on the Backdrop server to select surprise me images, instead of selecting random images by ourseleves (the back-end was implemented by a prior CL). 2) The surprise me images are per-category, ie. each wallpaper category has a "daily refresh slider". At most one slider may be active at a time. Toggling one slider to active should deactivate others. 3) Use "daily refresh" instead of "surprise me" in the code to distinguish from the old picker. Although it's possible to share code path with the old picker, generally avoid it for clarity. Test steps include: 1) Toggle daily refresh between enabled/disabled, during tablet/clamshell mode, and among different categories. 2) Enable surprise me on the old picker, then add switch --new-wallpaper-picker, and see the migration. 3) See the sync is working for two devices with the same account id. Bug: 834998, 810169, 834994, 837338 Change-Id: I369ce57ac4bd07e91da31bb2971b6970501f9c3a Reviewed-on: https://chromium-review.googlesource.com/1093742 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#568732}
-
Min Qin authored
This CL adds a flag into BrowserParts to allow Chrome to start with only the ServiceManager, without loading additional functionalities such as profile. This will allow features like download/sync to run without fully instantiating Chrome, thus saving memory footprints. Once ServiceManager is started, serviceManagerStartupComplete() will get called. And Browser startup will be paused if the request is to start ServiceManager only BUG=842245 Change-Id: I436c4bde16db55af012b5d9cf468c073c86a86cc Reviewed-on: https://chromium-review.googlesource.com/1093303Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568731}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/47c29fa64b3f..4359d529121f git log 47c29fa64b3f..4359d529121f --date=short --no-merges --format='%ad %ae %s' 2018-06-20 allanmac@google.com Skia Compute core files Created with: gclient setdep -r src/third_party/skia@4359d529121f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I70bdb0c284710c99fd56217009581b7d605da1e1 Reviewed-on: https://chromium-review.googlesource.com/1107397Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568730}
-
Min Qin authored
This CL allows InProgressDownloadManager to take a URLLoaderFactoryGetter, and resume the download by itself. BUG=842245 Change-Id: Ie2e6dff715455ee8449be05d49c43144de8d25c8 Reviewed-on: https://chromium-review.googlesource.com/1102885Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568729}
-
Nico Weber authored
TBR=jbudorick Bug: 455679,843511 Change-Id: I716eaad2c98521978d25ee5b0bf00d57534eb19c Reviewed-on: https://chromium-review.googlesource.com/1104803Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#568728}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 90a2d3e7. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" 08784a11 "[Mojo Blob URLs] Make clicking an <a target="blank_"> with a blob URL work correctly." 3aaab5dd "webrtc wpt: trust getUserMedia to be compliant" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19929 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org, kojii@chromium.org: external/wpt/css/css-fonts foolip@chromium.org, robertma@chromium.org, smcgruer@chromium.org: external/wpt/infrastructure guidou@chromium.org: external/wpt/mediacapture-streams igrigorik@chromium.org, panicker@chromium.org: external/wpt/performance-timeline kojii@chromium.org: external/wpt/css/css-scoping mcasas@chromium.org: external/wpt/mediacapture-record TBR=robertma No-Export: true Change-Id: Ia2fe07a0430a87cdaa2f6a7da2f9f5cc3c1a3c4d Reviewed-on: https://chromium-review.googlesource.com/1107249 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#568727}
-
Michał Pichliński authored
Following change: https://chromium-review.googlesource.com/1026975 disallows having a control of Chromecast preference in settings, because calling Cast... after enabling Chromecast preference in runtime without a restart causes a crash due to missing MediaRouterUIService. Instead of not creating MediaRouterUIService, do not create MediaRouterActionController in this service when Media Router is disabled. Bug: 834719 Change-Id: I218523d631d9050ff27e69915ba098fe21907e25 Reviewed-on: https://chromium-review.googlesource.com/1067817 Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#568726}
-
Matt Falkenhagen authored
NetworkService and NetS13nSW currently fail this test. Bug: 850839 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Ic33481d43b34f36c5ac7b234a2ca149d4134fcd0 Reviewed-on: https://chromium-review.googlesource.com/1107029Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#568725}
-
rbpotter authored
Add test to verify that destination filtering works correctly. Bug: 773928 Change-Id: Id561ff1611e9de15991528002e9c5f245a6a22df Reviewed-on: https://chromium-review.googlesource.com/1102989Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#568724}
-
Samuel Huang authored
LLD-LTO flow (TODO) will be quite different from LLD flow. Supersize will need to tell them apart (and store them using distinct linker names in the .size file). This CL adds the functionality to detect LTO usage from LLD .map files. Previously linker detection (to discern Gold, and 2 versions of LLD files) only needed to examine the first line of .map file. But for LTO (LLD only), we'll need to look beyond this. The signal we chose is to look for 'thinlto-cache' prefix at locations where paths usually reside in .map files. To optimize for speed, we choose and scan one 'indicator section' (.ARM.exidx or .reloc, but easy to tweak). Details: - Refactor: Previously linker_map_parser.DetectLinkerNameFromMapFile() was called twice: to computie metadata, and in MapFileParser. Since the function is becoming more complex, we new call it once (for metadata), then pipe the information to MapFileParser to use. - Add linker_map_parser._DetectLto() to handle most of the parsing. As optimization, we use ad-hoc string processing instead of Regex. - Minor cleanup on version 0 vs. 1 difference for LLD. After this change, the list of linker names are: {'gold', 'lld_v0', 'lld-lto_v0', 'lld_v1', 'lld-lto_v1'}. Bug: 723798 Change-Id: I0498e50446be32a0335bb4781d60a6b72d7e87b5 Reviewed-on: https://chromium-review.googlesource.com/1107037 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:Samuel Huang <huangs@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#568723}
-
Emircan Uysaler authored
This is a reland of e048eba0 Original change's description: > Refactor VideoFrameBuffer::Type handling in MediaStreamRemoteVideoSource > > This CL cleans up this class in preparation for future types to be added. > > Bug: 853843 > Change-Id: Ibdf6f624cc01e776bd885fa785a1cdb37a19a150 > Reviewed-on: https://chromium-review.googlesource.com/1104965 > Reviewed-by: Christian Fremerey <chfremer@chromium.org> > Commit-Queue: Emircan Uysaler <emircan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568165} Bug: 853843 Change-Id: Ic7ff7acebc126438529c51d48d9db2b118e10887 TBR: chfremer@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1106943 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#568722}
-
Wenzhao Zang authored
1) Support preview for updating the layout of the currently set wallpaper. 2) Updates the spec of the preview top bar based on new spec. 3) Support highlighting the offline wallpaper when device is not connected (similar to the old picker). Bug: 836396, 835025 Change-Id: I0732bfa63efec6fa6baf4fabb253f7aa2f5bc9f3 Reviewed-on: https://chromium-review.googlesource.com/1089998 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#568721}
-
Martin Kreichgauer authored
This makes GetAssertionOperation decrypt the matching credential id id into its UserEntity value and carry those values as well as the credential id into the returned response. It was previously returning incomplete responses. Also fix the signature counter to 1, rather than 0, because webauthndemo insists that the number be greater than 0. Bug: 803842 Change-Id: I42e22ca9fb571ad6dea924bd765aa276d8c62d1a Reviewed-on: https://chromium-review.googlesource.com/1103518 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568720}
-
Kenneth Russell authored
Tbr: geofflang@chromium.org Bug: 854100 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I36ec64561f48b12d04269a3b3c031496902292ab Reviewed-on: https://chromium-review.googlesource.com/1107275Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#568719}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4004ae0e033a..a914f7ff310d git log 4004ae0e033a..a914f7ff310d --date=short --no-merges --format='%ad %ae %s' 2018-06-20 jiawei.shao@intel.com Use ShaderMap in Statemanager11 - Part II Created with: gclient setdep -r src/third_party/angle@a914f7ff310d The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id1ab00613120775a74f87059f6f97a9a22f933b9 Reviewed-on: https://chromium-review.googlesource.com/1106860Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568718}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9cccc5ce4fb9..2ac4352aea17 git log 9cccc5ce4fb9..2ac4352aea17 --date=short --no-merges --format='%ad %ae %s' 2018-06-19 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@2ac4352aea17 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I0be686bfae67b05024ac73b64e83b27707332e9b Reviewed-on: https://chromium-review.googlesource.com/1106980Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568717}
-
Christopher Cameron authored
Allow BrowserCompositorMac to transition between different parent UI layers, if needed. Bug: 853302 Change-Id: I85596a1fe42c490d770f023c68d9a4093f050dcc Reviewed-on: https://chromium-review.googlesource.com/1107047Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#568716}
-
Jinsuk Kim authored
This CL renames an API setrContainerViewInternals to setAccessDelegate and migrates to ViewEventSink that handles view-related methods for content layer, in preparation of deleting the class ContentViewCore. Bug: 598880 Change-Id: I3023d0ac2959d88ad82cfe91a8c6cf2fc3955320 Reviewed-on: https://chromium-review.googlesource.com/1106649Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#568715}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/4e454ce4..9edff1c2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0e42269e853a903edd722d7eb1f2af131a7bf45a Reviewed-on: https://chromium-review.googlesource.com/1107256Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568714}
-
Ryan Hansberry authored
This is the correct constant that is expected by host devices. Bug: 824568, 752273 Change-Id: I7f29159de6eb66f92f4534cd558fe82027175914 Reviewed-on: https://chromium-review.googlesource.com/1105621Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568713}
-
Kyle Horimoto authored
cryptauth::SecureChannel requires that the client call the Initialize() function before it starts connecting. I had forgotten to add this call when I originally implemented BleConnectionManager. Bug: 824568, 752273 Change-Id: I9464ee842382f53ed8cc253b5a4e93daf1af78d2 Reviewed-on: https://chromium-review.googlesource.com/1107297Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#568712}
-
Jordy Greenblatt authored
The basic settings page (via MainPageBehavior) searches its children for settings-sections to hide when it expands a subpage. Because CL https://chromium-review.googlesource.com/c/chromium/src/+/1105185 pushed the multidevice settings-section down the DOM tree, it is no longer automatically hidden. To avoid dealing with the /deep/ selector (see https://bugs.chromium.org/p/chromium/issues/detail?id=852098) I just had the basic page take page expansion into account directly when deciding whether to attach the multidevice-settings-section-container. Bug: 854400 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I89e08e5af79163146737d7ae5a9637536cb032c2 Reviewed-on: https://chromium-review.googlesource.com/1107168 Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#568711}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/846bb413e161..47c29fa64b3f git log 846bb413e161..47c29fa64b3f --date=short --no-merges --format='%ad %ae %s' 2018-06-20 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-06-19 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7df52383cfdf..4004ae0e033a (8 commits) Created with: gclient setdep -r src/third_party/skia@47c29fa64b3f The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I923f1d5ae0ab01a3ffd691e88d3d05ad33120d67 Reviewed-on: https://chromium-review.googlesource.com/1107179Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I36e2f8319ff878d53ede39aace6419eebdf4bd3a Reviewed-on: https://chromium-review.googlesource.com/1107282Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#568709}
-
Esmael El-Moslimany authored
Bug: 854081 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ib73d38ea25ca0ea70e3322b1e5066cd6a2b5ded9 Reviewed-on: https://chromium-review.googlesource.com/1106421Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#568708}
-
Victor Costan authored
Bug: 729800 Change-Id: I194f3f4b86794236cc90fbc8614b1da680c8aaa6 Reviewed-on: https://chromium-review.googlesource.com/1107315Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#568707}
-
Martin Kreichgauer authored
This moves the responsibility of generating the CredentialMetadata 'secret' parameter (formely profile_id) into the AuthenticatorRequestDelegate. CredentialMetadata uses the parameter to derive the HMAC and AEAD keys for encrypting/encoding credential metadata before storing it in the macOS keychain. For Chrome, implement profile-specific secrets by storing the value in the browser profile PrefService. This guarantees that credentials will be logically separated by user profile. Bug: 678128 Change-Id: I8c3d12c6db266105eeb63191e9d277d8cdb173ee Reviewed-on: https://chromium-review.googlesource.com/1102179 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#568706}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/208cf41c691b..7c2b573628be Created with: gclient setdep -r src-internal@7c2b573628be The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:835029 TBR=mmoss@chromium.org Change-Id: I6bba577918f109d3f88ca8dfc4315fd17ca0b740 Reviewed-on: https://chromium-review.googlesource.com/1107138Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568705}
-
Ahmed Fakhry authored
When a Chromebook is flipped into tablet mode, scrolling and gesture fling events should follow the same curve used by android in order to have a smoother and more fluid experience. BUG=813911,822455 Change-Id: I39b42bdda08a3c20e1b7fab4d8f7e41c2a69b61a Reviewed-on: https://chromium-review.googlesource.com/1087641Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sahel Sharifymoghaddam <sahel@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#568704}
-
Miguel Casas authored
crrev.com/c/1100535 landed a DCHECK that does not verify from ARC++, [1814:1814:0619/160631.868318:FATAL:vaapi_picture_factory.cc(48)] Check failed: picture_buffer.texture_target() == GetGLTextureTarget() (0 vs. 36197) #0 0x59c50521b4dc base::debug::StackTrace::StackTrace() #1 0x59c50518f620 logging::LogMessage::~LogMessage() #2 0x59c5026cc721 media::VaapiPictureFactory::Create() #3 0x59c5026d2a94 media::VaapiVideoDecodeAccelerator::AssignPictureBuffers() #4 0x59c506967623 arc::GpuArcVideoDecodeAccelerator::AssignPictureBuffers() #5 0x59c50269c433 arc::mojom::VideoDecodeAcceleratorStubDispatch::Accept() ... This CL corrects it. Bug: 822346 Test: YT App playing back correctly with dcheck_always_on=true on nautilus. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Icff42847518df24dcc38998acdc2903e7928469f Reviewed-on: https://chromium-review.googlesource.com/1106670Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#568703}
-
Nigel Tao authored
See https://bugs.chromium.org/p/chromium/issues/detail?id=613096#c5 for rationale These two files: third_party/closure_compiler/externs/accessibility_private.js third_party/closure_compiler/externs/autofill_private.js were updated in this commit, as an example of the change. A follow-up commit will update other *_private.js files. Bug: 613096 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ica4ab471956052b37c8bb6a9aabe4a7502408cfb Reviewed-on: https://chromium-review.googlesource.com/1090425 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#568702}
-
Clark DuVall authored
This should ensure the delete tasks get run. Bug: 854032 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I73304bee8ee59e3e30ecb060cd3288c2630c8191 Reviewed-on: https://chromium-review.googlesource.com/1106479Reviewed-by:
-
Sebastien Marchand authored
Note that the only two production uses of this function are in restoring this value either from (a) a session restored tab or (b) a discarded tab. This formalizes the "set on creation" nature of the property. It also means that it is available immediately when a session restored contents is added to a tab strip, rather than only afterwards, which simplifies some tab manager code. Change-Id: I2ee17ac809a5ad834e7207eee101f167512d9737 Reviewed-on: https://chromium-review.googlesource.com/1103317Reviewed-by:
-
Varun Khaneja authored
R=gayane Change-Id: Ia43fcdad17628e63397ffa735da6d7439fd0baad Reviewed-on: https://chromium-review.googlesource.com/1107133Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#568699}
-
Peter Collingbourne authored
It looks like every client of this code is passing in a delegate, so we can simplify it a little by removing the if checks. Change-Id: Ie32edc629117d9c204482d518f13c7beb5bf1cf7 Reviewed-on: https://chromium-review.googlesource.com/1106801Reviewed-by:
-
bsheedy authored
Adds expectations for Pixel 2 and Pixel 2 XL devices in WebVrDeviceTest#testDeviceCapabilitiesMatchExpectations. Not a big deal since we currently don't run automated tests on Pixel 2 devices, but this should prevent local testing from having a few constantly failing test cases. TBR=bajones@chromium.org Change-Id: I4cc1cfc0a8e74347274db4403e46b27bb0bf95d4 Reviewed-on: https://chromium-review.googlesource.com/1107271Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#568697}
-
Kent Tamura authored
heap_page.h is used in 6,000+ compilation units, and this CL reduces its estimated expanded size from 1.72MB to 1.40MB. This CL relands https://chromium-review.googlesource.com/1104080 . With the original code, GetRandomMagic() was folded into GetMagic(), and GetMagic() was not folded into IsValid(). With https://chromium-review.googlesource.com/1104080, ComputeRandomMagic() was not folded into GetMagic(), and GeMagic() and IsValid() were folded into IsValid() callsites. So the binary size increased. With this CL, GetMagic() isn't folded into IsValid() like the original code. So this CL won't increase the binary size, and should not have performance regression. Bug: 242216 Change-Id: I7b6cf78a454abbbf3a3e41d821ac23e208b6dbdb Reviewed-on: https://chromium-review.googlesource.com/1105208Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#568696}
-
Lindsay Pasricha authored
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5953a6d5c0256bcf37cc8038effb7f7ca65f2a55 Reviewed-on: https://chromium-review.googlesource.com/1107280Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#568695}
-
