- 14 Jun, 2018 40 commits
-
-
Luke Bjerring authored
Bug: 851320 Change-Id: I562fe492be73b0ad8929d8ae8be158230103157f Reviewed-on: https://chromium-review.googlesource.com/1095640Reviewed-by:
Raymond Toy <rtoy@chromium.org> Commit-Queue: Luke Bj <lukebjerring@chromium.org> Cr-Commit-Position: refs/heads/master@{#567231}
-
vasilii authored
layoutSubviews is called continuously when scrolling is happening. We shouldn't set a scrolling position there. Bug: 843557 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I16891bfbcf4eb2f30c4b7f2ad86275a1cc2f7cb8 Reviewed-on: https://chromium-review.googlesource.com/1078871 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567230}
-
Farah Charab authored
Describes the grammar of the v0 task queue manager fuzzer input using a protocol buffer. This grammar describes a test that can test the following interfaces: * Creating a task queue. * Posting a (delayed) task with a given duration. * Doing the above from within a task. Bug: 852076 Change-Id: Ie33637eff3d953c814a7c40185d709a6bfc1f791 Reviewed-on: https://chromium-review.googlesource.com/1097327Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Farah Charab <farahcharab@chromium.org> Cr-Commit-Position: refs/heads/master@{#567229}
-
Noel Gordon authored
Add coverage for Drive to the openQuickView<VolumeType> test group. Test: browser_test --gtest_filter="QuickView/FilesApp*" Bug: 836254 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibf081b03ebcb069274c83d00da1d2703649bb04d Reviewed-on: https://chromium-review.googlesource.com/1098913Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#567228}
-
Daniel Vogelheim authored
Change-Id: Id7b395474a612200ad83ace5a44ced22a8612087 Reviewed-on: https://chromium-review.googlesource.com/1086798Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#567227}
-
Vadym Doroshenko authored
In order to support filling with using server-side predictions NewPasswordFormManager should wait for them. This CL introduces waiting for filling up to 500 ms, if for this time no server predictions received NewPasswordFormManager fills without server support. Bug: 831123 Change-Id: I7031ba03ab0229ed41de7869a1379a83ccd82259 Reviewed-on: https://chromium-review.googlesource.com/1091056 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#567226}
-
Naoki Fukino authored
The gear menu option "Show hidden Play folders" doesn't make sense when the "Play Files" volume is not mounted. The option should be visible only when the corresponding volume is mounted. Bug: 851385 Test: Manually tested on Eve. Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5f39a669890c455cbd9763a6d0d047854545acca Reviewed-on: https://chromium-review.googlesource.com/1100721 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
-
Ramin Halavati authored
Disabling the test as it very occasionally fails. Bug: 852690 Change-Id: I17164a945d1ae99b3af9245af743af695d6737dc TBR: primiano@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1100822Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#567224}
-
Findit authored
This reverts commit 326c044a. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 567162 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMyNmMwNDRhMzBjY2M1MzIyNmEwMDhhMjY1MDA3ODVkZmEwZDZlZjkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10407 Sample Failed Step: viz_content_browsertests Original change's description: > Display Cutout: Notify the browser process on fullscreen frame change > > Notify the browser process when the frame owning the current > fullscreen element is changed. > > Design: https://docs.google.com/document/d/1j3jqmGRXAHzpeKeS_tLlOo4C9DsrvPOf_-PMnFzTmeE/edit#heading=h.wozo6ynsdlp3 > > BUG=838400 > > Change-Id: I7771f7b58a8c1cdb7ec0b89b30db1de1fe708b32 > Reviewed-on: https://chromium-review.googlesource.com/1054441 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Philip Jägenstedt <foolip@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567162} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=838400 Change-Id: Ifd09d76dcd36d3fe257c8f1a1d6c9a573e86d5e8 Reviewed-on: https://chromium-review.googlesource.com/1100837 Cr-Commit-Position: refs/heads/master@{#567223}
-
Darren Shen authored
The occluded bounds is stored in the fullscreen container and retreived to ensure caret in work area. Also updated the places to notify the correct occluded bounds for the new container mode. Bug: 826617 Change-Id: Iafe3dcf291975b586dece39ee6e07bb3f7f49dba Reviewed-on: https://chromium-review.googlesource.com/1036867 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Blake O'Hare <blakeo@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#567222}
-
Colin Blundell authored
This API allows test clients to populate an account from an email address with IdentityManager and its backing classes. It is conceptually similar to IdentityTestEnvironment::MakePrimaryAccountAvailable(). Bug: 798699 Change-Id: Iffaae9f989a37de3e406ccc10166ce44c7ed6bdb Reviewed-on: https://chromium-review.googlesource.com/1099057 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#567221}
-
Hajime Hoshi authored
This CL is a continuation of https://chromium-review.googlesource.com/c/chromium/src/+/1088356. This CL gives an event target to EventQueueImpl and use it instead of event->target() so that we can have EventQueueImpl and MediaElementEventQueue with the same structure. Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit# Bug: 846618 Change-Id: I394e3b1c01df3a2af671bb6d72fe9d32ac9ea94e Reviewed-on: https://chromium-review.googlesource.com/1098736Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
stkhapugin@chromium.org authored
Adds a tint to the leading image view, and moves color- and font-related code from coordinator to view controller. Bug: 819235 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Icd9c6f54d6d8b6e35eb9bc4803b42a3dbfd0bbf6 Reviewed-on: https://chromium-review.googlesource.com/1099380 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#567219}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7d4d6b816c28..b57a861f183b git log 7d4d6b816c28..b57a861f183b --date=short --no-merges --format='%ad %ae %s' 2018-06-14 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 4cc753e01054..d668be9ce66f (1 commits) Created with: gclient setdep -r src/third_party/skia@b57a861f183b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@chromium.org Change-Id: I749d5e987c923bf960ff3ee33cf3da6cd587b372 Reviewed-on: https://chromium-review.googlesource.com/1100696Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#567218}
-
Yuichiro Hanada authored
This CL also removes obsolete entries: - bshe@ (no longer working on VK) - bryeung@ and kevers@ (no longer in Chrome team) - sadrul@ (already the owner of the parent directory) Bug: None Change-Id: Ia49203ff7fd65a22fe1fa9aff0b38e8bf5257337 Reviewed-on: https://chromium-review.googlesource.com/1098433 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#567217}
-
David Roger authored
Site isolation for Gaia is now launched at 100%, and we can remove the codepath that was used when site isolation was disabled. In particular, after https://chromium-review.googlesource.com/c/chromium/src/+/1096664 the GaiaOriginIsolatedCallback always returns true, and can be removed. TBR=blundell Change-Id: If41007a3fc0b94c58a56f8f58a35f034861ae015 Reviewed-on: https://chromium-review.googlesource.com/1100466 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#567216}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4ddfe4f..d791a8f5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I40d2a424c71adcc34382fbf35ce543949f150a33 Reviewed-on: https://chromium-review.googlesource.com/1100681Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567215}
-
Stefan Zager authored
Conversion between 'frame' and 'contents' coordinate spaces is now a no-op. This CL settles on 'frame' as the term d'art for the coordinate space of the frame, so ViewportToContents becomes ViewportToFrame, and vice versa. Also, this adds a couple of missing float overrides for still-useful conversion methods. Arbitrarily converting between LayoutUnit and float can be a source of bugs. BUG=823365 R=skobes@chromium.org,bokan@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id687f88988e6e27ea75027026377d9464bee3406 Reviewed-on: https://chromium-review.googlesource.com/1099996 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#567214}
-
Mikel Astiz authored
Prior to this patch, TabContentsSyncedTabDelegate was itself a tab helper (WebContentsUserData) that was created on all platforms, with the whole purpose to reuse a partial implementation of sync_sessions::SyncedTabDelegate. This was a bit weird because a) The life cycle diverges across platforms: created lazily on Android, early otherwise. b) On Android there was no real need to register a tab helper. c) On Android, it's weird to reason about two tab delegates coexisting, one of which is a proxy but also overrides some logic. Instead, let's make TabContentsSyncedTabDelegate a base class that is *NOT* a WebContentsUserData, and let platform-specific subclasses decide whether they want to register as WebContentsUserData, as well as which logic they need to override. This also removes code that is dead on some platforms, because the base class is abtract and doesn't implements all methods (as opposed to a proxy object which cannot be abstract). Bug: 851905 Change-Id: I305ad85e2392fdd2ce428c0464b7750ac599babf Reviewed-on: https://chromium-review.googlesource.com/1097405 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Tatiana Gornak authored
TBR=dtrainor@chromium.org Bug: 852073 Change-Id: I59017409e79bcddce615de5a820f1424f34eedbc Reviewed-on: https://chromium-review.googlesource.com/1098917Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#567212}
-
Sylvain Defresne authored
Those fields are never accessed after initialization (except for destruction). Remove the fields also track preferences that are unused on iOS (they are related to managed accounts which is not supported on iOS). Bug: none Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I13f86b143d34fd0ba07d4372ff0e37133e0e2213 Reviewed-on: https://chromium-review.googlesource.com/1097334 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#567211}
-
Findit authored
This reverts commit 6bc98f91. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 566961 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzZiYzk4ZjkxODRkYjQzZmFlYWE5N2YwODZhMTFlYmEyNGZkMWMxZjkM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/27907 Sample Failed Step: unit_tests Original change's description: > Add server token revocation in AccountManager > > Bug: 820046 > Test: chromeos_unittests --gtest_filter="*AccountManager*" > Test: unit_tests --gtest_filter="*CrOSOAuthDelegateTest*" > Change-Id: I017bb9e9f9ed789d77235336be8fa465fd4289b8 > Reviewed-on: https://chromium-review.googlesource.com/1087455 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566961} Change-Id: Ie71a2d159ed50aa3196bf43b488877747b1f88b8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820046 Reviewed-on: https://chromium-review.googlesource.com/1100515 Cr-Commit-Position: refs/heads/master@{#567210}
-
David Roger authored
The guard was present in the .h, but not in the .cc. This CL adds the misssing guard in the .cc. Change-Id: I8716cbad52dd2f578cf730b41118ebbb554fc480 Reviewed-on: https://chromium-review.googlesource.com/1100470Reviewed-by:
-
Kush Sinha authored
This reverts commit 94c42a4f. Reason for revert: To unblock https://chromium-review.googlesource.com/c/chromium/src/+/1100515 Original change's description: > Code Cleanup: Dedup usages of AccountManager's URL Context > > |InlineLoginHandlerChromeOS| and |ChromeOSOAuth2TokenServiceDelegate| > use the system URL context because they 'know' that AccountManager is > going to use the same. This is a leaky abstraction. > > Add a method in AccountManager that returns its URL Request Context. > This request context happens to be the system URL context for now. > > Bug: 820046 > Change-Id: I668769167893c995f73df63acc575eb410c0f986 > Reviewed-on: https://chromium-review.googlesource.com/1088617 > Commit-Queue: Kush Sinha <sinhak@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Lutz Justen <ljusten@chromium.org> > Cr-Commit-Position: refs/heads/master@{#566998} TBR=xiyuan@chromium.org,ljusten@chromium.org,sinhak@chromium.org Change-Id: I57c56e1cde479c6544f93c42061cfc6eec08254e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 820046 Reviewed-on: https://chromium-review.googlesource.com/1100775Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#567208}
-
Michael Lippautz authored
Bug: chromium:847679 Change-Id: I36061d52a69fb89ce3d4a224904be39c82c40d59 Reviewed-on: https://chromium-review.googlesource.com/1098746 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Hajime Hoshi authored
This CL also marks WebThreadScheduler::DefaultTaskRunner main-thread only. Change-Id: Ia2b8d962c78a4cf426c1ecc1010d728b58c45e4a Reviewed-on: https://chromium-review.googlesource.com/1100603Reviewed-by:
Yuta Kitamura <yutak@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
Bug: 852202, 669772, 806658 Change-Id: Ife9c41fbe08c1f414bb5459cba29d98d7e1fb892 Reviewed-on: https://chromium-review.googlesource.com/1098650 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#567205}
-
Adam Rice authored
The Blink rename changed the WebSocket handshake files from WebSocketHandshake* to web_socket_handshake*. Since WebSocket is one word, these should properly be websocket_handshake*. Fix them. BUG=834596 Change-Id: I2009a679c948ea460713890ed548e42d797b290c Reviewed-on: https://chromium-review.googlesource.com/1098743Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Add plumbing that allows to skip the "manual password entry" logic when the smart card SAML sign-in is used. Without this, the user would be asked to type their password at the end of their HTTPS-client-certificate-based SAML sign-in. For this, the gaia sign-in screen JS code will ask the C++ handler whether the user is expected to have a password. In this CL, the handler is just a stub. It will be replaced later with an actual smart card sign-in logic, once it's implemented. No changes in behavior are expected from this CL alone. BUG=chromium:826417 TEST=none (existing tests) Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I44012f02fade8823556bcf1200a122b0791d8292 Reviewed-on: https://chromium-review.googlesource.com/1097406Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#567203}
-
Ramin Halavati authored
LoginPromptBrowserTest.CancelLoginInterstitialOnRedirect fails occasionally on Mac 10.12. Disabling it. Bug: 852703 Change-Id: I3ac9fac42fdb1da52a21ccf27049889693136e20 Reviewed-on: https://chromium-review.googlesource.com/1100467Reviewed-by:
-
Ramin Halavati authored
BrowserTest.ReattachDevToolsWindow occasionally fails on Mac 10.11. Bug: 852697 Change-Id: Ibd94a9b94d7963825c42dbe50fb8c72097409da0 TBR: ellyjones@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1100465Reviewed-by:
-
Sylvain Defresne authored
Bug: 798408 Change-Id: I6983b0468743607e8dd2a8722885a4861aaba8b2 Reviewed-on: https://chromium-review.googlesource.com/1096772Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Derek Cheng <imcheng@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#567200}
-
Alexander Hendrich authored
Fix1: If either AllowOnlyPolicyNetworksToConnect or AllowOnlyPolicyNetworksToAutoconnect is enabled, this CL will additionally remove the network configurations (AllowOnlyPolicyNetworksToConnect) or disable auto-connect (for AllowOnlyPolicyNetworksToAutoconnect) for the unmanaged networks to prevent Shill from re-connecting when searching for a best service to connect. Fix2: Fixed missing disconnect, when AllowOnlyPolicyNetworksToConnect gets enabled. This disconnect was incorrectly prevented by the |applied_autoconnect_policy_| boolean before, which ensures that the disconnect on AllowOnlyPolicyNetworksToAutoconnect only happens once. Bug: 850550 Change-Id: I869ed49d58adb82707e8856e896c5a141f6f6625 Reviewed-on: https://chromium-review.googlesource.com/1091051Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#567199}
-
Yuichiro Hanada authored
To make writing unit-tests easy, this CL separates mojo interfaces from ArcInputMethodManager. This CL does the following: - Rename ArcInputMethodManagerBridge to ArcInputMethodManagerService. - Introduce new ArcInputMethodManagerBridge interface for injection point. Bug: 845079 Test: unit tests Change-Id: I2e16b0bb9eba2c6bf9717813dff1640bd1f54b1d Reviewed-on: https://chromium-review.googlesource.com/1098738 Commit-Queue: Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#567198}
-
Morten Stenshorne authored
Apart from making it more human neck friendly, those which were in vertical-lr would expose bug 850504 (once support for anonymous NG table cells is enabled), which really isn't an interesting thing to test in these tests. To be consistent, rewrite all tests to use horizontal-tb, not just those that previously used vertical-lr. viewport-y-vertical-XX-rtl additionally need a fixed horizontal offset for the absolutely positioned box in the ref. Not sure what went wrong, but both NG and legacy decided to act up in identical ways. Bug: 850504 Change-Id: I888db0680c5d543c9ac19a1ae8ab9ca791d8b259 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/1099384Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#567197}
-
Friedrich Horschig authored
This CL connects the TabLayout int the keyboard accessory with the ViewPager in the accessory sheet. This means the visibility of keyboard and tabs can be controlled by the ManualFillingCoordinator and is decoupled from the accessory. Bug: 828832, 811747 Change-Id: I01f225458d068e75fde19398fc352672779d23c0 Reviewed-on: https://chromium-review.googlesource.com/1091190 Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#567196}
-
Roman Sorokin authored
Fixes regression introduced in CL:1068184 Also added a browsertest to verify behaviour on user kerberos files changed D-Bus signal BUG=chromium:845829 TEST=ExistingUserControllerActiveDirectoryTest.UserKerberosFilesChangedSignalTriggersFileUpdate Change-Id: Ieeb800f85210c094f34c93a71b0e7502ceae3114 Reviewed-on: https://chromium-review.googlesource.com/1089060Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567195}
-
Mark Cogan authored
This CL updates the tab grid selector control assets, and removes the programatic scaling effect now that the assets are scaled. Tinting is also now done in code. Bug: 849645 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I48e9a3e72cad8609ad14a2940733a02140d89005 Reviewed-on: https://chromium-review.googlesource.com/1099070 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#567194}
-
Joel Hockey authored
Bug: 845075 Change-Id: Id6667e02fcdd7be54d11e6ccec0074a475948754 Reviewed-on: https://chromium-review.googlesource.com/1100360Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#567193}
-
Mark Cogan authored
Per the attached bug, this CL changes the tab grid to not show the changed selection state when leaving the tab grid via a tap on a cell. Cell selection actually happened twice when a cell was tapped; once directly from the collection view, and a second time after the selection had round-tripped through the mediator. This CL cleans that up, and has the collection view decline all selection events, allowing them only to happen as a result of consumer calls. This CL adds a |showSelectionState| property to the grid view controller; when set to NO, the grid view controller will not update the selection state of the cells when the -selectWithItemID: consumer call is received. The ID of the selected item is maintained, however. This Cl also doesn't show the selection ring on the proxy cells animated for the transition. Bug: 849642 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ibf8d2c91dc80c42dea55c7e457efe7232d234267 Reviewed-on: https://chromium-review.googlesource.com/1096763Reviewed-by:
-
