- 31 Jul, 2019 12 commits
-
-
Robert Liao authored
This allows the HatsService to have multiple site IDs and specify what site ID to use. BUG=979530 Change-Id: I6b255a2ebe9cc1cb5e4b7ec10ab98f3f3b50c6dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711055Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Auto-Submit: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682531}
-
Joe DeBlasio authored
This CL adds an advanced section to the lookalike URL interstitial, updates the strings, and adds support for different descriptions for top site and engagement matches. The advanced section is hidden behind a feature param for now, so this CL has no immediately-user-visible change. Bug: 987359 Change-Id: Ic4ffb3610db7608de0adeb020b253caf8755e2ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717191Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#682530}
-
Tom Anderson authored
This is necessary for switching GlobalMenuBarX11 from gio to //dbus. GlobalMenuBarX11 lazily creates the history menu when it is opened, so we cannot call SetModel() because that would remove the menu and replace it with a new one. We need to update the menu in-place, which is now possible with MenuLayoutUpdated(). Also provided is MenuItemsPropertiesUpdated(), which avoids having to rebuild the entire menu tree if a single item becomes checked/unchecked, disabled/enabled, etc. BUG=981201 R=thestig Change-Id: I36397810ba38f16ef44206282203db16edfdd0c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720796 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682529}
-
Jenna Himawan authored
Bug: 988044, 160194 Change-Id: Ieecb98d113d7a769aebf6be1a3694f1a2c1a5141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710773 Commit-Queue: Jenna Himawan <jhimawan@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#682528}
-
Patrick Noland authored
Also, add a flag that disables the InstantExtended limit on search suggestions. Bug: 974852 Change-Id: I9f3a443b89c83cc4fa958756e25448688d9e0370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725172 Commit-Queue: Patrick Noland <pnoland@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#682527}
-
Kristi Park authored
Like placeholder text in input fields, this should not be selectable by users. Bug: 987948 Change-Id: I56d4586878bcd09fab1ba6186379305d3163dfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726936 Commit-Queue: Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Auto-Submit: Kristi Park <kristipark@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#682526}
-
Eric Stevenson authored
If a class is marked @MainDex and needed outside of the browser process then it's possible that a native method may be referenced outside of the browser process. Currently, this can cause problems for NativeMethods JNI interfaces on KitKat since the generated wrapper classes do not have the @MainDex annotation. This CL changes the JNI annotation processor to propagate @MainDex to generated native wrapper classes where necessary. Bug: 929661 Change-Id: I2f6e09475032550768ec3b03cc3b52519ba0dc3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726815 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#682525}
-
Avery Musbach authored
The present CL is just some simple code cleanup. Change-Id: Ica26c2b3f9bdfdd18a93debe1350db76f08760ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727369 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#682524}
-
Ken Rockot authored
The only services used in production ios code are the FilePatcher and Unzipper services, and these have been moved off of Service Manager. Identity service has no clients on ios so its support does not need to be maintained, and all other Service Manager usage was either only for test coverage, or nominal use of the InterfaceProvider API. The latter has been replaced with a new WebState::InterfaceBinder API which is roughly equivalent. The net result of this CL is the complete removal of all services/service_manager dependencies from ios/. Bug: 977637 Change-Id: I88ee321cf4fe58c550ac235de828ff93aa940f00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725482 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#682523}
-
Rune Lillesveen authored
This is necessary for having a per element color scheme for form controls in web pages using the color-scheme CSS property. Bug: 929098 Change-Id: I45310baec7e19fe8597d8a2359a77595909da7d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1650341Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#682522}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/12bc1c4dae87..ffff6c5fcc92 git log 12bc1c4dae87..ffff6c5fcc92 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 tsepez@chromium.org Make CPDF_Font a retainable type. Created with: gclient setdep -r src/third_party/pdfium@ffff6c5fcc92 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Bug: None Change-Id: Ie38918188e3ba1245a17014d1dca5c93b731e212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726836Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682521}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/019109290b69..67d90245bad4 git log 019109290b69..67d90245bad4 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 vapier@chromium.org convert next to __next__ (and .next() to next()) Created with: gclient setdep -r src/third_party/chromite@67d90245bad4 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I34b2e8becf6e79873e52b4ad19c8a343d9a1a9ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727394Reviewed-by:
-
- 30 Jul, 2019 28 commits
-
-
David Pursell authored
An extra "options" field was added to async_wait_t, zero it out by default. Change-Id: Ib6427879872450f1a530475fddf971c55e74a28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719464Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Pursell <dpursell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682519}
-
Mitsuru Oshima authored
* Fixed data dependency so that it builds necessary pak files. * Quirks manager isn't available in this test. * Do not run tasks in NetworkStateTestHelper setup, as it can run the tasks that should be run after setup. * Set the host window bounds in AshContentTest::SetUp before initializing ash. AshTestHelper will set its own otherwise. * Compute the test window size based on the display size. The current code uses fixed size and smaller than one used in interactive_ui_tests. Change-Id: I20725e1e5ae6ca9b93af6538b11bebf02bd2485b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722205 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682518}
-
Kyle Milka authored
Use a different std::string ctor to avoid the overflow. Also return false in the pointer is null. Bug: 988896 Change-Id: I5986937faf3bcc169b329e58efd2438db2d50f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727469Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6e86c1b05eee..245c002bc098 git log 6e86c1b05eee..245c002bc098 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 michaelludwig@google.com Remove use of SkDropShadowImageFilter::ShadowMode internally 2019-07-30 bungeman@google.com Fix potential use of uninitialized data in with GDI. Created with: gclient setdep -r src/third_party/skia@245c002bc098 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I862b15e213018a5ea70b3f2a4ee13d7a0e837408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726656Reviewed-by:
-
Changwan Ryu authored
Bug: 921655 Test: browser_tests --gtest_filter=ClientHintsBrowserTest.ClientHintsLifetimeNotAttachedJavaScriptBlocked* Change-Id: I19bf9d0c0c42b8f763906544bdb133d65d13bf93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688362Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682515}
-
Darren Shen authored
InputMethodEngineBase seems to keep track of a local cached composition but it's not actually needed. We delete this because it is error-prone: every operation needs to update the cache correctly. Bug: 980437 Change-Id: I786317a7b67813ab4a76de9bebbb3f3aa5030503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1688751 Auto-Submit: Darren Shen <shend@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#682514}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fa0175c0988d..c39e7c7cc884 git log fa0175c0988d..c39e7c7cc884 --date=short --no-merges --format='%ad %ae %s' 2019-07-30 capn@google.com Retry mmap() without MAP_JIT on older macOS 2019-07-30 capn@google.com Specify the MAP_JIT flag when allocating executable memory on macOS Created with: gclient setdep -r src/third_party/swiftshader@c39e7c7cc884 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:985816,chromium:985816 Change-Id: Iea2cf84af474440160c8c7e5b9ac5c4ec1554ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727395Reviewed-by:
-
Ian Wells authored
Prevent calling GetCurrentArticleSuggestions() when prefetch_prefs::IsEnabled() is false, but still check whether client is forbidden by the server from prefetching. Bug: 982468 Change-Id: I2acbbdff440a81fd1f6419c81641a27a6bc2af06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726657Reviewed-by:
Dan H <harringtond@chromium.org> Commit-Queue: Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#682512}
-
Clark DuVall authored
Follow ups to http://crrev.com/c/1721933. The deleted_frame_data_map_ was always getting empty FrameData because the render frame is no longer live by the time OnRenderFrameDeleted is called. Bug: 980774 Change-Id: I1be29171c25e3ff2f8aae74be408833c5b4ebc85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726812Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682511}
-
Olivier Yiptong authored
Using the Native File System API to write files, users will create a configurable FileWriter which defaults to writing files "atomically". Atomic writes are writes that materialize after the successful completion of an explicit `Close()`operation. This is to ensure that the target file is not left in an incomplete state. This is useful for a wide variety of applications like file editors and more. This is implemented by using a `move` or `rename` filesystem operation, which in most filesystems is atomic. Additionally, this CL implements the option to retain the original file data when writing atomically. Bug: 968550 Change-Id: Ia61372e6f52378730388987f5c0749f8ec15f03b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692325Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#682510}
-
Dave Tapuska authored
https://chromium.googlesource.com/chromium/src/+/ef7f7fa0e40d0eb1c52575b8687cc5b9ae67976e removed usage of frame creation and detach stack traces. Now we can remove them from Frame.h BUG=838348 Change-Id: I30ae0db97b369720ecf011d0a72b0740b47df547 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726831Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#682509}
-
Hongchan Choi authored
This CL is the devtool counterpart of the CL https://chromium-review.googlesource.com/c/chromium/src/+/1724815. This event is fired when the context is marked for GC, uninitialized, and waiting for the actual destruction. Rename it to clarify its behavior. Bug: 970898 Change-Id: I5b9b8b601b9fec4438b47e64b6021b18b9a69b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724889 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#682508}
-
Ken Rockot authored
Removes dependencies on Service Manager from the cups_ipp_parser service. The service is not actually used in production at the moment, so there are no clients to convert. This simply removes Service Manager dependencies and related code. Also removes some stale Service Manager dependencies and #includes from chrome/services/cups_proxy/. Bug: 977637 Change-Id: I08b8dd3af51df27b1d2b52d70144f466deb9dd77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725314Reviewed-by:
Luum Habtemariam <luum@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#682507}
-
Antonio Gomes authored
This CL implements phase 3.2.1 described on the design doc [1]. [1] https://docs.google.com/document/d/1rHJGi1U72qZsOGIctIf7GKRaY8d7BgtVW8MaMYumzYY/ It Onion soups files video_capture_impl.cc|h, video_capture_impl_manager.cc|h. For the later pair, it also adds the "web" prefix to the file and class names, since it is used by content/renderer/pepper code, unlikely to be moved to Blink. Additionally, the respective unit tests of each pair of files are also moved to Blink. Last, CL also: - makes the relevant video_capture mojo types available in Blink. - removes the blink:: namespace usage. BUG=704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: If08ec5fd00c8280696abc5395c6846010593e3dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718469 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#682506}
-
Varun Khaneja authored
SafeBrowsing.V4Update.Parse.Result: KEEP SafeBrowsing.V4Update.Result: KEEP SafeBrowsing.V4Update.TimedOut: Remove. Timed out cases are < 0.03% R=drubery, holte Bug: 969959 Change-Id: I7721bd3ab3bc3d8aa5cdbf773e22e30a96ecc78a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721832 Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#682505}
-
John Rummell authored
Adds: 1) Logs events 'canplay', 'load', 'playing', 'play', 'canplaythrough', 'stalled', and 'waiting'. 2) Adds heartbeat message every second that logs the status of the player. 3) Logs promise failures from play(). Bug: 986021 Test: Modified tests pass Change-Id: I4bddcc25249d6d13a0e4486b918829ae51cf7c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726649Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#682504}
-
Becky Zhou authored
Change-Id: I81f0d9798798aa97a5bfa46c39ca2d1f32b6b124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726631Reviewed-by:
-
Maksym Onufriienko authored
Base on https://chromium-swarm.appspot.com/task?id=46420ba12b52e810: 1. test started running on 3 simulators, but one of them, Clone 2 of iPad Air, did not start running tests and was stuck with error 'Test runner exited before starting test execution.' In Xcode10 for such a case entire run stopped, but Xcode11 runs tests on other 'good' Simulators. 2. tests finished but xcodebuild did not finish its execution since Clone 2 of iPad Air was irresponsible 3. in 3 mins test_runner killed xcodebuild 4. test_runner parses passed tests and start a new attempt using passed-tests filter 5. xcode ran 0 tests then and marked tests as succeeded but because 0 tests ran, test_runner assumed that TESTS_DID_NOT_START and marked results as failed. Fixed step 4 to stop execution in case all tests passed even for interrupted build. Bug: 987664 Change-Id: Idcd451d7feef518dc5613cb5f1bc42e8bbe84e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717919 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682502}
-
chrome://tab-stripJohn Lee authored
This CL adds an empty page chrome://tab-strip that is currently only accessible on ChromeOS or with the build flag enable_webui_tab_strip set to true. Bug: 989131 Change-Id: I07be8b89135690530593e8271f927059f3496c4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719324Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#682501}
-
Mustafa Emre Acer authored
These characters are already handled by the spoof checks and any domain containing them are left as punycode. However, ICU generates different skeletons for some of them, meaning lookalike URL checks don't always catch domains containing these characters. This CL fixes this so that two domains differing by one of these hyphens/dashes always produce the same skeleton string. Bug: 863661 Change-Id: Ia8d9400b49592d4b5f990323faf615485a8f83ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726760 Auto-Submit: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#682500}
-
Nico Weber authored
PVALLOC_AVAILABLE was first added in https://codereview.chromium.org/184313002/ 5.5 years ago, and it was on on linux if tcmalloc was not being used. (Or if something outside the build system set the define, something which can't happen with GN.) The since-the-new allocator shim handles pvalloc: base/allocator/allocator_shim_override_linker_wrapped_symbols.h Furthermore, the non-test use of PVALLOC_AVAILABLE was removed here: https://chromium-review.googlesource.com/c/chromium/src/+/544844 This unconditionally enables the pvalloc tests on linux; they seem to pass even with tcmalloc on. (The motivation is that this removes the only use of USE_TCMALLOC in a .h file, which makes converting NO_TCMALLOC to a buildflag easier.) Bug: 550886,961767 Change-Id: I2d5b5399fb8cedd5e07f430f835512b5f120373b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727149 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Mostyn Bramley-Moore <mostynb@vewd.com> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#682499}
-
Kristi Park authored
Apply the using-mouse-nav class on onmousedown instead of onclick, which would only apply after the mouse was released. Bug: 987638 Change-Id: I007fd9c9905341ae0a68a07a329fc44f8e8e10e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726637 Auto-Submit: Kristi Park <kristipark@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
-
John Williams authored
Bug: 951057 Change-Id: I02be8618b13f3fb185cecb97e03985185758fa3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1674448 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#682497}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8b2dfa0fc657..1ebe6014389e git log 8b2dfa0fc657..1ebe6014389e --date=short --no-merges --format='%ad %ae %s' 2019-07-30 lujc@google.com Vulkan: Only check sampler when setUniform1i(v) Created with: gclient setdep -r src/third_party/angle@1ebe6014389e The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ide8708462925f82411e2e8e659adbb6d5af04c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727376Reviewed-by:
-
Xinghui Lu authored
Change-Id: I8de955b61d4c30d924167a52c8deaa6ad5b8c4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726639Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682495}
-
Patrick Monette authored
This code was already deprecated in favor of third-party DLL blocking Bug: 986926 Change-Id: Id029917a3adcb7acd4c827544491045c6b73a0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720120 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#682494}
-
Jinsuk Kim authored
Added myself as an owner of the directory chrome/browser/gesturenav Bug: 937946 Change-Id: Ifda4fc8d05e555463a2dfd27cd6671ddba2e585e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727437Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia2d15a83afc330d822aa6a400433b971349b153a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727377Reviewed-by:
-
