GitLab

PostTask in WebMessagePortChannelImpl::postMessage seems cross-thread, but
copying blink::WebString accross threads is not thread safe.

This CL converts blink::WebString to base::string16 before PostTask, making
the code thread-safe assuming base::string16 can be copied accross threads.

BUG=392410

Review URL: https://codereview.chromium.org/379773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283332 0039d316-1c4b-4281-b951-d872f2087c98

This CL fixes an issue where the app list folder animation would hide the
item label for its animation, causing the text to pop in at the end of
animation.

This is fixed by only hiding the icon rather than the entire AppListItemView
during the animation.

BUG=393207

Review URL: https://codereview.chromium.org/395653005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283331 0039d316-1c4b-4281-b951-d872f2087c98

We want to build Chrome with toolkit-views available, but port things
gradually.

This change converts a View* argument into a callback argument that
calls the required member function on View.

This lets us get rid of eleven #ifdef guards which would otherwise need
to change (now, and again once the download shelf is ported to use views
on Mac).

BUG=390755

Review URL: https://codereview.chromium.org/377223002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283330 0039d316-1c4b-4281-b951-d872f2087c98

BUG=328417

Review URL: https://codereview.chromium.org/384063004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283329 0039d316-1c4b-4281-b951-d872f2087c98

Added a guard in |chromeos::EventRewriter::RewriteKeyEvent()|.
Moved |ui::XKeyEventKeyCode()| to share it. Added unit test cases.

BUG=390263
TEST=EventRewriterTest.TestRewriteModifiersRemapMany
R=derat@chromium.org,sadrul@chromium.org

Review URL: https://codereview.chromium.org/378503007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283328 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349436

Review URL: https://codereview.chromium.org/383213007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283327 0039d316-1c4b-4281-b951-d872f2087c98

BUG=333429

Review URL: https://codereview.chromium.org/385533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283326 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Possibly-uninitialized local variable
* Signedness mismatch
* Assignment inside conditional

This also contains a small number of other cleanups/simplifications to nearby
 code.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/368133005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283325 0039d316-1c4b-4281-b951-d872f2087c98

R=vsevik
BUG=375205

Review URL: https://codereview.chromium.org/363463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283324 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283317 0039d316-1c4b-4281-b951-d872f2087c98

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/390183009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283314 0039d316-1c4b-4281-b951-d872f2087c98

This simplifies things and better matches how we're actually using the
API.

BUG=389339
TEST=covered by unit tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/396703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283313 0039d316-1c4b-4281-b951-d872f2087c98

Remove the remaining overrides of View::HitTestRect() and
instead implement View::ViewTargeterDelegate::DoesIntersectRect().
Make View::HitTestRect() non-virtual.

BUG=388838
TEST=none

Review URL: https://codereview.chromium.org/380813003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283312 0039d316-1c4b-4281-b951-d872f2087c98

In the interest of conserving power, several incremental changes to timer slack have been committed over the last few weeks.  This CL disables those changes so we can get some numbers for the combined effect in terms of power usage and idle wakeup numbers.

This needs to be checked in because we can only get a good comparative measure for this when run on the bots in a controlled environment.

BUG=356804

Review URL: https://codereview.chromium.org/395763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283311 0039d316-1c4b-4281-b951-d872f2087c98

Initial patch.

Review URL: https://codereview.chromium.org/389263007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283310 0039d316-1c4b-4281-b951-d872f2087c98

BUG=375533
R=abodenha@chromium.org

Review URL: https://codereview.chromium.org/393673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283309 0039d316-1c4b-4281-b951-d872f2087c98

Prior to crrev.com/274857 *only* android-chromium-testshell. Then until crrev.com/276628 *both* (android-chromium-testshell and
android-chrome-shell) work. After that rev 276628 *only* android-chrome-shell works. bisect-perf-reggresion.py script should
handle these cases and set appropriate browser type based on revision.

BUG=385324
NOTRY=true

Review URL: https://codereview.chromium.org/399463002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283308 0039d316-1c4b-4281-b951-d872f2087c98

These things should be in a 'variables' block (otherwise they don't do
anything).

BUG=388270
NOTRY=true

Review URL: https://codereview.chromium.org/396823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283306 0039d316-1c4b-4281-b951-d872f2087c98

This contains fixes for the following sorts of issues:
* Signedness mismatch
* Assignment inside conditional
* Constant value was truncated
* Possibly-uninitialized local variable

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/377683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283305 0039d316-1c4b-4281-b951-d872f2087c98

Adds support for allowing users to change the appearance of 
distilled pages to different themes. The current themes are 
light, dark and sepia.

The theme of the page is controlled by the CSS class of the 
body element. When the page is loaded, this CSS class is set
 by inserting the CSS class into the HTML.  When a setting is 
changed while a distilled page is open, the CSS class is set 
by calling the JavaScript function useTheme which then updates 
the body element's CSS class.

BUG=383630

Review URL: https://codereview.chromium.org/341563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283303 0039d316-1c4b-4281-b951-d872f2087c98

* Fix typo.
* Remove unused code.
* Move IsFallbackFileBrowserHandler to file_tasks.cc since it is no more
 specific to fileBrowserHandler.

BUG=none

Review URL: https://codereview.chromium.org/391873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283302 0039d316-1c4b-4281-b951-d872f2087c98

The previous comment was incorrect. It seems to be a leftover when
the flag changed from --enable-shared-worker to
--disable-shared-worker in https://codereview.chromium.org/395006.

Review URL: https://codereview.chromium.org/378523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283300 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/383123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283299 0039d316-1c4b-4281-b951-d872f2087c98

There shouldn't be multiple content-areas housing the link-buttons.

See screenshots at http://crbug.com/392347.

BUG=392347
R=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/376093002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283296 0039d316-1c4b-4281-b951-d872f2087c98

TBR=brettw@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/390173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283295 0039d316-1c4b-4281-b951-d872f2087c98

TEST=checked that this works on a test device
BUG=384803

Review URL: https://codereview.chromium.org/385963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283294 0039d316-1c4b-4281-b951-d872f2087c98

This adds support for android resources to gn.

Two new templates are introduced:

java_string_grd: This is like gyp's build/java_strings_grd.gypi. It runs
grit and generates Android strings.xml files and then zips them
together.
android_resources: This is the target for android resources. It is
mostly a wrapper around process_resources.py. This is *not part* of
android_library (like it is in gyp). Making these two things separate is
more like facebook's BUCK and google's internal build rules (and gyp's
java.gypi and java_apk.gypi have gotten way too big and complicated).

Changes to the actual build scripts are very minor except for the added
support for andoid_resources to write_build_config.py. Building
resources requires getting all the transitive resource dependencies, and
so this reuses the simple sorted transitive dependency thing from
write_ordered_libraries.py.

TBR=rch@chromium.org
BUG=359249

Review URL: https://codereview.chromium.org/361633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283293 0039d316-1c4b-4281-b951-d872f2087c98

R=sky@chromium.org

Review URL: https://codereview.chromium.org/388393002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283292 0039d316-1c4b-4281-b951-d872f2087c98

Update simulator to keep up with renames in spec.

NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/395953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283290 0039d316-1c4b-4281-b951-d872f2087c98

MediaStreamVideoSource owns a VideoTrackAdapter, that sees the
frames passing by (possibly adapting frame rate and resolution).
This CL extends this VTA to monitor passing frames. Every time the
monitoring wakes up, it notifies the MediaStreamVideoSource of
the muted state via SetMutedState. This Class has no state, simply
updates all registered MediaStreamVideoTracks, who have a 
muted state.

Later CLs will further connect the MSVT::SetMutedState() to
ping WebMediaStreamTrack etc.

BUG=389159

Review URL: https://codereview.chromium.org/366243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283285 0039d316-1c4b-4281-b951-d872f2087c98

R=gab@chromium.org,asvitkine@chromium.org
TBR=sky@chromium.org
BUG=388741

Review URL: https://codereview.chromium.org/385123004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283282 0039d316-1c4b-4281-b951-d872f2087c98

Only a few provider implementations need this member.

BUG=None
TEST=build

Review URL: https://codereview.chromium.org/388203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283280 0039d316-1c4b-4281-b951-d872f2087c98

Was flaky. Now not flaky?

BUG=375856

Review URL: https://codereview.chromium.org/385763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283278 0039d316-1c4b-4281-b951-d872f2087c98

Original review: https://codereview.chromium.org/383083010

R=jamesr@chromium.org
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/395633002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283277 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283276 0039d316-1c4b-4281-b951-d872f2087c98

> NaCl: Update revision in DEPS, r13456 -> r13484
> 
> This pulls in the following Native Client changes:
> 
> r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
> r13458: (noelallen) Update and add GN files to build sel_ldr.
> r13459: (jvoung) Remove env cleanser references to obsolete env vars.
> r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
> r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
> r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
> r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
> r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
> r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
> r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
> r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
> r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
> r13470: (dschuff) Update revision for PNaCl r13392->r13466
> r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
> r13472: (dschuff) Build PNaCl with mingw again
> r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
> r13474: (dschuff) Update revision for PNaCl r13466->r13472
> r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
> r13476: (sky) Changes scan_sources not to output on bogus directory
> r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
> r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
> r13481: (hidehiko) Align at 16 bytes for stack for created thread.
> r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"
> 
> BUG=none
> TEST=browser_tests and nacl_integration
> R=jvoung@chromium.org
> 
> Review URL: https://codereview.chromium.org/390553002

TBR=dschuff@chromium.org

Review URL: https://codereview.chromium.org/397713006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283275 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283272 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13457: (dyen) LLVM Regression tests check for build files instead of empty dirs.
r13458: (noelallen) Update and add GN files to build sel_ldr.
r13459: (jvoung) Remove env cleanser references to obsolete env vars.
r13460: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13461: (hamaji) Non-SFI Mode: Add prctl syscall wrapper
r13462: (hamaji) Non-SFI Mode: Implement IRT fstat
r13463: (hamaji) Correct the return type of TestSuite in timefuncs_test
r13464: (hamaji) syscall_test: Do not test st_atime in the test for fstat
r13465: (earthdok) Implement initial MSan support. Also, adjust ASan build flags.
r13466: (dschuff) pnacl-ld: Do not attempt to parse ELF or bitcode files as linker scripts
r13467: (jvoung) Remove NaClSrpcIsStandalone() function.
r13468: (dschuff) Make testing architecture explicit PNaCl toolchain buildbot script
r13469: (dschuff) Stub out pnacl-opt and pnacl-finalize tools for scons built_elsewhere=1
r13470: (dschuff) Update revision for PNaCl r13392->r13466
r13471: (noelallen) Build nacl_bootstrap_helper and test with GN scons
r13472: (dschuff) Build PNaCl with mingw again
r13473: (earthdok) Zap the NaClSignalContext struct in SignalCatch.
r13474: (dschuff) Update revision for PNaCl r13466->r13472
r13475: (sehr) Munge nacl_helper_bootstrap using python rather than libelf
r13476: (sky) Changes scan_sources not to output on bogus directory
r13477: (dschuff) Reduce debugging metadata for pexe builds in Chrome
r13480: (jfb) PNaCl: Update LLVM revision in pnacl/COMPONENT_REVISIONS
r13481: (hidehiko) Align at 16 bytes for stack for created thread.
r13484: (jfb) Revert "Munge nacl_helper_bootstrap using python rather than libelf"

BUG=none
TEST=browser_tests and nacl_integration
R=jvoung@chromium.org

Review URL: https://codereview.chromium.org/390553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283271 0039d316-1c4b-4281-b951-d872f2087c98

> Hookup the PDF extension to the chrome extensions zoom API
> 
> BUG=303491
> 
> Review URL: https://codereview.chromium.org/392533002

TBR=raymes@chromium.org

Review URL: https://codereview.chromium.org/398643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283269 0039d316-1c4b-4281-b951-d872f2087c98

BUG=389333
TEST=Manual, see bug.

Review URL: https://codereview.chromium.org/335993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@283268 0039d316-1c4b-4281-b951-d872f2087c98