GitLab

Now that we use the PaintOpBuffer, analyze whether a DisplayItemList
has any discardable images to skip metadata generation if unnecessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2830243002
Cr-Commit-Position: refs/heads/master@{#469509}

Make the order of setting parameters in ConstructSystemRequestContext
exactly match the order in URLRequestContextBuilder.  Also add a few
(trivial) setters to URLRequestContextBuilder for things that
ConstructSystemRequestContext sets that URLRequestContextBuilder does
not support.

This is part of a multi-stage operation to use URLRequestContextBuilder
to create the system URLRequestContext:

1)  Defrag (This CL).
2)  Switch to having a URLRequestContextStorage own everything, and create
everything inline with system URLRequestContext configuration.
3)  Switch the proxy service to using the system URLRequestContext.
4)  Switch to using URLRequestContextBuilder, but having IOThread create
  everything (This could be combined with 2, but 2 will affect a lot of
  accessors, so will probably to do it incrementally)
5)  Switch to having URLRequestContextBuilder create everything it
  reasonably can.

Hopefully the incremental approach will help to protect against regressions.

BUG=715695

Review-Url: https://codereview.chromium.org/2860813002
Cr-Commit-Position: refs/heads/master@{#469508}

R=kpaulhamus@chromium.org

Review-Url: https://codereview.chromium.org/2857813002
Cr-Commit-Position: refs/heads/master@{#469507}

BUG=647036
TBR=yzshen,dpranke,jbroman

Review-Url: https://codereview.chromium.org/2853293003
Cr-Commit-Position: refs/heads/master@{#469506}

Screenshot in bug.

R=dschuyler@chromium.org
BUG=718210

Review-Url: https://codereview.chromium.org/2862773003
Cr-Commit-Position: refs/heads/master@{#469505}

https://pdfium.googlesource.com/pdfium.git/+log/d41f4752c81d..b8a8c43f3942

$ git log d41f4752c..b8a8c43f3 --date=short --no-merges --format='%ad %ae %s'
2017-05-04 thestig CPDF_Document::GetPageData() normally does not return NULL.
2017-05-04 thestig Make CPDF_Font member variables protected.

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I62224ef89307f373da6699d28dad3df96e6e658d
Reviewed-on: https://chromium-review.googlesource.com/496926
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469504}

CPU frequency file exists in [2] for a majority of devices. It can
also exist in [1] for certain devices like chell, cave, caroline,
veyron_speedy, etc. Add a parser to read data from [1] which has
different format from [2].

[1] /sys/devices/system/cpu/cpufreq/all_time_in_state
[2] /sys/devices/system/cpu/cpu*/cpufreq/stats/time_in_state

BUG=548510

Review-Url: https://codereview.chromium.org/2853863002
Cr-Commit-Position: refs/heads/master@{#469503}

This CL prevents flex pressure from squeezing paper-buttons. E.g. prevent
a long account name from making the "sign in to chrome" button into a
column of text.

BUG=718318
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2864483006
Cr-Commit-Position: refs/heads/master@{#469502}

BUG=718448

Review-Url: https://codereview.chromium.org/2857413002
Cr-Commit-Position: refs/heads/master@{#469501}

- move more things to the interface
- make offscreencanvas() only available for bindings

BUG=

Review-Url: https://codereview.chromium.org/2862923002
Cr-Commit-Position: refs/heads/master@{#469500}

This allows the hardware_class field in UMA to be populated on
iOS (with values like "iPhone9,3"), which will allow us to stop
sending those strings in the cpu_architecture field which is
what's currently being done.

BUG=370104

Review-Url: https://codereview.chromium.org/2860663005
Cr-Commit-Position: refs/heads/master@{#469499}

cc will soon reject frames with no render passes. Submit a frame with
a solid color quad of right size instead of an empty frame in
SurfacesInstance. Also, we just get rid of the empty frame submission in
HardwareRenderer because when SurfacesInstance updates its
references_surfaces the surface of HardwareRenderer will be garbage
collected and resources will be returned.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2856913002
Cr-Commit-Position: refs/heads/master@{#469498}

This patch updates the global interface listing after PaymentRequest was
enabled on additional platforms: Windows, Mac, ChromeOS, Linux.

blink-dev@ announcement:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/p1DYoxHlkKg/g_ZW1YLDCgAJ

This patch also re-enables global interface listing tests, which should
never be disabled.

BUG=717914

Review-Url: https://codereview.chromium.org/2856193002
Cr-Commit-Position: refs/heads/master@{#469497}

BUG=718185

Review-Url: https://codereview.chromium.org/2859533004
Cr-Commit-Position: refs/heads/master@{#469496}

Adding #if and #endif to match our coding style.

BUG=

Review-Url: https://codereview.chromium.org/2863643003
Cr-Commit-Position: refs/heads/master@{#469495}

R=dschuyler@chromium.org
BUG=718345
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2862963002
Cr-Commit-Position: refs/heads/master@{#469494}

There is no need to discover services when receive an extra didConnectPeripheral
event from macOS.

BUG=681414

Review-Url: https://codereview.chromium.org/2853933002
Cr-Commit-Position: refs/heads/master@{#469493}

MRWebUIMessageHandler

This is a reland of http://crrev/2731033002/. There were DCHECKs with side
effects that should have been CHECKs.

BUG=684638

Review-Url: https://codereview.chromium.org/2859953002
Cr-Commit-Position: refs/heads/master@{#469492}

BUG=640116

Review-Url: https://codereview.chromium.org/2864483004
Cr-Commit-Position: refs/heads/master@{#469491}

BUG=717322

Review-Url: https://codereview.chromium.org/2862913002
Cr-Commit-Position: refs/heads/master@{#469490}

Manually convert constructor/iirfilter.html to use new Audit.

Updated new-audionodeoptions to allow specifying constructor option
when testing the default constructor.

BUG=704976
TEST=constructor/iirfilter.html

Review-Url: https://codereview.chromium.org/2859193003
Cr-Commit-Position: refs/heads/master@{#469489}

No change in logic.

This creates an initial implementation of a new WebView-specific
blocking page. This has no change in logic, but paves the way for
choosing between two different blocking pages (loud and quiet).

Currently, all this does is specify SBErrorDisplayOptions without
depending on the defaults set in BaseBlockingPage.

This exposes CreateControllerClient() in BaseBlockingPage as protected
so that AwSafeBrowsingBlockingPage can take advantage of it.

BUG=718545

Review-Url: https://codereview.chromium.org/2863723002
Cr-Commit-Position: refs/heads/master@{#469488}

In Blink Renaming, Resource::error() was incorrectly renamed to GetError().
This CL re-renames it to FinishAsError().

This CL doesn't rename it to Error() because Error() looks like the getter of
|Resource::error_|.

BUG=675877

Review-Url: https://codereview.chromium.org/2855883004
Cr-Commit-Position: refs/heads/master@{#469487}

https://pdfium.googlesource.com/pdfium.git/+log/cf53b788ca1c..d41f4752c81d

$ git log cf53b788c..d41f4752c --date=short --no-merges --format='%ad %ae %s'
2017-05-04 dsinclair Remove unused IFX_Pause member
2017-05-04 thestig Mention pdfium_all target in README.md.
2017-05-04 npm Fix undefined shift in opj_get_all_encoding_parameters

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: Iaebce2e41bf2d1afe065f38102647a2e25985ddd
Reviewed-on: https://chromium-review.googlesource.com/496646
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#469486}

Android GN builds have been unable to build raw "unit_tests" as a target,
instead relying on unit_tests_apk or chrome/test:unit_tests. Linux builds,
in contrast, can do so without issue. I had thought that the issue was
that a "unit_tests" gn target in another directory was preventing gn
from creating a top-level alias. While this may be true, it's not the
reason for the discrepancy between Android and Linux builds. Instead,
the difference is that Linux builds create a unit_tests executable in
the top-level output directory, while Android builds create an APK and
a wrapper script in child directories.

This CL writes an additional wrapper script for gtest targets on Android
in the top-level directory that matches the suite's output_name (usually
its target name), allowing us to successfully build raw "unit_tests" on
Android. As a bonus, we can now run

  $ out/Release/unit_tests

(etc) on Android.

BUG=716117

Review-Url: https://codereview.chromium.org/2851523002
Cr-Commit-Position: refs/heads/master@{#469485}

Adds a more generic call to the helper delegate and calls out to the
LocaleManager. Then LocaleManager does the actual search engine setting
and any other potential fallout of the search engine choice.

BUG=712836, 712833

Review-Url: https://codereview.chromium.org/2860643003
Cr-Commit-Position: refs/heads/master@{#469484}

"paste as plain text" introduced an empty option in selection menu due
to the runtime string resource setting. Since we need to update
|canEditRichly| flag for the option in selection menu, there is no
simple way to do so right now, so simply remove this option.
Need to add it back later.

BUG=718330

Review-Url: https://codereview.chromium.org/2858333002
Cr-Commit-Position: refs/heads/master@{#469483}

A child surface ID is either a dependency (something the parents wants
to block its CompositorFrame on and may not exist in the display
compositor yet) or a reference (it is known to exist in the display
compositor).

Dependencies are held in CompositorFrameMetadata::embedded_surfaces, and
references are held in CompositorFrameMetadata::referenced_surfaces.

It was possible for a surface ID to end up in both places if the
primary and fallback SurfaceInfos in a SurfaceLayer matched. This
causes issues in an upcoming CL https://codereview.chromium.org/2831213004/
that "closes" an old fallback surface to receiving new CompositorFrames
if a new primary surface is being requested by a parent to reduce latency.

BUG=672962, 711948
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2861593002
Cr-Commit-Position: refs/heads/master@{#469482}

Now that renderer Compositor Frames go through SurfaceFactory,
we don't need to log DISPLAY_COMPOSITOR_RECEIVED_FRAME_COMPONENT
in RenderWidgetHostLatencyTracker.

BUG=NONE
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2863503002
Cr-Commit-Position: refs/heads/master@{#469481}

When a HoverHighlightView needs to be repopulated, other than removing
its children, the pointers it has to its children should be nulled out,
too. Otherwise, it would try to reuse them causing crashes. This CL adds
a Reset() function to HoverHighlightView that properly resets the state
of HoverHighlightView before re-populating it.

BUG=718411
TEST=none

Review-Url: https://codereview.chromium.org/2865533002
Cr-Commit-Position: refs/heads/master@{#469480}

Even if an image is smaller than the broken image icon it still needs to
render as a replaced element per https://html.spec.whatwg.org/multipage/rendering.html#images-3.
So do that, but ensure the broken image icon is hidden and don't render
it with a border or any other decoration.

BUG=715535

Review-Url: https://codereview.chromium.org/2853733004
Cr-Commit-Position: refs/heads/master@{#469479}

Change this to match ColorMediaFeatureEval's behavior.

Previously, this was incorrectly comparing the monochrome
feature against color bit depth.

BUG=645697

Review-Url: https://codereview.chromium.org/2863603002
Cr-Commit-Position: refs/heads/master@{#469478}

Launcher_ClickOnAppListButton is generated both on launcher start and closing. Replaced (in sequencer) with Launcher_Show (new) and Launcher_Dismiss (see prev CL) pair.

Bug=712331

Review-Url: https://codereview.chromium.org/2854283005
Cr-Commit-Position: refs/heads/master@{#469477}

SurfaceDependencies is a type alias that was introduced in PendingFrameObserver
but is not used consistently making understanding types more difficult. This
CL simplify removes the type alias.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2861713003
Cr-Commit-Position: refs/heads/master@{#469476}

The functions are practically identical and this can be better handled with
an if statement.

R=jfernandez@igalia.com

Review-Url: https://codereview.chromium.org/2829303002
Cr-Commit-Position: refs/heads/master@{#469475}

Reporting is a spec for delivering out-of-band reports from various
other parts of the browser. See http://wicg.github.io/reporting/ for
the spec, or https://goo.gl/pygX5I for details of the planned
implementation in Chromium.

This CL plumbs from Chromium's browsing data removal code to Reporting
(and also makes a few tweaks to Reporting's browsing data removal).

BUG=704259

Review-Url: https://codereview.chromium.org/2829683004
Cr-Commit-Position: refs/heads/master@{#469474}

BUG=

Review-Url: https://codereview.chromium.org/2863733002
Cr-Commit-Position: refs/heads/master@{#469473}

Added crashing layout tests.

BUG=717019
TBR=ethannicholas@chromium.org

Review-Url: https://codereview.chromium.org/2862913003
Cr-Commit-Position: refs/heads/master@{#469472}

Follow up of http://crrev.com/2853433002 that removes fake c++ adapters
that are no longer used.

Review-Url: https://codereview.chromium.org/2856093002
Cr-Commit-Position: refs/heads/master@{#469471}

This reverts commit f07732ec
(https://codereview.chromium.org/2791933004)
and reapplies b6d0c9a0
(https://codereview.chromium.org/2690183002/).

BUG=653916
TBR=jam@chromium.org, rkaplow@chromium.org
Previously reviewed at https://codereview.chromium.org/2690183002/

Review-Url: https://codereview.chromium.org/2856583002
Cr-Original-Commit-Position: refs/heads/master@{#468376}
Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d566487590518ec223
Review-Url: https://codereview.chromium.org/2856583002
Cr-Commit-Position: refs/heads/master@{#469470}