- 22 Jun, 2019 40 commits
-
-
Olivier Yiptong authored
This is the initial cl of the refactor of NativeFileSystemFileHandleImpl to mirror the split on the renderer side with the handle and the writer as two separate entities. It is the initial implementation for FileSystemFileWriterImpl. It includes only one no-op method for now: close(). This sets the stage for atomic writes as close() will be the explicit termination of a write, which allows us to do the atomic operation. Bug: 968550 Change-Id: I0af81efa46789f18c4a8b0bca3ab89c5703b798c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662709 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Auto-Submit: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#671539}
-
François Doray authored
Change-Id: Id8bfc831a72a7925dba2c417a6aea88c407daf7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1646779Reviewed-by:
Rick Byers <rbyers@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Auto-Submit: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#671538}
-
Michael Lippautz authored
- Adds support for large objects - Adds tests for strong and weak backing stores With these changes, the marking verifier is able to catch any object resurrections during pre-finalization as well. Bug: 976703 Change-Id: I75097a0a0d79e136992b07d8881e9136f1a9bd4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669932 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#671537}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I629c8739f49535699d0823bb9a654fc3f7cd8db3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672767Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671536}
-
Nico Weber authored
Now that we do PGO, linux already used lld in pgo builds, so this doesn't really change much on linux (lld is now used for building the instrumented compiler too, which isn't that big a change). No intended behavior change. Bug: 958852 Change-Id: Ia19d47fd5d3e366b513570041e3b3a16d05a8b93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636672Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#671535}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 1b42c60c. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ib54a0b58e672e0af13edc4bf7c344c2d16a8624b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672765Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671534}
-
alanlxl authored
Add a Chrome D-Bus service, export ShouldDeferScreenDim method for powerd to call Bug: 933199 Change-Id: I275f4eb5f406d6ecdd1fca3590a00c2a0618eb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598921Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#671533}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cc6fb9162f85..e96e29124ef0 Created with: gclient setdep -r src-internal@e96e29124ef0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: I9cf5b66ece159af51b480a768e309c2220a71e96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672259Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671532}
-
Rakina Zata Amni authored
Locked elements might be marked with NeedsReattachLayoutTree during style recalc on the element, leading to layout tree reattachment on the locked element's subtree - even though the style recalc for its subtree is blocked. With this CL, layout tree reattachment won't happen on a locked subtree and we will remember to mark it for reattachment later when it gets unlocked/needs update. Showed some small improvements in perf: https://pinpoint-dot-chromeperf.appspot.com/job/17848933ec0000 Bug: 966446 Change-Id: Ifcf93e89e948b39ebc3bc02f274800076893d517 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1668615Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#671531}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6bbeb4ab7222..31d587474367 git log 6bbeb4ab7222..31d587474367 --date=short --no-merges --format='%ad %ae %s' 2019-06-22 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@31d587474367 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: Id6defa4bee810e7c1daac1387235de0a9cea3e1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672184Reviewed-by:
-
Morten Stenshorne authored
Shuffle code around in LayoutDescendant(), so that we know the size before (final) layout. Block fragmentation requires that we know the block-start offset before layout, so that the fragmentation machinery knows where fragmentainers end. One exception is centered dialogs. Those cannot occur inside block fragmentation, so I left that piece of code after layout, rather than fixing it (would require some trivial amount of work, but it just doesn't seem worth it). Bug: 829028 Change-Id: I2491507327c5443aaec398682b5bca30d0d3d295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670881Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#671529}
-
Nate Chapin authored
Fuzzers might pass in a value that makes us CHECK Bug: 953402 Change-Id: I27fd7b6f65eb6b16b5ab612525afda11dd2c55fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670113 Auto-Submit: Nate Chapin <japhet@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#671528}
-
Chris Morin authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/d8ac0c37a3b2..ed5a30c1446a $ git log d8ac0c37a..ed5a30c14 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 cmtm system_api: ArcStopped dbus signal from upstart script 2019-06-14 dtor system_api: add explicit error code for license issues for Plugin VM Created with: roll-dep src/third_party/cros_system_api Bug: b:133248517 Change-Id: I59e21d64c366e2b009704fc5d2d9da414fe519c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672258 Auto-Submit: Chris Morin <cmtm@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#671527}
-
Peter Kasting authored
Bug: none TBR: sky Change-Id: Ic37d23ea66f53a107e1f968c096edd0b0414d314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670387 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#671526}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2d4afcc3cff3..cc6fb9162f85 Created with: gclient setdep -r src-internal@cc6fb9162f85 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: Ie001a0bb7b50bde9126a52a903bf4a2804547a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672574Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/385e9d4f27d3..14c7de5dcb80 git log 385e9d4f27d3..14c7de5dcb80 --date=short --no-merges --format='%ad %ae %s' 2019-06-22 evanhernandez@chromium.org run_tests: Dump logs via cros_logging, not print() 2019-06-22 mikenichols@chromium.org config_skew_unittest: Update ignored boards list Created with: gclient setdep -r src/third_party/chromite@14c7de5dcb80 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ia62d956abf40212c5b674be699a0df5dd70d8d88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672555Reviewed-by:
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia8555a701b0e251f206feeca980293548cb81e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672575Reviewed-by:
-
Yeol authored
FootnoteContainerView::FootnoteContainerView() should take an std::unique_ptr<View> to better convey ownership transfers. Bug: 973845 Change-Id: Iaea1c9f0b9b054a0133c36f461dbced03ef2aaa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670573Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Yeol Park <peary2@gmail.com> Cr-Commit-Position: refs/heads/master@{#671522}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/46e13cfb..f887b175 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If2429eb18f0251b8140a3c19e3ac69b5679d6c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672486Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#671521}
-
Kenneth Russell authored
The underlying Swarming hardware's been upgraded. Try running tests on the newer configuration, which also includes Mesa 19.0.2. Also change the short name on the waterfall to "exp" from "rel". Bug: 927465, 950552, 966500 Change-Id: I2b13595615f2919379f4a49ac1f928646e493d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666530 Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#671520}
-
Luum Habtemariam authored
- Changed interface from ipp_t* -> std::string - Removed virtual abstraction since there are no other implementations - Updated tests Bug: chromium:945409 Test: unittests pass Change-Id: Icd7094c1f3b8f07b0dac295186e0e839ce093478 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671928Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#671519}
-
Varun Khaneja authored
No functional change. R=nparker Bug: 963165,966646 Change-Id: I28b579ee3643592b8f9b440dbd7b4778917aff21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671865 Commit-Queue: Varun Khaneja <vakh@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Cr-Commit-Position: refs/heads/master@{#671518}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7afb8a45a389..796ade2e6451 git log 7afb8a45a389..796ade2e6451 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 fmayer@google.com Teach trace_to_profile to handle InternedData. Created with: gclient setdep -r src/third_party/perfetto@796ade2e6451 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I9228ae5b1de12ac12b866d04cab3ac65246a8681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672710Reviewed-by:
-
Shakti Sahu authored
Bug: 975506, 975683, 972774 Change-Id: I791a5503f3a37b329144709e96095f8a7b0569e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666775Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#671516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/13820f2a7ac9..2d4afcc3cff3 Created with: gclient setdep -r src-internal@2d4afcc3cff3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:132908766 TBR=tzik@google.com,dbeam@google.com,huanzhong@google.com Change-Id: I097ac2d0418e21b312d359f0e1afc063284efe7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672709Reviewed-by:
-
Tom Anderson authored
* Use 128x128 logo for the "background mode" status icon on Linux. * The 22x22 logo is now unused, so remove it. [1] removes internal icons. * Always use the highest resolution image representation that we're given, since all status icon implementations want to draw in pixel coordinates and we don't know in general how large the containing window will be. * Change StatusIconLinuxX11 drawing logic to handle icon resizing. [1] https://chrome-internal-review.googlesource.com/c/chrome/theme/google_chrome/+/1410578/ BUG=419673 R=thestig Change-Id: I2cad9414ba24022b9305d808c8b30228ae5d5c17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1671427Reviewed-by:Lei Zhang <thestig@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#671514}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/647f200016ab..dfd760055152 git log 647f200016ab..dfd760055152 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 jmadill@chromium.org Vulkan: Don't update pipeline when only textures change. 2019-06-21 timvp@google.com Increase demangled array size 2019-06-21 dongja@google.com GL/Vulkan: handle depth texture discrepancy Created with: gclient setdep -r src/third_party/angle@dfd760055152 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I959067ec494d2a6603a35f12ec46ec4a8e59cd01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672685Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b4580351c794..6bbeb4ab7222 git log b4580351c794..6bbeb4ab7222 --date=short --no-merges --format='%ad %ae %s' 2019-06-22 mtklein@google.com remove xbyak 2019-06-21 mtklein@google.com vmovq 2019-06-21 mtklein@google.com vpmovzxbd 2019-06-21 mtklein@google.com vmovups, both ways 2019-06-21 mtklein@google.com jne Created with: gclient setdep -r src/third_party/skia@6bbeb4ab7222 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bsalomon@google.com Change-Id: I3353d52729de684043bc89a1d2aebe47c8657d8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672691Reviewed-by:
-
Dana Fried authored
Includes both calls and documentation that can be simplified. Change-Id: Ibdfe9dfaeb640ca72213cf60897e36c017c92ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669882Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#671511}
-
David Bertoni authored
For extensions with service worker-based scripts, only allow a service worker to be registered at the root scope if it specifies the extension's script. Bug: 973582 Change-Id: I5c41bd83cfdcd996033a0ce762a348f10d370e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602440 Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#671510}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1c2b616bc420..385e9d4f27d3 git log 1c2b616bc420..385e9d4f27d3 --date=short --no-merges --format='%ad %ae %s' 2019-06-22 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@385e9d4f27d3 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Ie0c31cdb01d14bb759ce9bbf86cc2b3e756ec1f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672704Reviewed-by:
-
Rakib M. Hasan authored
Instead of setting class member functions to MagicMock classes and making sure that they are set back to their original values at the end of a test within a finally block, we can use a with block by using mock.patch.object to patch member functions of a class. Also updates the sanitization of the tags returned from GetPlatformTags. Since tags are case insensitive we can remove the lower function call. We can also replace the chain of replace calls with one re.sub call to change spaces and underscores to dashes. Bug: chromium:976505 Change-Id: Ic8b5da86ef711d5698916fef40da0ed439b8ce49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670024 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#671508}
-
Charlene Yan authored
Index can be out of bounds when attaching to a new tabstrip. Bug: 915956 Change-Id: Id921c4232f7e081b7d821f6722ff2ba7994ade76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670125 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#671507}
-
Findit authored
This reverts commit ad356ab2. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 671493 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FkMzU2YWIyZGExODA4YWFmMWQwOTA5MDMxYjg4YmY0Y2E5ODE2MjcM Sample Failed Build: https://ci.chromium.org/buildbot/chromium/android-archive-rel/1549 Sample Failed Step: compile Original change's description: > Mass refactoring: Change JNI #includes to use full paths (chrome/, ui/). > > Using relative paths was causing build failures. To create this change: > * find out/Debug -name *_jni.h -delete > * find . -name BUILD.gn -exec sed -i '/jni_package =/d' {} \; > * ninja $ALL_JNI_HEADERS minus third_party, chromecast, cronet, libassistant > * refactor_jni_includes.py --out-dir out/Debug > * fix DEPs files manually > * split out chrome/ and ui/ changes into this cl > > See https://groups.google.com/a/chromium.org/forum/?#!topic/java/MEovGrAwbqI > for discussion on naming scheme. > > Bug: 964169 > Change-Id: I1e3b455c0405d93d7f516796fa77b5d0679d9888 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669073 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#671493} Change-Id: I44a0fdfc7b2e2a68a31abc64efbfda35c632a52f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 964169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672487 Cr-Commit-Position: refs/heads/master@{#671506}
-
sczs authored
If the user interacts with the Banner mid presentation we should finish the presentation animation (meaning that completeTransition will be called) so the user can safely interact with the Banner. If completeTransition is not called and the user tries to dismiss the banner or present an InfobarModal, the banner will freeze until completeTransition gets called from the PropertyAnimator completion block. This CL's creates plumbing between the InfobarBanner and the TransitionDriver so the animation stops and finishes after an interaction with the Banner. Bug: 977017 Change-Id: I63b9593262cb15aca182af029a5a3fd19f8d2ff4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670393 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#671505}
-
dpapad authored
Previously these checks were customly implemented in PRESUBMIT.py Bug: 720034,425829 Change-Id: I04a11f680ace0a6b7d250f4116562ce3710eb27a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670274 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#671504}
-
Antoine Labour authored
Move from GraphicsResetStatus logic from decoders to GLContext and make it sticky. This is to ensure that once the GL context is lost once, we never try to use the context again, as some drivers wrongly claim they recovered from it. Bug: 946978 Change-Id: I1527fe6ac997ddb766c7c3fec30270c3ae84a5cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1669997 Commit-Queue: Antoine Labour <piman@chromium.org> Auto-Submit: Antoine Labour <piman@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#671503}
-
Gyuyoung Kim authored
Though Web IDL spec removed [PrimaryGlobal] and made [Exposed] required [1], many blink's IDL files have not followed it yet. So, this CL adds the keyword to the IDL files which don't have the keyword yet in the renderer/module/payments directory. Additionally, this CL updates the URLs of the specificiations. [1] https://github.com/heycam/webidl/issues/365 Bug: 963267 Change-Id: I6fdaba4bac93e7538756ccb8b931261035c2ad1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1670667Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0bed9125..46e13cfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I08715659e63ae79b3f660a2956bb4e16d735bc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672567Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/125f7cc4d52d..dd2737e2b572 git log 125f7cc4d52d..dd2737e2b572 --date=short --no-merges --format='%ad %ae %s' 2019-06-21 debrian@google.com Augment presubmit_support to output a json summary. Created with: gclient setdep -r src/third_party/depot_tools@dd2737e2b572 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:971895 TBR=agable@chromium.org Change-Id: I7eaf369f689f5adc8f6b6dee520f18a7e1ad3137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1672179Reviewed-by:
-
