- 11 Dec, 2018 40 commits
-
-
Stephen White authored
The plan is to move the actual test targets in Dawn to Dawn's src/test directory. This change makes Chrome temporarily point at some intermediate proxy targets, so we can move the real ones without breaking Chrome. Bug: dawn:61 Change-Id: I166c17f1689e2a2e71b1607af44f6f9a8c14b6af Reviewed-on: https://chromium-review.googlesource.com/c/1372709Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Stephen White <senorblanco@chromium.org> Cr-Commit-Position: refs/heads/master@{#615715}
-
Sergey Berezin authored
The main build always runs with a timeout of 7h. Make sure the individual shards always complete sooner, so any failed or timed out shards are correctly indicated on the build UI. Bug: 907852 Change-Id: I1580ee0a92f371536f1435e56596ee3d8aeb861b Reviewed-on: https://chromium-review.googlesource.com/c/1372533Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615714}
-
Miguel Casas-Sanchez authored
Use BindOnce to placate the presubmit warning. Bug: 714018 Change-Id: I5b268640b8b9ad48c3a3f0fc25a3f7b1dbd7adea Reviewed-on: https://chromium-review.googlesource.com/c/1371903Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#615713}
-
Kevin Strohbehn authored
This prevents ChromeVox from reading a hierarchy of inactive results. Bug: 910348 Change-Id: I393c7a347c63393890ed84b81647828ccc8f547d Reviewed-on: https://chromium-review.googlesource.com/c/1369127Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Kevin Strohbehn <ginko@google.com> Cr-Commit-Position: refs/heads/master@{#615712}
-
Max Moroz authored
Also switch libFuzzer UBSan buildbot (using us_ubsan_security config) to the component build. Otherwise, the build is failing with the errors of the following form: ./libblink_core.so: undefined symbol: _ZTIN5blink15LargeObjectPageE ./v8_context_snapshot_generator failed with exit code 127 ninja: build stopped: subcommand failed. $ c++filt _ZTIN5blink15LargeObjectPageE typeinfo for blink::LargeObjectPage R=bpastene@chromium.org, kbr@chromium.org Bug: 701825, 868612, 911856 Change-Id: I482ecf28d06cc95c2c9d43dd310311acd3249c5b Reviewed-on: https://chromium-review.googlesource.com/c/1372267 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615711}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/be607ad63609..611bbaabb28c git log be607ad63609..611bbaabb28c --date=short --no-merges --format='%ad %ae %s' 2018-12-11 syoussefi@chromium.org Vulkan: Convert vertex attributes in compute Created with: gclient setdep -r src/third_party/angle@611bbaabb28c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org Change-Id: Ic998f990b6e9e0f1478d46a396bf934ade155654 Reviewed-on: https://chromium-review.googlesource.com/c/1372654Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615710}
-
Matt Wolenetz authored
Updates one of the subtests to be less tightly bound to one implementation's scheduling of append error algorithm versus readyState transitions to HAVE_METADATA when one appendBuffer could potentially cause both. Change-Id: I50f98c2815014aacd67cb27bfc3d71ba50a16ab4 Reviewed-on: https://chromium-review.googlesource.com/c/1371166Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615709}
-
danakj authored
This code was copied over from WebViewImpl when adding the HidePopups call in order to have a pinch zoom or scroll tap outside the current popup in a non-main-frame-local-rooted iframe hide the current popup. This is modifying state on WebViewImpl meant to track between TapDown and Tap, to avoid the Tap showing a popup that was hidden by TapDown. WebFrameWidgetImpl does not show popups on Tap, and if it did, it should track this transient state locally not on WebViewImpl. Also remove the undocumented FALLTHROUGH which was not explained in 671732 as it now goes to nothing. R=dcheng@chromium.org Change-Id: I9d67539cf0afbb9db239b73bf83418e1a877e6db Bug: 912193, 671732 Reviewed-on: https://chromium-review.googlesource.com/c/1372539Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#615708}
-
Zhongyi Shi authored
No behavior change, just prepare the connectivity probing manager to probe for server preferred address. Bug: 913733 Change-Id: Ib4bb47c80cdc42edf8241bf63369b1e6e0e50c14 Reviewed-on: https://chromium-review.googlesource.com/c/1370952Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#615707}
-
Tobias Sargeant authored
Block in a java bridge call instead of directly in javascript, so that tests can control the blocking behaviour more directly. Bug: 907887 Change-Id: I9a293ed31d28c47b11ba26bb5b93b71da8e9e650 Reviewed-on: https://chromium-review.googlesource.com/c/1353993Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#615706}
-
Eugene But authored
Add WebStateTest.CallLoadURLWithParamsDuringSessionRestore test to verify that LoadURLWithParams call does not interupt the session restoration and that URL is eventually loaded when restoration is complete. Bug: 877671 Change-Id: I1a326fea25ca175436af348e487d15183f6385c1 Reviewed-on: https://chromium-review.googlesource.com/c/1368652Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#615705}
-
Wan-Teh Chang authored
https://aomedia.googlesource.com/aom.git/+log/67223a304e09..98dae942edd3 $ git log 67223a304..98dae942e --date=short --no-merges --format='%ad %ae %s' 2018-12-07 johann.koenig move av1_round_shift_array definition 2018-12-07 david.turner Refactor refresh_frame_flags/refresh_frame_mask 2018-12-07 david.turner Cleanup, remove side-effects from bitstream 2018-12-05 yunqingwang Optimize temporal filter applying 2018-12-05 david.turner Remove frame_refs: de-duplicate ref frame refs 2018-12-06 david.turner Remove redundant AV1_COMMON.frame_to_show 2018-12-06 frederic.barbier Cleanup dead func av1_get_tile_n_bits declaration 2018-12-06 aniket.dhok Optimize highbd inv_txfm modules 2018-12-03 yuec Make max and min partition more well-defined 2018-12-05 yunqingwang Refactor temporal filtering 2018-11-19 sanampudi.venkatarao Improve motion mode gating 2018-12-04 yunqingwang Use memmove to resolve memcpy-param-overlap 2018-12-04 david.turner Change buffer references from indices to pointers 2018-12-04 debargha Fix compile warning w/ -DCONFIG_COLLECT_RD_STATS=1 2018-12-04 aniket.dhok Optimize highbd inv_txfm modules 2018-11-20 wtc Clear dangling frame buffer indexes. 2018-11-15 david.turner Remove some side-effects from av1_pack_bitstream 2018-11-30 yaowu.google.com Use shorter int for temporal filter calculations 2018-11-30 chiyotsai Fix simple_motion_search with different bsize 2018-11-12 david.turner Remove unused variables from AV1_COMMON & AV1_COMP (...) Created with: roll-dep src/third_party/libaom/source/libaom R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@chromium.org Bug: 901206 Change-Id: I6d7500688e19d4856e0898759dd68fea1971041b Reviewed-on: https://chromium-review.googlesource.com/c/1372630Reviewed-by:
Johann Koenig <johannkoenig@google.com> Commit-Queue: Wan-Teh Chang <wtc@google.com> Cr-Commit-Position: refs/heads/master@{#615704}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/09163779000e..05e255178ba2 git log 09163779000e..05e255178ba2 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 tsepez@chromium.org Fix null deref in cxfa_itemlayoutprocessor.cpp 2018-12-11 tsepez@chromium.org Get Attribute names much more simply. 2018-12-11 thestig@chromium.org Reduce reallocation in string classes. 2018-12-11 tsepez@chromium.org Rename some structures in xfa_basic_data.cpp for consistency. Created with: gclient setdep -r src/third_party/pdfium@05e255178ba2 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:913569,chromium:912790 TBR=dsinclair@chromium.org Change-Id: I4b5ba856864194d464857f9a31b1bcc843b4e6a2 Reviewed-on: https://chromium-review.googlesource.com/c/1372653Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615703}
-
Avi Drissman authored
BUG=582001 Change-Id: Ia2abb1393718c8c0aa54a350ccc065077e362870 Reviewed-on: https://chromium-review.googlesource.com/c/1363797 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615702}
-
Xianzhu Wang authored
Remove DisplayItem::Replay(), DisplayItem::AppendToDisplayItemList() and PaintArtifact::AppendToDisplayItemList() which were for pre-SPv175. Change DrawsContent() from a virtual method to a getter. Change-Id: I6040faf6723bb7eba5acb0d729ac49c0f766710f Reviewed-on: https://chromium-review.googlesource.com/c/1372419Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#615701}
-
Scott Violet authored
SessionController may block windows (such as browser windows) from becoming active. When trasitioning from blocking to not-blocking we should ensure there is an active window. To do otherwise means there may be no active window, which is a state we try to ensure doesn't exist. BUG=914017 TEST=covered by tests Change-Id: I5d9392ea7706ea3603ecc6f68201f4931ebfe642 Reviewed-on: https://chromium-review.googlesource.com/c/1372408Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#615700}
-
Becky Zhou authored
TBR=twellington@chromium.org NOTRY=true Bug: 914068 Change-Id: I6e37d73acb34d9353ed704cf18d9998d0a056b0d Reviewed-on: https://chromium-review.googlesource.com/c/1372634Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615699}
-
Rakina Zata Amni authored
Use FrozenArray instead of StyleSheetList for adoptedStyleSheets. Draft spec: https://wicg.github.io/construct-stylesheets/index.html Bug: 807560 Change-Id: I683bf3ae2f5a1c44f9128b49e41662988c3f53d9 Reviewed-on: https://chromium-review.googlesource.com/c/1371687Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#615698}
-
Christopher Cameron authored
Leave the "print using system dialog" item (which appears when one presses option) disabled, because that interface appears in the Chrome process (instead of the app process). Bug: 913396 Change-Id: Ifd5715d68fbc532533834b869a1931ed3a48237d Reviewed-on: https://chromium-review.googlesource.com/c/1371941Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#615697}
-
Eugene But authored
NavigationItemChanged is called in 2 cases: 1.) title was changed for navigation item 2.) window.location.replace API was called Case #1 can be tracked with TitleWasSet and case #2 can be tarcked with DidFinishNavigation. IOSChromeLocalSessionEventRouter already overrides DidFinishNavigation, so this CL replaces NavigationItemChanged with TitleWasSet. Bug: 720786 Change-Id: I15f839467cc2541308823038eae86ec9a6a9a9e0 Reviewed-on: https://chromium-review.googlesource.com/c/1369053 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#615696}
-
Steven Valdez authored
Also fixes the ssl-version-max commandline flag. Change-Id: If7c22b7df0d8e37575481be9deb6e707650e3e37 Reviewed-on: https://chromium-review.googlesource.com/c/1330075Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: Steven Valdez <svaldez@chromium.org> Cr-Commit-Position: refs/heads/master@{#615695}
-
Tommy Martino authored
Bug: 914065 Change-Id: I9e030c1086428566692a6db7400f822018f653c0 Reviewed-on: https://chromium-review.googlesource.com/c/1372555 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#615694}
-
Pavel Feldman authored
Bug: 717195 Change-Id: I0360d0dea935d2da11179dd7380f36bf52b85ced Reviewed-on: https://chromium-review.googlesource.com/c/1370862 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#615693}
-
Stuart Langley authored
1/ Fix up the FileManagerRootType enums to reflexct the values sent. 2/ Add back the deprecated "ADD_NEW_SERVICES_MENU" so that the enums have a consistent value. Note that there will be a time period where the accounting is incorrect for roots > 15. 3/ Add expiry to all FileBrowser metrics, M79 which is the last release of 2019. 4/ Mark as obsolete FileBrowser.CloudImport.UserAction which does not appear to exist anymore. Bug: 849156 Change-Id: If7eea77f079cb6ca24ab9a744924899e2404df3b Reviewed-on: https://chromium-review.googlesource.com/c/1370156Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615692}
-
Stephen Martinis authored
This was removed in https://crrev.com/c/1361804. I missed this reference though. Bug: 718157 Change-Id: Idbddfec89d5c143c494df1f5572cb82f631baf62 Reviewed-on: https://chromium-review.googlesource.com/c/1371192Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#615691}
-
Dana Fried authored
Does not currently affect the test, but the minimum size reported by the toolbar is incorrect (see issue #842239). If the display is small and the minimum window width grows at all, the target point for the drag operation ends up still in the first (and focused) window, so the test fails. This change forces the endpoint of the drag onto the second window, and raises an error if it cannot do so. Bug: 898632 Change-Id: If4ee828e3309de247b1940a6b7f8ea98cffd5063 Reviewed-on: https://chromium-review.googlesource.com/c/1372711Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#615690}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/12659a46b9d9..5beabfe91862 git log 12659a46b9d9..5beabfe91862 --date=short --no-merges --format='%ad %ae %s' 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d2791c205bca..09056de49d52 (1 commits) 2018-12-11 michaelludwig@google.com Update 405 vk blacklist 2018-12-11 bsalomon@google.com Revert "Move some Gr headers from include/gpu to include/private and src/gpu." 2018-12-11 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader a233ceaecd85..d2791c205bca (1 commits) Created with: gclient setdep -r src/third_party/skia@5beabfe91862 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ethannicholas@chromium.org Change-Id: I1b5e3ddc0842924bfbc2da32384ebd504879d2a7 Reviewed-on: https://chromium-review.googlesource.com/c/1372469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615689}
-
Lakshmi Kumar Dabbiru authored
Had interacted is being logged just when prompt is shown. Introduced shown boolean to denote that and fixed logging for had_user_interacted. Bug: 848955 Change-Id: Ib3d17ab567b88c7ebda2dbe08cb3e46cf0807924 Reviewed-on: https://chromium-review.googlesource.com/c/1372281 Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#615688}
-
Giovanni Ortuño Urquidi authored
Four small changes: 1. Make a js_library that depends on the //services/device/public/mojom:mojom_externs_js_library. This unearthens a bunch of problems. 2. Add externs for nested enum in interfaces and in structs. 3. Refactor externs type generator to correctly generate externs for nested enums, structs, and unions. 4. Changed the generated externs to not generate "mojo.internal.AssociatedInterfaceProxy" and "mojo.internal.AssociatedInterfaceRequest" since they are not fully supported by the lite bindings yet. Change-Id: Ife282be5e2b5dde5fc17a345c138981812a617d8 Reviewed-on: https://chromium-review.googlesource.com/c/1369560 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#615687}
-
Darwin Huang authored
Bug: 896479 Change-Id: I95b4c57b2643883f2ea7f0ebbea4f50d7bc7111a Reviewed-on: https://chromium-review.googlesource.com/c/1371016Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#615686}
-
Tommy Steimel authored
This CL adds a Windows implementation of a global MediaKeysListener. This implementation uses a KeyboardHook to receive media key events. Bug: 902379 Change-Id: Ieb4003292e2a0622e500b83c1d8b298129e1f1fe Reviewed-on: https://chromium-review.googlesource.com/c/1362197Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#615685}
-
Wei Li authored
The distance calculation was broken due to pinned element and hovered element used different coordinates. r91bef92b also fixed this issue. This CL refactored the function name to make the coordinates used clearer, and also added unit test to prevent future breakage. BUG=899001 Change-Id: Ic1e2e577eb085a82f5ea32f608312335d6befd42 Reviewed-on: https://chromium-review.googlesource.com/c/1372551Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#615684}
-
Etienne Pierre-Doray authored
base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more explicit counterpart. It should have been replaced by : * base::ScopedAllowBaseSyncPrimitivesForTesting in test files. * base::ScopedAllowSyncPrimitives in non-test files * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads that don't allow blocking The last one is strongly frowned upon but this CL aims to document existing behavior rather than address it. Owners are encouraged to follow-up by fixing unnecessary waits and more particularly unnecessary waits outside-blocking-scope. Note: The non-for-testing versions require friend'ing in thread_restrictions.h but care was taken to add these friends ahead of git cl split (since it wasn't possible to do a line-by-line associated CL split). Refer to the top-level CL if necessary : https://chromium-review.googlesource.com/c/chromium/src/+/1288533 Please CQ if LGTY! This CL was uploaded by git cl split. R=thakis@chromium.org Bug: 766678 Change-Id: Ifef9e8ac9c9893f4e11e20dc8221578971904b6f Reviewed-on: https://chromium-review.googlesource.com/c/1325194 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#615683}
-
Jacob Dufault authored
Bug: 912234 Change-Id: I1f1e0a22c0866ecca1c988695b6651851120fe4d Reviewed-on: https://chromium-review.googlesource.com/c/1372528Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Jacob Dufault <jdufault@chromium.org> Cr-Commit-Position: refs/heads/master@{#615682}
-
David Grogan authored
This includes column containers, ortho children, and non-horizontal writing modes. This is a reland after the original[1] triggered an underlying crash issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1332247 Bug: 845235, 909021 Change-Id: I0d29126d5d4c2f203deecb03ee23480d46b447ef Reviewed-on: https://chromium-review.googlesource.com/c/1371196Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#615681}
-
James Darpinian authored
As requested in the review of https://crrev.com/c/1336753. After https://crbug.com/913996 is fixed we can remove outstanding_result_pointer_ entirely when DCHECKs are disabled. It also turns out that we can't use the string argument to ASSERT_DEATH to detect a CHECK message in a test because the message strings are stripped in official builds. Bug: 905890, 913421, 913996 Change-Id: Ia7df19057564ef7a4bbbab9ba36f583c6e6bca0f Reviewed-on: https://chromium-review.googlesource.com/c/1370484 Commit-Queue: James Darpinian <jdarpinian@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#615680}
-
Robert Ma authored
This file does not seem to exist any more and new builds should always have chromium_revision in their JSON results. Bug: 811976 Change-Id: If8c9a2d1d9a2e18f5171947990bf404aedc41b67 Reviewed-on: https://chromium-review.googlesource.com/c/1371072 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#615679}
-
Dan Sanders authored
The issue mentioned in this TODO was already completed in the associated bug. Bug: 869660 Change-Id: I57f35558770a0c56441a899371eff5d723d76a26 Reviewed-on: https://chromium-review.googlesource.com/c/1371076Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#615678}
-
David Tseng authored
This change is part of the effort to move AutomationManagerAura into ui/. This change in particular removes deps on content/ inside of AutomationManagerAura. Highlights: - removes usage of hard-coded desktop tree id in automation api (native and js bindings) - makes all known tree managers implement AXHostDelegate TBR=servolk@chromium.org Bug: 888152 Test: existing browser_tests (Automation Api tests, ChromeVox tests). Change-Id: I86a211d7588d280223c6dbacda0f0f1ad056a4fa Reviewed-on: https://chromium-review.googlesource.com/c/1361650 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#615677}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/11ba6a8ca5be..a039a0255e18 Created with: gclient setdep -r src-internal@a039a0255e18 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:914014 TBR=mmoss@chromium.org Change-Id: I6d593dd2e9f3c7fd2f8f3eda2e8d56e44d88ffaf Reviewed-on: https://chromium-review.googlesource.com/c/1372467Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#615676}
-