GitLab

The WindowTreeHost and ContextFactory implementations are specific to
the view manager and should be moved there. No one else should be
using these directly. I'm also nuking launcher as it was temporary and
the only other place that was using this code.

BUG=365012
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/315223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275453 0039d316-1c4b-4281-b951-d872f2087c98

--disable-touch-editing can be used to disable touch text selection.

Originally landed as r274972, but reverted due to blink layout test
failures. Layout tests are fixed in r175595 (blink).

BUG=304872

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274972

Review URL: https://codereview.chromium.org/305423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275452 0039d316-1c4b-4281-b951-d872f2087c98

R=rsesek@chromium.org, rockot@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/314133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275451 0039d316-1c4b-4281-b951-d872f2087c98

BUG=339558

Review URL: https://codereview.chromium.org/319733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275449 0039d316-1c4b-4281-b951-d872f2087c98

Unfortunately, TSan doesn't handle operator(), neither does the PRESUBMIT script.
We're going to deprecate v1 soon, so it doesn't worth fixing.

TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/320593002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275448 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [Android] Remove hardware menu button dragging support. (https://codereview.chromium.org/317083005/)

Reason for revert:
AppMenuHandler.hardwareMenuButtonUp is still used by clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572, hence this is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder to fail to compile with the following error:

../../../clank/java/apps/chrome/src/com/google/android/apps/chrome/Main.java:1572: cannot find symbol
symbol  : method hardwareMenuButtonUp()
location: class org.chromium.chrome.browser.appmenu.AppMenuHandler
                mAppMenuHandler.hardwareMenuButtonUp();

Original issue's description:
> [Android] Remove hardware menu button dragging support.
> 
> This code path was broken sometime within a year, and we don't think
> it's worth to support this more.
> 
> BUG=366154
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275395

TBR=aurimas@chromium.org,tedchoc@chromium.org,kkimlabs@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=366154

Review URL: https://codereview.chromium.org/317383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275447 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275441 0039d316-1c4b-4281-b951-d872f2087c98

We were adding an extra null into the string because FPDFLink_GetURL only gives the length without the null terminator.

BUG=pdfium:6
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/316233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275439 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275438 0039d316-1c4b-4281-b951-d872f2087c98

R=fischman@chromium.org

Review URL: https://codereview.chromium.org/311263013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275437 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add creation of v14 compatible resources to process_resources.py (https://codereview.chromium.org/321453002/)

Reason for revert:
This is causing instrumentation-yakju-clankium-tot and clang-clankium-tot-builder (downstream) to fail with the following error message:

FAILED: cd ../../clank/native/framework; python ../../../build/android/gyp/process_resources.py --android-sdk /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//platforms/android-19 --android-sdk-tools /b/build/slave/instrumentation-yakju-clankium-tot/build/src/third_party/android_tools/sdk//build-tools/19.0.0 --android-manifest ../../../clank/java/apps/deviceextras/AndroidManifest.xml --dependencies-res-dirs "" --extra-res-packages "" --extra-r-text-files "" --proguard-file ../../../out/Debug/device_extras_apk/proguard.txt --resource-dir ../../../clank/java/apps/deviceextras/res --res-v14-compatibility-dir ../../../out/Debug/device_extras_apk/res_v14_compatibility --crunch-output-dir ../../../out/Debug/device_extras_apk/res --R-dir ../../../out/Debug/device_extras_apk/gen --stamp ../../../out/Debug/device_extras_apk/codegen.stamp
Traceback (most recent call last):
  File "../../../build/android/gyp/process_resources.py", line 217, in <module>
    main()
  File "../../../build/android/gyp/process_resources.py", line 166, in main
    options.v14_verify_only)
  File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 335, in GenerateV14Resources
    ErrorIfStyleResourceExistsInDir(input_dir)
  File "/b/build/slave/instrumentation-yakju-clankium-tot/build/src/build/android/gyp/generate_v14_compatible_resources.py", line 107, in ErrorIfStyleResourceExistsInDir
    '-v17 directory. Please refer to '
Exception: error: style file /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values/styles.xml should be under /b/build/slave/instrumentation-yakju-clankium-tot/build/src/clank/java/apps/deviceextras/res/values-v17 directory. Please refer to http://crbug.com/243952 for the details.

I don't know resource loading well enough to tell if that's a legitimate issue or not; so for now reverting this to fix the build bots, and if it is a legitimate issue then ideally it could be fixed before relanding this?

Original issue's description:
> Add creation of v14 compatible resources to process_resources.py
> 
> There are a lot of steps in processing resources and preparing them for
> packaging. It will be easier if these are all done by the same script.
> 
> BUG=375431,359249
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275401

TBR=newt@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375431,359249

Review URL: https://codereview.chromium.org/314363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275436 0039d316-1c4b-4281-b951-d872f2087c98

This is a part of effort for enabling Drive in open file dialog
of incognito windows. It enabled protocol handler for drive: scheme
in incognito profiles.

BUG=359418

Review URL: https://codereview.chromium.org/310613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275435 0039d316-1c4b-4281-b951-d872f2087c98

Since ExtensionRegistry provide canonical way, use  ExtensionRegistry instead.

BUG=374353
TEST=unit_tests

Review URL: https://codereview.chromium.org/298023009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275434 0039d316-1c4b-4281-b951-d872f2087c98

This affects only official Chrome builds.

BUG=374279

Review URL: https://codereview.chromium.org/318993003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275433 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds a support of opening multiple files to Video Player. Previously, the player can open only a single file.

This patch does:
* Remove file-tasks filter which removes VideoPlayer on opening a single file.
* Add left/right arrows which can switches to prev/next video.
  - Arrows are hidden when opening a single file.
  - Left (or right) arrow are hidden when playing the first (or last) file.

BUG=355545
TEST=manual
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/313273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275432 0039d316-1c4b-4281-b951-d872f2087c98

Previously WorkspaceManager was used for this container which resulted in various
issues when login screen window was not full screen and was supposed to be resized
only by virtual keyboard container. Otherwise panels and shelf were taken into account
even though they are stacked below the lock container.

This CL improves previous fix
https://codereview.chromium.org/231123002

Disable this layout manager with --ash-disable-lock-layout-manager

Verified that existing out-of-box/login/multi-profiles login/lock* virtual keyboard
overscroll/non-overscroll configurations work fine.

Non-overscroll lock screen configuration is updated to use the same behavior as
login in https://codereview.chromium.org/320523003

BUG=375666
TEST=LockLayoutManager.*, existing tests

Review URL: https://codereview.chromium.org/254673004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275431 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/306233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275430 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275429 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jvanverth@google.com
NOTRY=True

Review URL: https://codereview.chromium.org/316213005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275428 0039d316-1c4b-4281-b951-d872f2087c98

BUG=378865
NOTRY=true

Review URL: https://codereview.chromium.org/319923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275427 0039d316-1c4b-4281-b951-d872f2087c98

Browser tests get time-out on debug build and close the tree frequently.
This CL disable slow tests which got time-out at least once in the last month on debug build.

BUG=327719

Review URL: https://codereview.chromium.org/311353004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275426 0039d316-1c4b-4281-b951-d872f2087c98

I noticed this because a Telemetry unittest was triggering the NOTREACHED
during session restore on Windows. I don't know much about this code, but the
fallthroughs certainly look unintentional.

BUG=

Review URL: https://codereview.chromium.org/317163006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275425 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381584,344704
TBR=bruening@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/319943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275424 0039d316-1c4b-4281-b951-d872f2087c98

Mojo interfaces are asynchronous. This CL adds generic callback
functions that will be used to define vase interface for return parameters to method calls.

R=viettrungluu@chromium.org,rmcilroy@chromium.org

Review URL: https://codereview.chromium.org/310783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275423 0039d316-1c4b-4281-b951-d872f2087c98

IMF now assumes the IME composing happens with a physical key being pressed.
That assumption is not true for on-screen keyboard scenario.
For on-screen keyboard, when user touch a key button on the screen, the JS
code will call IME API like chrome.input.ime.setComposition(). IMF then should
generate events as:
  keydown(229), compositionstart, compositionupdate, input, keyup.
The events compositionstart, compositionupdate and input are generated by
RenderWidgetHostViewAura::SetCompositionText(). So we need to send fake key
events to generate keydown(229) and keyup.

The other part of this change is to make InputMethodEventFilter not depend on
physical key events. Originally, InputMethodEventFilter relies on key events
to find the root window and then get the EventProcessor. It will break
on-screen scenario, because without a physical key being pressed,
target_dispatcher_ will be NULL.
This cl is to let InputMethodEventFilter to always get the EventProcessor from
input_method_->GetTextInputClient()->GetAttachedWindow()->GetRootWindow()...

BUG=376183
TEST=Verified on Pixel device.

Review URL: https://codereview.chromium.org/298893003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275422 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
1) Run clang-format through source and header files.
2) Fix data member variables to use unix_hacker_ style.
3) Rename file name to mock_web_audio_device.

BUG=331299
TEST=content_unittests, content_shell. No functional changes
TBR=dpranke@chromium.org

Review URL: https://codereview.chromium.org/317253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=369451

Review URL: https://codereview.chromium.org/311263005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275420 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
R=brettw@chromium.org

Review URL: https://codereview.chromium.org/307333003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275419 0039d316-1c4b-4281-b951-d872f2087c98

I'm about to commit a patch to improve of filelist draw. But it makes some tests flaky because the currently directory changes faster than before. This patch makes the logic of directory changing more robust.

BUG=367123
TEST=browser_test passes

Review URL: https://codereview.chromium.org/312493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275418 0039d316-1c4b-4281-b951-d872f2087c98

R=isherman@chromium.org
BUG=377705

Review URL: https://codereview.chromium.org/309063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275417 0039d316-1c4b-4281-b951-d872f2087c98

It times out.

TBR=dtu@chromium.org
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/321483005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=359418

Review URL: https://codereview.chromium.org/306023012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275415 0039d316-1c4b-4281-b951-d872f2087c98

This simple patch makes the selected icons look good on the dark blue selection
background. Also, it is less tricky.

TEST=Tested manually with multiple icons.
BUG=375020

Review URL: https://codereview.chromium.org/319553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275414 0039d316-1c4b-4281-b951-d872f2087c98

google_util is intended for componentization, whereas the information of what
the current brand is and whether a given brand is organic is inherently
embedder-specific. This functionality is moved to a new google_brand namespace.

BUG=373224
TBR=jochen

Review URL: https://codereview.chromium.org/316963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275413 0039d316-1c4b-4281-b951-d872f2087c98

That way we get some coverage for this target on Linux too.

It might not even need a master restart, since I think this is using
recipes?

BUG=348066
TEST=these linux bots in master.chromium.fyi
R=sky@chromium.org

Review URL: https://codereview.chromium.org/311263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275412 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381050
TEST=./unit_tests --gtest_filter="DriveBackendSyncTest.*" --gtest_repeat=-1 with ASAN build

Review URL: https://codereview.chromium.org/310253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=231125
TEST=git cl try

Review URL: https://codereview.chromium.org/318873003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275410 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/314113006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275409 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275408 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175595:175622&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/317323002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275407 0039d316-1c4b-4281-b951-d872f2087c98