- 28 Nov, 2018 40 commits
-
-
Zhiqiang Zhang authored
This reverts commit 7c453583. Reason for revert: This introduces some regression in some cases. The old logic works just fine so it is safe to revert. Original change's description: > [Android MR] Postpone route selection until session launch > > Previously, we unselect and re-select the route due to CAF limitation. > The reason is that we need to set the receiver app ID after the user > choose a device. However CAF won't be able to know a device was selected > after the receiver app ID gets changed. > > In this CL, to solve the issue, we intercept the click event in > MediaRouteChooserDialog (which would select the route automatically). > The route selection is postponed right before session launch. Therefore > we are able to set the receiver app ID and select the route to get rid > of CAF limitation. > > Bug: 711860 > Change-Id: I5b1534d36d540b62199a6fb739c56ad5131c2711 > Reviewed-on: https://chromium-review.googlesource.com/c/1351893 > Reviewed-by: Thomas Guilbert <tguilbert@chromium.org> > Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611437} TBR=zqzhang@chromium.org,tguilbert@chromium.org Change-Id: I30322daecf8c866fdda9e846d0cb37d9a319f033 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 711860 Reviewed-on: https://chromium-review.googlesource.com/c/1352973Reviewed-by:
Zhiqiang Zhang <zqzhang@chromium.org> Commit-Queue: Zhiqiang Zhang <zqzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611572}
-
Takuto Ikuta authored
Due to too many include, v8_context_snapshot_external_references.cc has long compile time. This CL removes header files for ConstructorCallback by introducing forward declaration. That reduces compile time of v8_context_snapshot_external_references.cc from 24.6s to 4.5s in Z840 Linux. Change-Id: I247e6a92dfdec15f19a38771eb64b4a85c447c25 Reviewed-on: https://chromium-review.googlesource.com/c/1352110Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#611571}
-
Fergal Daly authored
Adds tests for manipulating it via the attribute. Renames PartNames() to Part() to match with part(), the API wrapper. This uses the same IDL as classList. Bug: 805271 Change-Id: I9715df48478510029f5d985124e46111c41cffc3 Reviewed-on: https://chromium-review.googlesource.com/c/1333014 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#611570}
-
liberato@chromium.org authored
This adds the Distribution class, which will replace the TargetDistribution typedef in Model. It provides some convenient functionality, such as += and max-finding. None of the uses of TargetDistribution are updated here. Change-Id: I0e86d9dbaddcd5421cbc65e73213329603346733 Reviewed-on: https://chromium-review.googlesource.com/c/1329881 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#611569}
-
Takashi Toyoshima authored
|response.head.headers| can be empty in some cases, e.g. ftp accesses. We previously added a null check in GetHeaderString(), but OnReceiveResponse() itself accesses it without any null check. This patch adds a check to have a status code, and uses a fallback value if it does not exist. Bug: 908261 Change-Id: I15e0e61ce39c9e7846c26ab8875485b4597ce458 Reviewed-on: https://chromium-review.googlesource.com/c/1351348Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#611568}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f2a2ae33b38..8640c5d4e9f9 Created with: gclient setdep -r src-internal@8640c5d4e9f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860880,chromium:892303 TBR=mmoss@chromium.org Change-Id: I18acbcb34b9104a93e1bcf5149a1becea85dfaa4 Reviewed-on: https://chromium-review.googlesource.com/c/1351760Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611567}
-
DongJun Kim authored
https://google.github.io/styleguide/cppguide.html#Namespace_Names > Namespace names are all lower-case. This CL has no behavior changes. Bug: 889726 Change-Id: Icf64d8eaa44e8d4e2a321ae831379c483a765d14 Reviewed-on: https://chromium-review.googlesource.com/c/1352069Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#611566}
-
Nigel Tao authored
BUG=826982 Change-Id: Iede4849e94bbecc9340dcd3d612e419531185fa9 Reviewed-on: https://chromium-review.googlesource.com/c/1347955 Commit-Queue: Nigel Tao <nigeltao@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#611565}
-
Roger McFarlane authored
This CL integrates ARIA label and description parsing into the render/JS to browser communication path. This allows the browser to have knowledge of the ARIA label and description. Bug: 896719 Change-Id: If5e8d9389f10beecae102080ebcde066aae6c80a Reviewed-on: https://chromium-review.googlesource.com/c/1342673Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#611564}
-
Chih-Yu Huang authored
Move the common macros to macros.h. This CL is just code refactoring, not changing any code logic. BUG=b:119794200 TEST=Run VDA unittest on Bob and Eve Change-Id: I066a5e79c58e9c95c3db714534bf9f309f8314a5 Reviewed-on: https://chromium-review.googlesource.com/c/1345751Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611563}
-
Austin Eng authored
Add additional internal formats for CopyTexImage2D Unsuppresses previously failing test # for webgl2_conformance_expectations.py Bug: 905531 Change-Id: Ib9f525afa0188def6464c9f6134efc0090825f6b TBR: kbr@chromium.org Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_angle_rel_ng;luci.chromium.try:win_angle_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/1340369 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#611562}
-
Kent Tamura authored
A follow-up of crrev.com/611454. We had other instances of LAYOUT_TEST_PATH_PREFIX. TBR=qyesrsley@chromium.org Bug: 909012 No-Try: true Change-Id: Iec4c017f9123857f50e56ae3e8f5c6ae457af949 Reviewed-on: https://chromium-review.googlesource.com/c/1352087Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#611561}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/36900aad7d96..cde48580e93d git log 36900aad7d96..cde48580e93d --date=short --no-merges --format='%ad %ae %s' 2018-11-28 lamontjones@chromium.org Add missing unit tests. 2018-11-28 dgarrett@google.com Reland generic_stage.GetRepoRepository: Make arguments flexible. Created with: gclient setdep -r src/third_party/chromite@cde48580e93d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ib9820977399c623028a09c41feff07fe16fc06f3 Reviewed-on: https://chromium-review.googlesource.com/c/1352607Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611560}
-
Darren Shen authored
This reverts commit 01dd4ead. Reason for revert: Seems to have broken fushcia cast: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/fuchsia-arm64-cast/2910 Original change's description: > Make BrowserWithTestWindowTests work with single process Mash > > The InputDeviceClient needs to only be created once, so remove it > from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest, > it gets created twice: during test suite setup, and as part of > OzonePlatform (due to AshTestHelper/ash::Shell). > > Many tests still need one though, especially those that create a > WebContents, so add it to RenderViewHostTestEnabler, which should > take care of all RenderViewHostTestHarness tests or tests that create > the enabler manually. > > Also update a few other tests to either create their own > RenderViewHostTestEnabler or InputDeviceClient as appropriate. > > Also the InputDeviceManager can be a true singleton now (not thread- > singleton). > > Bug: 905430 > Change-Id: I2974968efe0415f0b56218e24b4fa546a1524fe1 > Reviewed-on: https://chromium-review.googlesource.com/c/1341075 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Evan Stade <estade@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611556} TBR=sky@chromium.org,estade@chromium.org Change-Id: Iadad5f76d31d82e8dc4cd427db184f536fdbef38 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905430 Reviewed-on: https://chromium-review.googlesource.com/c/1352125Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611559}
-
Wei Li authored
The test was disabled because ChromeOS will exit the test. But it is no longer the case on ChromeOS. Let's enable it. It is a bit weird to have this test inside tab_contents_iterator_unittest.cc since it has little to do with tab content. This CL moves the test to chrome/browser/lifetime/ since it tests whether AttemptRestart() sets the preference correctly. We also clean up the headers. BUG=none Change-Id: I663a0a7159b325b3783d816bec1d518ad7da7adb Reviewed-on: https://chromium-review.googlesource.com/c/1352573 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#611558}
-
Mike Dougherty authored
This CL removes macro usage from /ios/chrome/browser/autofill. This CL was uploaded by git cl split. R=mahmadi@chromium.org Bug: 589840 Change-Id: I84f6c6f53c27df62ebd04b6bcc88a0e27ba67833 Reviewed-on: https://chromium-review.googlesource.com/c/1351959Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611557}
-
Evan Stade authored
The InputDeviceClient needs to only be created once, so remove it from AuraTestSuiteSetup. Otherwise, in BrowserWithTestWindowTest, it gets created twice: during test suite setup, and as part of OzonePlatform (due to AshTestHelper/ash::Shell). Many tests still need one though, especially those that create a WebContents, so add it to RenderViewHostTestEnabler, which should take care of all RenderViewHostTestHarness tests or tests that create the enabler manually. Also update a few other tests to either create their own RenderViewHostTestEnabler or InputDeviceClient as appropriate. Also the InputDeviceManager can be a true singleton now (not thread- singleton). Bug: 905430 Change-Id: I2974968efe0415f0b56218e24b4fa546a1524fe1 Reviewed-on: https://chromium-review.googlesource.com/c/1341075Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611556}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I9b2114b02f1b7cd9e6ca24a3db88e0d6675d82be Reviewed-on: https://chromium-review.googlesource.com/c/1352949Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#611555}
-
Sunny Sachanandani authored
This causes video corruption when swap chain is resized to a small size and then resized back to a large size. If the swap chain doesn't update after resizing back, it will remain with the smaller size. It's also likely that this causes video corruption issues with minimize and restore, and with the Aero peek live preview Windows feature. Split out from crrev.com/1305198 because that change is more risky and we want to wait until M72 branches to land it. Bug: 908069 Change-Id: I8a3edde507bca836dbf321b8ebc4e486415d193b Reviewed-on: https://chromium-review.googlesource.com/c/1352771Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#611554}
-
Hiroki Nakagawa authored
This CL moves WebWorkerFetchContext creation from ThreadedMessagingProxy::StartGlobalScope() to Dedicatedworker::CreateGlobalScopeCreationParams() in order to put params construction in one place for code cleanup. Bug: 906991 Change-Id: I7a365bbc0706f271b61e9f56648f9b7a47506dd8 Reviewed-on: https://chromium-review.googlesource.com/c/1351199Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#611553}
-
Sunny Sachanandani authored
UMA data from experiment on Dev/Canary looks good. Keep the finch flag until M72 is branched to serve as a kill switch. Bug: 869677 Change-Id: I2bad591041f5b4c56d1e356069ac5b0364947d0d Reviewed-on: https://chromium-review.googlesource.com/c/1351281Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#611552}
-
Antonio Gomes authored
BUG=903873 Change-Id: I42f35c394e36350c0bd88c8131edc64b2e6d677f Reviewed-on: https://chromium-review.googlesource.com/c/1351159Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#611551}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0bd32409b7b7..cf714a81c86e git log 0bd32409b7b7..cf714a81c86e --date=short --no-merges --format='%ad %ae %s' 2018-11-28 jiawei.shao@intel.com Add checks on the texture view used as color or depth stencil attachment Created with: gclient setdep -r src/third_party/dawn@cf714a81c86e The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: If3904770001e8839dcf3b228c82f04145ec9fdcb Reviewed-on: https://chromium-review.googlesource.com/c/1351136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611550}
-
Brandon Wylie authored
Since the CachedImageFetcher uses a disk cache, there's potential for flickering. Particularly for low-end devices. This adds an in-memory caching layer that clients can use to prevent flickering problems for latency-sensitive features. Bug: 889234 Change-Id: I2da010aabeb7619b01f55f6305a8a0670d2831cf Reviewed-on: https://chromium-review.googlesource.com/c/1343042Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611549}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/3e2cdea95cd8..cb8a4ddc2277 git log 3e2cdea95cd8..cb8a4ddc2277 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 thestig@chromium.org Get rid of "exceptions" in CBC_QRCoderBitVector::At(). 2018-11-28 thestig@chromium.org Get rid of "exceptions" in CBC_SymbolInfo::Lookup(). 2018-11-28 thestig@chromium.org Get rid of "exceptions" from CBC_EncoderContext ctor. 2018-11-28 tsepez@chromium.org Try to make pdf_cfx_barcode_fuzzer result more consistent. 2018-11-28 tsepez@chromium.org Remove CBC_PDF417::m_compact and m_compaction. Created with: gclient setdep -r src/third_party/pdfium@cb8a4ddc2277 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie8e20561d1ea213a82d72b91f568c7ce286f29d1 Reviewed-on: https://chromium-review.googlesource.com/c/1352606Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611548}
-
Mike Dougherty authored
This CL moves the handling of Javascript console logs to an improved architecture, but is a no-op in terms of functionality. This will allow Javascript logs to be exposed in non-debug builds (instead of printing them to the device console as is done currently). Bug: 899851 Change-Id: I25eedc1f450df48acf66e4306f8846e0f761276f Reviewed-on: https://chromium-review.googlesource.com/c/1338946 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#611547}
-
Alexander Alekseev authored
Bug: 902564 Change-Id: Ia77cbc8986acc9c3767cb08dd2f50567b14ddf70 Reviewed-on: https://chromium-review.googlesource.com/c/1351464 Commit-Queue: Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611546}
-
Alan Cutter authored
The PageActionIconContainerView constructor takes 7 arguments. This CL replaces them with a single Params struct for readability at the call sites (in the absence of named function parameter passing in C++). This CL has no changes in behaviour. Bug: 788051 Change-Id: I423faf616c0f06236479c01579dd971c86251361 Reviewed-on: https://chromium-review.googlesource.com/c/1347640 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#611545}
-
Darren Shen authored
This reverts commit b5418f5c. Reason for revert: FindIt says it's 74% confident that it's breaking KioskTest.LaunchAppUserCancel on linux cros. https://findit-for-me.appspot.com/waterfall/failure?url=https://build.chromium.org/p/chromium.chromiumos/builders/linux-chromeos-rel/builds/16574 Original change's description: > Run ClearSigninProfile on user session start > > Also, ClearSigninProfile now closes any browser window opened in the > profile. Ideally, no browsers would be open in the sign-in profile, but > we've had cases where that had happened. > > BUG=906837,901768 > > Change-Id: Ia231d2ce3420c5c743bcd17f839ad00f4a851874 > Reviewed-on: https://chromium-review.googlesource.com/c/1347105 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611442} TBR=tbarzic@chromium.org,achuith@chromium.org,alemate@chromium.org,jdufault@chromium.org Change-Id: I3f497a9076e926be8d28110f051685edb27e8f7e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 906837, 901768 Reviewed-on: https://chromium-review.googlesource.com/c/1352121Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611544}
-
Vlad Tsyrklevich authored
SafeStack support has been abandoned. Bug: 908597 Change-Id: I800af0440054fb4de593a01af347b9b341cc55e5 Reviewed-on: https://chromium-review.googlesource.com/c/1351778 Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#611543}
-
Vlad Tsyrklevich authored
SafeStack support has been abandoned. Bug: 908597 Change-Id: If425e16a2bed5781d32a935e0dca06a4666fabc4 Reviewed-on: https://chromium-review.googlesource.com/c/1351751Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org> Cr-Commit-Position: refs/heads/master@{#611542}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/752d220a5f31..3b7c9d099b0d git log 752d220a5f31..3b7c9d099b0d --date=short --no-merges --format='%ad %ae %s' 2018-11-28 enga@chromium.org Change offsets in MultiDrawElements* entrypoints to match glMultiDrawElements 2018-11-28 jmadill@chromium.org Remove gl::Error. 2018-11-27 timvp@google.com Enhance ANGLE for Android Developer Options 2018-11-27 jmadill@chromium.org Slight refactor to ErrorStrings.h. Created with: gclient setdep -r src/third_party/angle@3b7c9d099b0d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890539 TBR=fjhenigman@chromium.org Change-Id: I9745811bd3b3fcd37a1aff9bb1462953f0ad174c Reviewed-on: https://chromium-review.googlesource.com/c/1352605Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611541}
-
Peter Qiu authored
PrefService requires home directory to be setup before the underlying pref store (JsonPrefStore) can be initialized properly. Now that the creation of PrefService is moved from CastBrowserMainParts::PreCreateThreads to CastMainDelegate::PostEarlyInitialization, we need to do the same for home directory creation as well. Bug: internal b/119800555 Test: Test locally on a cast build Change-Id: I513680c3b30dbd0c9cc862d87604376e502be763 Reviewed-on: https://chromium-review.googlesource.com/c/1352038Reviewed-by:
Sean Topping <seantopping@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Peter Qiu <zqiu@chromium.org> Cr-Commit-Position: refs/heads/master@{#611540}
-
Darren Shen authored
Test is failing. TBR=ossu@chromium.org Bug: 909095 Change-Id: Iefcbf963b5d366d1bdf4ed4b572cf665de941efd Reviewed-on: https://chromium-review.googlesource.com/c/1351862 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#611539}
-
Xida Chen authored
The forward declaration in in layer_tree_host_impl.h seems to be in alphabetic order where one of them isn't. This CL corrects the order, and also removes a forward-declaration for a struct which isn't needed. Bug: None Change-Id: I275a1af8392f20ec023a69107aa508b2a29b3d55 Reviewed-on: https://chromium-review.googlesource.com/c/1352515Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611538}
-
Hirokazu Honda authored
V4L2Device::VideoPixelFormatToV4L2PixFmt returns either single and multi plane v4l2 pix fmt, depending on VideoPixelFormat. This would rather return single or multi plane v4l2 pix format with given VideoPixelFormat and |single_planar|. V4L2VEA always uses multi plane formats. On the other hand, V4L2 IP depends on its caller's decision. So V4L2IP's caller specifies single or multi planes by the number of buffers on VideoFrameLayout. VideoFrameLayoutToV4L2PixFmt() is also added in this CL, which returns v4l2 pixel format from given VideoFrameLayout. This CL also adds IsMultiPlanarV4L2PixFmt(), which returns whether v4l2 pix fmt is multi planar or not. BUG=chromium:894381 TEST=VDA unittest with/without --test_import on hana TEST=VEA unittest with YV12 raw video data on hana Change-Id: I8cce3229e81fe041eb0bf8ea60f2735ef610e1b0 Reviewed-on: https://chromium-review.googlesource.com/c/1341428 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#611537}
-
rbpotter authored
The 3 linked bugs are all due to an issue with refocusing a list item from an element after the last control. In this case, the last control should be refocused, not the first control. This case can be identified by the first element in the focus event's path. This will be the list item itself if focus is coming from outside the control from an element that is before the list item in the tab order. It will be the last control if focus is coming from an element that is after the list item in the tab order. Bug: 908330, 908323, 908014 Change-Id: Ie2289547470e2f66cd9285d29e9ed1e0ab3207c1 Reviewed-on: https://chromium-review.googlesource.com/c/1351713 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611536}
-
Joshua Bell authored
Feature shipped in M69 Bug: 862455 Change-Id: Ie729a201fe30449123dcc22147301b152a5ff327 Reviewed-on: https://chromium-review.googlesource.com/c/1338721 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Cr-Commit-Position: refs/heads/master@{#611535}
-
Matthew Mourgos authored
Continuation dots no longer seen instead of complete folder name on hovering mouse pointer on Folder Name in App Launcher Constinuation dots are also no longer seen when editing folder name Bug: 870619 Change-Id: I58620f9011aacf264bf0b641c9b14e022add8b2f Reviewed-on: https://chromium-review.googlesource.com/c/1352582 Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Cr-Commit-Position: refs/heads/master@{#611534}
-
Tarun Bansal authored
Prefetch a URL only if it's score is more than the specified threshold. Additionally, only the highest ranking URL is now eligible for prefetching. Bug: 903945 Change-Id: I6c8166e8424da8c06f093998d606e1962184d20d TBR: ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1352034Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#611533}
-