- 29 Sep, 2020 40 commits
-
-
Asanka Herath authored
There are two methods of converting a value to a IdentifiableToken: either directly via the IdentifiableToken constructor or through IdentifiabilityDigestHelper. Differences between the two can result in different digests. This change removes the latter. Bug: 973801 Change-Id: Ic4fa466afe76abb6288fc024d34f32f05be32018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433029 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Caleb Raitto <caraitto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811586}
-
Lei Zhang authored
std::unique_ptr should not be used at the global scope. Switch to a raw pointer. Bug: 537099 Change-Id: I2d3b6ba65cf528003cfae21edb683405d62f9082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430726 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#811585}
-
Mike Wittman authored
Second in a series factoring the ThreadProfiler platform specific configuration state from the code that takes action on the state. Defines functions to handle runtime module state, which is necessary for Android profiling. The end goal is to reduce the configuration complexity, to support enabling per-thread on Android. Bug: 1129939 Change-Id: I4cb619ce15c94ec0b5d05d99de2b02eda6dab199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425184 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#811584}
-
Maggie Cai authored
This CL adds the support to share a Google Drive folder in Sharesheet. BUG=1097623, 1128829 Change-Id: I30dffaa3428cc82e0209ff52abfa97e757a273f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434118Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#811583}
-
Fergal Daly authored
R=tikuta@chromium.org Bug: 984869 Change-Id: I07a131c587e921a11ff1ac63a90831b794677a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437651 Commit-Queue: Fergal Daly <fergal@chromium.org> Auto-Submit: Fergal Daly <fergal@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#811582}
-
Tom Anderson authored
R=sky BUG=1066670 Change-Id: Ia9232be6f923aaea4c9860d6c0087dd91340ba5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432141 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811581}
-
Minoru Chikamune authored
GetCurrent() and SetCurrent() static functions are not used anymore because these functions are moved to MainThreadSchedulerImpl. So this CL removes these static functions. [related design doc] https://docs.google.com/document/d/1y-vHkrD1z2RtyWYwT6rJkSLHClYNjDDpUbTtBU7l95A Bug: 1105403 Change-Id: I3def70869cd97cf6b2f06642630c1c707d28ae3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437650Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
-
Matt Menke authored
In particular, remove the ability to make it use a raw data pointer. This isn't safe if Mojo is configured to copy data for same-process calls, and nothing is using it, anyways. Also remove the ability to mutate stored data directly. Also remove SetToFilePath(), which nothing is using. This does not remove SetToFilePathRange(), which is what it calls. We do want to remove that, too, eventually. Bug: None Change-Id: I0dcb291c5c2988d3e45a00d92201d0352fe03d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431431 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#811579}
-
Miyoung Shin authored
This CL is a part of moving mojom::FrameHost::UpdateState to blink, and moves page_state.mojom from content to blink and replaces {Web}HistoryScrollRestorationType with blink::mojom::ScrollRestorationType. Bug: 1110246 Change-Id: I3cf3db19aabb7bbd574dcaf6b5ebc2b2ce1ab23c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417678Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/306abde46d50..0d33d0e062db 2020-09-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I62160b2193033b82c133d77e874c554f127c7163 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437643Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811577}
-
Brandon Jones authored
This time with the Oculus code path fixed too! This value is not used by Blink, and does not need to be communicated over the mojo interface. The XRDeviceId enum should not be removed because it is used for usage stats. Bug: 1017477 Change-Id: I84115dafd37288afa2425aeebb863e9dee9d3093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435938Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#811576}
-
Alexander Alekseev authored
This CL adds latest graph values to the legend to make current system state easier to read. Screenshots: https://screenshot.googleplex.com/7GEoQ34yCo4LGuX.png https://screenshot.googleplex.com/A2jgLi6Nt8x6erc.png Bug: 1132183 Change-Id: I4d0ac763487fe3259da22cbe84e624ddd2ef9688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430090Reviewed-by:
-
Omid Tourzan authored
The other elements in the panel push icon to the right so it shrinks. Changing to min-width to fix it. Bug: 1133113 Change-Id: I9f2cfbbaf0bb111b3b80cd4a685effba08f720a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437652Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Omid Tourzan <oto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811574}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3d921f1b2c56..e96cdd18ac5f 2020-09-28 ethannicholas@google.com moved SkSL IntLiteral data into IRNode 2020-09-28 johnstiles@google.com Remove fKind field from BasicBlock::Node. 2020-09-28 herb@google.com air gap SkStrikeServer API from implementation 2020-09-28 ethannicholas@google.com moved SkSL DoStatement's data into IRNode 2020-09-28 jvanverth@google.com Add deprecation warning when running Metal on older OSes. 2020-09-28 bsalomon@google.com Work around python 2 shutil.copy2 date bug 2020-09-28 egdaniel@google.com Fix offscreen drawing when cleaning up vulkan viewer. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: I41d4b21227a026f7543f788b5951db4d051a31d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437096Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ifca12b4c615d89c595946ef6223d63b776373768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437638Reviewed-by:
-
Chunbo Hua authored
This reverts commit 3234b57f. Reason for revert: AUD stripping patch from WebRTC has been rolled to Chromium: https://webrtc.googlesource.com/src/+/9345dcfeea73f9dd68dc83dee60255e86dac3f97 and https://source.chromium.org/chromium/chromium/src/+/76165ce5bf99790f8dbae685259723e867458337. CBP for H264 support can come back in. Original change's description: > Remove constrained baseline profile support for H264 in M86. > > Bug: 982799 > Change-Id: Ibe20d74bfe6182b8464855106ca2d09f5dca087c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363462 > Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799783} TBR=dalecurtis@chromium.org,chunbo.hua@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 982799 Change-Id: Ib1c0212181d7efffe1cd4b82a0a1ddc9a603a0f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427573Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Chunbo Hua <chunbo.hua@intel.com> Cr-Commit-Position: refs/heads/master@{#811571}
-
Peter Kasting authored
Bug: 772945 Change-Id: Ie796f6598a821ba63596efecdb7683fbadbeac08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429259Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#811570}
-
Wei Lee authored
For historical reason, we put our js files, html files and resources under src/ directory of CCA directory. However, we reference the resource differently on platform app/SWA. On platform app, a resource foo.js is referenced as "chrome-extension://.../js/foo.js". While on SWA, it is references as: "chrome://.../src/js/foo.js". We should align the path between two versions of CCA and further replace the relative path by absolute paths in resource files. By doing so, we can further support launching CCA (SWA) when typing random CCA URL in Chrome. (e.g. chrome://camera-app/foo) NOPRESUBMIT=true Bug: 980846 Test: cca deploy [DUT] Test: cca test [DUT] Test: Both version (Platform app / SWA) works normally Test: tast run [DUT] camera.CCAUI* Change-Id: I845fe698ad92ee8da003b2ac3d12519509bdedd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434188 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811569}
-
Kevin McNee authored
static_cast is better suited for downcasting since it can check that the types are related. /chrome/browser/chromeos/login This CL was uploaded by git cl split. R=antrim@chromium.org Change-Id: I295668a0311ddb164cd898569faf9041ca0e431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435750 Auto-Submit: Kevin McNee <mcnee@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Commit-Queue: Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#811568}
-
Yutaka Hirano authored
https://github.com/WICG/web-transport/pull/135 Bug: 1011392 Change-Id: Ifd765d9986a3e3cb47358cd5c1c5572445a408d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435025Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#811567}
-
Caitlin Fischer authored
More specifically, check the feature's state after field trials have been created from the variations seed and before the variations header is updated. Checking the state for the first time in VariationsIdsProvider::GenerateBase64EncodedProto() could cause a deadlock. Bug: 1094303 Change-Id: I53fe3446e3a4567d4b9122b54642b5744eb8b46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431556 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811566}
-
Jon Mann authored
Recent changes to the apps framework caused a delay in loading app information during login. This requires that we wait for WebAppProvider::on_registry_ready() before querying the apps database for information on installed PWAs. This issue was resulting in the Messages feature getting disabled after the app was perceived to be uninstalled. Bug: 1131140 Change-Id: Ie2448fed1d04a9525b5dd5a452cb0b000a29ce0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429527 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#811565}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: If5c50c02fb0de2c641ff96d42a618af9b664b3bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437639Reviewed-by:
-
tby authored
This CL finalizes the error/status enum for ItemSuggestCache and adds histogram calls. Bug: 1034842 Change-Id: I952466a377d8e5e2a2dc30e9c8da6f181b80dba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434074Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#811563}
-
Gavin Williams authored
In destination dropdown replace printer-status-icon-cros element with new printer status icons. Screenshot: http://screen/8SUKwKANZWKfgpR Bug: 1123754 Change-Id: I5da99ab07512c50c10ab30d5b1ef9e945e910162 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433027 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
-
Dylan Cutler authored
identifiability study. This API leaks entropy about users' machines' underlying GL instrumentation. We are reporting digests to UKM for the study to determine the available entropy scripts can use to identify users across different origins. The instrumentation is only active if the study is enabled and collection of this type of surface is allowed. If it is, we construct a digest of the two enums to key the samples with (surface_token) and then a digest of the method's output (sample_token). Bug: 973801 Change-Id: I6cf2301578f85563852691ec9e7e286cc7fa85e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431782Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Dylan Cutler <dylancutler@google.com> Cr-Commit-Position: refs/heads/master@{#811561}
-
Jazz Xu authored
Bug: 1133026 Change-Id: Id4cc583e1eca14b083d2b22c9ee4b25e857d4175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437370Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#811560}
-
Josh Simmons authored
Removed and obsoleted NativeSmbFileShare.ReadDirectoryCount and NativeSmbFileShare.ReadDirectoryDuration, which are no longer used with the new smbfs implementation that is now enabled by default. Extended expiry date for NativeSmbFileShare.RemountResult UMA to M94. Bug: 1088968 Change-Id: I5272135376d22a3b1312de8e5e50f00c6e6b5181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418754 Commit-Queue: Josh Simmons <simmonsjosh@google.com> Reviewed-by:
Anand K Mistry <amistry@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811559}
-
Maggie Cai authored
This CL adds the API to create intent from file path. When the intent coming from a client with physical file path, it is easier for the client to directly pass the file path in. There is one issue where doing this will make the file manager involve in the intent handling even when the file is not directly shared from the file manager. Luciano will look into the file system context and see if there is a way to get the file system context without involving the file manager. There is another option that is possible is to add another field in the intent with file path, and the receiving end will have to resolve both fields to get the whole list of file. At the moment I will prefer to keep it simple for the receiving end. BUG=1092784 Change-Id: I02001085546d00434e0a47ef71e7a066b80f1d82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435125 Commit-Queue: Maggie Cai <mxcai@chromium.org> Reviewed-by:
-
Gavin Williams authored
Add 3 printer status specific icon SVGs to print-preview. In destination dialog replace printer-status-icon-cros element with new icons. Screenshot: http://screen/AaaU5KHz26fmFHS Bug: 1123754 Change-Id: I8d7a9a764e4f59843623227e57d9ef9bc743193d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432767Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I30f62024c838d2453eb2488b407476372e38b504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437809Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Ia5396badfb38aee0b077f3be0baf44fd0edd8a60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437636Reviewed-by:
-
Liquan (Max) Gu authored
Change: * Fixed the issue of not being able to launch payment handler twice. The cause is that when PaymentHandler UI is opened and closed, the payment handler's PaymentAppProvider was used, instead of the merchant's. * Changed PaymentAppProvider to make it one per merchant's WebContents, not one per payment handler's WebContents. * Rename WebContents PaymentHandler's codebase to make it better distinguish between the merchant's and the paymentHandler's. * Move PaymentAppProvider::SetOpenedWindow() from service_worker_client_utils into PaymentRequestImpl --> ServiceWorkerPaymentAppBridge. Bug: 1131874 Change-Id: I831fec0f3cce0d19abf49d23ccf1e61689afe33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434101Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#811554}
-
Aaron Leventhal authored
It is safe to access layout after a call to HandleLayoutComplete(), and it should be done as soon as possible. Exactly what leads to the fatal errors should still be investigated anyway, but this is a simple fix and we still a way to repro. Bug: 1131848,1125186 Change-Id: Ia529928fdee731f9fcf81d65a80edb49aadee9fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436418 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Auto-Submit: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#811553}
-
Ahmed Fakhry authored
This is part of the recording service work needed for capture mode. (See go/simple-recording-service). This CL defines the base APIs for audio encoders, and ports the PCM and Opus implementations from blink to //media. A follow-up CL should be to migrate blink's media recorder to use these new encoders. BUG=1131275, 1126586 TEST=Added tests at media_unittests --gtest_filter=*AudioEncodersTest* Also, Manually tested both encoders in my WIP recording service CL, and the output captured webm file contains recorded audio that plays back successfully. Change-Id: Iea132162d319a5b580e6b447e3d5658fbf731de6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426146 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by: -
Sergey Ulanov authored
InProcessVideoCaptureProvider uses VideoCaptureSystem on a separate device thread, but it was deleting it on the IO browser thread. Fixed InProcessVideoCaptureProvider to delete VideoCaptureSystem on the same thread on which it's being used. Bug: 1127447 Change-Id: Ibf867acea96a28dd992ae9d1139a5ec162d8ee8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427031 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#811551}
-
Daniel Libby authored
Instead of looping for the expected condition, use the LocalSurfaceId increasing as evidence that the expected visual properties update was delivered, and test for the expected values directly. If the test remains flaky, this will give a better indication of where things are breaking down. Also fix the math for the expected width of the second segment - for devices where there are an odd number of DIPs in width, the segments won't be equal. R=jonross@chromium.org Bug: 1089994 Change-Id: I1a81dc73055a4fca8ffc4b577b1b25046dcf23d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433306 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#811550}
-
Noel Gordon authored
ColorSpace is an internal detail of the image loader and should not be visible to clients: remove it from ImageLoaderRequest. The internal use is in ImageRequestTask: add a colorSpace_ member, and document that it used for RAW images (PIEX) only. After CL:2432150, it was decided that we just use the raw string PIEX color space value, so extend that idea and use the raw string in ImageLoaderUtil too (allows us to remove ColorSpace). No change in behavior. Spelling correction: ganna => gamma. Checked the veracity of the color space transform adobeRgb to sRgb and it is correct. This code appeared before the <canvas> element had color management. The <canvas> element supports that feature today in Chrome: add a TODO. Bug: 1132695 Change-Id: I12cad9a0aea106ce4a6c6dcbc2a9137bf0224e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437530Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#811549}
-
Brian Sheedy authored
Stops hardcoding an appended '-public' onto the instance we use for the Diff step in the Gold code, instead calling a method to get which instance to use. This is because not all uses of Gold, e.g. ANGLE's, can use the public instance (because it doesn't exist). These cases can override the method to return the base/internal instance instead. Bug: skia:10778 Change-Id: I94de33cac9a7f6935ae1507461c75be0fbc01170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436649 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811548}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1099c11d5d12..ead81e2ba233 2020-09-29 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-09-28 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I66aecd41cf3037678ff07c05c12a67f260358c2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436901Reviewed-by:
-
