- 02 Jun, 2020 40 commits
-
-
Yi Gu authored
Previously CompositorTimeline was updated on Animation level which introduced a reverse dependency. This patch moves the update logic up to AnimationTimeline level to fix this issue. Bug: 921031 Change-Id: Iaaa92686003c741cad424eb9867a0993193c05c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225853Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774351}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/e246638c18ca..cd6894f0a29e 2020-06-02 taylori@google.com Fix slice interleaving bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: wenbinzhang@google.com Change-Id: I9fed1ca29c65c12d9b53906baf10c6a32fbf18c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227150Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774350}
-
Arthur Wang authored
This reverts commit 41dddd7d. Reason for revert: Break gclient runhooks for someone https://bugs.chromium.org/p/chromium/issues/detail?id=1090465 Original change's description: > Refractor manage_render_test_goldens.py and add manage_wpr_archives.py > > R=bsheedy@chromium.org,harringtond@chromium.org > > Bug: 1060399 > Change-Id: Ifb06c6a94a51a6b1a2815bf94fa8f5a53dec1db8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219525 > Reviewed-by: Haiyang Pan <hypan@google.com> > Reviewed-by: Robbie Iannucci <iannucci@chromium.org> > Reviewed-by: Dan H <harringtond@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Commit-Queue: Arthur Wang <wuwang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774253} TBR=iannucci@chromium.org,bsheedy@chromium.org,hypan@google.com,harringtond@chromium.org,wuwang@chromium.org Change-Id: I3597b11b7ae43b93747ae4ee2821c15d5072d50c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225632Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#774349}
-
Tom Anderson authored
This is a reland of 0af7d7aa Original change's description: > [XProto] Remove all remaining non-event usages of XRandR > > BUG=1066670 > R=msisov > CC=sky > > Change-Id: Iecd593c0c77878a80bf84e9e3c504fd90815db6c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220686 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Maksim Sisov <msisov@igalia.com> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773876} Bug: 1066670 R=msisov TBR=jamiewalch Change-Id: Id24ace289778fc9f6feb8de9ed2744a2630be766 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226785Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774348}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/c43545625d9c..724a60fb10c7 2020-06-02 rwkeane@google.com Code Coverage: Force CI Bot Waterfall Run If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ib3a2716014a42a0777041f90bafafc61c8867196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226967Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774347}
-
Roman Aleksandrov authored
Since the pin pad buttons are no more tabbable (see for more details: https://crbug.com/1043194) we can return focus to textfield on number insert. Bug: 1009417 Change-Id: I4b1ebeef0a8e32a5ff2ba9b39da3ee424b7bdb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208864Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#774346}
-
Findit authored
This reverts commit 00c7f91f. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 774325 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzAwYzdmOTFmMDk0NjIzOTlmZmY1ZTUyNjZlZWRkY2Q2ZTBjOTQwNWMM Sample Failed Build: https://ci.chromium.org/b/8878570367609188432 Sample Failed Step: compile Original change's description: > Re-land migrate md5sum tool to portable zlib utils > > Use the set of portable code from zlib that shouldn't have > extra dependencies (e.g. 'base'). > > Also allow building the tool for other targets (e.g. Linux, > OSX, etc) as that allows easier testing and profiling. > > Compilation is disabled for Windows, see crbug.com/1090428. > > Bug: 1076580, 1087999 > Change-Id: Ic036685029be99b06753ea18f9fc62ce7c1a6540 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225526 > Reviewed-by: Tao Bai <michaelbai@chromium.org> > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#774325} Change-Id: I90e7158af6e9484a63f523cc75f5bfc52288262b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1076580, 1087999 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227311 Cr-Commit-Position: refs/heads/master@{#774345}
-
Peter Kasting authored
ArcCustomTabView was the lone implementation of this abstract base. Merge the two classes and simplify the construction to happen directly, rather than through a factory method. Further simplify the class by making it not be a View override. ArcCustomTabView didn't do anything related to being a View other than call GetWidget(), which it can just as easily call on (what was) its child NativeViewHost. Now that view is made a direct child of the widget ContentsView, without the ArcCustomTabView in between. For now, lifetimes stay the same -- the NativeViewHost becomes set_owned_by_client() instead of |this| in order to preserve the property that the custom tab and its |host_| are deleted together, irrespective of the lifetime of the widget ContentsView. Bug: none Change-Id: I921189cf74b63cc34d3789332e1b53a627e83602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225493Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#774344}
-
Evan Stade authored
Bug: 1007826 Change-Id: Ibfbad4000f7144629fe01d856e2fcbda26228f26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107585 Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#774343}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f0122481..ce9a17d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If6c2cf309af57fcd8b6a2001eda8838af6926636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225545Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774342}
-
Ben Pastene authored
This is a reland of 3a8d37c3 Reland fix: - Only adds the needed test data if `cros_sdk_version != ""` That will prevent ebuild invocations from trying to add non-existant items to data (since the ebuild doesn't use the cros chrome-sdk cache). Original change's description: > chromeos: Add only the current SDK version's items to a test's data. > > Instead of adding every version of a given item, this will add only the > current version's. This is a bit tricky since individual versions of an > item are keyed by symlink. And since isolate doesn't follow symlinks, > we have to follow them ourselves. > > Bug: 1027382 > Change-Id: I6b3ea4ec15de3804e99fd6af768daac64f490d5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931155 > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771959} Bug: 1027382 Change-Id: I2ff8c8452f5f6f43e178d547e963b6f8b7d17166 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218581Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#774341}
-
Lei Zhang authored
Use a well defined way to do this. Change-Id: Ifb70fdc002251d00b8db73e8f8a6130c7a126357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227113Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#774340}
-
Mustafa Emre Acer authored
Users may sometimes press non character keys such as ESC when on a webpage (e.g. to close popups or other prompts). This CL ignores these cases and does not undelay the warning. Bug: 1057157 Change-Id: Id20dc58b279e3e85935e4619dce3f958e512f3b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225361 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#773833} Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225525 Cr-Commit-Position: refs/heads/master@{#774339}
-
Lily Chen authored
This adds comments to better explain use cases for adding the special exceptions to SameSite cookie rules for chrome:// scheme pages that were added in https://crrev.com/c/1904544. Bug: 1007320 Change-Id: Iba4f6c20d2a4bbca6297be813ebdc9aa0437dcef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227058 Commit-Queue: Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Auto-Submit: Lily Chen <chlily@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#774338}
-
Scott Violet authored
It does nothing, and AFAICT hasn't done anything for more than two years. It's also the case that we already rerun failing tests. I would also argue that having an annotation for this is a bit of anti-pattern. BUG=797002 TEST=none Change-Id: I37349d54a4c9d86fd54e5c97cfd244e7ad52a4cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226780Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774337}
-
Kevin Marshall authored
Tests which play back video can flake when run in parallel due to a problematic DCHECK in VideoCadenceEstimator (see bug). Bug: 1090159,1090489 Change-Id: Ie4e93ba562108503a98992011632355e4ddfc7ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226923Reviewed-by:
David Dorwin <ddorwin@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774336}
-
Stephen Chenney authored
We don't support CSS mask on html elements. The image-orientation tests have some problems that need fixing. TBR: fs@opera.com Bug: 1071173, 432153, 1071929, 1076121 Change-Id: I3ff1e9c93845b3c6e5d56a0a1c7f943830b04dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225623Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#774335}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iea9020d6d7a75ae1f36987100f06accb1cc89f97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225284Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774334}
-
Lukasz Anforowicz authored
If content::ContextMenuParams includes a non-empty |frame_url|, then the context menu (the menu shown after right clicking in a frame) includes frame-specific commands like "View frame source" and/or "Reload frame". Before r749036 / 82.0.4084.0, context menu shown for the main frame would exclude such frame-specific items. This behavior has regressed in r749036, because it failed to preserve the following logic from //third_party/blink/renderer/core/page/context_menu_controller.cc: if (selected_frame != page_->MainFrame()) data.frame_url = WebURL(UrlFromFrame(selected_frame)); and instead started to unconditionally populate the |frame_url| field in RenderFrameHostImpl::OnContextMenu. This CL fixes the regression. Bug: 1085040 Change-Id: I149447654bee858037a4230828e2c4a7b3c7c0bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212995Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#774333}
-
Maggie Chen authored
Bug: 949839 Change-Id: I86f724255250bf7219c2c81bdc80dcc31f343d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226315Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#774332}
-
Jun Mukai authored
On some occasions, ui::Layer gets a transform which is identical to the original. Setting and handling transform causes some tasks, and that doesn't make much sense to do so when the transform doesn't change actually. It seems a few of unittests expect to get invoked, so this CL also changes those expectations. This wouldn't change the actual system behavior. Bug: 1082562 Test: compositor_unittests, aura_unittests, views_unittests Change-Id: Ia83b3b2ba87aa9825da6e2862aee3db9c665c72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225227 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#774331}
-
Jerome Jiang authored
https://aomedia.googlesource.com/aom.git/+log/c810066815b8..2aa13c436e4d $ git log c81006681..2aa13c436 --date=short --no-merges --format='%ad %ae %s' 2020-06-01 marpan rtc-svc: Set init_seq_coding_tools in svc_set_params 2020-06-01 marpan rtc-svc: Fix to framerate with set_svc_params 2020-05-14 vdziumenko Add NEON version of few subpixl|variance functions 2020-05-27 yunqingwang Extend prune_starting_mv to speed 3 2020-05-28 remya.prakasan Disable 'prune_ref_frame_for_gm_search' for mt 2020-05-19 marpan Update comment in scene detection 2020-05-14 vdziumenko Optimize NEON version of aom_sse function 2020-05-28 vdziumenko Fix av1_inv_txfm2d_add_NxM_neon for arm 32bit 2020-05-21 paulwilkins Change to active best Q calculation. 2020-05-21 chiyotsai Remove adaptive motion search speed feature (...) 2020-04-30 jzern aom/aom.h: rm AOM_SET_DBG_* controls 2020-04-29 chiyotsai Packs txfm_search parameters in MACROBLOCK to TxfmSearchParams 2020-05-01 elliottk Doc update for control codes 2020-04-29 marpan rtc: Refactor active_best_quality for 1 pass cbr 2020-04-25 wtc Remove the put_frame and put_slice callbacks 2020-04-26 wtc Minor cleanup related to external frame buffers 2020-04-26 elliottk Remove multi-resolution encoding from API 2020-04-25 wtc Move NELEMENTS macro to aom_dsp/aom_dsp_common.h 2020-04-20 wtc Replace for loops with range-based for loops 2020-04-28 yaowu.google.com Avoid the copy of non-existing u&v planes Created with: roll-dep src/third_party/libaom/source/libaom R=jzern@google.com Change-Id: Id0b26a6ad183ccf92f706a1efe86467b009ff69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225868Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Jerome Jiang <jianj@google.com> Cr-Commit-Position: refs/heads/master@{#774330}
-
Siyu An authored
Fixed: 1088618, 1088617, 1088616, 1088602 Change-Id: I05bd235d90ae7d4ed42345f701fa393f0e35889c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225395 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#774329}
-
Wei Li authored
Touch point view can be owned by views hierarchy if we manage to remove it from the view hierarchy when we need to delete it or to transfer ownership to someone else. Thus this CL removed using set_owned_by_client() for touch point view. BUG=1044687 Change-Id: I7790a8bc679faadd4288dc16024a05eed8038048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224007Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#774328}
-
Dominic Mazzoni authored
Bug: 1090432 Change-Id: I00eea4851b95669ffa5e6824d2eecf1366f65dbc Tbr: tapted@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226972Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#774327}
-
Dana Fried authored
Issue was caused by a previous fix for CrOS not taking hover card images into account. Now there is a uniform margin around preview images, as there was before. Also removed a redundant SetProperty call that was overridden later in the same function. Bug: 1087759 Change-Id: I5d1ab7081f9e1195961ead27cfc365bb6e25ede8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225239Reviewed-by:
Connie Wan <connily@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#774326}
-
Adenilson Cavalcanti authored
Use the set of portable code from zlib that shouldn't have extra dependencies (e.g. 'base'). Also allow building the tool for other targets (e.g. Linux, OSX, etc) as that allows easier testing and profiling. Compilation is disabled for Windows, see crbug.com/1090428. Bug: 1076580, 1087999 Change-Id: Ic036685029be99b06753ea18f9fc62ce7c1a6540 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225526Reviewed-by:
Tao Bai <michaelbai@chromium.org> Reviewed-by:
Adenilson Cavalcanti <cavalcantii@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> Cr-Commit-Position: refs/heads/master@{#774325}
-
David Black authored
Previously, Assistant notifications would always be removed when clicked or when clicking their buttons. Now, Assistant notifications may opt to *not* be removed when clicked or when clicking their buttons. This is used by Assistant timers v2, as Assistant timer notifications should no longer be removed on some click events moving forward. Bug: b:157930832 Change-Id: Ifb11186b89d7514258306d26bbd5f79e2c93f9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225580Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#774324}
-
Gang Wu authored
Bug: 1090156 Change-Id: I149875e07cbac11a0edb475cc58a006c7dea9c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226336Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#774323}
-
Stephen Chenney authored
TBR: fs@opera.com Bug: 1086473 Change-Id: I94a11a2eb805167d04019a17fed034447e608e4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227189Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#774322}
-
Roman Sorokin authored
Bug: 1067260 Change-Id: Icff47ce0aba635b73b8d589361f1689e2c64d2f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212274 Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#774321}
-
Vladimir Levin authored
This patch modifies one test to ensure that positioned elements are properly hidden, and adds a new one that ensures that positioned elements start painting properly when unhidden. R=chrishtr@chromium.org Fixed: 1090373 Change-Id: I7801f429de5c6752f681461b692a9f044fbf3ec0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227112 Commit-Queue: vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#774320}
-
Mason Freed authored
This test is a V0 only test. This was suggested by a comment in [1]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2208386/3/third_party/blink/web_tests/fast/dom/shadow/disconnected-distribution-cycle.html#15 Bug: 937746 Change-Id: I9fdf4620f36d6f44d8451d7529d2d605f52453dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225824Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#774319}
-
Sorin Jianu authored
This code polls for the installer progress, collects it, and invokes the callback to have the progress injected in the installer stack, and propagate it to the UI. Bug: 1014594 Change-Id: I0d457e8680dcc065fac7b8c842e1db6340a52032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226299Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#774318}
-
Dale Curtis authored
Does the following: - Internalizes h264 and min resolution details. - Sets the minimum resolution to 64,64 for both decoders. - Only loops through the video device profiles once. - Switches away from an std::pair to a named struct. - Adds AV1 GUID values and uses them in DXVA decoder. - Stops D3D11VideoDecoder for enumerating unsupported profiles. - Stops using the DXVA2_Intel_ModeH264_E for enumeration. - Gives all resolution tests a square resolution; e.g., 4k x 4k. - Doesn't test or indicate support for a duplicate portrait resolution. R=liberato, tmathmeyer Bug: 1073252 Test: Updated unittests. Change-Id: I8013e89104c96fad845fdbaecdb1d4b239f9a380 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223261 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#774317}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/393b040fb4f0..e5cd744fe49e 2020-06-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: If955161c4418532f0c22559b75c421441e2e2d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774316}
-
Anthony Polito authored
the rest of the file uses 1 space after a period, fix a 2 space case. Change-Id: Ibbe2eb2e32699125e6b072cd9643875e39c17f36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227111Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Anthony Polito <apolito@google.com> Cr-Commit-Position: refs/heads/master@{#774315}
-
Gil Dekel authored
This CL fixes a bug in which we do not remove PrivacyScreenToastController as an observer of PrivacyScreenController during destruction. Bug: b:157775487, 1090385 Change-Id: I97f0740a2a97493750e2f751ae2eb390b743df2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225863Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#774314}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/47a3341e07d6..3fb9c1bbfb23 2020-06-02 enga@chromium.org Add warning for non-c-typedef-for-linkage 2020-06-02 enga@chromium.org Skip creating the VkImageView if the texture usage is only Copy If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1064305 Tbr: cwallez@google.com Change-Id: Ib8232e6adf2acf911b79104944eec45a6dd7b00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226966Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774313}
-
Patrick Brosset authored
The new grid overlay needs to be shown only on grid container elements. The legacy one would be displayed when hovering items too. We no longer want to do this. Here are before/after screenshots taken while hovering over an element that is both a grid item and grid container. In the Before shot, you can see the parent grid being highlighted too. Not in the After shot. Before: https://i.imgur.com/lKeakiu.jpg After: https://i.imgur.com/aCZB1cT.jpg Bug: 1047356 Change-Id: I2d12fa06d7b86d5b1c19a38560b466a00d96fb32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224985 Commit-Queue: Patrick Brosset <patrick.brosset@microsoft.com> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774312}
-