GitLab

"open-with-" link in Drive. Later CLs will use app_id field to look up
an associated app.

Also adjusted unit test so that it would assert less and expect more.
I expect more from my unit tests. :-)

Original review: http://codereview.chromium.org/10546034/

TBR=zelidrag@chromium.org
BUG=chromium:126895
TEST=Ran updated unit test.  Ran clang trybot.

Review URL: https://chromiumcodereview.appspot.com/10546128

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141696 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10546068

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Old tests set up to be runnable.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141690

Review URL: https://chromiumcodereview.appspot.com/10544105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141694 0039d316-1c4b-4281-b951-d872f2087c98

This doesn't allow you to check for updates or show progress, it just notifies you if a new version is ready. As such, I didn't see a reason to limit it to Google Chrome builds.

This also fixes a bug where a 'disabled' state permanently hides the status text.

BUG=117403
TEST=manual with --check-for-update-interval=1 and manually editing the version


Review URL: https://chromiumcodereview.appspot.com/10541013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141693 0039d316-1c4b-4281-b951-d872f2087c98

here's the build log:
http://build.chromium.org/p/chromium.chromiumos/buildstatus?builder=Linux%20ChromiumOS%20Tests%20%282%29&number=3405

BUG=None
TEST=Old tests set up to be runnable.

Review URL: https://chromiumcodereview.appspot.com/10544105

TBR=jennb@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10544113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141692 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10533095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Old tests set up to be runnable.

Review URL: https://chromiumcodereview.appspot.com/10544105

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141690 0039d316-1c4b-4281-b951-d872f2087c98

CID_COUNT=4
CID=104190,104193,104197,104204
BUG=none
TEST=none
R=groby
TBR=rdsmith,vrk,tommi

Review URL: https://chromiumcodereview.appspot.com/10538083

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141688 0039d316-1c4b-4281-b951-d872f2087c98

http://www.sqlite.org/src/info/f9c4a7c8f4

Upstream commits in branch-3.7.6:
http://www.sqlite.org/src/info/a61786e760 (third hunk)
http://www.sqlite.org/src/info/e6a04bf9f1 (correction)

I have left out the comment addition seen in the trunk commit, because the backport to the 3.7.6 branch doesn't include it.

[Patch from Evangelos Foutras <evangelos@foutrelis.com> ]

BUG=122525
TEST=distros using gcc4.7 shouldn't crash.  see bug.
R=shess@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10387026
Patch from Evangelos Foutras <evangelos@foutrelis.com>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141687 0039d316-1c4b-4281-b951-d872f2087c98

Make Progress to output to stderr, it automatically flushes and it doesn't
interfere with the output, making testing easier and stdout more usable in
general, like if piping the results.

NOTRY=true
R=cmp@chromium.org
BUG=
TEST=new integration test


Review URL: https://chromiumcodereview.appspot.com/10533085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141686 0039d316-1c4b-4281-b951-d872f2087c98

in Drive.  Later CLs will use app_id field to look up an associated app.

Also adjusted unit test so that it would assert less and expect more.
I expect more from my unit tests. :-)

BUG=chromium:126895
TEST=Ran updated unit test.


Review URL: https://chromiumcodereview.appspot.com/10546034

TBR=gspencer@chromium.org
Review URL: https://chromiumcodereview.appspot.com/10539112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141685 0039d316-1c4b-4281-b951-d872f2087c98

When the user highlights all or part of a link, don't show "Go to <URL>" if that would navigate to the same place as the link itself, as this is redundant.

BUG=112768
TEST=Go to a bug with a link; highlight the link (or the link without "http://" and/or the trailing slash), right-click, verify there's no "go to" context menu item.
Review URL: https://chromiumcodereview.appspot.com/10536108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141684 0039d316-1c4b-4281-b951-d872f2087c98

We don't want the GPU process sandbox on by default on Chrome OS.
Since we control Chrome's command line, we can make sure it's enabled
for users, but disabled for developers.

Add an '--enable-chromeos-gpu-sandbox' flag, and remove the #ifdef that
disabled the sandbox on Chrome OS. Until we manually add the flag to
Chrome OS, the sandbox will continue to be disabled.

Moreover, even with the flag on, we only enable the sandbox on 64 bits and
for Intel GPUs.

BUG=127664
TEST=unit tests, and WebGL test websites on Lumpy.


Review URL: https://chromiumcodereview.appspot.com/10534049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141683 0039d316-1c4b-4281-b951-d872f2087c98

BUG=97804,112525
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10535113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141682 0039d316-1c4b-4281-b951-d872f2087c98

Currently, if a single file has multiple tests, a single failure will abort running the rest of the tests.

There's still no way to expect rather than assert, but I plan to add that next.

BUG=none
TEST=the tests all continue to pass, but if you edit one to make it fail, runAllTests will continue running later tests.

Review URL: https://chromiumcodereview.appspot.com/10534054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141681 0039d316-1c4b-4281-b951-d872f2087c98

in Drive.  Later CLs will use app_id field to look up an associated app.

Also adjusted unit test so that it would assert less and expect more.
I expect more from my unit tests. :-)

BUG=chromium:126895
TEST=Ran updated unit test.


Review URL: https://chromiumcodereview.appspot.com/10546034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141680 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows data to be appended to 2 different sources (1 audio and 1 video).  Also makes sure that appended data matches the mimetype provided in AddId().

BUG=122909
TEST=ChunkDemuxerTest.*


Review URL: https://chromiumcodereview.appspot.com/10545066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141679 0039d316-1c4b-4281-b951-d872f2087c98

RenderWidgetHost asked RWHV for a backing store in view coordinates,
but RWHV matched in pixel coordinates. As a result, backing store
allocation was considered unsuccessful repeatedly every frame, and every
frame would retry until the frame timeout (50ms) was elapsed.

If the browser process is very busy, the fps meter tends to show NaN
fps: It renders FPS in the renderer, and since the renderer was almost
always doing nothing (since it waited on the browser), almost all frame
times were filtered out (very short frame times are filtered out), and
often there were 0 frame times to sample from for FPS computation.

BUG=132178
TEST=Open poster circle with FPS meter enabled. 60fps instead of NaN.
TBR=avi

Review URL: https://chromiumcodereview.appspot.com/10533098

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141675 0039d316-1c4b-4281-b951-d872f2087c98

Note that this isn't intended to be complete coverage; it's an attempt to preserve coverage from the old tests while making these "real" unit tests, i.e. with every class except for the main one being tested mocked.  Thorough unit tests are intended for the future after we're more completely done with refactoring.  

BUG=107264
BUG=105200
BUG=110886

Review URL: https://chromiumcodereview.appspot.com/10344024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141674 0039d316-1c4b-4281-b951-d872f2087c98

* Moves system tray ownership and creation to status area widget.
* Status area is laid out as a grid for support of additional trays.
* Shelf alignment property is moved to TrayBackgroundView

BUG=124914
TEST=Status area tests and functionality should be unaffected.
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10535112

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141671 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=132272
NOTRY=true


Review URL: https://chromiumcodereview.appspot.com/10536119

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141670 0039d316-1c4b-4281-b951-d872f2087c98

BUG=119832
TEST=manually
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10539111

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141668 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10534113

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141667 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of all uses of NetLogEventParameters in net/base,
with the exception of net_log itself, of course.

R=eroman@chromium.org
BUG=126243

Review URL: https://chromiumcodereview.appspot.com/10539094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141666 0039d316-1c4b-4281-b951-d872f2087c98

The original code review: http://codereview.chromium.org/10479015/

TBR=csilv@chromium.org, brettw@chromium.org
BUG=112190
TEST=None

Review URL: https://chromiumcodereview.appspot.com/10541108

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141665 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131184,131200
TEST=Click on a bookmark folder button, it should not try / prompt to open all of the links in the folder.


Review URL: https://chromiumcodereview.appspot.com/10546104

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141664 0039d316-1c4b-4281-b951-d872f2087c98

IDR_OTR_ICON_FULLSCREEN when in touch layout and either fullscreen or
running in Metro.

BUG=131698


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141573

Review URL: https://chromiumcodereview.appspot.com/10538082

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141663 0039d316-1c4b-4281-b951-d872f2087c98

BUG=132230
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10545135

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141662 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127791,131852
TEST=Manually.


Review URL: https://chromiumcodereview.appspot.com/10539086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141661 0039d316-1c4b-4281-b951-d872f2087c98

TBR=oshima
BUG=131622
Review URL: https://chromiumcodereview.appspot.com/10542122

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141660 0039d316-1c4b-4281-b951-d872f2087c98

BUG=130828
R=oshima@chromium.org
TBR=sky@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10540091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141659 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141658 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141657 0039d316-1c4b-4281-b951-d872f2087c98

BUG=131878
TEST=Existing and new LauncherPlatformAppBrowserTest.*

Review URL: https://chromiumcodereview.appspot.com/10541109

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141656 0039d316-1c4b-4281-b951-d872f2087c98

BUG=126183
TBR=oshima
Review URL: https://chromiumcodereview.appspot.com/10537123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141655 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141654 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10538067

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141653 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
Review URL: https://chromiumcodereview.appspot.com/10546096

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141651 0039d316-1c4b-4281-b951-d872f2087c98

- CreateFileStreamWriter wiring in FSO
- Add yet another write-protection at IsolatedContext (in addition to ChildProcessSecurityPolicy, so that we can make each fs read-only or writable in DRT/testing)

BUG=none
TEST=existing tests should pass

Original review URL: https://chromiumcodereview.appspot.com/10540070

Review URL: https://chromiumcodereview.appspot.com/10532085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141650 0039d316-1c4b-4281-b951-d872f2087c98

Add extension ID to crash dump info when trying to clear content settings for an unregistered extension.


BUG=128652
TEST=none


Review URL: https://chromiumcodereview.appspot.com/10544094

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@141649 0039d316-1c4b-4281-b951-d872f2087c98