GitLab

This has the potential to leak user information during an isolated
prerender and isn't otherwise beneficial in the context of a prerender.

Bug: 1103392
Change-Id: Ic1806bcdf3476bc2c864f91028125d380b0b1be1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300805Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789562}

Change Log:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/23f1f9cf6d..f624790b7f
Full diff:
https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/23f1f9cf6d..f624790b7f

Bug: None
Change-Id: I877dfe42561531e71ae3bf7a69cd5566bfaad300
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303397Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Mirko Bonadei <mbonadei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789561}

Remove unused ash-chrome versions to avoid consuming too much disk
space.

Bug: 1104318
Change-Id: Ie5b74a271389dcb3b34fa1872f5d5b31b1d1af8d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303975
Commit-Queue: Yuke Liao <liaoyuke@chromium.org>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Reviewed-by: Sven Zheng <svenzheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789560}

This is a part of the work of removing
DisplayItemClient::VisualRect() which is an obstacle of integrating
FragmentData with LayoutNGBlockFragments.

Bug: 1104064
Change-Id: I47ef92d3a30fa178006e3c696b110de75cca7543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304658Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789559}

The CSSInterpolationEnvironment constructor that accepts a
CSSVariableResolver should only be used when the CSSCascade flag is
disabled.

Change-Id: I7a7b984c16dcc684e5d76d412a0e1565d7efb1c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302113
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789558}

Bug: 1106206
Change-Id: Id49eace861305bb57819a34824c06a7583f16518
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304769Reviewed-by: Ian Clelland <iclelland@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#789557}

The issue previously manifested with the MSVC linker, which
is no longer in use.

BUG=812421,584575

Change-Id: I92f5703408c64bf5fb2962507b26eab7f1ace013
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304137
Commit-Queue: Will Harris <wfh@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789556}

This CL adds user actions and histograms for Grouping tabs suggestion. In
addition, it modifies the metric names for Closing tabs suggestion to
yield cleaner code.

The new user actions and histograms are:
  * TabsSuggestions.Considered.Accepted.Grouping
  * TabsSuggestions.Considered.Dismissed.Grouping
  * TabsSuggestions.NotConsidered.Grouping
  * Tabs.Suggestions.NumSuggestionsChanged.Grouping

The modified user actions and histograms are:
  * TabsSuggestions.Close.Accepted renames to
    TabsSuggestions.Considered.Accepted.Closing

  * TabsSuggestions.Close.Dismissed renames to
    TabsSuggestions.Considered.Dismissed.Closing

  * TabsSuggestions.Close.SuggestionsReview.Accepted is removed.

  * TabsSuggestions.Close.SuggestionsReview.Dismissed renames to
    TabsSuggestions.NotConsidered.Closing

  * Tabs.Suggestions.Close.NumSuggestionsChanged renames to
    Tabs.Suggestions.NumSuggestionsChanged.Closing

Bug: 1076538
Change-Id: I9429c0d2923b52f2c708872d8f5fcf8cb41b1ca5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2295800
Commit-Queue: Mei Liang <meiliang@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789555}

This reverts commit ec645d52.

Reason for revert: crbug.com/1106867

Original change's description:
> [Clank SSM]: Enable stack sampling in android browsertests.
> 
> android_browsertests must depend on libunwindstack directly instead of
> through DFM, since loading of a partitioned library is not supported in
> an APK.
> (internal discussion)
> https://groups.google.com/a/google.com/g/clank-components/c/ktt285Gtax4/m/yRy8qm8LAQAJ
> 
> This CL also re-enables tracing use of StackSampingProfiler, which
> was accidentally disabled in https://crrev.com/784147?
> 
> Bug: 1004855
> Change-Id: I5967bf3815008843ba8a77e926977e39a4ccfbd8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293071
> Reviewed-by: Wez <wez@chromium.org>
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@google.com>
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#789530}

TBR=wez@chromium.org,wittman@chromium.org,dpranke@google.com,etiennep@chromium.org

Change-Id: I61309dcf5ceb5591dbf9f40e506ee25ee2ac475c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1004855
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304932Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789554}

See attached bug for specific cases addressed.

Needs testing on MacOS.

Bug: 1106506
Change-Id: I65cf6236d618b1cf8ada7b8b4ef07dbd7ed74e12
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303775Reviewed-by: Caroline Rising <corising@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789553}

In the previous CL, a code calling ExtensionToolbarButton::UpdateIcon()
from ExtensionToolbarContainer was removed.
(https://chromium-review.googlesource.com/c/chromium/src/+/2253600/29/chrome/browser/ui/views/extensions/extensions_toolbar_container.cc)

However, ExtensionToolbarButton should update icon color
when WebAppFrameToolbar overrides icon color for ExtensionToolbarButton.
(https://chromium.googlesource.com/chromium/src/+/master/chrome/browser/ui/views/web_apps/web_app_frame_toolbar_view.cc#471)
Otherwise, ExtensionToolbarButton ignores the overridden color.

When WebAppFrameToolbar overrides icon color, ExtensionToolbarContainer::UpdateAllIcon()
we be called. Thus, we should call ExtensionToolbarButton::UpdateIcon() in it.

Bug: 1106698, 1048901
Change-Id: I2082a16d18b312cd5a578f2c84b709e60cee6c5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303418Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789552}

Fixed the bug that when user changes the position of an app in folder,
the change won't update the syncable service so that the user will lose
their changes if they logout.

R=tbarzic@chromium.org

Bug: 1041633
Change-Id: I14be6e26f3fc7b4532aad2f4b17199d7bbaabce1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293470
Commit-Queue: Wen-Chien Wang <wcwang@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Jenny Zhang <jennyz@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789551}

Ideally, frame submission is expected to be at full rate of 60fps.
However, in many scenarios, this is not necessary. For example, when a
window is (partially) occluded by another window, or when a window is
behind a backdrop filter that blurs its content, or when a window is
going through an animation (e.g. going in or out of overview mode). In
such cases, we'd like to submit frames to a lower fps to improve
performance - this is where the frame throttling comes in.

This changelist only deals with browser windows, and when UI is going
into and out of overview mode. We'd like to throttle the BeginFrames
(ShouldSendBeginFrames), so that all the browser windows in overview
mode will update at a reasonable lower fps.

Here is the design doc if you'd like to inspect more.
https://docs.google.com/document/d/1kvCIuA_xsh1VAsFiC5i1paAtjkGm2z-hFhFXWYfL7Sg/edit?usp=sharing

Bug: 1095670
Change-Id: I8c9697fa5c0886032525395355d3c8ce76e439cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246716Reviewed-by: kylechar <kylechar@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Commit-Queue: Jun Liu <yjliu@chromium.org>
Auto-Submit: Jun Liu <yjliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789550}

If the user scheduled a download that starts right away, or the
network condition met right away. Download schedule struct should be
cleared, or the download will be shown in the "scheduled for later"
section, but it's actually completed.

Bug: 1106208,1078454
Change-Id: I70526221839d16c96a31b1409c28e5227cc9daa2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301379Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789549}

Screenshots (in Arabic UI)
Before: https://screenshot.googleplex.com/upvG78K5yqY.png
After: https://screenshot.googleplex.com/TDMh0T0XzbR.png

Bug: 1044038
Change-Id: Ibe5f960629cd506762ac14af44a7818f238215f0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303715
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789548}

Bug: 1106425, b/161142289
Change-Id: If3c89644289b6eb1d5b61f6680f03bf95e3b6888
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303172Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789547}

These continue to be important, especially with video support
being added to the PhotoPicker.

Bug: 1105074
Change-Id: If3bb8d759f7a18cf7fc2fba838927517b15f094b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299628
Commit-Queue: Finnur Thorarinsson <finnur@chromium.org>
Auto-Submit: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789546}

Bug: 1087263
Change-Id: I4f94508c5940858a63321812569d75c4064c29bf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302191Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Rainhard Findling <rainhard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789545}

Include build-tools 30.0.1 which is also needed by the R SDK.

The Android R SDK sources aren't available yet as R has not been
released to AOSP. Disable updating the sources package for now.

Bug: 1106471
Change-Id: I2ec942069f3ca95c694be0cbf3510700afcd1b19
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304533Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789544}

Bug: 819294
Change-Id: I79cb83515d197106c70345526a2a17177e8ca9e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303437Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: José Dapena Paz <jdapena@igalia.com>
Cr-Commit-Position: refs/heads/master@{#789543}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: Ia35e6f02796ec299fde4e4ae6384cb1bcd7e2090
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304153Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789542}

The download later dialog needs to be scrollable. In phone landscape
mode, not all the view is shown.

Bug: 1106363,1078454
Change-Id: Iae8d649b7259fee0a8800aa71e7a14cd759d49e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301039Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789541}

Used sed to replace 's/base::Bind(/base::BindOnce(/g' then fixed compile
errors that needed BindRepeating.

Bug: 1007660
Change-Id: Ib7acf35a67fdfea520f9ebbe1f18543801a30da7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290077Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789540}

Since third_party/libavif is only used by
third_party/blink/renderer/platform/image-decoders, it makes more sense
for third_party/libavif to be in the same component as
third_party/blink/renderer/platform/image-decoders.

Change-Id: I92c464f662065267311c412e18279e76086ac364
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302941Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#789539}

Just use the general pool at best-effort priority for logging command
line and field trials during startup, since it doesn't need to be on the
UI thread.

Change-Id: I73dfb14ae67bcc953fa7c90b5840354d5b4a84b3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302946Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789538}

Bug: 1105139
Change-Id: Idf56cc5a8fdc30490c750f22e3e6341100fa0370
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303462Reviewed-by: Travis Skare <skare@chromium.org>
Commit-Queue: Sophey Dong <sophey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789537}

The crosvm args for Plugin VM were changed in http://crrev.com/i/3119886
so it no longer matches the code here.

A sample list of arguments can be seen at go/paste/6706238773526528.

Bug: 1106680
Change-Id: I98d90f2679673868e42f2911637f84626af48f8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302878
Auto-Submit: Timothy Loh <timloh@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789536}

* Moves calls to UpdateAccessibleName() into UpdateMode().  The
  unconditional call in OnDownloadUpdated() is now effectively called
  earlier, and conditionally, but it only had an effect in a subset of
  the cases where UpdateMode() is called, and is unrelated to the things
  that change in the meantime*, so this is fine.
  *Except: The other existing call in GetInProgressAccessibleAlertText()
  was necessary to ensure this _was_ updated in time in that case, and
  now that it's done earlier, is no longer needed.
* Inlines the contents of UpdateAccessibleName() since it's now only
  called once.
* Adds a new helper, UpdateAccessibleAlertAndTimersForNormalMode(),
  which handles everything UpdateMode() was doing specifically for the
  kNormal case.  Refactors the existing switch significantly to reduce
  duplication.
* Removes a call to StopDownloadProgress() from the destructor which had
  no effect (since the timers were about to be deleted anyway).
* Inlines StartDownloadProgress() and StopDownloadProgress() into the
  new helper since they're now each only called once.
* Sets up parameters for various timers in the constructor so this
  helper can largely just Reset() them to start them.
* Inlines ProgressTimerFired() as a lambda into the progress timer
  constructor.
* Renames various timer-related members in hopes of greater clarity.

Bug: none
Change-Id: Ida6a1f9d607d95f190be3908d7639de8bd515990
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301209
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789535}

This change migrates callbacks related to the extension networking
private API to OnceCallback. There should be no functional change.

Bug: 1007786
Change-Id: Ibd606bcce6f1c5f4eb458b4270c542d1f6b9d5a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289408Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789534}

Adding an empty process that is built and installed along with GCPW.
gcpw_extension.exe process is meant to be a service process that is
installed by gcp_setup.exe.

In this change;

An empty process with basic initialization is created
Self extracting module script is modified to include gcpw_extension.exe
Adds another event category called "GCPW Extension Events"

Bug: 1101590
Change-Id: I39f0e73d266c5328b4c18d348003a9109a55fe78
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2278588Reviewed-by: Rakesh Soma <rakeshsoma@google.com>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yusuf Sengul <yusufsn@google.com>
Cr-Commit-Position: refs/heads/master@{#789533}

This change creates a new Polymer component network-diagnostics that
runs diagnostic routines and then displays the results.

Bug: chromium:1098405
Change-Id: I245b3378e477f4fae89d9b33201c7359cc9e8e56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261189
Commit-Queue: Trent Begin <tbegin@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789532}

Trigger teardownUI with legacy startup by updating the main scene state
instead of direct call in MainController.

Bug: 1045660
Change-Id: I6ca5e3d5c9dfd5b732da64f95eabdedff0571a15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231119
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789531}

android_browsertests must depend on libunwindstack directly instead of
through DFM, since loading of a partitioned library is not supported in
an APK.
(internal discussion)
https://groups.google.com/a/google.com/g/clank-components/c/ktt285Gtax4/m/yRy8qm8LAQAJ

This CL also re-enables tracing use of StackSampingProfiler, which
was accidentally disabled in https://crrev.com/784147?

Bug: 1004855
Change-Id: I5967bf3815008843ba8a77e926977e39a4ccfbd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293071Reviewed-by: Wez <wez@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789530}

AX-Relnotes: screen reader support for Use Suggested Password popup
Bug: 786147
Change-Id: Ic59b7c0d01da7c7258ada0761dfdbb4204bed962
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300184
Commit-Queue: Aaron Leventhal <aleventhal@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Nektarios Paisios <nektar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789529}

There are enough of them now that I think it makes sense to split them
out.

Bug: None
Change-Id: I503872e8877fc5f623e87550f5acab3b7d8a3650
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302490
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789528}

WebMessagePort::MessageReceiver::OnMessage() is documented as returning
false if passed a message that it cannot handle (e.g. because it is
malformed or unrecognised).  The default OnMessage() implementation was
instead returning true.

Also tidy up the comment for OnMessage() to document only the return-
false-on-failure path, since the converse (true-on-success) is implicit.

Change-Id: If5f72913465aff40360d3dcc9a88fb8c10fbe237
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300386
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Commit-Queue: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789527}

This is a reland of 6eb566d2

Reason for revert: Cause failure in CheckedLockImpl::Acquire
crbug.com/1099649
Mark worker_released_condition_ declare_only_used_while_idle
to prevent priority queue from being acquired in ScopedBlockingCall.

Original change's description:
> [Jobs API]: Use worker_lock in JobTaskSource.
>
> Possible race when Join():
> - thread A: Join: worker_released_condition_->Wait()
> - thread C: WillRunTask:
>               GetMaxConcurrency() returns > 0
> - thread B: already running, finishes all the work
>               GetMaxConcurrency() goes 0
> - thread B: DidProcessTask:
>               worker_released_condition_->Signal(),
> - thread A: Join returns (GetMaxConcurrency() is 0)
> - thread C: TryIncrementWorkerCountFromWorkerRelease
>               worker count goes 1
> - thread C: runs worker_task after Join
>
> To fix race when Joining, all writes to |state_| are protected by
> |worker_lock|. Memory ordering is no longer necessary.
>
> Alternative: cancel before Join returns with a compare and swap and
> loop again if new workers.
>
> Change-Id: I4e478ffae2bdaec56386739f78de089d0e74e42c
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248159
> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
> Reviewed-by: Gabriel Charette <gab@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#781453}

Change-Id: I1c7c0054a52b9b12dd6d0edd049ab2a7912df361
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272942
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789526}

This ensures that, during navigation commit, it doesn't matter whether
we are reusing a Document or not. Code that needs to catch and handle
that case can null-check LocalDOMWindow::document().

This requires adding a separate LocalDOMWindow::Initialize() step,
because LocalDOMWindow::InstallNewDocument() can no longer detect
whether this a window reuse case or not.

Bug: 1106273
Change-Id: I23021d505d6a2dc2f54f435359ce5490e4ed561e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302939
Auto-Submit: Nate Chapin <japhet@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789525}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: I5e7627dc3a2167304ac07257b7aacd1f82a4d215
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304654Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#789524}

gfx::Image is not ThreadSafe, so use gfx::ImageSkia instead when we
need to pass image between threads.

Bug:1100967

Change-Id: I7511f9b83e2a3e384c37fdb6b308bb00ab353948
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299460Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#789523}