- 14 Nov, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d3d14bef93aa..0958085d644d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I0e5258e99f438185ba0771b0d69a6f1035ca3b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538586Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827585}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/1a585d5f75ba..c82766bd799c 2020-11-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0b28234eaf8cb98ec262cad92860bf3a2920a0cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538585Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827584}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dd07f370. With Chromium commits locally applied on WPT: 31c0c978 "Do not parse @counter-style rules with invalid names" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I3e1545054fab554d344a24a20a5a6785cb0162c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538018Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827583}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605311889-6aa079e52bcacb107b5b307931590de3ab576ff9.profdata to chrome-linux-master-1605331818-354f114f606d230c1e738fe6417f2e0ad93b6521.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Idf5e61598c933eaa066360131190ed9bc91047ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538734Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/da1f66c8cee1..464aaeb55864 2020-11-14 enga@chromium.org Add InjectValidationError to command encoder 2020-11-14 enga@chromium.org Add end2end tests flags --enable-toggles and --disable-toggles If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC sarahmashay@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: sarahmashay@google.com Change-Id: I8cfcd3fe9cd9ac5e0150e0225a0557de45cd5615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538342Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605301167-f6c0732f2f3db66870746c695537723e836403a0.profdata to chrome-win64-master-1605311889-01c8544d12c27e9bf1aec153e89a1523ade38101.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I30b398c613a0e2764eacc8e56a41f3698f579d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538556Reviewed-by:
-
Per Kjellander authored
This reverts commit 748c6dcc. Reason for revert: Fix committed to open source webrtc and rolled in https://chromium.googlesource.com/chromium/src.git/+/0b1202a6c3f1a152d80cf4f9fe2798369cffa619 Original change's description: > Disable flaky */ConnectionTest.Video/* test. > > Bug: 1143311 > Change-Id: Ie8a50d33f65b2799e1a36f8aeacfed423acc96ce > NoTry: True > Tbr: perkj@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536118 > Reviewed-by: David Bertoni <dbertoni@chromium.org> > Commit-Queue: David Bertoni <dbertoni@chromium.org> > Auto-Submit: David Bertoni <dbertoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#827052} TBR=dbertoni@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1143311 Change-Id: I8f66c0e079afe81d5c9a075bc8c61306dc75f847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538754Reviewed-by:
Per Kjellander <perkj@chromium.org> Commit-Queue: Per Kjellander <perkj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827579}
-
Keishi Hattori authored
Use HeapVector for media_query_list_listeners_ instead of HeapListHashSet as a specular fix for a bug in HeapListHashSet. Bug: 1139511 Change-Id: I8c697b6079d186108aed95fa552a38fb3c56d502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536574Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#827578}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ed95a75961bf..99df1af2aed6 2020-11-14 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 482b6a1c..b7fa55af (827429:827532) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5b1d0b0cedaa35f59f034e58cd578e9122256b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538119Reviewed-by:
-
Wei Lee authored
This reverts commit 7e541959. Reason for revert: b/173092399 Original change's description: > [CCA] Retained pinned status after migrating to SWA > > This CL fixes a bug that the pinned status might be lost after migrating > CCA to SWA. > > Bug: 1144678 > Test: Manually > > Change-Id: I9bf2fd846645a77d8b7a47cbd7b9afc043950943 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2516659 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Ben Wells <benwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825255} TBR=benwells@chromium.org,alancutter@chromium.org,ortuno@chromium.org,wtlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144678 Change-Id: Ib55441a7ef81924a0256429ab5ccd1526cb754ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537739Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#827576}
-
Victor Costan authored
Before this CL, Chrome was built assuming SSE2 support on Windows, Linux, Chrome OS, and Android. This CL raises the assumption to SSE3 on all these platforms. This CL is a no-op for MSVC builds, which don't have a way to explicitly target SSE3. This CL does not impact Mac, where we only support 64-bit builds, which allows us to assume SSSE3 support. (The first 64-bit Intel Mac used the Core 2 microarchitecture.) This CL will not have a usage impact on Chrome OS, which already assumes SSE3 support, and on Android, where we require Lollipop+, which is only used in phones with SSSE3+ support. This CL will have a tiny impact on Windows and Linux usage. The impact has been quantified and deemed acceptable. Impacted users are receiving a notification starting in M87. Confusingly, "SSSE3" is not a typo of "SSE3". It is the next step up after SSE3, and before SSE4. This CL will cause Chrome to require SSE3. Targeting SSSE3 is future work. More details can be found in the design doc linked in the attached bug. Bug: 1123353 Change-Id: If93aa9d37e75f3068b06c42f7412c7c4578f3b9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311044Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#827575}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1605278951-6acf5f1c81bf8e5b853d44ef9575d8aab067a4b3.profdata to chrome-win32-master-1605301167-f2e539f21f91663031225bb0d3160662a773cdbd.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If5fee15a2ce7fd83cae86f22ac02aa0925de9f75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537973Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fb999eb4b31d..d3d14bef93aa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1040645 Tbr: Change-Id: Iff512fef9d1c86f65d09ab5f6c83a4cce19cb40c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538339Reviewed-by:
-
Xiaocheng Hu authored
The spec requires a @counter-style rule to be invalid if its name is among the disallowed values. This patch implements it. Bug: 687225 Change-Id: Ib4c06453c30301cbc64e18950c8686fe63e08220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533855 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#827572}
-
Guido Trotter authored
Previous instructions in 2530745 installed the whole espeak-ng tarball, and not just the chrome-extension/ directory, under /usr/share/chromeos-assets/speech_synthesis/espeak-ng . Moreover attempt to provide instructions which would work on standard linux / rodete to create the directory and set the permissions correctly. R=dmazzoni@chromium.org, dtseng@chromium.org Signed-off-by:
Guido Trotter <ultrotter@chromium.org> Change-Id: I41193bf02374f0bdde55371619ed4db72dae63e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536434Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#827571}
-
Bryan Clark authored
This is analogous to the hardcoded value in the mixer used by the real chromecast. Bug: b/173016177 Change-Id: Ia1d2e779fe1ae74ee7cf824cabb4b1e18adfdc7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538485Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Bryan Clark <bryanclark@google.com> Cr-Commit-Position: refs/heads/master@{#827570}
-
Wan-Teh Chang authored
The avifIO reader allows blink::AVIFImageDecoder to support incremental decoding partially. blink::AVIFImageDecoder still cannot output parts of a frame incrementally (such as row by row), but for a multi-frame image, it can output full frames incrementally. In addition, it can decode image metadata (such as image size and frame count) incrementally before IsAllDataReceived() becomes true. Implement the FrameIsReceivedAtIndex() method. Change DecodeFrameCount() to return increasing frame count as frames are received. This change requires including avif.h in avif_image_decoder.h. As a result, forward declarations of libavif types are removed from avif_image_decoder.h. TestInvalidStaticImage() needs to call IsSizeAvailable() explicitly because blink::ImageDecoder::SetData() with all_data_received=true no longer causes size to be decoded. Bug: 1136922 Bug: 1148577 Change-Id: I089f34711547f31030a1ea39d1f58f42106582e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530221 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#827569}
-
Julie Jeongeun Kim authored
This CL adds WebRequestResourceType::OBJECT to DCHECK() in WebRequestPermissions::HideRequest() since OBJECT type could take this path. Bug: 1145496 Change-Id: I77f620acbd18147de7faf90940523235feec62cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537509 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#827568}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d347b31c0e2e..1a585d5f75ba 2020-11-14 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia29dec2060b829715d7874f700d8133aa226bb3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538340Reviewed-by:
-
Alan Screen authored
The TestPrintBackend class has been a minimal implementation of a PrintBackend that could be used in a limited fashion for focused unit tests. It did not behave in a consistent fashion between the various interfaces; for example, setting a new default printer would not be reflected when getting PrinterBasicInfo. The out-of-process print driver feature is intending to use this class in a more general manner, for use of fake printer drivers in browser tests. This makes it desirable to make this class be better behaved. Introduce unit tests specifically for TestPrintBackend, to provide confidence for use by larger browser tests. Ensure that the same mapping of available printers is used across the PrintBackend APIs, so that calls to get printer info or capabilities would be guaranteed available for any printer identified by EnumeratePrinters(). Also ensure that the default printer is kept consistent when the environment is generated or later modified. Updated PrintBackend::PrinterBasicInfo class to have a fully-parameterized constructor and equality operator to assist with unit tests here as well as in the forthcoming tests for later OOPPD changes. Bug: 809738 Change-Id: Ia35e0c99bdb0eba8faa48dfc955d73a816e7d84d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2463559 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#827566}
-
Alexander Dunaev authored
A few views tests are X11-specific, and they were completely skipped for Ozone. Here the skip logic is modified so these tests are no longer skipped for the X11 platform when Ozone is enabled. A helper SkipTestIfNotLinuxX11() function is introduced for convenience. Also GetPlatformName() is renamed to GetPlatformNameForTest(). The method is useful for tests where it lets us skipping tests for certain platforms. Hence renaming it and withdrawing its 'temporary' status. Change-Id: Id53bd92c36eadac11370697706e41bf836dac623 Bug: 1109112, 1109696 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532458 Commit-Queue: Alexander Dunaev <adunaev@igalia.com> Reviewed-by:
-
Bartek Nowierski authored
PartitionDirectMap and AllocNewSlotSpan have been reporting things inconsistently. After this CL, the metrics will have the following (consistent) meaning: 1. total_size_of_super_pages - total virtual address space for normal bucket super pages 2. total_size_of_direct_mapped_pages - total virtual address space for direct map regions 3. total_size_of_committed_pages - total committed pages for slots (doesn't include metadata, bitmaps, or any data outside or regions described in #1 and #2) Change-Id: I1ac1b3044d15b33dcbd506f133d1fe7fa322277f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532542 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=bindusuvarna@chromium.org Change-Id: I14e0381d4b0a0f2d6e95029a28b5ffd117fe7d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538314Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#827563}
-
Lijin Shen authored
1. Set a max width of message if the width is greater than the max 2. Show/hide container on animation start/end, handled by single action message Bug: 1123947 Change-Id: I72d717bc2d5fe15005c5cbf9c662e08d6357d8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526628 Commit-Queue: Lijin Shen <lazzzis@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#827562}
-
Samuel Huang authored
With crrev.com/c/2535582 changing how android-binary-size-generator bot results on gs:// can be invalidated, the "version" field in size config JSON files are no longer needed, and can be remove. This CL needs to wait on the downstream change https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3402103 to land first, to allow template "android_size_bot_config" change. Bug: 1040645 Change-Id: I4a6af0fce816c4994777db09f48a336b60be47b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536853Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#827561}
-
Leo Zhang authored
This will fix an init crash when shared library passes the MainEntry to Chrome Utility process, which is a CFI violation. This requires corresponding changes from decoder side to take effect. TEST=local build Chrome with use_cfi BUG=b:172527471 Change-Id: I6d9584533491be3e1fc489bc592075a49e90c5e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537516 Commit-Queue: Leo Zhang <googleo@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Cr-Commit-Position: refs/heads/master@{#827560}
-
Emircan Uysaler authored
This CL addresses the crash that occurs when ScenicSurface is destructed before ScenicOverlayView. When that occurs raw pointer held by ScenicOverlayView is invalid, so we should check ScenicSurfaceFactory for a reference instead. Bug: 1148797 Change-Id: I7972a09227e72c212254044f8e6800d50cbe470f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536775 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#827559}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1605268075-daeeb1bc6080c8b4d9f48b3dab7bc22bf5a02dcb.profdata to chrome-win64-master-1605301167-f6c0732f2f3db66870746c695537723e836403a0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7ba9d4850c3f5bdbf48ff0ec829dc2bcf0a9fbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537123Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/01909e016604..fb999eb4b31d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1141619 Tbr: Change-Id: Ifeef8d0e32b7ec761c0de09f66a365da55a9d5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538553Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Iaf3557bdbe4a4e0fb1a8e68ad90b6b578a5e9d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538554Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f42a94a7f50d..ed95a75961bf 2020-11-13 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5cee6c65..482b6a1c (827322:827429) 2020-11-13 natim@webrtc.org VoipVolumeControl subAPI for VoIP API If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I50b59c4e50add84dcca5951e97d81debea3227f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538498Reviewed-by:
-
Liquan (Max) Gu authored
This CL splits CPRService#retry() into two parts. The common part goes into PRService, while the Chrome specific part is left in CPRService. Bug: 1131059 Change-Id: I9a90c53f109c7f5224129904f3af22f92bcadf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536854 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#827554}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 88b177ae. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: If0f1551a0c9bb8661fa85a9646dd448971b03d8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537587Reviewed-by:
-
Dave Tapuska authored
Move these testing APIs into the base implementation. BUG=1097816 Change-Id: I4e476c9d150cc204692bedf82d577c5e4909051c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536980 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#827552}
-
Ken Rockot authored
ContentBrowserClient::WillStartServiceManager exists exclusively to initialize some Audio Service policy state very early in browser lifetime. This was necessary at one point because the Service Manager was a prerequisite for various service bits to be configured, and Service Manager bringup happens very early in startup. Because the Service Manager is no longer used to host the Audio Service, the service is free to manage its own configuration independently. It can instead now query the sandboxing policy on-demand when launching the service process, eliminating any need for a ContentBrowserClient API. This also deletes the unused ShouldTerminateOnServiceQuit ContentBrowserClient API, as well as its supporting code within Service Manager. Bug: 977637 Change-Id: I3fa148cf4ceb9bb26f56e2b736d20a6cce2170dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538333 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
This patch implements the parsing of the descriptors of @counter-style following spec: https://drafts.csswg.org/css-counter-styles-3/#the-counter-style-rule WPT verifying the parsing is also added. Bug: 687225 Change-Id: Ifecdfbdfb9efcb330453d0059a0f1e73c0f3e662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530523Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
-
Alexander Cooper authored
This flag allows us to configure OpenXR features which, though shipped on Android/ARCore may not be ready to be shipped on Desktop/OpenXR, due to the slightly different permissions, or due to an inability for us to actually test on real hardware. Change-Id: I985f2e17119185053539f6c2671695c57081c24f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537584Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#827549}
-
zhiyuancai authored
Add an item "Track prices" to the tab switcher toolbar menu. This CL only handles adding this item, and does not add the response part when clicking this item. Bug: 1144742 Change-Id: I01baa8961158b39216e790b99113d6dab980c1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518830 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#827548}
-
Sam Fortiner authored
The max overlap for fixed feature (crrev.com/766618) had an assumption that the overlap testing rect, as computed by BoundingBoxForCompositingOverlapTest, is in viewport space and includes the area that a fixed-pos layer can occupy given any valid scroll offset. This expansion was limited to just the fixed-pos layer and did not include out-of-flow composited children of the fixed-pos layer. This decision to use viewport space for the expanded rect caused an unrecognized embedding of the scroll offset into the rect position at compositing inputs time when the expanded bounding rect was computed. The dependency on scroll offset could cause incorrect overlap test results when the scroll offset changed and overlap testing re-ran without a compositing inputs update. This was addressed by moving the fixed-pos layer's expanded bounds to absolute space in crrev.com/807955. However, this later revision also caused the children of a fixed-pos element to change from storing their unexpanded overlap test bounding rects in viewport space to storing them in absolute space without expanding their bounds or otherwise compensating for no compositing inputs update on scroll offset. This effectively introduced a dependency on the scroll offset at bounds computation time for children of fixed-pos, leading to crbug.com/1137974 due to incorrect overlap testing results. This was addressed in m87 by reverting revision crrev.com/807955. This change addresses the issue in a different way. The new approach is as follows: 1. Fixed-pos (and their children) compute non-expanded bounds instead of expanded bounds in BoundingBoxForCompositingOverlapTest, now renamed to LocalBoundingBoxForCompositingOverlapTest. These bounds, for fixed-pos layers, are kept in viewport coords when stored on AncestorDependentCompositingInputs, keeping them scrolloffset agnostics as cached. Additionally, by avoiding expanding the bounds, the return values from (un)ClippedAbsoluteBoundingBox are no longer expanded. These return values are used by layer squashing sparsity calculations, meaning this change reverts that calculation to its previous behavior before the MaxOverlapBoundsForFixed feature was introduced. 2. Conversion to absolute coords and expansion happens at overlap testing time, instead of compositing inputs update time, avoiding the problem that was attempted to be addressed via crrev.com/807955. Additionally, children of fixed-pos elements are also converted from viewport to absolute space during overlap testing, avoiding the issue found in crbug.com/1137974. 3. Only the top-most fixed-pos element expands its bounds. Without this limitation, children of a fixed-pos element would also expand their bounds and could detect overlap with siblings that they couldn't actually overlap with. E.g. two absolutely positioned siblings with a common fixed-pos ancestor do not need to expand their bounds to determine if they can overlap. 4. Because of the change in number 3, it becomes important that the fixed-pos layer's bound for overlap includes all that area covered by the fixed-pos layer and any of its children that may have their own composition layer. Without this consideration, it's possible for a child to extend beyond the fixed-pos expanded bounds and not cause something to composite due to overlap even though it intersects when scroll offsets change. This would be fixed on a lifecycle update that re-ran compositing with the new scroll offsets, but is still incorrect behavior. To address this issue, the overlap testing bounds for the top-most fixed-pos layer is expanded to include its composited stacking children. All of these cases also have tests added to validate them. Bug: 1124753 Change-Id: I42b22892fb0040bde8cbabb7c85fe30f71f4ee57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522407Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Sam Fortiner <samfort@microsoft.com> Cr-Commit-Position: refs/heads/master@{#827547}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605290311-c0a8bccef266e50cf7d2fe9fae22d951549688a8.profdata to chrome-linux-master-1605311889-6aa079e52bcacb107b5b307931590de3ab576ff9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I827b4fc2fa57673e692bbc0eef000f4ddadde020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538552Reviewed-by:
-
