GitLab

Changes startup / restore behavior to better match Lion resume expectations.  Chrome can get launched by the |loginwindow| process due to the resume feature on Lion.  In this case, if there were no windows open in Chrome when restarting, Chrome re-opens with no windows upon login.  This is also the expectation under previous OSs when Chrome is a login item, so that's been changed here too.

BUG=90249
TEST=Manual.  On Lion.  Turn Chrome session restore on, close all windows (but don't quit), restart computer.  Expect Chrome launches on startup with no open windows.

Review URL: http://codereview.chromium.org/7497056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96198 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise having an inner frame that matches the app's extent could mean that the process
is not swapped, even if we're not in an app process.

Difference from r94843 is that the popup window is 200x200, so that it results in a separate
Browser instance even on Chrome OS.

BUG=89272
TEST=no
R=creis@chromium.org

Review URL: http://codereview.chromium.org/7608015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96197 0039d316-1c4b-4281-b951-d872f2087c98

Fix plugin so that frames can still be painted after the decoder has
been destroyed.

BUG=NONE
TEST=gles2 consistently runs without crashing

Review URL: http://codereview.chromium.org/7607014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96196 0039d316-1c4b-4281-b951-d872f2087c98

multiple tests to fix flakiness.

Added some logging to figure out chromeos test failures.

BUG=91715
TEST=no
TBR=jochen

Original Review URL: http://codereview.chromium.org/7607003

Review URL: http://codereview.chromium.org/7606033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96195 0039d316-1c4b-4281-b951-d872f2087c98

Now that the Chrome downloads system is more stable since when this hook was originally written, the hook is now updated to work for all downloads (it previously did not work well for dangerous downloads, or downloads from an incognito window).

A new input to the automation hook also requires changes to several pyauto files that invoke the hook.

BUG=69738,91263
TEST=None

Review URL: http://codereview.chromium.org/7544026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96193 0039d316-1c4b-4281-b951-d872f2087c98

* Added GL surface and context support for Wayland.
* Updated ui/gfx files to allow Wayland support
* All Wayland code is behind the use_wayland gyp flag

This CL depends on http://codereview.chromium.org/7457023

BUG=
TEST=Compiled Chrome with use_wayland disabled to verify that
the changes didn't break anything


Review URL: http://codereview.chromium.org/7467007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96192 0039d316-1c4b-4281-b951-d872f2087c98

remove the bookmark bar visibility check because ntp4 doesn't use the floating bookmark bar.

(the ShouldShowBookmarkBar code will be ripped out soonish with the rest of ntp3)

BUG=none
TEST=waterfall

Review URL: http://codereview.chromium.org/7608031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96191 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96190 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=linux touch bot passes

Review URL: http://codereview.chromium.org/7604039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96189 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7552043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96187 0039d316-1c4b-4281-b951-d872f2087c98

I left a --new-tab-page-3 flag for testing purposes.

BUG=none
TEST=manual

Review URL: http://codereview.chromium.org/7600013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96186 0039d316-1c4b-4281-b951-d872f2087c98

TBR=chase@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7552042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96185 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Manual testing was performed. Warning message from presubmit test includes note to report issues to joi@chromium.org

Review URL: http://codereview.chromium.org/7582002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96184 0039d316-1c4b-4281-b951-d872f2087c98

BUG=91716
TEST=Download something. Hit cmd-shift-f for fullscreen. close box should stay centered
     vertically.

Review URL: http://codereview.chromium.org/7598002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96183 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76250
TEST=see bug

R=sky@chromium.org

Review URL: http://codereview.chromium.org/7575004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96182 0039d316-1c4b-4281-b951-d872f2087c98

If switched on via a command line flag, the new version of the
enrollment screen is enabled. It uses the authentication extension,
which will fetch an OAuth token that is then used to register for device
policy.

BUG=chromium-os:18203
TEST=Enable flags and test enrollment.

Review URL: http://codereview.chromium.org/7562008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96181 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7497066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96179 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7605024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96177 0039d316-1c4b-4281-b951-d872f2087c98

R=altimofeev@chromium.org
BUG=chromium-os:18916
TEST=Sign in as a new or existing user with different images chosen. Change picture to different ones. Check that each time the appropriate histogram is updated at chrome://histograms.

Review URL: http://codereview.chromium.org/7590002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96176 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96175 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7606027

TBR=kmillikin@chromium.org
Review URL: http://codereview.chromium.org/7608025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96174 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96173 0039d316-1c4b-4281-b951-d872f2087c98

R=danno@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/7606027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96172 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96171 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/7605006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96170 0039d316-1c4b-4281-b951-d872f2087c98

Note: This was a TODO for akalin.

BUG=None
TEST=None

R=akalin@chromium.org

Review URL: http://codereview.chromium.org/7497051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96169 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=try

Review URL: http://codereview.chromium.org/7608019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96168 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96167 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/7608021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96166 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92297
TEST=None
TBR=sky@chromium.org

Review URL: http://codereview.chromium.org/7607030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=92292
TEST=None

Review URL: http://codereview.chromium.org/7604030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96163 0039d316-1c4b-4281-b951-d872f2087c98

is selected so that input methods don't eat keyboard shortcuts.

BUG=80772
TEST=manual

Review URL: http://codereview.chromium.org/7554005

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/7604029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96162 0039d316-1c4b-4281-b951-d872f2087c98

Some general notes:
 - It's a lot of code for a single review, about 1.5K lines (plus tests, plus those generated docs, = 3.5K).  Apologies.  But it's close to the minimal amount of useful functionality.  I've left some TODOs in the code to fix up soon.
 - No integration-style tests, but I'll start writing those now.  Works from within a browser though.
 - Sync not hooked up yet, of course.
 - Ditto events.
 - Ditto thinking about incognito mode.
 - Ditto fun bugs like what happens if you set key "foo.bar" to "baz".
 - This is the first significant amount of C++ code I've ever written... so don't hold back.
 - The docs (i.e. my changes to extension_api.json) are a little incomplete, and I'm aware of that.

A summary of the implementation:
 - There is an ExtensionSettings factory-type object which hands out ExtensionSettingsStorage areas for extensions.  You may notice that I basically did the same thing that ExtensionPreferences does (so, lives with the profile, etc).
 - ExtensionSettingsStorage is a pure interface, with three implementations.
   - the main leveldb implementation.
   - a caching decorator, designed to sit on top of the leveldb implementation.
   - a "no-op" implementation which gives a trivial in-memory storage area when wrapped with a cache.  This is used in the cases where the leveldb database fails to initialise (ExtensionSettings handles this).
   -  and note that my plan is, when hooking up sync, that this will be implemented as another decorator.
 - ... the code is pretty well documented so not much else to say.

For testing, turns out gtest is pretty snazzy.  There are a bunch of test fixtrues in extension_settings_storage_unittest.h, so that 3 different configurations are tested: leveldb, leveldb + cache, and no-op + cache.

BUG=47327
TEST=unit tests provided


Review URL: http://codereview.chromium.org/7189029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96159 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual


Review URL: http://codereview.chromium.org/7607028

TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/7497059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96158 0039d316-1c4b-4281-b951-d872f2087c98

R=hashimoto@chromium.org
BUG=chromium-os:18955
TEST=Manual


Review URL: http://codereview.chromium.org/7607028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96157 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96156 0039d316-1c4b-4281-b951-d872f2087c98

The older code could screw up pending_operations_ in QuotaFileIO when another Write is issued in WriteCallback.  This patch is to fix the issue by always firing callbacks asynchronously.

BUG=86556
TEST=test_shell_tests:QuotaFileIOTest.*

Review URL: http://codereview.chromium.org/7508010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96154 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96151 0039d316-1c4b-4281-b951-d872f2087c98

is selected so that input methods don't eat keyboard shortcuts.

BUG=80772
TEST=manual

Review URL: http://codereview.chromium.org/7554005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96149 0039d316-1c4b-4281-b951-d872f2087c98