GitLab

Flip the VaapiVP8Encoder flag to enable VA-API based HW VP8 encoder by
default.

BUG=794608
TEST=veatest, apprtc

Change-Id: If99f825788786dc4cc2be8c4f7a3908d04023368
Reviewed-on: https://chromium-review.googlesource.com/1080436Reviewed-by: Dan Sanders <sandersd@chromium.org>
Commit-Queue: Pawel Osciak <posciak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564004}

This patch moves files for MetricsHelper, WorkerMetricsHelper, and
CompositorMetricsHelper to the directories designated by the new
scheduler architecture.

Bug: 826203
Change-Id: I8ca04d9585a5284859f4bcac323d0b45ead57d7e
Reviewed-on: https://chromium-review.googlesource.com/1082062Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Commit-Queue: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564003}

On legacy Mojo running on Chrome OS and ARC++, we use the handshake
length as the protocol version identifier.

Use mojo::edk::GenerateRandomToken() to generate the Mojo handshake
as it produces 32-byte string.

BUG=b:109586979
TEST=Make sure camera works on Soraka and Dru.

Change-Id: I28f37e7d32747b8507b24745d1f5f2db6319d951
Reviewed-on: https://chromium-review.googlesource.com/1084366Reviewed-by: Wu-Cheng Li <wuchengli@chromium.org>
Commit-Queue: Ricky Liang <jcliang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564002}

input[type=color]: Fix a regression that suggested colors were broken if OPTION's labels were not #rrggbb.

crrev.com/525311 caused this regression.  ColorChooserPopupUIController
should pass color strings to the popup UI code, instead of label
strings.

Bug: 849130
Change-Id: I2da1e2c032c1b0dba8fbffd4ded2a24b5c6dc0f6
Reviewed-on: https://chromium-review.googlesource.com/1084148Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564001}

Bug: 848314
Change-Id: I0c7f2140d9ba680bfddb43d6b8b07f7544de17fb
Reviewed-on: https://chromium-review.googlesource.com/1080930Reviewed-by: Matthew Wolenetz <wolenetz@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Max Moroz <mmoroz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564000}

This CL adds basic tests for integration of Crostini Apps with the App
List. In particular, we check that enabling/disabling Crostini shows/
hides the Terminal app, and installing/updating/removing apps is also
appropriately reflected in the app list.

This CL also adds a CrostiniTestHelper class, to aid testing Crostini
app integration. The CrostiniRegistryService intentionally does not
use the CrostiniTestHelper aside from the proto-building helper
functions to keep it explicit about what it is testing.

Bug: 842552
Change-Id: I0794a2a966eb5446775f5227b1ce18046f25bfb5
Reviewed-on: https://chromium-review.googlesource.com/1080430
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563999}

It looks the fix (and the comment there) introduced in https://crrev.com/c/729614 is not
correct.

The root cause is that we *connect* a shadow root before detaching the host's children in
attachShadow. That is the reason why host child's parent-in-the-flat-tree would be null in
detaching in the test case of bug 767403.

The correct fix is to call lazyReattach for host's children before *connecting* a shadow root,
so that they can see the original flat tree structure before attachShadow.

BUG: 767403
Change-Id: If02ff5ac42ebab10a97bb63873da54d168cbd81f
Reviewed-on: https://chromium-review.googlesource.com/1075952
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563998}

Bug: 830505
Change-Id: I9e1084ad1647f898933f40dfdb536cffdc371a46
Reviewed-on: https://chromium-review.googlesource.com/1080493
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563997}

TBR=sdy@chromium.org

Bug: 849129
Change-Id: Ie79332db99b99040f58fc38995213a79afd56b1e
Reviewed-on: https://chromium-review.googlesource.com/1084358Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563996}

This is workaround for MSVC compile error.
../../base/task_scheduler/task_tracker.cc(458): error C2440: 'initializing': cannot convert from 'base::HistogramBase *const (*)[2]' to 'base::HistogramBase *const (*&)[2]'

This has been happening on
https://ci.chromium.org/buildbot/chromium.fyi/WinMSVC64%20Goma%20Canary/6721

Change-Id: I64401b69a4ad2e1f9ea4716e127f26b0de662909
Reviewed-on: https://chromium-review.googlesource.com/1084131Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563995}

With bidi adjustment code merged into inline_box_traversal.cc, some
member functions of InlineBoxTraversal are no longer need. This patch
removes these functions, and also cleans up some relevant helpers.

Change-Id: I5572df7826d4fdcdcd33ca0f5fbc47cdc6ec807b
Reviewed-on: https://chromium-review.googlesource.com/1083496Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563994}

Makes use of WebInputEventType enum, consolidates numerous
JNI's for gesture event ack processing. One less TODO's with
my name.

Change-Id: I681709b788664f9228da1a51f4131948aee137d6
Reviewed-on: https://chromium-review.googlesource.com/1074794
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563993}

The BrowserContextDependencyManager is currently using base::Singleton,
so during unit tests it gets cleaned up by the AtExitManager after every
test. This means that individual BrowserContextKeyedServiceFactory
objects must use base::Singleton instead of base::NoDestructor, as they
otherwise will not be similarly destructed. This CL changes the BCDM to
use base::NoDestructor so that the factories can also use it.

Change-Id: I8825c9275d32605ad090faf810b29ae597e381be
Reviewed-on: https://chromium-review.googlesource.com/1080438Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563992}

Using wpt-import in Chromium 2819ce2b.
With Chromium commits locally applied on WPT:
e8832df8 "webrtc wpt: remove test_state_change_event"


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19033

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-ui

TBR=foolip

No-Export: true
Change-Id: Id33477b9fe45d931502d18aa38993c4c7056923a
Reviewed-on: https://chromium-review.googlesource.com/1084316
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563991}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=amineer@chromium.org

Change-Id: Ifa6cae82f11b6e22c69f5a9d406eea0f6e061476
Reviewed-on: https://chromium-review.googlesource.com/1083726Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563990}

This CL adds focus painter and a11y strings to elements in
UnifiedSystemTray.

TEST=manual
BUG=848623

Change-Id: I77d0ea57e470df445ca3c3ce9117fc95a358393d
Reviewed-on: https://chromium-review.googlesource.com/1082060
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563989}

Possibly some assumptions these tests are relying on have changed.
Details in https://crbug.com/849129

TBR=sdy@chromium.org

Bug: 849129, 837660
Change-Id: I6d01ae3ae0f054df982e4fdc4fede3abc9977557
Reviewed-on: https://chromium-review.googlesource.com/1084143Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563988}

BUG=847529

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I9f013aa2051d740d91e2047ebcc79b04bd5a65bb
Reviewed-on: https://chromium-review.googlesource.com/1082715Reviewed-by: Mike Pinkerton <pinkerton@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563987}

This is no longer actively being used and was replaced by
virtualKeyboardPrivate.setContainerBehavior

Removal of this was safe after the M67 branch.

Bug: 819095
Change-Id: I289f6940521cbb9fbe75626e51f4cb70fccf8c29
Reviewed-on: https://chromium-review.googlesource.com/1082181Reviewed-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563986}

Bug: 849132, 818742
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19b0351bead5ba120ece100963db4fbccc4f85c4
Reviewed-on: https://chromium-review.googlesource.com/1084315
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563985}

When V8ScriptRunner compiles a script it check if there is a cached
metadata for the script to decide it should generate code cache or not.

Before this CL, we didn't populate cached metadata for installed scripts
in S13nServiceWorker code path so V8ScriptRunner never generated caches
for installed scripts.

This fixes ServiceWorkerVersionBrowserV8CacheTest.Restart.

Bug: 846229
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I51d8d6cae30449ab35ba735280815ae5c8ecc4a9
Reviewed-on: https://chromium-review.googlesource.com/1082172Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563984}

TBR=hendrich@chromium.org

Bug: 849128
Change-Id: Ifa512ea6d0fef935dd13cb4695a7b1a32f382fec
Reviewed-on: https://chromium-review.googlesource.com/1084139
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563983}

It was reporting a preferred size inconsistent with its Layout(), causing
potential clipping.

To fix, anticipate the required alignment using constants.

Bug: 847904, 810970
Change-Id: I78e7aa3dbfe04d3cd6695047aca74627b3186336
Reviewed-on: https://chromium-review.googlesource.com/1082057Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Trent Apted <tapted@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563982}

Remove references to reading list in showcase content suggestions.

Bug: 849089
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I13832f021626cd3e063087666d72a64ceb628e88
Reviewed-on: https://chromium-review.googlesource.com/1084311Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563981}

Also add a disclaimer that it's really only mostly scheduled.

Bug: 848171
Change-Id: I370c2f47f3118f49fe47e8d72347d13b3a09956a
Reviewed-on: https://chromium-review.googlesource.com/1084064Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563980}

The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: Ib2469b52dbf1eade85e633422ae30cc5d05d3df9
Reviewed-on: https://chromium-review.googlesource.com/1083870Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563979}

When the UIRefresh flag is enabled, additional actions are added to the
share menu.  These actions end up pushing the Print action off of the
first screenful of items, so tests must be updated to scroll the
collection view if needed.

Also converts a History egtest to use a constant for an a11y identifier
and to avoid inadvertently dismissing the history ui.

BUG=825431

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I1efebb04d1de54dcef7c2c7d3374eff2c61c9838
Reviewed-on: https://chromium-review.googlesource.com/1083723Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563978}

TBR=avi

Bug: 837660
Change-Id: I89edb8171622a88adbb41e40187e463b11b4a97f
Reviewed-on: https://chromium-review.googlesource.com/1084035Reviewed-by: Sidney San Martín <sdy@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563977}

This reverts commit db365e5d.

Reason for revert: WOFF2 test blocking wpt-importer, seemingly flaky.

Original change's description:
> Unskip WOFF2 WPT tests
>
> The WOFF2 reftests from the Fonts WG have recently been modified to load
> required support fonts as Web fonts and hence remove the need of manual
> installation (*). The tests have already been imported into WebKit and
> Mozilla repositories. This CL unskips the WOFF2 test suite in Chromium
> too, in order to import the tests at the next synchronization cycle.
>
> (*) https://github.com/w3c/web-platform-tests/commit/31c2aeb1e71c5490f8fd304d731c18848065ad24
>
> R=​foolip@chromium.org
>
> Bug: 781154
> Change-Id: I91f73c584c11d46116182beebd1d0e8d24b82566
> Reviewed-on: https://chromium-review.googlesource.com/1073148
> Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
> Commit-Queue: Frédéric Wang <fwang@igalia.com>
> Cr-Commit-Position: refs/heads/master@{#563665}

TBR=foolip@chromium.org,fwang@igalia.com

No-Try: true
Bug: 781154
Change-Id: I685e21681fa1f34a128edf54107cb9907d6eba14
Reviewed-on: https://chromium-review.googlesource.com/1084271
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563976}

Bug: 837660
Change-Id: Ic2a0384c82aaa403834087e8cd0bb1a410200c21
Reviewed-on: https://chromium-review.googlesource.com/1083893Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563975}

This reverts commit f911e11e.

Reason for revert: Clusterfuzz still reported problems.

This is not a full revert, but keep the non-ref-counted function
interfaces and shorter test code so that it will be easier to switch
to full non-ref-counted again.

Original change's description:
> Reland "[CI] Make paint property nodes non-ref-counted"
>
> This reverts commit 887383b3.
>
> Reason for revert: Retry in M69.
>
> Original change's description:
> > Revert "[CI] Make paint property nodes non-ref-counted"
> >
> > This reverts commit 70fc0b01.
> >
> > Reason for revert: Caused bugs found by clusterfuzz
> >
> > Original change's description:
> > > [CI] Make paint property nodes non-ref-counted
> > >
> > > Now all paint property nodes are owned by ObjectPaintProperties
> > > (and LocalFrameView temporarily before removing non-RLS mode).
> > > Others just use raw pointers or references.
> > >
> > > Bug: 833496
> > > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > > Change-Id: I2d544fe153bb94698623248748df63c8aa2081ae
> > > Reviewed-on: https://chromium-review.googlesource.com/1031101
> > > Reviewed-by: Tien-Ren Chen <trchen@chromium.org>
> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#554626}
> >
> > TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org
> >
> > Change-Id: I02bb50d6744cb81a797246a0116b677e80a3c69f
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Bug: 833496,837932,837943
> > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> > Reviewed-on: https://chromium-review.googlesource.com/1034292
> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#554653}
>
> TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 833496, 837932, 837943
> Change-Id: I0b4ef70db1f1f211ba97c30d617225355c750992
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> Reviewed-on: https://chromium-review.googlesource.com/1083491
> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563930}

TBR=wangxianzhu@chromium.org,trchen@chromium.org,chrishtr@chromium.org

Change-Id: I1491f062f2e337cdf329c26742cef33437baca0c
Bug: 833496, 849033, 849036
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Reviewed-on: https://chromium-review.googlesource.com/1083700
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563974}

Now, this class provides the ability to pass a base::OnceClosure to the
constructor which is invoked when the object is deleted.

Bug: 824568, 752273
Change-Id: Ia9765dcdd8805af419a20492f505b43860eb6373
Reviewed-on: https://chromium-review.googlesource.com/1083828
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563973}

Previously, the function was named connection_details_to_channel_map().
However, the map value is a tuple with three components, so this CL
renames it to connection_details_to_active_metadata_map().

Bug: 824568, 752273
Change-Id: Id063f564c81e6625b50df615781daa5395f735e3
Reviewed-on: https://chromium-review.googlesource.com/1083827
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563972}

Additionally, add IsSameDevice() test function, which returns whether a
RemoteDevice and RemoteDeviceRef refer to the same device.

TBR=jhawkins@chromium.org

Bug: 824568, 752273
Change-Id: Ic7884421165a9454617adb07332a7ae8a52a993e
Reviewed-on: https://chromium-review.googlesource.com/1083860
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563971}

Now, its NotifyConnectionForHandledRequests() function returns a vector
of the clients that have been passed to the delegate callback.

Bug: 824568, 752273
Change-Id: I153fa23501cf7f6b6c0c10b39136f456e82e9b12
Reviewed-on: https://chromium-review.googlesource.com/1083858Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563970}

This reverts commit 9e453cfc.

Reason for revert: After discussing with hansberry@, we changed this part of the design, and this class is no longer needed.

Original change's description:
> [CrOS MultiDevice] Add LocalDeviceMetadataManager.
> 
> This class provides an interface for setting and retrieving metadata
> about the local device (i.e., the device on which this code is running).
> 
> The "default" metadata should be set once the user logs in and should be
> used for all requests during a user session. Before the user signs in,
> however, the default metadata is unset, since metadata is account-
> specific. Thus, this class also provides the ability to tie arbitrary
> metadata to a specific request ID.
> 
> Bug: 824568, 752273
> Change-Id: I78e3da20ff680c1c4cc9ce70e203005aacbdfe23
> Reviewed-on: https://chromium-review.googlesource.com/1079722
> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#563483}

TBR=khorimoto@chromium.org,hansberry@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 824568, 752273
Change-Id: Ied459e3da24d4961f49f4c218b2f9a5909eac7a2
Reviewed-on: https://chromium-review.googlesource.com/1084251Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563969}

BUG=762641
TBR=muyuanli@google.com

Change-Id: Iaca1a843885b8052c59a46dd0d549cd1e7bcc108
Reviewed-on: https://chromium-review.googlesource.com/1083976
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563968}

The problem was that there were alive processes when tests finished, and swarming considered that a failure (e.g. [1]).

The cause was that the processes were using a job object (to fix other races), and the code in base launched processes suspended if they were in a job object and later resumed them. The race was that layout test script kills the browser when there are any test failures. It did this using "taskkill.exe /t" (recursive). Windows would delete the network process, and as it was killing the browser it would sometimes do that in between the small window where the relaunched network process was created suspended and it was resumed. Child processes have logic to kill themselves if the parent is gone, but since the child process was suspended that didn't run.

The suspension when a process is in a job object was added in r100027 [2]. However the code that was moved there (test server) didn't have this originally. Also, the documentation that describes that this is needed [3] is for functionality that ended in Windows XP [4].

Note that a few weeks ago relaunching started using this as well in [5]. I'm removing created-as-suspended for that code as well, since that seems rare and keeping code in base/ that has this race condition that leaves processes around seems much worse than the alternative race of windows sometimes not being in foreground.

[1] https://chromium-swarm.appspot.com/task?id=3dd10a30220aa810&refresh=10&show_raw=1
[2] https://codereview.chromium.org/7789018
[3] https://msdn.microsoft.com/en-us/library/windows/desktop/ms681949(v=vs.85).aspx
[4] https://msdn.microsoft.com/en-us/library/windows/desktop/ms684159(v=vs.85).aspx
[5] https://chromium-review.googlesource.com/c/chromium/src/+/1064510

Bug: 820996
Change-Id: Ie79118efffac347bf3df1d65e1124fba095acdc0
Reviewed-on: https://chromium-review.googlesource.com/1081559Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#563967}

https://webrtc.googlesource.com/src.git/+log/38eac97..0c12d8d


git log 38eac97..0c12d8d --date=short --no-merges --format='%ad %ae %s'
2018-06-03 buildbot@webrtc.org Roll chromium_revision f2d1e453..cf1645be (563863:563963)


Created with:
  gclient setdep -r src/third_party/webrtc@0c12d8d

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I994863999d11f564c141e652ef0949129080c962
Reviewed-on: https://chromium-review.googlesource.com/1084193Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563966}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

The AutoRoll server is located here: https://afdo-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: Ie5a1e39f39615a4e72bf057a9e3e898d8979ce6f
Reviewed-on: https://chromium-review.googlesource.com/1084192Reviewed-by: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#563965}